10b57cec5SDimitry Andric //===- X86DiscriminateMemOps.cpp - Unique IDs for Mem Ops -----------------===//
20b57cec5SDimitry Andric //
30b57cec5SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
40b57cec5SDimitry Andric // See https://llvm.org/LICENSE.txt for license information.
50b57cec5SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
60b57cec5SDimitry Andric //
70b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
80b57cec5SDimitry Andric ///
90b57cec5SDimitry Andric /// This pass aids profile-driven cache prefetch insertion by ensuring all
100b57cec5SDimitry Andric /// instructions that have a memory operand are distinguishible from each other.
110b57cec5SDimitry Andric ///
120b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
130b57cec5SDimitry Andric
140b57cec5SDimitry Andric #include "X86.h"
150b57cec5SDimitry Andric #include "X86InstrBuilder.h"
160b57cec5SDimitry Andric #include "X86InstrInfo.h"
170b57cec5SDimitry Andric #include "X86MachineFunctionInfo.h"
180b57cec5SDimitry Andric #include "X86Subtarget.h"
1981ad6265SDimitry Andric #include "llvm/CodeGen/MachineFunctionPass.h"
200b57cec5SDimitry Andric #include "llvm/CodeGen/MachineModuleInfo.h"
210b57cec5SDimitry Andric #include "llvm/IR/DebugInfoMetadata.h"
220b57cec5SDimitry Andric #include "llvm/ProfileData/SampleProf.h"
230b57cec5SDimitry Andric #include "llvm/ProfileData/SampleProfReader.h"
240b57cec5SDimitry Andric #include "llvm/Support/Debug.h"
250b57cec5SDimitry Andric #include "llvm/Transforms/IPO/SampleProfile.h"
26*bdd1243dSDimitry Andric #include <optional>
270b57cec5SDimitry Andric using namespace llvm;
280b57cec5SDimitry Andric
290b57cec5SDimitry Andric #define DEBUG_TYPE "x86-discriminate-memops"
300b57cec5SDimitry Andric
310b57cec5SDimitry Andric static cl::opt<bool> EnableDiscriminateMemops(
320b57cec5SDimitry Andric DEBUG_TYPE, cl::init(false),
330b57cec5SDimitry Andric cl::desc("Generate unique debug info for each instruction with a memory "
345ffd83dbSDimitry Andric "operand. Should be enabled for profile-driven cache prefetching, "
350b57cec5SDimitry Andric "both in the build of the binary being profiled, as well as in "
360b57cec5SDimitry Andric "the build of the binary consuming the profile."),
370b57cec5SDimitry Andric cl::Hidden);
380b57cec5SDimitry Andric
390b57cec5SDimitry Andric static cl::opt<bool> BypassPrefetchInstructions(
400b57cec5SDimitry Andric "x86-bypass-prefetch-instructions", cl::init(true),
410b57cec5SDimitry Andric cl::desc("When discriminating instructions with memory operands, ignore "
420b57cec5SDimitry Andric "prefetch instructions. This ensures the other memory operand "
430b57cec5SDimitry Andric "instructions have the same identifiers after inserting "
440b57cec5SDimitry Andric "prefetches, allowing for successive insertions."),
450b57cec5SDimitry Andric cl::Hidden);
460b57cec5SDimitry Andric
470b57cec5SDimitry Andric namespace {
480b57cec5SDimitry Andric
490b57cec5SDimitry Andric using Location = std::pair<StringRef, unsigned>;
500b57cec5SDimitry Andric
diToLocation(const DILocation * Loc)510b57cec5SDimitry Andric Location diToLocation(const DILocation *Loc) {
520b57cec5SDimitry Andric return std::make_pair(Loc->getFilename(), Loc->getLine());
530b57cec5SDimitry Andric }
540b57cec5SDimitry Andric
550b57cec5SDimitry Andric /// Ensure each instruction having a memory operand has a distinct <LineNumber,
560b57cec5SDimitry Andric /// Discriminator> pair.
updateDebugInfo(MachineInstr * MI,const DILocation * Loc)570b57cec5SDimitry Andric void updateDebugInfo(MachineInstr *MI, const DILocation *Loc) {
580b57cec5SDimitry Andric DebugLoc DL(Loc);
590b57cec5SDimitry Andric MI->setDebugLoc(DL);
600b57cec5SDimitry Andric }
610b57cec5SDimitry Andric
620b57cec5SDimitry Andric class X86DiscriminateMemOps : public MachineFunctionPass {
630b57cec5SDimitry Andric bool runOnMachineFunction(MachineFunction &MF) override;
getPassName() const640b57cec5SDimitry Andric StringRef getPassName() const override {
650b57cec5SDimitry Andric return "X86 Discriminate Memory Operands";
660b57cec5SDimitry Andric }
670b57cec5SDimitry Andric
680b57cec5SDimitry Andric public:
690b57cec5SDimitry Andric static char ID;
700b57cec5SDimitry Andric
710b57cec5SDimitry Andric /// Default construct and initialize the pass.
720b57cec5SDimitry Andric X86DiscriminateMemOps();
730b57cec5SDimitry Andric };
740b57cec5SDimitry Andric
IsPrefetchOpcode(unsigned Opcode)750b57cec5SDimitry Andric bool IsPrefetchOpcode(unsigned Opcode) {
760b57cec5SDimitry Andric return Opcode == X86::PREFETCHNTA || Opcode == X86::PREFETCHT0 ||
77*bdd1243dSDimitry Andric Opcode == X86::PREFETCHT1 || Opcode == X86::PREFETCHT2 ||
78*bdd1243dSDimitry Andric Opcode == X86::PREFETCHIT0 || Opcode == X86::PREFETCHIT1;
790b57cec5SDimitry Andric }
800b57cec5SDimitry Andric } // end anonymous namespace
810b57cec5SDimitry Andric
820b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
830b57cec5SDimitry Andric // Implementation
840b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
850b57cec5SDimitry Andric
860b57cec5SDimitry Andric char X86DiscriminateMemOps::ID = 0;
870b57cec5SDimitry Andric
880b57cec5SDimitry Andric /// Default construct and initialize the pass.
X86DiscriminateMemOps()890b57cec5SDimitry Andric X86DiscriminateMemOps::X86DiscriminateMemOps() : MachineFunctionPass(ID) {}
900b57cec5SDimitry Andric
runOnMachineFunction(MachineFunction & MF)910b57cec5SDimitry Andric bool X86DiscriminateMemOps::runOnMachineFunction(MachineFunction &MF) {
920b57cec5SDimitry Andric if (!EnableDiscriminateMemops)
930b57cec5SDimitry Andric return false;
940b57cec5SDimitry Andric
950b57cec5SDimitry Andric DISubprogram *FDI = MF.getFunction().getSubprogram();
960b57cec5SDimitry Andric if (!FDI || !FDI->getUnit()->getDebugInfoForProfiling())
970b57cec5SDimitry Andric return false;
980b57cec5SDimitry Andric
990b57cec5SDimitry Andric // Have a default DILocation, if we find instructions with memops that don't
1000b57cec5SDimitry Andric // have any debug info.
1010b57cec5SDimitry Andric const DILocation *ReferenceDI =
1020b57cec5SDimitry Andric DILocation::get(FDI->getContext(), FDI->getLine(), 0, FDI);
1030b57cec5SDimitry Andric assert(ReferenceDI && "ReferenceDI should not be nullptr");
1040b57cec5SDimitry Andric DenseMap<Location, unsigned> MemOpDiscriminators;
1050b57cec5SDimitry Andric MemOpDiscriminators[diToLocation(ReferenceDI)] = 0;
1060b57cec5SDimitry Andric
1070b57cec5SDimitry Andric // Figure out the largest discriminator issued for each Location. When we
1080b57cec5SDimitry Andric // issue new discriminators, we can thus avoid issuing discriminators
1090b57cec5SDimitry Andric // belonging to instructions that don't have memops. This isn't a requirement
1100b57cec5SDimitry Andric // for the goals of this pass, however, it avoids unnecessary ambiguity.
1110b57cec5SDimitry Andric for (auto &MBB : MF) {
1120b57cec5SDimitry Andric for (auto &MI : MBB) {
1130b57cec5SDimitry Andric const auto &DI = MI.getDebugLoc();
1140b57cec5SDimitry Andric if (!DI)
1150b57cec5SDimitry Andric continue;
1160b57cec5SDimitry Andric if (BypassPrefetchInstructions && IsPrefetchOpcode(MI.getDesc().Opcode))
1170b57cec5SDimitry Andric continue;
1180b57cec5SDimitry Andric Location Loc = diToLocation(DI);
1190b57cec5SDimitry Andric MemOpDiscriminators[Loc] =
1200b57cec5SDimitry Andric std::max(MemOpDiscriminators[Loc], DI->getBaseDiscriminator());
1210b57cec5SDimitry Andric }
1220b57cec5SDimitry Andric }
1230b57cec5SDimitry Andric
1240b57cec5SDimitry Andric // Keep track of the discriminators seen at each Location. If an instruction's
1250b57cec5SDimitry Andric // DebugInfo has a Location and discriminator we've already seen, replace its
1260b57cec5SDimitry Andric // discriminator with a new one, to guarantee uniqueness.
1270b57cec5SDimitry Andric DenseMap<Location, DenseSet<unsigned>> Seen;
1280b57cec5SDimitry Andric
1290b57cec5SDimitry Andric bool Changed = false;
1300b57cec5SDimitry Andric for (auto &MBB : MF) {
1310b57cec5SDimitry Andric for (auto &MI : MBB) {
1320b57cec5SDimitry Andric if (X86II::getMemoryOperandNo(MI.getDesc().TSFlags) < 0)
1330b57cec5SDimitry Andric continue;
1340b57cec5SDimitry Andric if (BypassPrefetchInstructions && IsPrefetchOpcode(MI.getDesc().Opcode))
1350b57cec5SDimitry Andric continue;
1360b57cec5SDimitry Andric const DILocation *DI = MI.getDebugLoc();
1370b57cec5SDimitry Andric bool HasDebug = DI;
1380b57cec5SDimitry Andric if (!HasDebug) {
1390b57cec5SDimitry Andric DI = ReferenceDI;
1400b57cec5SDimitry Andric }
1410b57cec5SDimitry Andric Location L = diToLocation(DI);
1420b57cec5SDimitry Andric DenseSet<unsigned> &Set = Seen[L];
1430b57cec5SDimitry Andric const std::pair<DenseSet<unsigned>::iterator, bool> TryInsert =
1440b57cec5SDimitry Andric Set.insert(DI->getBaseDiscriminator());
1450b57cec5SDimitry Andric if (!TryInsert.second || !HasDebug) {
1460b57cec5SDimitry Andric unsigned BF, DF, CI = 0;
1470b57cec5SDimitry Andric DILocation::decodeDiscriminator(DI->getDiscriminator(), BF, DF, CI);
148*bdd1243dSDimitry Andric std::optional<unsigned> EncodedDiscriminator =
149*bdd1243dSDimitry Andric DILocation::encodeDiscriminator(MemOpDiscriminators[L] + 1, DF, CI);
1500b57cec5SDimitry Andric
1510b57cec5SDimitry Andric if (!EncodedDiscriminator) {
1520b57cec5SDimitry Andric // FIXME(mtrofin): The assumption is that this scenario is infrequent/OK
1530b57cec5SDimitry Andric // not to support. If evidence points otherwise, we can explore synthesizeing
1540b57cec5SDimitry Andric // unique DIs by adding fake line numbers, or by constructing 64 bit
1550b57cec5SDimitry Andric // discriminators.
1560b57cec5SDimitry Andric LLVM_DEBUG(dbgs() << "Unable to create a unique discriminator "
1570b57cec5SDimitry Andric "for instruction with memory operand in: "
1580b57cec5SDimitry Andric << DI->getFilename() << " Line: " << DI->getLine()
1590b57cec5SDimitry Andric << " Column: " << DI->getColumn()
1600b57cec5SDimitry Andric << ". This is likely due to a large macro expansion. \n");
1610b57cec5SDimitry Andric continue;
1620b57cec5SDimitry Andric }
1630b57cec5SDimitry Andric // Since we were able to encode, bump the MemOpDiscriminators.
1640b57cec5SDimitry Andric ++MemOpDiscriminators[L];
16581ad6265SDimitry Andric DI = DI->cloneWithDiscriminator(*EncodedDiscriminator);
1660b57cec5SDimitry Andric assert(DI && "DI should not be nullptr");
1670b57cec5SDimitry Andric updateDebugInfo(&MI, DI);
1680b57cec5SDimitry Andric Changed = true;
1690b57cec5SDimitry Andric std::pair<DenseSet<unsigned>::iterator, bool> MustInsert =
1700b57cec5SDimitry Andric Set.insert(DI->getBaseDiscriminator());
1710b57cec5SDimitry Andric (void)MustInsert; // Silence warning in release build.
1720b57cec5SDimitry Andric assert(MustInsert.second && "New discriminator shouldn't be present in set");
1730b57cec5SDimitry Andric }
1740b57cec5SDimitry Andric
1750b57cec5SDimitry Andric // Bump the reference DI to avoid cramming discriminators on line 0.
1760b57cec5SDimitry Andric // FIXME(mtrofin): pin ReferenceDI on blocks or first instruction with DI
1770b57cec5SDimitry Andric // in a block. It's more consistent than just relying on the last memop
1780b57cec5SDimitry Andric // instruction we happened to see.
1790b57cec5SDimitry Andric ReferenceDI = DI;
1800b57cec5SDimitry Andric }
1810b57cec5SDimitry Andric }
1820b57cec5SDimitry Andric return Changed;
1830b57cec5SDimitry Andric }
1840b57cec5SDimitry Andric
createX86DiscriminateMemOpsPass()1850b57cec5SDimitry Andric FunctionPass *llvm::createX86DiscriminateMemOpsPass() {
1860b57cec5SDimitry Andric return new X86DiscriminateMemOps();
1870b57cec5SDimitry Andric }
188