xref: /freebsd/contrib/llvm-project/llvm/lib/IR/ModuleSummaryIndex.cpp (revision fe6060f10f634930ff71b7c50291ddc610da2475)
10b57cec5SDimitry Andric //===-- ModuleSummaryIndex.cpp - Module Summary Index ---------------------===//
20b57cec5SDimitry Andric //
30b57cec5SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
40b57cec5SDimitry Andric // See https://llvm.org/LICENSE.txt for license information.
50b57cec5SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
60b57cec5SDimitry Andric //
70b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
80b57cec5SDimitry Andric //
90b57cec5SDimitry Andric // This file implements the module index and summary classes for the
100b57cec5SDimitry Andric // IR library.
110b57cec5SDimitry Andric //
120b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
130b57cec5SDimitry Andric 
140b57cec5SDimitry Andric #include "llvm/IR/ModuleSummaryIndex.h"
150b57cec5SDimitry Andric #include "llvm/ADT/SCCIterator.h"
160b57cec5SDimitry Andric #include "llvm/ADT/Statistic.h"
170b57cec5SDimitry Andric #include "llvm/ADT/StringMap.h"
18480093f4SDimitry Andric #include "llvm/Support/CommandLine.h"
190b57cec5SDimitry Andric #include "llvm/Support/Path.h"
200b57cec5SDimitry Andric #include "llvm/Support/raw_ostream.h"
210b57cec5SDimitry Andric using namespace llvm;
220b57cec5SDimitry Andric 
230b57cec5SDimitry Andric #define DEBUG_TYPE "module-summary-index"
240b57cec5SDimitry Andric 
250b57cec5SDimitry Andric STATISTIC(ReadOnlyLiveGVars,
260b57cec5SDimitry Andric           "Number of live global variables marked read only");
270b57cec5SDimitry Andric STATISTIC(WriteOnlyLiveGVars,
280b57cec5SDimitry Andric           "Number of live global variables marked write only");
290b57cec5SDimitry Andric 
30480093f4SDimitry Andric static cl::opt<bool> PropagateAttrs("propagate-attrs", cl::init(true),
31480093f4SDimitry Andric                                     cl::Hidden,
32480093f4SDimitry Andric                                     cl::desc("Propagate attributes in index"));
33480093f4SDimitry Andric 
345ffd83dbSDimitry Andric static cl::opt<bool> ImportConstantsWithRefs(
355ffd83dbSDimitry Andric     "import-constants-with-refs", cl::init(true), cl::Hidden,
365ffd83dbSDimitry Andric     cl::desc("Import constant global variables with references"));
375ffd83dbSDimitry Andric 
385ffd83dbSDimitry Andric constexpr uint32_t FunctionSummary::ParamAccess::RangeWidth;
395ffd83dbSDimitry Andric 
400b57cec5SDimitry Andric FunctionSummary FunctionSummary::ExternalNode =
410b57cec5SDimitry Andric     FunctionSummary::makeDummyFunctionSummary({});
420b57cec5SDimitry Andric 
43*fe6060f1SDimitry Andric GlobalValue::VisibilityTypes ValueInfo::getELFVisibility() const {
44*fe6060f1SDimitry Andric   bool HasProtected = false;
45*fe6060f1SDimitry Andric   for (const auto &S : make_pointee_range(getSummaryList())) {
46*fe6060f1SDimitry Andric     if (S.getVisibility() == GlobalValue::HiddenVisibility)
47*fe6060f1SDimitry Andric       return GlobalValue::HiddenVisibility;
48*fe6060f1SDimitry Andric     if (S.getVisibility() == GlobalValue::ProtectedVisibility)
49*fe6060f1SDimitry Andric       HasProtected = true;
50*fe6060f1SDimitry Andric   }
51*fe6060f1SDimitry Andric   return HasProtected ? GlobalValue::ProtectedVisibility
52*fe6060f1SDimitry Andric                       : GlobalValue::DefaultVisibility;
53*fe6060f1SDimitry Andric }
54*fe6060f1SDimitry Andric 
55*fe6060f1SDimitry Andric bool ValueInfo::isDSOLocal(bool WithDSOLocalPropagation) const {
56*fe6060f1SDimitry Andric   // With DSOLocal propagation done, the flag in evey summary is the same.
57*fe6060f1SDimitry Andric   // Check the first one is enough.
58*fe6060f1SDimitry Andric   return WithDSOLocalPropagation
59*fe6060f1SDimitry Andric              ? getSummaryList().size() && getSummaryList()[0]->isDSOLocal()
60*fe6060f1SDimitry Andric              : getSummaryList().size() &&
61*fe6060f1SDimitry Andric                    llvm::all_of(
62*fe6060f1SDimitry Andric                        getSummaryList(),
630b57cec5SDimitry Andric                        [](const std::unique_ptr<GlobalValueSummary> &Summary) {
640b57cec5SDimitry Andric                          return Summary->isDSOLocal();
650b57cec5SDimitry Andric                        });
660b57cec5SDimitry Andric }
670b57cec5SDimitry Andric 
680b57cec5SDimitry Andric bool ValueInfo::canAutoHide() const {
690b57cec5SDimitry Andric   // Can only auto hide if all copies are eligible to auto hide.
700b57cec5SDimitry Andric   return getSummaryList().size() &&
710b57cec5SDimitry Andric          llvm::all_of(getSummaryList(),
720b57cec5SDimitry Andric                       [](const std::unique_ptr<GlobalValueSummary> &Summary) {
730b57cec5SDimitry Andric                         return Summary->canAutoHide();
740b57cec5SDimitry Andric                       });
750b57cec5SDimitry Andric }
760b57cec5SDimitry Andric 
770b57cec5SDimitry Andric // Gets the number of readonly and writeonly refs in RefEdgeList
780b57cec5SDimitry Andric std::pair<unsigned, unsigned> FunctionSummary::specialRefCounts() const {
790b57cec5SDimitry Andric   // Here we take advantage of having all readonly and writeonly references
800b57cec5SDimitry Andric   // located in the end of the RefEdgeList.
810b57cec5SDimitry Andric   auto Refs = refs();
820b57cec5SDimitry Andric   unsigned RORefCnt = 0, WORefCnt = 0;
830b57cec5SDimitry Andric   int I;
840b57cec5SDimitry Andric   for (I = Refs.size() - 1; I >= 0 && Refs[I].isWriteOnly(); --I)
850b57cec5SDimitry Andric     WORefCnt++;
860b57cec5SDimitry Andric   for (; I >= 0 && Refs[I].isReadOnly(); --I)
870b57cec5SDimitry Andric     RORefCnt++;
880b57cec5SDimitry Andric   return {RORefCnt, WORefCnt};
890b57cec5SDimitry Andric }
900b57cec5SDimitry Andric 
91480093f4SDimitry Andric constexpr uint64_t ModuleSummaryIndex::BitcodeSummaryVersion;
92480093f4SDimitry Andric 
935ffd83dbSDimitry Andric uint64_t ModuleSummaryIndex::getFlags() const {
945ffd83dbSDimitry Andric   uint64_t Flags = 0;
955ffd83dbSDimitry Andric   if (withGlobalValueDeadStripping())
965ffd83dbSDimitry Andric     Flags |= 0x1;
975ffd83dbSDimitry Andric   if (skipModuleByDistributedBackend())
985ffd83dbSDimitry Andric     Flags |= 0x2;
995ffd83dbSDimitry Andric   if (hasSyntheticEntryCounts())
1005ffd83dbSDimitry Andric     Flags |= 0x4;
1015ffd83dbSDimitry Andric   if (enableSplitLTOUnit())
1025ffd83dbSDimitry Andric     Flags |= 0x8;
1035ffd83dbSDimitry Andric   if (partiallySplitLTOUnits())
1045ffd83dbSDimitry Andric     Flags |= 0x10;
1055ffd83dbSDimitry Andric   if (withAttributePropagation())
1065ffd83dbSDimitry Andric     Flags |= 0x20;
107*fe6060f1SDimitry Andric   if (withDSOLocalPropagation())
108*fe6060f1SDimitry Andric     Flags |= 0x40;
1095ffd83dbSDimitry Andric   return Flags;
1105ffd83dbSDimitry Andric }
1115ffd83dbSDimitry Andric 
1125ffd83dbSDimitry Andric void ModuleSummaryIndex::setFlags(uint64_t Flags) {
113*fe6060f1SDimitry Andric   assert(Flags <= 0x7f && "Unexpected bits in flag");
1145ffd83dbSDimitry Andric   // 1 bit: WithGlobalValueDeadStripping flag.
1155ffd83dbSDimitry Andric   // Set on combined index only.
1165ffd83dbSDimitry Andric   if (Flags & 0x1)
1175ffd83dbSDimitry Andric     setWithGlobalValueDeadStripping();
1185ffd83dbSDimitry Andric   // 1 bit: SkipModuleByDistributedBackend flag.
1195ffd83dbSDimitry Andric   // Set on combined index only.
1205ffd83dbSDimitry Andric   if (Flags & 0x2)
1215ffd83dbSDimitry Andric     setSkipModuleByDistributedBackend();
1225ffd83dbSDimitry Andric   // 1 bit: HasSyntheticEntryCounts flag.
1235ffd83dbSDimitry Andric   // Set on combined index only.
1245ffd83dbSDimitry Andric   if (Flags & 0x4)
1255ffd83dbSDimitry Andric     setHasSyntheticEntryCounts();
1265ffd83dbSDimitry Andric   // 1 bit: DisableSplitLTOUnit flag.
1275ffd83dbSDimitry Andric   // Set on per module indexes. It is up to the client to validate
1285ffd83dbSDimitry Andric   // the consistency of this flag across modules being linked.
1295ffd83dbSDimitry Andric   if (Flags & 0x8)
1305ffd83dbSDimitry Andric     setEnableSplitLTOUnit();
1315ffd83dbSDimitry Andric   // 1 bit: PartiallySplitLTOUnits flag.
1325ffd83dbSDimitry Andric   // Set on combined index only.
1335ffd83dbSDimitry Andric   if (Flags & 0x10)
1345ffd83dbSDimitry Andric     setPartiallySplitLTOUnits();
1355ffd83dbSDimitry Andric   // 1 bit: WithAttributePropagation flag.
1365ffd83dbSDimitry Andric   // Set on combined index only.
1375ffd83dbSDimitry Andric   if (Flags & 0x20)
1385ffd83dbSDimitry Andric     setWithAttributePropagation();
139*fe6060f1SDimitry Andric   // 1 bit: WithDSOLocalPropagation flag.
140*fe6060f1SDimitry Andric   // Set on combined index only.
141*fe6060f1SDimitry Andric   if (Flags & 0x40)
142*fe6060f1SDimitry Andric     setWithDSOLocalPropagation();
1435ffd83dbSDimitry Andric }
1445ffd83dbSDimitry Andric 
1450b57cec5SDimitry Andric // Collect for the given module the list of function it defines
1460b57cec5SDimitry Andric // (GUID -> Summary).
1470b57cec5SDimitry Andric void ModuleSummaryIndex::collectDefinedFunctionsForModule(
1480b57cec5SDimitry Andric     StringRef ModulePath, GVSummaryMapTy &GVSummaryMap) const {
1490b57cec5SDimitry Andric   for (auto &GlobalList : *this) {
1500b57cec5SDimitry Andric     auto GUID = GlobalList.first;
1510b57cec5SDimitry Andric     for (auto &GlobSummary : GlobalList.second.SummaryList) {
1520b57cec5SDimitry Andric       auto *Summary = dyn_cast_or_null<FunctionSummary>(GlobSummary.get());
1530b57cec5SDimitry Andric       if (!Summary)
1540b57cec5SDimitry Andric         // Ignore global variable, focus on functions
1550b57cec5SDimitry Andric         continue;
1560b57cec5SDimitry Andric       // Ignore summaries from other modules.
1570b57cec5SDimitry Andric       if (Summary->modulePath() != ModulePath)
1580b57cec5SDimitry Andric         continue;
1590b57cec5SDimitry Andric       GVSummaryMap[GUID] = Summary;
1600b57cec5SDimitry Andric     }
1610b57cec5SDimitry Andric   }
1620b57cec5SDimitry Andric }
1630b57cec5SDimitry Andric 
1640b57cec5SDimitry Andric GlobalValueSummary *
1650b57cec5SDimitry Andric ModuleSummaryIndex::getGlobalValueSummary(uint64_t ValueGUID,
1660b57cec5SDimitry Andric                                           bool PerModuleIndex) const {
1670b57cec5SDimitry Andric   auto VI = getValueInfo(ValueGUID);
1680b57cec5SDimitry Andric   assert(VI && "GlobalValue not found in index");
1690b57cec5SDimitry Andric   assert((!PerModuleIndex || VI.getSummaryList().size() == 1) &&
1700b57cec5SDimitry Andric          "Expected a single entry per global value in per-module index");
1710b57cec5SDimitry Andric   auto &Summary = VI.getSummaryList()[0];
1720b57cec5SDimitry Andric   return Summary.get();
1730b57cec5SDimitry Andric }
1740b57cec5SDimitry Andric 
1750b57cec5SDimitry Andric bool ModuleSummaryIndex::isGUIDLive(GlobalValue::GUID GUID) const {
1760b57cec5SDimitry Andric   auto VI = getValueInfo(GUID);
1770b57cec5SDimitry Andric   if (!VI)
1780b57cec5SDimitry Andric     return true;
1790b57cec5SDimitry Andric   const auto &SummaryList = VI.getSummaryList();
1800b57cec5SDimitry Andric   if (SummaryList.empty())
1810b57cec5SDimitry Andric     return true;
1820b57cec5SDimitry Andric   for (auto &I : SummaryList)
1830b57cec5SDimitry Andric     if (isGlobalValueLive(I.get()))
1840b57cec5SDimitry Andric       return true;
1850b57cec5SDimitry Andric   return false;
1860b57cec5SDimitry Andric }
1870b57cec5SDimitry Andric 
188e8d8bef9SDimitry Andric static void
189e8d8bef9SDimitry Andric propagateAttributesToRefs(GlobalValueSummary *S,
190e8d8bef9SDimitry Andric                           DenseSet<ValueInfo> &MarkedNonReadWriteOnly) {
1910b57cec5SDimitry Andric   // If reference is not readonly or writeonly then referenced summary is not
1920b57cec5SDimitry Andric   // read/writeonly either. Note that:
1930b57cec5SDimitry Andric   // - All references from GlobalVarSummary are conservatively considered as
1940b57cec5SDimitry Andric   //   not readonly or writeonly. Tracking them properly requires more complex
1950b57cec5SDimitry Andric   //   analysis then we have now.
1960b57cec5SDimitry Andric   //
1970b57cec5SDimitry Andric   // - AliasSummary objects have no refs at all so this function is a no-op
1980b57cec5SDimitry Andric   //   for them.
1990b57cec5SDimitry Andric   for (auto &VI : S->refs()) {
2000b57cec5SDimitry Andric     assert(VI.getAccessSpecifier() == 0 || isa<FunctionSummary>(S));
201e8d8bef9SDimitry Andric     if (!VI.getAccessSpecifier()) {
202e8d8bef9SDimitry Andric       if (!MarkedNonReadWriteOnly.insert(VI).second)
203e8d8bef9SDimitry Andric         continue;
204e8d8bef9SDimitry Andric     } else if (MarkedNonReadWriteOnly.contains(VI))
205e8d8bef9SDimitry Andric       continue;
2060b57cec5SDimitry Andric     for (auto &Ref : VI.getSummaryList())
2070b57cec5SDimitry Andric       // If references to alias is not read/writeonly then aliasee
2080b57cec5SDimitry Andric       // is not read/writeonly
2090b57cec5SDimitry Andric       if (auto *GVS = dyn_cast<GlobalVarSummary>(Ref->getBaseObject())) {
2100b57cec5SDimitry Andric         if (!VI.isReadOnly())
2110b57cec5SDimitry Andric           GVS->setReadOnly(false);
2120b57cec5SDimitry Andric         if (!VI.isWriteOnly())
2130b57cec5SDimitry Andric           GVS->setWriteOnly(false);
2140b57cec5SDimitry Andric       }
2150b57cec5SDimitry Andric   }
2160b57cec5SDimitry Andric }
2170b57cec5SDimitry Andric 
218*fe6060f1SDimitry Andric // Do the access attribute and DSOLocal propagation in combined index.
2190b57cec5SDimitry Andric // The goal of attribute propagation is internalization of readonly (RO)
2200b57cec5SDimitry Andric // or writeonly (WO) variables. To determine which variables are RO or WO
2210b57cec5SDimitry Andric // and which are not we take following steps:
2220b57cec5SDimitry Andric // - During analysis we speculatively assign readonly and writeonly
2230b57cec5SDimitry Andric //   attribute to all variables which can be internalized. When computing
2240b57cec5SDimitry Andric //   function summary we also assign readonly or writeonly attribute to a
2250b57cec5SDimitry Andric //   reference if function doesn't modify referenced variable (readonly)
2260b57cec5SDimitry Andric //   or doesn't read it (writeonly).
2270b57cec5SDimitry Andric //
2280b57cec5SDimitry Andric // - After computing dead symbols in combined index we do the attribute
229*fe6060f1SDimitry Andric //   and DSOLocal propagation. During this step we:
2300b57cec5SDimitry Andric //   a. clear RO and WO attributes from variables which are preserved or
2310b57cec5SDimitry Andric //      can't be imported
2320b57cec5SDimitry Andric //   b. clear RO and WO attributes from variables referenced by any global
2330b57cec5SDimitry Andric //      variable initializer
2340b57cec5SDimitry Andric //   c. clear RO attribute from variable referenced by a function when
2350b57cec5SDimitry Andric //      reference is not readonly
2360b57cec5SDimitry Andric //   d. clear WO attribute from variable referenced by a function when
2370b57cec5SDimitry Andric //      reference is not writeonly
238*fe6060f1SDimitry Andric //   e. clear IsDSOLocal flag in every summary if any of them is false.
2390b57cec5SDimitry Andric //
2400b57cec5SDimitry Andric //   Because of (c, d) we don't internalize variables read by function A
2410b57cec5SDimitry Andric //   and modified by function B.
2420b57cec5SDimitry Andric //
2430b57cec5SDimitry Andric // Internalization itself happens in the backend after import is finished
2440b57cec5SDimitry Andric // See internalizeGVsAfterImport.
2450b57cec5SDimitry Andric void ModuleSummaryIndex::propagateAttributes(
2460b57cec5SDimitry Andric     const DenseSet<GlobalValue::GUID> &GUIDPreservedSymbols) {
247480093f4SDimitry Andric   if (!PropagateAttrs)
248480093f4SDimitry Andric     return;
249e8d8bef9SDimitry Andric   DenseSet<ValueInfo> MarkedNonReadWriteOnly;
250*fe6060f1SDimitry Andric   for (auto &P : *this) {
251*fe6060f1SDimitry Andric     bool IsDSOLocal = true;
2520b57cec5SDimitry Andric     for (auto &S : P.second.SummaryList) {
253e8d8bef9SDimitry Andric       if (!isGlobalValueLive(S.get())) {
254e8d8bef9SDimitry Andric         // computeDeadSymbols should have marked all copies live. Note that
255e8d8bef9SDimitry Andric         // it is possible that there is a GUID collision between internal
256e8d8bef9SDimitry Andric         // symbols with the same name in different files of the same name but
257e8d8bef9SDimitry Andric         // not enough distinguishing path. Because computeDeadSymbols should
258e8d8bef9SDimitry Andric         // conservatively mark all copies live we can assert here that all are
259e8d8bef9SDimitry Andric         // dead if any copy is dead.
260e8d8bef9SDimitry Andric         assert(llvm::none_of(
261e8d8bef9SDimitry Andric             P.second.SummaryList,
262e8d8bef9SDimitry Andric             [&](const std::unique_ptr<GlobalValueSummary> &Summary) {
263e8d8bef9SDimitry Andric               return isGlobalValueLive(Summary.get());
264e8d8bef9SDimitry Andric             }));
2650b57cec5SDimitry Andric         // We don't examine references from dead objects
266e8d8bef9SDimitry Andric         break;
267e8d8bef9SDimitry Andric       }
2680b57cec5SDimitry Andric 
2690b57cec5SDimitry Andric       // Global variable can't be marked read/writeonly if it is not eligible
2700b57cec5SDimitry Andric       // to import since we need to ensure that all external references get
2710b57cec5SDimitry Andric       // a local (imported) copy. It also can't be marked read/writeonly if
2720b57cec5SDimitry Andric       // it or any alias (since alias points to the same memory) are preserved
2730b57cec5SDimitry Andric       // or notEligibleToImport, since either of those means there could be
2740b57cec5SDimitry Andric       // writes (or reads in case of writeonly) that are not visible (because
2750b57cec5SDimitry Andric       // preserved means it could have external to DSO writes or reads, and
2760b57cec5SDimitry Andric       // notEligibleToImport means it could have writes or reads via inline
2770b57cec5SDimitry Andric       // assembly leading it to be in the @llvm.*used).
2780b57cec5SDimitry Andric       if (auto *GVS = dyn_cast<GlobalVarSummary>(S->getBaseObject()))
2790b57cec5SDimitry Andric         // Here we intentionally pass S.get() not GVS, because S could be
280480093f4SDimitry Andric         // an alias. We don't analyze references here, because we have to
281480093f4SDimitry Andric         // know exactly if GV is readonly to do so.
282480093f4SDimitry Andric         if (!canImportGlobalVar(S.get(), /* AnalyzeRefs */ false) ||
2830b57cec5SDimitry Andric             GUIDPreservedSymbols.count(P.first)) {
2840b57cec5SDimitry Andric           GVS->setReadOnly(false);
2850b57cec5SDimitry Andric           GVS->setWriteOnly(false);
2860b57cec5SDimitry Andric         }
287e8d8bef9SDimitry Andric       propagateAttributesToRefs(S.get(), MarkedNonReadWriteOnly);
288*fe6060f1SDimitry Andric 
289*fe6060f1SDimitry Andric       // If the flag from any summary is false, the GV is not DSOLocal.
290*fe6060f1SDimitry Andric       IsDSOLocal &= S->isDSOLocal();
291*fe6060f1SDimitry Andric     }
292*fe6060f1SDimitry Andric     if (!IsDSOLocal)
293*fe6060f1SDimitry Andric       // Mark the flag in all summaries false so that we can do quick check
294*fe6060f1SDimitry Andric       // without going through the whole list.
295*fe6060f1SDimitry Andric       for (const std::unique_ptr<GlobalValueSummary> &Summary :
296*fe6060f1SDimitry Andric            P.second.SummaryList)
297*fe6060f1SDimitry Andric         Summary->setDSOLocal(false);
2980b57cec5SDimitry Andric   }
299480093f4SDimitry Andric   setWithAttributePropagation();
300*fe6060f1SDimitry Andric   setWithDSOLocalPropagation();
3010b57cec5SDimitry Andric   if (llvm::AreStatisticsEnabled())
3020b57cec5SDimitry Andric     for (auto &P : *this)
3030b57cec5SDimitry Andric       if (P.second.SummaryList.size())
3040b57cec5SDimitry Andric         if (auto *GVS = dyn_cast<GlobalVarSummary>(
3050b57cec5SDimitry Andric                 P.second.SummaryList[0]->getBaseObject()))
3060b57cec5SDimitry Andric           if (isGlobalValueLive(GVS)) {
3070b57cec5SDimitry Andric             if (GVS->maybeReadOnly())
3080b57cec5SDimitry Andric               ReadOnlyLiveGVars++;
3090b57cec5SDimitry Andric             if (GVS->maybeWriteOnly())
3100b57cec5SDimitry Andric               WriteOnlyLiveGVars++;
3110b57cec5SDimitry Andric           }
3120b57cec5SDimitry Andric }
3130b57cec5SDimitry Andric 
314480093f4SDimitry Andric bool ModuleSummaryIndex::canImportGlobalVar(GlobalValueSummary *S,
315480093f4SDimitry Andric                                             bool AnalyzeRefs) const {
316480093f4SDimitry Andric   auto HasRefsPreventingImport = [this](const GlobalVarSummary *GVS) {
317480093f4SDimitry Andric     // We don't analyze GV references during attribute propagation, so
318480093f4SDimitry Andric     // GV with non-trivial initializer can be marked either read or
319480093f4SDimitry Andric     // write-only.
320480093f4SDimitry Andric     // Importing definiton of readonly GV with non-trivial initializer
321480093f4SDimitry Andric     // allows us doing some extra optimizations (like converting indirect
322480093f4SDimitry Andric     // calls to direct).
323480093f4SDimitry Andric     // Definition of writeonly GV with non-trivial initializer should also
324480093f4SDimitry Andric     // be imported. Not doing so will result in:
325480093f4SDimitry Andric     // a) GV internalization in source module (because it's writeonly)
326480093f4SDimitry Andric     // b) Importing of GV declaration to destination module as a result
327480093f4SDimitry Andric     //    of promotion.
328480093f4SDimitry Andric     // c) Link error (external declaration with internal definition).
329480093f4SDimitry Andric     // However we do not promote objects referenced by writeonly GV
330480093f4SDimitry Andric     // initializer by means of converting it to 'zeroinitializer'
3315ffd83dbSDimitry Andric     return !(ImportConstantsWithRefs && GVS->isConstant()) &&
3325ffd83dbSDimitry Andric            !isReadOnly(GVS) && !isWriteOnly(GVS) && GVS->refs().size();
333480093f4SDimitry Andric   };
334480093f4SDimitry Andric   auto *GVS = cast<GlobalVarSummary>(S->getBaseObject());
335480093f4SDimitry Andric 
336480093f4SDimitry Andric   // Global variable with non-trivial initializer can be imported
337480093f4SDimitry Andric   // if it's readonly. This gives us extra opportunities for constant
338480093f4SDimitry Andric   // folding and converting indirect calls to direct calls. We don't
339480093f4SDimitry Andric   // analyze GV references during attribute propagation, because we
340480093f4SDimitry Andric   // don't know yet if it is readonly or not.
341480093f4SDimitry Andric   return !GlobalValue::isInterposableLinkage(S->linkage()) &&
342480093f4SDimitry Andric          !S->notEligibleToImport() &&
343480093f4SDimitry Andric          (!AnalyzeRefs || !HasRefsPreventingImport(GVS));
344480093f4SDimitry Andric }
345480093f4SDimitry Andric 
3460b57cec5SDimitry Andric // TODO: write a graphviz dumper for SCCs (see ModuleSummaryIndex::exportToDot)
3470b57cec5SDimitry Andric // then delete this function and update its tests
3480b57cec5SDimitry Andric LLVM_DUMP_METHOD
3490b57cec5SDimitry Andric void ModuleSummaryIndex::dumpSCCs(raw_ostream &O) {
3500b57cec5SDimitry Andric   for (scc_iterator<ModuleSummaryIndex *> I =
3510b57cec5SDimitry Andric            scc_begin<ModuleSummaryIndex *>(this);
3520b57cec5SDimitry Andric        !I.isAtEnd(); ++I) {
3530b57cec5SDimitry Andric     O << "SCC (" << utostr(I->size()) << " node" << (I->size() == 1 ? "" : "s")
3540b57cec5SDimitry Andric       << ") {\n";
355480093f4SDimitry Andric     for (const ValueInfo &V : *I) {
3560b57cec5SDimitry Andric       FunctionSummary *F = nullptr;
3570b57cec5SDimitry Andric       if (V.getSummaryList().size())
3580b57cec5SDimitry Andric         F = cast<FunctionSummary>(V.getSummaryList().front().get());
3590b57cec5SDimitry Andric       O << " " << (F == nullptr ? "External" : "") << " " << utostr(V.getGUID())
3605ffd83dbSDimitry Andric         << (I.hasCycle() ? " (has cycle)" : "") << "\n";
3610b57cec5SDimitry Andric     }
3620b57cec5SDimitry Andric     O << "}\n";
3630b57cec5SDimitry Andric   }
3640b57cec5SDimitry Andric }
3650b57cec5SDimitry Andric 
3660b57cec5SDimitry Andric namespace {
3670b57cec5SDimitry Andric struct Attributes {
3680b57cec5SDimitry Andric   void add(const Twine &Name, const Twine &Value,
3690b57cec5SDimitry Andric            const Twine &Comment = Twine());
3700b57cec5SDimitry Andric   void addComment(const Twine &Comment);
3710b57cec5SDimitry Andric   std::string getAsString() const;
3720b57cec5SDimitry Andric 
3730b57cec5SDimitry Andric   std::vector<std::string> Attrs;
3740b57cec5SDimitry Andric   std::string Comments;
3750b57cec5SDimitry Andric };
3760b57cec5SDimitry Andric 
3770b57cec5SDimitry Andric struct Edge {
3780b57cec5SDimitry Andric   uint64_t SrcMod;
3790b57cec5SDimitry Andric   int Hotness;
3800b57cec5SDimitry Andric   GlobalValue::GUID Src;
3810b57cec5SDimitry Andric   GlobalValue::GUID Dst;
3820b57cec5SDimitry Andric };
3830b57cec5SDimitry Andric }
3840b57cec5SDimitry Andric 
3850b57cec5SDimitry Andric void Attributes::add(const Twine &Name, const Twine &Value,
3860b57cec5SDimitry Andric                      const Twine &Comment) {
3870b57cec5SDimitry Andric   std::string A = Name.str();
3880b57cec5SDimitry Andric   A += "=\"";
3890b57cec5SDimitry Andric   A += Value.str();
3900b57cec5SDimitry Andric   A += "\"";
3910b57cec5SDimitry Andric   Attrs.push_back(A);
3920b57cec5SDimitry Andric   addComment(Comment);
3930b57cec5SDimitry Andric }
3940b57cec5SDimitry Andric 
3950b57cec5SDimitry Andric void Attributes::addComment(const Twine &Comment) {
3960b57cec5SDimitry Andric   if (!Comment.isTriviallyEmpty()) {
3970b57cec5SDimitry Andric     if (Comments.empty())
3980b57cec5SDimitry Andric       Comments = " // ";
3990b57cec5SDimitry Andric     else
4000b57cec5SDimitry Andric       Comments += ", ";
4010b57cec5SDimitry Andric     Comments += Comment.str();
4020b57cec5SDimitry Andric   }
4030b57cec5SDimitry Andric }
4040b57cec5SDimitry Andric 
4050b57cec5SDimitry Andric std::string Attributes::getAsString() const {
4060b57cec5SDimitry Andric   if (Attrs.empty())
4070b57cec5SDimitry Andric     return "";
4080b57cec5SDimitry Andric 
4090b57cec5SDimitry Andric   std::string Ret = "[";
4100b57cec5SDimitry Andric   for (auto &A : Attrs)
4110b57cec5SDimitry Andric     Ret += A + ",";
4120b57cec5SDimitry Andric   Ret.pop_back();
4130b57cec5SDimitry Andric   Ret += "];";
4140b57cec5SDimitry Andric   Ret += Comments;
4150b57cec5SDimitry Andric   return Ret;
4160b57cec5SDimitry Andric }
4170b57cec5SDimitry Andric 
4180b57cec5SDimitry Andric static std::string linkageToString(GlobalValue::LinkageTypes LT) {
4190b57cec5SDimitry Andric   switch (LT) {
4200b57cec5SDimitry Andric   case GlobalValue::ExternalLinkage:
4210b57cec5SDimitry Andric     return "extern";
4220b57cec5SDimitry Andric   case GlobalValue::AvailableExternallyLinkage:
4230b57cec5SDimitry Andric     return "av_ext";
4240b57cec5SDimitry Andric   case GlobalValue::LinkOnceAnyLinkage:
4250b57cec5SDimitry Andric     return "linkonce";
4260b57cec5SDimitry Andric   case GlobalValue::LinkOnceODRLinkage:
4270b57cec5SDimitry Andric     return "linkonce_odr";
4280b57cec5SDimitry Andric   case GlobalValue::WeakAnyLinkage:
4290b57cec5SDimitry Andric     return "weak";
4300b57cec5SDimitry Andric   case GlobalValue::WeakODRLinkage:
4310b57cec5SDimitry Andric     return "weak_odr";
4320b57cec5SDimitry Andric   case GlobalValue::AppendingLinkage:
4330b57cec5SDimitry Andric     return "appending";
4340b57cec5SDimitry Andric   case GlobalValue::InternalLinkage:
4350b57cec5SDimitry Andric     return "internal";
4360b57cec5SDimitry Andric   case GlobalValue::PrivateLinkage:
4370b57cec5SDimitry Andric     return "private";
4380b57cec5SDimitry Andric   case GlobalValue::ExternalWeakLinkage:
4390b57cec5SDimitry Andric     return "extern_weak";
4400b57cec5SDimitry Andric   case GlobalValue::CommonLinkage:
4410b57cec5SDimitry Andric     return "common";
4420b57cec5SDimitry Andric   }
4430b57cec5SDimitry Andric 
4440b57cec5SDimitry Andric   return "<unknown>";
4450b57cec5SDimitry Andric }
4460b57cec5SDimitry Andric 
4470b57cec5SDimitry Andric static std::string fflagsToString(FunctionSummary::FFlags F) {
4480b57cec5SDimitry Andric   auto FlagValue = [](unsigned V) { return V ? '1' : '0'; };
4490b57cec5SDimitry Andric   char FlagRep[] = {FlagValue(F.ReadNone),     FlagValue(F.ReadOnly),
4500b57cec5SDimitry Andric                     FlagValue(F.NoRecurse),    FlagValue(F.ReturnDoesNotAlias),
451480093f4SDimitry Andric                     FlagValue(F.NoInline), FlagValue(F.AlwaysInline), 0};
4520b57cec5SDimitry Andric 
4530b57cec5SDimitry Andric   return FlagRep;
4540b57cec5SDimitry Andric }
4550b57cec5SDimitry Andric 
4560b57cec5SDimitry Andric // Get string representation of function instruction count and flags.
4570b57cec5SDimitry Andric static std::string getSummaryAttributes(GlobalValueSummary* GVS) {
4580b57cec5SDimitry Andric   auto *FS = dyn_cast_or_null<FunctionSummary>(GVS);
4590b57cec5SDimitry Andric   if (!FS)
4600b57cec5SDimitry Andric     return "";
4610b57cec5SDimitry Andric 
4620b57cec5SDimitry Andric   return std::string("inst: ") + std::to_string(FS->instCount()) +
4630b57cec5SDimitry Andric          ", ffl: " + fflagsToString(FS->fflags());
4640b57cec5SDimitry Andric }
4650b57cec5SDimitry Andric 
4660b57cec5SDimitry Andric static std::string getNodeVisualName(GlobalValue::GUID Id) {
4670b57cec5SDimitry Andric   return std::string("@") + std::to_string(Id);
4680b57cec5SDimitry Andric }
4690b57cec5SDimitry Andric 
4700b57cec5SDimitry Andric static std::string getNodeVisualName(const ValueInfo &VI) {
4710b57cec5SDimitry Andric   return VI.name().empty() ? getNodeVisualName(VI.getGUID()) : VI.name().str();
4720b57cec5SDimitry Andric }
4730b57cec5SDimitry Andric 
4740b57cec5SDimitry Andric static std::string getNodeLabel(const ValueInfo &VI, GlobalValueSummary *GVS) {
4750b57cec5SDimitry Andric   if (isa<AliasSummary>(GVS))
4760b57cec5SDimitry Andric     return getNodeVisualName(VI);
4770b57cec5SDimitry Andric 
4780b57cec5SDimitry Andric   std::string Attrs = getSummaryAttributes(GVS);
4790b57cec5SDimitry Andric   std::string Label =
4800b57cec5SDimitry Andric       getNodeVisualName(VI) + "|" + linkageToString(GVS->linkage());
4810b57cec5SDimitry Andric   if (!Attrs.empty())
4820b57cec5SDimitry Andric     Label += std::string(" (") + Attrs + ")";
4830b57cec5SDimitry Andric   Label += "}";
4840b57cec5SDimitry Andric 
4850b57cec5SDimitry Andric   return Label;
4860b57cec5SDimitry Andric }
4870b57cec5SDimitry Andric 
4880b57cec5SDimitry Andric // Write definition of external node, which doesn't have any
4890b57cec5SDimitry Andric // specific module associated with it. Typically this is function
4900b57cec5SDimitry Andric // or variable defined in native object or library.
4910b57cec5SDimitry Andric static void defineExternalNode(raw_ostream &OS, const char *Pfx,
4920b57cec5SDimitry Andric                                const ValueInfo &VI, GlobalValue::GUID Id) {
4930b57cec5SDimitry Andric   auto StrId = std::to_string(Id);
4940b57cec5SDimitry Andric   OS << "  " << StrId << " [label=\"";
4950b57cec5SDimitry Andric 
4960b57cec5SDimitry Andric   if (VI) {
4970b57cec5SDimitry Andric     OS << getNodeVisualName(VI);
4980b57cec5SDimitry Andric   } else {
4990b57cec5SDimitry Andric     OS << getNodeVisualName(Id);
5000b57cec5SDimitry Andric   }
5010b57cec5SDimitry Andric   OS << "\"]; // defined externally\n";
5020b57cec5SDimitry Andric }
5030b57cec5SDimitry Andric 
5040b57cec5SDimitry Andric static bool hasReadOnlyFlag(const GlobalValueSummary *S) {
5050b57cec5SDimitry Andric   if (auto *GVS = dyn_cast<GlobalVarSummary>(S))
5060b57cec5SDimitry Andric     return GVS->maybeReadOnly();
5070b57cec5SDimitry Andric   return false;
5080b57cec5SDimitry Andric }
5090b57cec5SDimitry Andric 
5100b57cec5SDimitry Andric static bool hasWriteOnlyFlag(const GlobalValueSummary *S) {
5110b57cec5SDimitry Andric   if (auto *GVS = dyn_cast<GlobalVarSummary>(S))
5120b57cec5SDimitry Andric     return GVS->maybeWriteOnly();
5130b57cec5SDimitry Andric   return false;
5140b57cec5SDimitry Andric }
5150b57cec5SDimitry Andric 
5165ffd83dbSDimitry Andric static bool hasConstantFlag(const GlobalValueSummary *S) {
5175ffd83dbSDimitry Andric   if (auto *GVS = dyn_cast<GlobalVarSummary>(S))
5185ffd83dbSDimitry Andric     return GVS->isConstant();
5195ffd83dbSDimitry Andric   return false;
5205ffd83dbSDimitry Andric }
5215ffd83dbSDimitry Andric 
522480093f4SDimitry Andric void ModuleSummaryIndex::exportToDot(
523480093f4SDimitry Andric     raw_ostream &OS,
524480093f4SDimitry Andric     const DenseSet<GlobalValue::GUID> &GUIDPreservedSymbols) const {
5250b57cec5SDimitry Andric   std::vector<Edge> CrossModuleEdges;
5260b57cec5SDimitry Andric   DenseMap<GlobalValue::GUID, std::vector<uint64_t>> NodeMap;
5270b57cec5SDimitry Andric   using GVSOrderedMapTy = std::map<GlobalValue::GUID, GlobalValueSummary *>;
5280b57cec5SDimitry Andric   std::map<StringRef, GVSOrderedMapTy> ModuleToDefinedGVS;
5290b57cec5SDimitry Andric   collectDefinedGVSummariesPerModule(ModuleToDefinedGVS);
5300b57cec5SDimitry Andric 
5310b57cec5SDimitry Andric   // Get node identifier in form MXXX_<GUID>. The MXXX prefix is required,
5320b57cec5SDimitry Andric   // because we may have multiple linkonce functions summaries.
5330b57cec5SDimitry Andric   auto NodeId = [](uint64_t ModId, GlobalValue::GUID Id) {
5340b57cec5SDimitry Andric     return ModId == (uint64_t)-1 ? std::to_string(Id)
5350b57cec5SDimitry Andric                                  : std::string("M") + std::to_string(ModId) +
5360b57cec5SDimitry Andric                                        "_" + std::to_string(Id);
5370b57cec5SDimitry Andric   };
5380b57cec5SDimitry Andric 
5390b57cec5SDimitry Andric   auto DrawEdge = [&](const char *Pfx, uint64_t SrcMod, GlobalValue::GUID SrcId,
5400b57cec5SDimitry Andric                       uint64_t DstMod, GlobalValue::GUID DstId,
5410b57cec5SDimitry Andric                       int TypeOrHotness) {
5420b57cec5SDimitry Andric     // 0 - alias
5430b57cec5SDimitry Andric     // 1 - reference
5440b57cec5SDimitry Andric     // 2 - constant reference
5450b57cec5SDimitry Andric     // 3 - writeonly reference
5460b57cec5SDimitry Andric     // Other value: (hotness - 4).
5470b57cec5SDimitry Andric     TypeOrHotness += 4;
5480b57cec5SDimitry Andric     static const char *EdgeAttrs[] = {
5490b57cec5SDimitry Andric         " [style=dotted]; // alias",
5500b57cec5SDimitry Andric         " [style=dashed]; // ref",
5510b57cec5SDimitry Andric         " [style=dashed,color=forestgreen]; // const-ref",
5520b57cec5SDimitry Andric         " [style=dashed,color=violetred]; // writeOnly-ref",
5530b57cec5SDimitry Andric         " // call (hotness : Unknown)",
5540b57cec5SDimitry Andric         " [color=blue]; // call (hotness : Cold)",
5550b57cec5SDimitry Andric         " // call (hotness : None)",
5560b57cec5SDimitry Andric         " [color=brown]; // call (hotness : Hot)",
5570b57cec5SDimitry Andric         " [style=bold,color=red]; // call (hotness : Critical)"};
5580b57cec5SDimitry Andric 
5590b57cec5SDimitry Andric     assert(static_cast<size_t>(TypeOrHotness) <
5600b57cec5SDimitry Andric            sizeof(EdgeAttrs) / sizeof(EdgeAttrs[0]));
5610b57cec5SDimitry Andric     OS << Pfx << NodeId(SrcMod, SrcId) << " -> " << NodeId(DstMod, DstId)
5620b57cec5SDimitry Andric        << EdgeAttrs[TypeOrHotness] << "\n";
5630b57cec5SDimitry Andric   };
5640b57cec5SDimitry Andric 
5650b57cec5SDimitry Andric   OS << "digraph Summary {\n";
5660b57cec5SDimitry Andric   for (auto &ModIt : ModuleToDefinedGVS) {
5670b57cec5SDimitry Andric     auto ModId = getModuleId(ModIt.first);
5680b57cec5SDimitry Andric     OS << "  // Module: " << ModIt.first << "\n";
5690b57cec5SDimitry Andric     OS << "  subgraph cluster_" << std::to_string(ModId) << " {\n";
5700b57cec5SDimitry Andric     OS << "    style = filled;\n";
5710b57cec5SDimitry Andric     OS << "    color = lightgrey;\n";
5720b57cec5SDimitry Andric     OS << "    label = \"" << sys::path::filename(ModIt.first) << "\";\n";
5730b57cec5SDimitry Andric     OS << "    node [style=filled,fillcolor=lightblue];\n";
5740b57cec5SDimitry Andric 
5750b57cec5SDimitry Andric     auto &GVSMap = ModIt.second;
5760b57cec5SDimitry Andric     auto Draw = [&](GlobalValue::GUID IdFrom, GlobalValue::GUID IdTo, int Hotness) {
5770b57cec5SDimitry Andric       if (!GVSMap.count(IdTo)) {
5780b57cec5SDimitry Andric         CrossModuleEdges.push_back({ModId, Hotness, IdFrom, IdTo});
5790b57cec5SDimitry Andric         return;
5800b57cec5SDimitry Andric       }
5810b57cec5SDimitry Andric       DrawEdge("    ", ModId, IdFrom, ModId, IdTo, Hotness);
5820b57cec5SDimitry Andric     };
5830b57cec5SDimitry Andric 
5840b57cec5SDimitry Andric     for (auto &SummaryIt : GVSMap) {
5850b57cec5SDimitry Andric       NodeMap[SummaryIt.first].push_back(ModId);
5860b57cec5SDimitry Andric       auto Flags = SummaryIt.second->flags();
5870b57cec5SDimitry Andric       Attributes A;
5880b57cec5SDimitry Andric       if (isa<FunctionSummary>(SummaryIt.second)) {
5890b57cec5SDimitry Andric         A.add("shape", "record", "function");
5900b57cec5SDimitry Andric       } else if (isa<AliasSummary>(SummaryIt.second)) {
5910b57cec5SDimitry Andric         A.add("style", "dotted,filled", "alias");
5920b57cec5SDimitry Andric         A.add("shape", "box");
5930b57cec5SDimitry Andric       } else {
5940b57cec5SDimitry Andric         A.add("shape", "Mrecord", "variable");
5950b57cec5SDimitry Andric         if (Flags.Live && hasReadOnlyFlag(SummaryIt.second))
5960b57cec5SDimitry Andric           A.addComment("immutable");
5970b57cec5SDimitry Andric         if (Flags.Live && hasWriteOnlyFlag(SummaryIt.second))
5980b57cec5SDimitry Andric           A.addComment("writeOnly");
5995ffd83dbSDimitry Andric         if (Flags.Live && hasConstantFlag(SummaryIt.second))
6005ffd83dbSDimitry Andric           A.addComment("constant");
6010b57cec5SDimitry Andric       }
602*fe6060f1SDimitry Andric       if (Flags.Visibility)
603*fe6060f1SDimitry Andric         A.addComment("visibility");
6040b57cec5SDimitry Andric       if (Flags.DSOLocal)
6050b57cec5SDimitry Andric         A.addComment("dsoLocal");
6060b57cec5SDimitry Andric       if (Flags.CanAutoHide)
6070b57cec5SDimitry Andric         A.addComment("canAutoHide");
608480093f4SDimitry Andric       if (GUIDPreservedSymbols.count(SummaryIt.first))
609480093f4SDimitry Andric         A.addComment("preserved");
6100b57cec5SDimitry Andric 
6110b57cec5SDimitry Andric       auto VI = getValueInfo(SummaryIt.first);
6120b57cec5SDimitry Andric       A.add("label", getNodeLabel(VI, SummaryIt.second));
6130b57cec5SDimitry Andric       if (!Flags.Live)
6140b57cec5SDimitry Andric         A.add("fillcolor", "red", "dead");
6150b57cec5SDimitry Andric       else if (Flags.NotEligibleToImport)
6160b57cec5SDimitry Andric         A.add("fillcolor", "yellow", "not eligible to import");
6170b57cec5SDimitry Andric 
6180b57cec5SDimitry Andric       OS << "    " << NodeId(ModId, SummaryIt.first) << " " << A.getAsString()
6190b57cec5SDimitry Andric          << "\n";
6200b57cec5SDimitry Andric     }
6210b57cec5SDimitry Andric     OS << "    // Edges:\n";
6220b57cec5SDimitry Andric 
6230b57cec5SDimitry Andric     for (auto &SummaryIt : GVSMap) {
6240b57cec5SDimitry Andric       auto *GVS = SummaryIt.second;
6250b57cec5SDimitry Andric       for (auto &R : GVS->refs())
6260b57cec5SDimitry Andric         Draw(SummaryIt.first, R.getGUID(),
6270b57cec5SDimitry Andric              R.isWriteOnly() ? -1 : (R.isReadOnly() ? -2 : -3));
6280b57cec5SDimitry Andric 
6290b57cec5SDimitry Andric       if (auto *AS = dyn_cast_or_null<AliasSummary>(SummaryIt.second)) {
6300b57cec5SDimitry Andric         Draw(SummaryIt.first, AS->getAliaseeGUID(), -4);
6310b57cec5SDimitry Andric         continue;
6320b57cec5SDimitry Andric       }
6330b57cec5SDimitry Andric 
6340b57cec5SDimitry Andric       if (auto *FS = dyn_cast_or_null<FunctionSummary>(SummaryIt.second))
6350b57cec5SDimitry Andric         for (auto &CGEdge : FS->calls())
6360b57cec5SDimitry Andric           Draw(SummaryIt.first, CGEdge.first.getGUID(),
6370b57cec5SDimitry Andric                static_cast<int>(CGEdge.second.Hotness));
6380b57cec5SDimitry Andric     }
6390b57cec5SDimitry Andric     OS << "  }\n";
6400b57cec5SDimitry Andric   }
6410b57cec5SDimitry Andric 
6420b57cec5SDimitry Andric   OS << "  // Cross-module edges:\n";
6430b57cec5SDimitry Andric   for (auto &E : CrossModuleEdges) {
6440b57cec5SDimitry Andric     auto &ModList = NodeMap[E.Dst];
6450b57cec5SDimitry Andric     if (ModList.empty()) {
6460b57cec5SDimitry Andric       defineExternalNode(OS, "  ", getValueInfo(E.Dst), E.Dst);
6470b57cec5SDimitry Andric       // Add fake module to the list to draw an edge to an external node
6480b57cec5SDimitry Andric       // in the loop below.
6490b57cec5SDimitry Andric       ModList.push_back(-1);
6500b57cec5SDimitry Andric     }
6510b57cec5SDimitry Andric     for (auto DstMod : ModList)
6520b57cec5SDimitry Andric       // The edge representing call or ref is drawn to every module where target
6530b57cec5SDimitry Andric       // symbol is defined. When target is a linkonce symbol there can be
6540b57cec5SDimitry Andric       // multiple edges representing a single call or ref, both intra-module and
6550b57cec5SDimitry Andric       // cross-module. As we've already drawn all intra-module edges before we
6560b57cec5SDimitry Andric       // skip it here.
6570b57cec5SDimitry Andric       if (DstMod != E.SrcMod)
6580b57cec5SDimitry Andric         DrawEdge("  ", E.SrcMod, E.Src, DstMod, E.Dst, E.Hotness);
6590b57cec5SDimitry Andric   }
6600b57cec5SDimitry Andric 
6610b57cec5SDimitry Andric   OS << "}";
6620b57cec5SDimitry Andric }
663