1480093f4SDimitry Andric //===-- InvalidatedIteratorChecker.cpp ----------------------------*- C++ -*--//
2480093f4SDimitry Andric //
3480093f4SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4480093f4SDimitry Andric // See https://llvm.org/LICENSE.txt for license information.
5480093f4SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6480093f4SDimitry Andric //
7480093f4SDimitry Andric //===----------------------------------------------------------------------===//
8480093f4SDimitry Andric //
9480093f4SDimitry Andric // Defines a checker for access of invalidated iterators.
10480093f4SDimitry Andric //
11480093f4SDimitry Andric //===----------------------------------------------------------------------===//
12480093f4SDimitry Andric
13480093f4SDimitry Andric #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
14480093f4SDimitry Andric #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
15480093f4SDimitry Andric #include "clang/StaticAnalyzer/Core/Checker.h"
16480093f4SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
17480093f4SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
18480093f4SDimitry Andric
19480093f4SDimitry Andric
20480093f4SDimitry Andric #include "Iterator.h"
21480093f4SDimitry Andric
22480093f4SDimitry Andric using namespace clang;
23480093f4SDimitry Andric using namespace ento;
24480093f4SDimitry Andric using namespace iterator;
25480093f4SDimitry Andric
26480093f4SDimitry Andric namespace {
27480093f4SDimitry Andric
28480093f4SDimitry Andric class InvalidatedIteratorChecker
295ffd83dbSDimitry Andric : public Checker<check::PreCall, check::PreStmt<UnaryOperator>,
305ffd83dbSDimitry Andric check::PreStmt<BinaryOperator>,
315ffd83dbSDimitry Andric check::PreStmt<ArraySubscriptExpr>,
325ffd83dbSDimitry Andric check::PreStmt<MemberExpr>> {
33480093f4SDimitry Andric
34*647cbc5dSDimitry Andric const BugType InvalidatedBugType{this, "Iterator invalidated",
35*647cbc5dSDimitry Andric "Misuse of STL APIs"};
36480093f4SDimitry Andric
37*647cbc5dSDimitry Andric void verifyAccess(CheckerContext &C, SVal Val) const;
38*647cbc5dSDimitry Andric void reportBug(StringRef Message, SVal Val, CheckerContext &C,
39*647cbc5dSDimitry Andric ExplodedNode *ErrNode) const;
40*647cbc5dSDimitry Andric
41480093f4SDimitry Andric public:
42480093f4SDimitry Andric void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
435ffd83dbSDimitry Andric void checkPreStmt(const UnaryOperator *UO, CheckerContext &C) const;
445ffd83dbSDimitry Andric void checkPreStmt(const BinaryOperator *BO, CheckerContext &C) const;
455ffd83dbSDimitry Andric void checkPreStmt(const ArraySubscriptExpr *ASE, CheckerContext &C) const;
465ffd83dbSDimitry Andric void checkPreStmt(const MemberExpr *ME, CheckerContext &C) const;
47480093f4SDimitry Andric
48480093f4SDimitry Andric };
49480093f4SDimitry Andric
50480093f4SDimitry Andric } // namespace
51480093f4SDimitry Andric
checkPreCall(const CallEvent & Call,CheckerContext & C) const52480093f4SDimitry Andric void InvalidatedIteratorChecker::checkPreCall(const CallEvent &Call,
53480093f4SDimitry Andric CheckerContext &C) const {
54480093f4SDimitry Andric // Check for access of invalidated position
55480093f4SDimitry Andric const auto *Func = dyn_cast_or_null<FunctionDecl>(Call.getDecl());
56480093f4SDimitry Andric if (!Func)
57480093f4SDimitry Andric return;
58480093f4SDimitry Andric
59480093f4SDimitry Andric if (Func->isOverloadedOperator() &&
60480093f4SDimitry Andric isAccessOperator(Func->getOverloadedOperator())) {
61480093f4SDimitry Andric // Check for any kind of access of invalidated iterator positions
62480093f4SDimitry Andric if (const auto *InstCall = dyn_cast<CXXInstanceCall>(&Call)) {
63480093f4SDimitry Andric verifyAccess(C, InstCall->getCXXThisVal());
64480093f4SDimitry Andric } else {
65480093f4SDimitry Andric verifyAccess(C, Call.getArgSVal(0));
66480093f4SDimitry Andric }
67480093f4SDimitry Andric }
68480093f4SDimitry Andric }
69480093f4SDimitry Andric
checkPreStmt(const UnaryOperator * UO,CheckerContext & C) const705ffd83dbSDimitry Andric void InvalidatedIteratorChecker::checkPreStmt(const UnaryOperator *UO,
715ffd83dbSDimitry Andric CheckerContext &C) const {
725ffd83dbSDimitry Andric if (isa<CXXThisExpr>(UO->getSubExpr()))
735ffd83dbSDimitry Andric return;
745ffd83dbSDimitry Andric
755ffd83dbSDimitry Andric ProgramStateRef State = C.getState();
765ffd83dbSDimitry Andric UnaryOperatorKind OK = UO->getOpcode();
775ffd83dbSDimitry Andric SVal SubVal = State->getSVal(UO->getSubExpr(), C.getLocationContext());
785ffd83dbSDimitry Andric
795ffd83dbSDimitry Andric if (isAccessOperator(OK)) {
805ffd83dbSDimitry Andric verifyAccess(C, SubVal);
815ffd83dbSDimitry Andric }
825ffd83dbSDimitry Andric }
835ffd83dbSDimitry Andric
checkPreStmt(const BinaryOperator * BO,CheckerContext & C) const845ffd83dbSDimitry Andric void InvalidatedIteratorChecker::checkPreStmt(const BinaryOperator *BO,
855ffd83dbSDimitry Andric CheckerContext &C) const {
865ffd83dbSDimitry Andric ProgramStateRef State = C.getState();
875ffd83dbSDimitry Andric BinaryOperatorKind OK = BO->getOpcode();
885ffd83dbSDimitry Andric SVal LVal = State->getSVal(BO->getLHS(), C.getLocationContext());
895ffd83dbSDimitry Andric
905ffd83dbSDimitry Andric if (isAccessOperator(OK)) {
915ffd83dbSDimitry Andric verifyAccess(C, LVal);
925ffd83dbSDimitry Andric }
935ffd83dbSDimitry Andric }
945ffd83dbSDimitry Andric
checkPreStmt(const ArraySubscriptExpr * ASE,CheckerContext & C) const955ffd83dbSDimitry Andric void InvalidatedIteratorChecker::checkPreStmt(const ArraySubscriptExpr *ASE,
965ffd83dbSDimitry Andric CheckerContext &C) const {
975ffd83dbSDimitry Andric ProgramStateRef State = C.getState();
985ffd83dbSDimitry Andric SVal LVal = State->getSVal(ASE->getLHS(), C.getLocationContext());
995ffd83dbSDimitry Andric verifyAccess(C, LVal);
1005ffd83dbSDimitry Andric }
1015ffd83dbSDimitry Andric
checkPreStmt(const MemberExpr * ME,CheckerContext & C) const1025ffd83dbSDimitry Andric void InvalidatedIteratorChecker::checkPreStmt(const MemberExpr *ME,
1035ffd83dbSDimitry Andric CheckerContext &C) const {
1045ffd83dbSDimitry Andric if (!ME->isArrow() || ME->isImplicitAccess())
1055ffd83dbSDimitry Andric return;
1065ffd83dbSDimitry Andric
1075ffd83dbSDimitry Andric ProgramStateRef State = C.getState();
1085ffd83dbSDimitry Andric SVal BaseVal = State->getSVal(ME->getBase(), C.getLocationContext());
1095ffd83dbSDimitry Andric verifyAccess(C, BaseVal);
1105ffd83dbSDimitry Andric }
1115ffd83dbSDimitry Andric
verifyAccess(CheckerContext & C,SVal Val) const112*647cbc5dSDimitry Andric void InvalidatedIteratorChecker::verifyAccess(CheckerContext &C,
113*647cbc5dSDimitry Andric SVal Val) const {
114480093f4SDimitry Andric auto State = C.getState();
115480093f4SDimitry Andric const auto *Pos = getIteratorPosition(State, Val);
116480093f4SDimitry Andric if (Pos && !Pos->isValid()) {
117480093f4SDimitry Andric auto *N = C.generateErrorNode(State);
118480093f4SDimitry Andric if (!N) {
119480093f4SDimitry Andric return;
120480093f4SDimitry Andric }
121480093f4SDimitry Andric reportBug("Invalidated iterator accessed.", Val, C, N);
122480093f4SDimitry Andric }
123480093f4SDimitry Andric }
124480093f4SDimitry Andric
reportBug(StringRef Message,SVal Val,CheckerContext & C,ExplodedNode * ErrNode) const125*647cbc5dSDimitry Andric void InvalidatedIteratorChecker::reportBug(StringRef Message, SVal Val,
126*647cbc5dSDimitry Andric CheckerContext &C,
127480093f4SDimitry Andric ExplodedNode *ErrNode) const {
128*647cbc5dSDimitry Andric auto R = std::make_unique<PathSensitiveBugReport>(InvalidatedBugType, Message,
129*647cbc5dSDimitry Andric ErrNode);
130480093f4SDimitry Andric R->markInteresting(Val);
131480093f4SDimitry Andric C.emitReport(std::move(R));
132480093f4SDimitry Andric }
133480093f4SDimitry Andric
registerInvalidatedIteratorChecker(CheckerManager & mgr)134480093f4SDimitry Andric void ento::registerInvalidatedIteratorChecker(CheckerManager &mgr) {
135480093f4SDimitry Andric mgr.registerChecker<InvalidatedIteratorChecker>();
136480093f4SDimitry Andric }
137480093f4SDimitry Andric
shouldRegisterInvalidatedIteratorChecker(const CheckerManager & mgr)1385ffd83dbSDimitry Andric bool ento::shouldRegisterInvalidatedIteratorChecker(const CheckerManager &mgr) {
139480093f4SDimitry Andric return true;
140480093f4SDimitry Andric }
141