10b57cec5SDimitry Andric //== GenericTaintChecker.cpp ----------------------------------- -*- C++ -*--=// 20b57cec5SDimitry Andric // 30b57cec5SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 40b57cec5SDimitry Andric // See https://llvm.org/LICENSE.txt for license information. 50b57cec5SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 60b57cec5SDimitry Andric // 70b57cec5SDimitry Andric //===----------------------------------------------------------------------===// 80b57cec5SDimitry Andric // 90b57cec5SDimitry Andric // This checker defines the attack surface for generic taint propagation. 100b57cec5SDimitry Andric // 110b57cec5SDimitry Andric // The taint information produced by it might be useful to other checkers. For 120b57cec5SDimitry Andric // example, checkers should report errors which involve tainted data more 130b57cec5SDimitry Andric // aggressively, even if the involved symbols are under constrained. 140b57cec5SDimitry Andric // 150b57cec5SDimitry Andric //===----------------------------------------------------------------------===// 160b57cec5SDimitry Andric 17a7dea167SDimitry Andric #include "Yaml.h" 180b57cec5SDimitry Andric #include "clang/AST/Attr.h" 190b57cec5SDimitry Andric #include "clang/Basic/Builtins.h" 20a7dea167SDimitry Andric #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" 21*81ad6265SDimitry Andric #include "clang/StaticAnalyzer/Checkers/Taint.h" 220b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" 230b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/Checker.h" 240b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/CheckerManager.h" 2504eeddc0SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" 265ffd83dbSDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" 270b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" 280b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" 29a7dea167SDimitry Andric #include "llvm/Support/YAMLTraits.h" 305ffd83dbSDimitry Andric 31a7dea167SDimitry Andric #include <limits> 325ffd83dbSDimitry Andric #include <memory> 330b57cec5SDimitry Andric #include <utility> 340b57cec5SDimitry Andric 35*81ad6265SDimitry Andric #define DEBUG_TYPE "taint-checker" 36*81ad6265SDimitry Andric 370b57cec5SDimitry Andric using namespace clang; 380b57cec5SDimitry Andric using namespace ento; 390b57cec5SDimitry Andric using namespace taint; 400b57cec5SDimitry Andric 41*81ad6265SDimitry Andric using llvm::ImmutableSet; 42*81ad6265SDimitry Andric 430b57cec5SDimitry Andric namespace { 4404eeddc0SDimitry Andric 4504eeddc0SDimitry Andric class GenericTaintChecker; 4604eeddc0SDimitry Andric 4704eeddc0SDimitry Andric /// Check for CWE-134: Uncontrolled Format String. 4804eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgUncontrolledFormatString = 4904eeddc0SDimitry Andric "Untrusted data is used as a format string " 5004eeddc0SDimitry Andric "(CWE-134: Uncontrolled Format String)"; 5104eeddc0SDimitry Andric 5204eeddc0SDimitry Andric /// Check for: 5304eeddc0SDimitry Andric /// CERT/STR02-C. "Sanitize data passed to complex subsystems" 5404eeddc0SDimitry Andric /// CWE-78, "Failure to Sanitize Data into an OS Command" 5504eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgSanitizeSystemArgs = 5604eeddc0SDimitry Andric "Untrusted data is passed to a system call " 5704eeddc0SDimitry Andric "(CERT/STR02-C. Sanitize data passed to complex subsystems)"; 5804eeddc0SDimitry Andric 5904eeddc0SDimitry Andric /// Check if tainted data is used as a buffer size in strn.. functions, 6004eeddc0SDimitry Andric /// and allocators. 6104eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgTaintedBufferSize = 6204eeddc0SDimitry Andric "Untrusted data is used to specify the buffer size " 6304eeddc0SDimitry Andric "(CERT/STR31-C. Guarantee that storage for strings has sufficient space " 6404eeddc0SDimitry Andric "for character data and the null terminator)"; 6504eeddc0SDimitry Andric 6604eeddc0SDimitry Andric /// Check if tainted data is used as a custom sink's parameter. 6704eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgCustomSink = 6804eeddc0SDimitry Andric "Untrusted data is passed to a user-defined sink"; 6904eeddc0SDimitry Andric 7004eeddc0SDimitry Andric using ArgIdxTy = int; 7104eeddc0SDimitry Andric using ArgVecTy = llvm::SmallVector<ArgIdxTy, 2>; 7204eeddc0SDimitry Andric 7304eeddc0SDimitry Andric /// Denotes the return value. 7404eeddc0SDimitry Andric constexpr ArgIdxTy ReturnValueIndex{-1}; 7504eeddc0SDimitry Andric 7604eeddc0SDimitry Andric static ArgIdxTy fromArgumentCount(unsigned Count) { 7704eeddc0SDimitry Andric assert(Count <= 7804eeddc0SDimitry Andric static_cast<std::size_t>(std::numeric_limits<ArgIdxTy>::max()) && 7904eeddc0SDimitry Andric "ArgIdxTy is not large enough to represent the number of arguments."); 8004eeddc0SDimitry Andric return Count; 8104eeddc0SDimitry Andric } 8204eeddc0SDimitry Andric 8304eeddc0SDimitry Andric /// Check if the region the expression evaluates to is the standard input, 8404eeddc0SDimitry Andric /// and thus, is tainted. 8504eeddc0SDimitry Andric /// FIXME: Move this to Taint.cpp. 8604eeddc0SDimitry Andric bool isStdin(SVal Val, const ASTContext &ACtx) { 8704eeddc0SDimitry Andric // FIXME: What if Val is NonParamVarRegion? 8804eeddc0SDimitry Andric 8904eeddc0SDimitry Andric // The region should be symbolic, we do not know it's value. 9004eeddc0SDimitry Andric const auto *SymReg = dyn_cast_or_null<SymbolicRegion>(Val.getAsRegion()); 9104eeddc0SDimitry Andric if (!SymReg) 9204eeddc0SDimitry Andric return false; 9304eeddc0SDimitry Andric 9404eeddc0SDimitry Andric // Get it's symbol and find the declaration region it's pointing to. 95*81ad6265SDimitry Andric const auto *DeclReg = 96*81ad6265SDimitry Andric dyn_cast_or_null<DeclRegion>(SymReg->getSymbol()->getOriginRegion()); 9704eeddc0SDimitry Andric if (!DeclReg) 9804eeddc0SDimitry Andric return false; 9904eeddc0SDimitry Andric 10004eeddc0SDimitry Andric // This region corresponds to a declaration, find out if it's a global/extern 10104eeddc0SDimitry Andric // variable named stdin with the proper type. 10204eeddc0SDimitry Andric if (const auto *D = dyn_cast_or_null<VarDecl>(DeclReg->getDecl())) { 10304eeddc0SDimitry Andric D = D->getCanonicalDecl(); 10404eeddc0SDimitry Andric // FIXME: This should look for an exact match. 10504eeddc0SDimitry Andric if (D->getName().contains("stdin") && D->isExternC()) { 10604eeddc0SDimitry Andric const QualType FILETy = ACtx.getFILEType().getCanonicalType(); 10704eeddc0SDimitry Andric const QualType Ty = D->getType().getCanonicalType(); 10804eeddc0SDimitry Andric 10904eeddc0SDimitry Andric if (Ty->isPointerType()) 11004eeddc0SDimitry Andric return Ty->getPointeeType() == FILETy; 11104eeddc0SDimitry Andric } 11204eeddc0SDimitry Andric } 11304eeddc0SDimitry Andric return false; 11404eeddc0SDimitry Andric } 11504eeddc0SDimitry Andric 11604eeddc0SDimitry Andric SVal getPointeeOf(const CheckerContext &C, Loc LValue) { 11704eeddc0SDimitry Andric const QualType ArgTy = LValue.getType(C.getASTContext()); 11804eeddc0SDimitry Andric if (!ArgTy->isPointerType() || !ArgTy->getPointeeType()->isVoidType()) 11904eeddc0SDimitry Andric return C.getState()->getSVal(LValue); 12004eeddc0SDimitry Andric 12104eeddc0SDimitry Andric // Do not dereference void pointers. Treat them as byte pointers instead. 12204eeddc0SDimitry Andric // FIXME: we might want to consider more than just the first byte. 12304eeddc0SDimitry Andric return C.getState()->getSVal(LValue, C.getASTContext().CharTy); 12404eeddc0SDimitry Andric } 12504eeddc0SDimitry Andric 12604eeddc0SDimitry Andric /// Given a pointer/reference argument, return the value it refers to. 12704eeddc0SDimitry Andric Optional<SVal> getPointeeOf(const CheckerContext &C, SVal Arg) { 12804eeddc0SDimitry Andric if (auto LValue = Arg.getAs<Loc>()) 12904eeddc0SDimitry Andric return getPointeeOf(C, *LValue); 13004eeddc0SDimitry Andric return None; 13104eeddc0SDimitry Andric } 13204eeddc0SDimitry Andric 13304eeddc0SDimitry Andric /// Given a pointer, return the SVal of its pointee or if it is tainted, 13404eeddc0SDimitry Andric /// otherwise return the pointer's SVal if tainted. 13504eeddc0SDimitry Andric /// Also considers stdin as a taint source. 13604eeddc0SDimitry Andric Optional<SVal> getTaintedPointeeOrPointer(const CheckerContext &C, SVal Arg) { 13704eeddc0SDimitry Andric const ProgramStateRef State = C.getState(); 13804eeddc0SDimitry Andric 13904eeddc0SDimitry Andric if (auto Pointee = getPointeeOf(C, Arg)) 14004eeddc0SDimitry Andric if (isTainted(State, *Pointee)) // FIXME: isTainted(...) ? Pointee : None; 14104eeddc0SDimitry Andric return Pointee; 14204eeddc0SDimitry Andric 14304eeddc0SDimitry Andric if (isTainted(State, Arg)) 14404eeddc0SDimitry Andric return Arg; 14504eeddc0SDimitry Andric 14604eeddc0SDimitry Andric // FIXME: This should be done by the isTainted() API. 14704eeddc0SDimitry Andric if (isStdin(Arg, C.getASTContext())) 14804eeddc0SDimitry Andric return Arg; 14904eeddc0SDimitry Andric 15004eeddc0SDimitry Andric return None; 15104eeddc0SDimitry Andric } 15204eeddc0SDimitry Andric 15304eeddc0SDimitry Andric bool isTaintedOrPointsToTainted(const Expr *E, const ProgramStateRef &State, 15404eeddc0SDimitry Andric CheckerContext &C) { 155*81ad6265SDimitry Andric return getTaintedPointeeOrPointer(C, C.getSVal(E)).has_value(); 15604eeddc0SDimitry Andric } 15704eeddc0SDimitry Andric 15804eeddc0SDimitry Andric /// ArgSet is used to describe arguments relevant for taint detection or 15904eeddc0SDimitry Andric /// taint application. A discrete set of argument indexes and a variadic 16004eeddc0SDimitry Andric /// argument list signified by a starting index are supported. 16104eeddc0SDimitry Andric class ArgSet { 16204eeddc0SDimitry Andric public: 16304eeddc0SDimitry Andric ArgSet() = default; 16404eeddc0SDimitry Andric ArgSet(ArgVecTy &&DiscreteArgs, Optional<ArgIdxTy> VariadicIndex = None) 16504eeddc0SDimitry Andric : DiscreteArgs(std::move(DiscreteArgs)), 16604eeddc0SDimitry Andric VariadicIndex(std::move(VariadicIndex)) {} 16704eeddc0SDimitry Andric 16804eeddc0SDimitry Andric bool contains(ArgIdxTy ArgIdx) const { 16904eeddc0SDimitry Andric if (llvm::is_contained(DiscreteArgs, ArgIdx)) 17004eeddc0SDimitry Andric return true; 17104eeddc0SDimitry Andric 17204eeddc0SDimitry Andric return VariadicIndex && ArgIdx >= *VariadicIndex; 17304eeddc0SDimitry Andric } 17404eeddc0SDimitry Andric 17504eeddc0SDimitry Andric bool isEmpty() const { return DiscreteArgs.empty() && !VariadicIndex; } 17604eeddc0SDimitry Andric 17704eeddc0SDimitry Andric private: 17804eeddc0SDimitry Andric ArgVecTy DiscreteArgs; 17904eeddc0SDimitry Andric Optional<ArgIdxTy> VariadicIndex; 18004eeddc0SDimitry Andric }; 18104eeddc0SDimitry Andric 18204eeddc0SDimitry Andric /// A struct used to specify taint propagation rules for a function. 18304eeddc0SDimitry Andric /// 18404eeddc0SDimitry Andric /// If any of the possible taint source arguments is tainted, all of the 18504eeddc0SDimitry Andric /// destination arguments should also be tainted. If ReturnValueIndex is added 18604eeddc0SDimitry Andric /// to the dst list, the return value will be tainted. 18704eeddc0SDimitry Andric class GenericTaintRule { 18804eeddc0SDimitry Andric /// Arguments which are taints sinks and should be checked, and a report 18904eeddc0SDimitry Andric /// should be emitted if taint reaches these. 19004eeddc0SDimitry Andric ArgSet SinkArgs; 19104eeddc0SDimitry Andric /// Arguments which should be sanitized on function return. 19204eeddc0SDimitry Andric ArgSet FilterArgs; 19304eeddc0SDimitry Andric /// Arguments which can participate in taint propagationa. If any of the 19404eeddc0SDimitry Andric /// arguments in PropSrcArgs is tainted, all arguments in PropDstArgs should 19504eeddc0SDimitry Andric /// be tainted. 19604eeddc0SDimitry Andric ArgSet PropSrcArgs; 19704eeddc0SDimitry Andric ArgSet PropDstArgs; 19804eeddc0SDimitry Andric 19904eeddc0SDimitry Andric /// A message that explains why the call is sensitive to taint. 20004eeddc0SDimitry Andric Optional<StringRef> SinkMsg; 20104eeddc0SDimitry Andric 20204eeddc0SDimitry Andric GenericTaintRule() = default; 20304eeddc0SDimitry Andric 20404eeddc0SDimitry Andric GenericTaintRule(ArgSet &&Sink, ArgSet &&Filter, ArgSet &&Src, ArgSet &&Dst, 20504eeddc0SDimitry Andric Optional<StringRef> SinkMsg = None) 20604eeddc0SDimitry Andric : SinkArgs(std::move(Sink)), FilterArgs(std::move(Filter)), 20704eeddc0SDimitry Andric PropSrcArgs(std::move(Src)), PropDstArgs(std::move(Dst)), 20804eeddc0SDimitry Andric SinkMsg(SinkMsg) {} 20904eeddc0SDimitry Andric 21004eeddc0SDimitry Andric public: 21104eeddc0SDimitry Andric /// Make a rule that reports a warning if taint reaches any of \p FilterArgs 21204eeddc0SDimitry Andric /// arguments. 21304eeddc0SDimitry Andric static GenericTaintRule Sink(ArgSet &&SinkArgs, 21404eeddc0SDimitry Andric Optional<StringRef> Msg = None) { 21504eeddc0SDimitry Andric return {std::move(SinkArgs), {}, {}, {}, Msg}; 21604eeddc0SDimitry Andric } 21704eeddc0SDimitry Andric 21804eeddc0SDimitry Andric /// Make a rule that sanitizes all FilterArgs arguments. 21904eeddc0SDimitry Andric static GenericTaintRule Filter(ArgSet &&FilterArgs) { 22004eeddc0SDimitry Andric return {{}, std::move(FilterArgs), {}, {}}; 22104eeddc0SDimitry Andric } 22204eeddc0SDimitry Andric 22304eeddc0SDimitry Andric /// Make a rule that unconditionally taints all Args. 22404eeddc0SDimitry Andric /// If Func is provided, it must also return true for taint to propagate. 22504eeddc0SDimitry Andric static GenericTaintRule Source(ArgSet &&SourceArgs) { 22604eeddc0SDimitry Andric return {{}, {}, {}, std::move(SourceArgs)}; 22704eeddc0SDimitry Andric } 22804eeddc0SDimitry Andric 22904eeddc0SDimitry Andric /// Make a rule that taints all PropDstArgs if any of PropSrcArgs is tainted. 23004eeddc0SDimitry Andric static GenericTaintRule Prop(ArgSet &&SrcArgs, ArgSet &&DstArgs) { 23104eeddc0SDimitry Andric return {{}, {}, std::move(SrcArgs), std::move(DstArgs)}; 23204eeddc0SDimitry Andric } 23304eeddc0SDimitry Andric 23404eeddc0SDimitry Andric /// Make a rule that taints all PropDstArgs if any of PropSrcArgs is tainted. 23504eeddc0SDimitry Andric static GenericTaintRule SinkProp(ArgSet &&SinkArgs, ArgSet &&SrcArgs, 23604eeddc0SDimitry Andric ArgSet &&DstArgs, 23704eeddc0SDimitry Andric Optional<StringRef> Msg = None) { 23804eeddc0SDimitry Andric return { 23904eeddc0SDimitry Andric std::move(SinkArgs), {}, std::move(SrcArgs), std::move(DstArgs), Msg}; 24004eeddc0SDimitry Andric } 24104eeddc0SDimitry Andric 24204eeddc0SDimitry Andric /// Process a function which could either be a taint source, a taint sink, a 24304eeddc0SDimitry Andric /// taint filter or a taint propagator. 24404eeddc0SDimitry Andric void process(const GenericTaintChecker &Checker, const CallEvent &Call, 24504eeddc0SDimitry Andric CheckerContext &C) const; 24604eeddc0SDimitry Andric 24704eeddc0SDimitry Andric /// Handles the resolution of indexes of type ArgIdxTy to Expr*-s. 24804eeddc0SDimitry Andric static const Expr *GetArgExpr(ArgIdxTy ArgIdx, const CallEvent &Call) { 24904eeddc0SDimitry Andric return ArgIdx == ReturnValueIndex ? Call.getOriginExpr() 25004eeddc0SDimitry Andric : Call.getArgExpr(ArgIdx); 25104eeddc0SDimitry Andric }; 25204eeddc0SDimitry Andric 25304eeddc0SDimitry Andric /// Functions for custom taintedness propagation. 25404eeddc0SDimitry Andric static bool UntrustedEnv(CheckerContext &C); 25504eeddc0SDimitry Andric }; 25604eeddc0SDimitry Andric 25704eeddc0SDimitry Andric using RuleLookupTy = CallDescriptionMap<GenericTaintRule>; 25804eeddc0SDimitry Andric 25904eeddc0SDimitry Andric /// Used to parse the configuration file. 26004eeddc0SDimitry Andric struct TaintConfiguration { 26104eeddc0SDimitry Andric using NameScopeArgs = std::tuple<std::string, std::string, ArgVecTy>; 26204eeddc0SDimitry Andric enum class VariadicType { None, Src, Dst }; 26304eeddc0SDimitry Andric 26404eeddc0SDimitry Andric struct Common { 26504eeddc0SDimitry Andric std::string Name; 26604eeddc0SDimitry Andric std::string Scope; 26704eeddc0SDimitry Andric }; 26804eeddc0SDimitry Andric 26904eeddc0SDimitry Andric struct Sink : Common { 27004eeddc0SDimitry Andric ArgVecTy SinkArgs; 27104eeddc0SDimitry Andric }; 27204eeddc0SDimitry Andric 27304eeddc0SDimitry Andric struct Filter : Common { 27404eeddc0SDimitry Andric ArgVecTy FilterArgs; 27504eeddc0SDimitry Andric }; 27604eeddc0SDimitry Andric 27704eeddc0SDimitry Andric struct Propagation : Common { 27804eeddc0SDimitry Andric ArgVecTy SrcArgs; 27904eeddc0SDimitry Andric ArgVecTy DstArgs; 28004eeddc0SDimitry Andric VariadicType VarType; 28104eeddc0SDimitry Andric ArgIdxTy VarIndex; 28204eeddc0SDimitry Andric }; 28304eeddc0SDimitry Andric 28404eeddc0SDimitry Andric std::vector<Propagation> Propagations; 28504eeddc0SDimitry Andric std::vector<Filter> Filters; 28604eeddc0SDimitry Andric std::vector<Sink> Sinks; 28704eeddc0SDimitry Andric 28804eeddc0SDimitry Andric TaintConfiguration() = default; 28904eeddc0SDimitry Andric TaintConfiguration(const TaintConfiguration &) = default; 29004eeddc0SDimitry Andric TaintConfiguration(TaintConfiguration &&) = default; 29104eeddc0SDimitry Andric TaintConfiguration &operator=(const TaintConfiguration &) = default; 29204eeddc0SDimitry Andric TaintConfiguration &operator=(TaintConfiguration &&) = default; 29304eeddc0SDimitry Andric }; 29404eeddc0SDimitry Andric 29504eeddc0SDimitry Andric struct GenericTaintRuleParser { 29604eeddc0SDimitry Andric GenericTaintRuleParser(CheckerManager &Mgr) : Mgr(Mgr) {} 29704eeddc0SDimitry Andric /// Container type used to gather call identification objects grouped into 29804eeddc0SDimitry Andric /// pairs with their corresponding taint rules. It is temporary as it is used 29904eeddc0SDimitry Andric /// to finally initialize RuleLookupTy, which is considered to be immutable. 30004eeddc0SDimitry Andric using RulesContTy = std::vector<std::pair<CallDescription, GenericTaintRule>>; 30104eeddc0SDimitry Andric RulesContTy parseConfiguration(const std::string &Option, 30204eeddc0SDimitry Andric TaintConfiguration &&Config) const; 30304eeddc0SDimitry Andric 30404eeddc0SDimitry Andric private: 30504eeddc0SDimitry Andric using NamePartsTy = llvm::SmallVector<SmallString<32>, 2>; 30604eeddc0SDimitry Andric 30704eeddc0SDimitry Andric /// Validate part of the configuration, which contains a list of argument 30804eeddc0SDimitry Andric /// indexes. 30904eeddc0SDimitry Andric void validateArgVector(const std::string &Option, const ArgVecTy &Args) const; 31004eeddc0SDimitry Andric 31104eeddc0SDimitry Andric template <typename Config> static NamePartsTy parseNameParts(const Config &C); 31204eeddc0SDimitry Andric 31304eeddc0SDimitry Andric // Takes the config and creates a CallDescription for it and associates a Rule 31404eeddc0SDimitry Andric // with that. 31504eeddc0SDimitry Andric template <typename Config> 31604eeddc0SDimitry Andric static void consumeRulesFromConfig(const Config &C, GenericTaintRule &&Rule, 31704eeddc0SDimitry Andric RulesContTy &Rules); 31804eeddc0SDimitry Andric 31904eeddc0SDimitry Andric void parseConfig(const std::string &Option, TaintConfiguration::Sink &&P, 32004eeddc0SDimitry Andric RulesContTy &Rules) const; 32104eeddc0SDimitry Andric void parseConfig(const std::string &Option, TaintConfiguration::Filter &&P, 32204eeddc0SDimitry Andric RulesContTy &Rules) const; 32304eeddc0SDimitry Andric void parseConfig(const std::string &Option, 32404eeddc0SDimitry Andric TaintConfiguration::Propagation &&P, 32504eeddc0SDimitry Andric RulesContTy &Rules) const; 32604eeddc0SDimitry Andric 32704eeddc0SDimitry Andric CheckerManager &Mgr; 32804eeddc0SDimitry Andric }; 32904eeddc0SDimitry Andric 3305ffd83dbSDimitry Andric class GenericTaintChecker : public Checker<check::PreCall, check::PostCall> { 3310b57cec5SDimitry Andric public: 3325ffd83dbSDimitry Andric void checkPreCall(const CallEvent &Call, CheckerContext &C) const; 3335ffd83dbSDimitry Andric void checkPostCall(const CallEvent &Call, CheckerContext &C) const; 3340b57cec5SDimitry Andric 335a7dea167SDimitry Andric void printState(raw_ostream &Out, ProgramStateRef State, const char *NL, 336a7dea167SDimitry Andric const char *Sep) const override; 337a7dea167SDimitry Andric 338a7dea167SDimitry Andric /// Generate a report if the expression is tainted or points to tainted data. 339a7dea167SDimitry Andric bool generateReportIfTainted(const Expr *E, StringRef Msg, 340a7dea167SDimitry Andric CheckerContext &C) const; 341a7dea167SDimitry Andric 34204eeddc0SDimitry Andric private: 34304eeddc0SDimitry Andric const BugType BT{this, "Use of Untrusted Data", "Untrusted Data"}; 344480093f4SDimitry Andric 34504eeddc0SDimitry Andric bool checkUncontrolledFormatString(const CallEvent &Call, 34604eeddc0SDimitry Andric CheckerContext &C) const; 3470b57cec5SDimitry Andric 34804eeddc0SDimitry Andric void taintUnsafeSocketProtocol(const CallEvent &Call, 34904eeddc0SDimitry Andric CheckerContext &C) const; 3500b57cec5SDimitry Andric 35104eeddc0SDimitry Andric /// Default taint rules are initilized with the help of a CheckerContext to 35204eeddc0SDimitry Andric /// access the names of built-in functions like memcpy. 35304eeddc0SDimitry Andric void initTaintRules(CheckerContext &C) const; 3540b57cec5SDimitry Andric 35504eeddc0SDimitry Andric /// CallDescription currently cannot restrict matches to the global namespace 35604eeddc0SDimitry Andric /// only, which is why multiple CallDescriptionMaps are used, as we want to 35704eeddc0SDimitry Andric /// disambiguate global C functions from functions inside user-defined 35804eeddc0SDimitry Andric /// namespaces. 35904eeddc0SDimitry Andric // TODO: Remove separation to simplify matching logic once CallDescriptions 36004eeddc0SDimitry Andric // are more expressive. 3610b57cec5SDimitry Andric 36204eeddc0SDimitry Andric mutable Optional<RuleLookupTy> StaticTaintRules; 36304eeddc0SDimitry Andric mutable Optional<RuleLookupTy> DynamicTaintRules; 3640b57cec5SDimitry Andric }; 3650b57cec5SDimitry Andric } // end of anonymous namespace 3660b57cec5SDimitry Andric 36704eeddc0SDimitry Andric /// YAML serialization mapping. 36804eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Sink) 36904eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Filter) 37004eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Propagation) 371a7dea167SDimitry Andric 372a7dea167SDimitry Andric namespace llvm { 373a7dea167SDimitry Andric namespace yaml { 37404eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration> { 37504eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration &Config) { 376a7dea167SDimitry Andric IO.mapOptional("Propagations", Config.Propagations); 377a7dea167SDimitry Andric IO.mapOptional("Filters", Config.Filters); 378a7dea167SDimitry Andric IO.mapOptional("Sinks", Config.Sinks); 379a7dea167SDimitry Andric } 380a7dea167SDimitry Andric }; 381a7dea167SDimitry Andric 38204eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Sink> { 38304eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Sink &Sink) { 38404eeddc0SDimitry Andric IO.mapRequired("Name", Sink.Name); 38504eeddc0SDimitry Andric IO.mapOptional("Scope", Sink.Scope); 38604eeddc0SDimitry Andric IO.mapRequired("Args", Sink.SinkArgs); 38704eeddc0SDimitry Andric } 38804eeddc0SDimitry Andric }; 38904eeddc0SDimitry Andric 39004eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Filter> { 39104eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Filter &Filter) { 39204eeddc0SDimitry Andric IO.mapRequired("Name", Filter.Name); 39304eeddc0SDimitry Andric IO.mapOptional("Scope", Filter.Scope); 39404eeddc0SDimitry Andric IO.mapRequired("Args", Filter.FilterArgs); 39504eeddc0SDimitry Andric } 39604eeddc0SDimitry Andric }; 39704eeddc0SDimitry Andric 39804eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Propagation> { 39904eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Propagation &Propagation) { 400a7dea167SDimitry Andric IO.mapRequired("Name", Propagation.Name); 401480093f4SDimitry Andric IO.mapOptional("Scope", Propagation.Scope); 402a7dea167SDimitry Andric IO.mapOptional("SrcArgs", Propagation.SrcArgs); 403a7dea167SDimitry Andric IO.mapOptional("DstArgs", Propagation.DstArgs); 40404eeddc0SDimitry Andric IO.mapOptional("VariadicType", Propagation.VarType); 40504eeddc0SDimitry Andric IO.mapOptional("VariadicIndex", Propagation.VarIndex); 406a7dea167SDimitry Andric } 407a7dea167SDimitry Andric }; 408a7dea167SDimitry Andric 40904eeddc0SDimitry Andric template <> struct ScalarEnumerationTraits<TaintConfiguration::VariadicType> { 41004eeddc0SDimitry Andric static void enumeration(IO &IO, TaintConfiguration::VariadicType &Value) { 41104eeddc0SDimitry Andric IO.enumCase(Value, "None", TaintConfiguration::VariadicType::None); 41204eeddc0SDimitry Andric IO.enumCase(Value, "Src", TaintConfiguration::VariadicType::Src); 41304eeddc0SDimitry Andric IO.enumCase(Value, "Dst", TaintConfiguration::VariadicType::Dst); 414a7dea167SDimitry Andric } 415a7dea167SDimitry Andric }; 416a7dea167SDimitry Andric } // namespace yaml 417a7dea167SDimitry Andric } // namespace llvm 418a7dea167SDimitry Andric 4190b57cec5SDimitry Andric /// A set which is used to pass information from call pre-visit instruction 42004eeddc0SDimitry Andric /// to the call post-visit. The values are signed integers, which are either 4210b57cec5SDimitry Andric /// ReturnValueIndex, or indexes of the pointer/reference argument, which 4220b57cec5SDimitry Andric /// points to data, which should be tainted on return. 423*81ad6265SDimitry Andric REGISTER_MAP_WITH_PROGRAMSTATE(TaintArgsOnPostVisit, const LocationContext *, 424*81ad6265SDimitry Andric ImmutableSet<ArgIdxTy>) 425*81ad6265SDimitry Andric REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(ArgIdxFactory, ArgIdxTy) 4260b57cec5SDimitry Andric 42704eeddc0SDimitry Andric void GenericTaintRuleParser::validateArgVector(const std::string &Option, 42804eeddc0SDimitry Andric const ArgVecTy &Args) const { 42904eeddc0SDimitry Andric for (ArgIdxTy Arg : Args) { 43004eeddc0SDimitry Andric if (Arg < ReturnValueIndex) { 431a7dea167SDimitry Andric Mgr.reportInvalidCheckerOptionValue( 43204eeddc0SDimitry Andric Mgr.getChecker<GenericTaintChecker>(), Option, 433a7dea167SDimitry Andric "an argument number for propagation rules greater or equal to -1"); 434a7dea167SDimitry Andric } 435a7dea167SDimitry Andric } 436a7dea167SDimitry Andric } 437a7dea167SDimitry Andric 43804eeddc0SDimitry Andric template <typename Config> 43904eeddc0SDimitry Andric GenericTaintRuleParser::NamePartsTy 44004eeddc0SDimitry Andric GenericTaintRuleParser::parseNameParts(const Config &C) { 44104eeddc0SDimitry Andric NamePartsTy NameParts; 44204eeddc0SDimitry Andric if (!C.Scope.empty()) { 44304eeddc0SDimitry Andric // If the Scope argument contains multiple "::" parts, those are considered 44404eeddc0SDimitry Andric // namespace identifiers. 44504eeddc0SDimitry Andric llvm::SmallVector<StringRef, 2> NSParts; 44604eeddc0SDimitry Andric StringRef{C.Scope}.split(NSParts, "::", /*MaxSplit*/ -1, 44704eeddc0SDimitry Andric /*KeepEmpty*/ false); 44804eeddc0SDimitry Andric NameParts.append(NSParts.begin(), NSParts.end()); 44904eeddc0SDimitry Andric } 45004eeddc0SDimitry Andric NameParts.emplace_back(C.Name); 45104eeddc0SDimitry Andric return NameParts; 452480093f4SDimitry Andric } 453480093f4SDimitry Andric 45404eeddc0SDimitry Andric template <typename Config> 45504eeddc0SDimitry Andric void GenericTaintRuleParser::consumeRulesFromConfig(const Config &C, 45604eeddc0SDimitry Andric GenericTaintRule &&Rule, 45704eeddc0SDimitry Andric RulesContTy &Rules) { 45804eeddc0SDimitry Andric NamePartsTy NameParts = parseNameParts(C); 45904eeddc0SDimitry Andric llvm::SmallVector<const char *, 2> CallDescParts{NameParts.size()}; 46004eeddc0SDimitry Andric llvm::transform(NameParts, CallDescParts.begin(), 46104eeddc0SDimitry Andric [](SmallString<32> &S) { return S.c_str(); }); 46204eeddc0SDimitry Andric Rules.emplace_back(CallDescription(CallDescParts), std::move(Rule)); 46304eeddc0SDimitry Andric } 4640b57cec5SDimitry Andric 46504eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 46604eeddc0SDimitry Andric TaintConfiguration::Sink &&S, 46704eeddc0SDimitry Andric RulesContTy &Rules) const { 46804eeddc0SDimitry Andric validateArgVector(Option, S.SinkArgs); 46904eeddc0SDimitry Andric consumeRulesFromConfig(S, GenericTaintRule::Sink(std::move(S.SinkArgs)), 47004eeddc0SDimitry Andric Rules); 47104eeddc0SDimitry Andric } 47204eeddc0SDimitry Andric 47304eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 47404eeddc0SDimitry Andric TaintConfiguration::Filter &&S, 47504eeddc0SDimitry Andric RulesContTy &Rules) const { 47604eeddc0SDimitry Andric validateArgVector(Option, S.FilterArgs); 47704eeddc0SDimitry Andric consumeRulesFromConfig(S, GenericTaintRule::Filter(std::move(S.FilterArgs)), 47804eeddc0SDimitry Andric Rules); 47904eeddc0SDimitry Andric } 48004eeddc0SDimitry Andric 48104eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 48204eeddc0SDimitry Andric TaintConfiguration::Propagation &&P, 48304eeddc0SDimitry Andric RulesContTy &Rules) const { 48404eeddc0SDimitry Andric validateArgVector(Option, P.SrcArgs); 48504eeddc0SDimitry Andric validateArgVector(Option, P.DstArgs); 48604eeddc0SDimitry Andric bool IsSrcVariadic = P.VarType == TaintConfiguration::VariadicType::Src; 48704eeddc0SDimitry Andric bool IsDstVariadic = P.VarType == TaintConfiguration::VariadicType::Dst; 48804eeddc0SDimitry Andric Optional<ArgIdxTy> JustVarIndex = P.VarIndex; 48904eeddc0SDimitry Andric 49004eeddc0SDimitry Andric ArgSet SrcDesc(std::move(P.SrcArgs), IsSrcVariadic ? JustVarIndex : None); 49104eeddc0SDimitry Andric ArgSet DstDesc(std::move(P.DstArgs), IsDstVariadic ? JustVarIndex : None); 49204eeddc0SDimitry Andric 49304eeddc0SDimitry Andric consumeRulesFromConfig( 49404eeddc0SDimitry Andric P, GenericTaintRule::Prop(std::move(SrcDesc), std::move(DstDesc)), Rules); 49504eeddc0SDimitry Andric } 49604eeddc0SDimitry Andric 49704eeddc0SDimitry Andric GenericTaintRuleParser::RulesContTy 49804eeddc0SDimitry Andric GenericTaintRuleParser::parseConfiguration(const std::string &Option, 49904eeddc0SDimitry Andric TaintConfiguration &&Config) const { 50004eeddc0SDimitry Andric 50104eeddc0SDimitry Andric RulesContTy Rules; 50204eeddc0SDimitry Andric 50304eeddc0SDimitry Andric for (auto &F : Config.Filters) 50404eeddc0SDimitry Andric parseConfig(Option, std::move(F), Rules); 50504eeddc0SDimitry Andric 50604eeddc0SDimitry Andric for (auto &S : Config.Sinks) 50704eeddc0SDimitry Andric parseConfig(Option, std::move(S), Rules); 50804eeddc0SDimitry Andric 50904eeddc0SDimitry Andric for (auto &P : Config.Propagations) 51004eeddc0SDimitry Andric parseConfig(Option, std::move(P), Rules); 51104eeddc0SDimitry Andric 51204eeddc0SDimitry Andric return Rules; 51304eeddc0SDimitry Andric } 51404eeddc0SDimitry Andric 51504eeddc0SDimitry Andric void GenericTaintChecker::initTaintRules(CheckerContext &C) const { 5160b57cec5SDimitry Andric // Check for exact name match for functions without builtin substitutes. 517480093f4SDimitry Andric // Use qualified name, because these are C functions without namespace. 5180b57cec5SDimitry Andric 51904eeddc0SDimitry Andric if (StaticTaintRules || DynamicTaintRules) 52004eeddc0SDimitry Andric return; 52104eeddc0SDimitry Andric 52204eeddc0SDimitry Andric using RulesConstructionTy = 52304eeddc0SDimitry Andric std::vector<std::pair<CallDescription, GenericTaintRule>>; 52404eeddc0SDimitry Andric using TR = GenericTaintRule; 52504eeddc0SDimitry Andric 52604eeddc0SDimitry Andric const Builtin::Context &BI = C.getASTContext().BuiltinInfo; 52704eeddc0SDimitry Andric 52804eeddc0SDimitry Andric RulesConstructionTy GlobalCRules{ 52904eeddc0SDimitry Andric // Sources 53004eeddc0SDimitry Andric {{"fdopen"}, TR::Source({{ReturnValueIndex}})}, 53104eeddc0SDimitry Andric {{"fopen"}, TR::Source({{ReturnValueIndex}})}, 53204eeddc0SDimitry Andric {{"freopen"}, TR::Source({{ReturnValueIndex}})}, 53304eeddc0SDimitry Andric {{"getch"}, TR::Source({{ReturnValueIndex}})}, 53404eeddc0SDimitry Andric {{"getchar"}, TR::Source({{ReturnValueIndex}})}, 53504eeddc0SDimitry Andric {{"getchar_unlocked"}, TR::Source({{ReturnValueIndex}})}, 53604eeddc0SDimitry Andric {{"gets"}, TR::Source({{0}, ReturnValueIndex})}, 537*81ad6265SDimitry Andric {{"gets_s"}, TR::Source({{0}, ReturnValueIndex})}, 53804eeddc0SDimitry Andric {{"scanf"}, TR::Source({{}, 1})}, 539*81ad6265SDimitry Andric {{"scanf_s"}, TR::Source({{}, {1}})}, 54004eeddc0SDimitry Andric {{"wgetch"}, TR::Source({{}, ReturnValueIndex})}, 541*81ad6265SDimitry Andric // Sometimes the line between taint sources and propagators is blurry. 542*81ad6265SDimitry Andric // _IO_getc is choosen to be a source, but could also be a propagator. 543*81ad6265SDimitry Andric // This way it is simpler, as modeling it as a propagator would require 544*81ad6265SDimitry Andric // to model the possible sources of _IO_FILE * values, which the _IO_getc 545*81ad6265SDimitry Andric // function takes as parameters. 546*81ad6265SDimitry Andric {{"_IO_getc"}, TR::Source({{ReturnValueIndex}})}, 547*81ad6265SDimitry Andric {{"getcwd"}, TR::Source({{0, ReturnValueIndex}})}, 548*81ad6265SDimitry Andric {{"getwd"}, TR::Source({{0, ReturnValueIndex}})}, 549*81ad6265SDimitry Andric {{"readlink"}, TR::Source({{1, ReturnValueIndex}})}, 550*81ad6265SDimitry Andric {{"readlinkat"}, TR::Source({{2, ReturnValueIndex}})}, 551*81ad6265SDimitry Andric {{"get_current_dir_name"}, TR::Source({{ReturnValueIndex}})}, 552*81ad6265SDimitry Andric {{"gethostname"}, TR::Source({{0}})}, 553*81ad6265SDimitry Andric {{"getnameinfo"}, TR::Source({{2, 4}})}, 554*81ad6265SDimitry Andric {{"getseuserbyname"}, TR::Source({{1, 2}})}, 555*81ad6265SDimitry Andric {{"getgroups"}, TR::Source({{1, ReturnValueIndex}})}, 556*81ad6265SDimitry Andric {{"getlogin"}, TR::Source({{ReturnValueIndex}})}, 557*81ad6265SDimitry Andric {{"getlogin_r"}, TR::Source({{0}})}, 55804eeddc0SDimitry Andric 55904eeddc0SDimitry Andric // Props 56004eeddc0SDimitry Andric {{"atoi"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 56104eeddc0SDimitry Andric {{"atol"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 56204eeddc0SDimitry Andric {{"atoll"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 56304eeddc0SDimitry Andric {{"fgetc"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 56404eeddc0SDimitry Andric {{"fgetln"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 565*81ad6265SDimitry Andric {{"fgets"}, TR::Prop({{2}}, {{0, ReturnValueIndex}})}, 56604eeddc0SDimitry Andric {{"fscanf"}, TR::Prop({{0}}, {{}, 2})}, 567*81ad6265SDimitry Andric {{"fscanf_s"}, TR::Prop({{0}}, {{}, {2}})}, 56804eeddc0SDimitry Andric {{"sscanf"}, TR::Prop({{0}}, {{}, 2})}, 569*81ad6265SDimitry Andric 57004eeddc0SDimitry Andric {{"getc"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 57104eeddc0SDimitry Andric {{"getc_unlocked"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 57204eeddc0SDimitry Andric {{"getdelim"}, TR::Prop({{3}}, {{0}})}, 57304eeddc0SDimitry Andric {{"getline"}, TR::Prop({{2}}, {{0}})}, 57404eeddc0SDimitry Andric {{"getw"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 57504eeddc0SDimitry Andric {{"pread"}, TR::Prop({{0, 1, 2, 3}}, {{1, ReturnValueIndex}})}, 57604eeddc0SDimitry Andric {{"read"}, TR::Prop({{0, 2}}, {{1, ReturnValueIndex}})}, 57704eeddc0SDimitry Andric {{"strchr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 57804eeddc0SDimitry Andric {{"strrchr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 57904eeddc0SDimitry Andric {{"tolower"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 58004eeddc0SDimitry Andric {{"toupper"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 581*81ad6265SDimitry Andric {{"fread"}, TR::Prop({{3}}, {{0, ReturnValueIndex}})}, 582*81ad6265SDimitry Andric {{"recv"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 583*81ad6265SDimitry Andric {{"recvfrom"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 584*81ad6265SDimitry Andric 585*81ad6265SDimitry Andric {{"ttyname"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 586*81ad6265SDimitry Andric {{"ttyname_r"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 587*81ad6265SDimitry Andric 588*81ad6265SDimitry Andric {{"basename"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 589*81ad6265SDimitry Andric {{"dirname"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 590*81ad6265SDimitry Andric {{"fnmatch"}, TR::Prop({{1}}, {{ReturnValueIndex}})}, 591*81ad6265SDimitry Andric {{"memchr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 592*81ad6265SDimitry Andric {{"memrchr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 593*81ad6265SDimitry Andric {{"rawmemchr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 594*81ad6265SDimitry Andric 595*81ad6265SDimitry Andric {{"mbtowc"}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 596*81ad6265SDimitry Andric {{"wctomb"}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 597*81ad6265SDimitry Andric {{"wcwidth"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 598*81ad6265SDimitry Andric 599*81ad6265SDimitry Andric {{"memcmp"}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 600*81ad6265SDimitry Andric {{"memcpy"}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 601*81ad6265SDimitry Andric {{"memmove"}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 602*81ad6265SDimitry Andric // If memmem was called with a tainted needle and the search was 603*81ad6265SDimitry Andric // successful, that would mean that the value pointed by the return value 604*81ad6265SDimitry Andric // has the same content as the needle. If we choose to go by the policy of 605*81ad6265SDimitry Andric // content equivalence implies taintedness equivalence, that would mean 606*81ad6265SDimitry Andric // haystack should be considered a propagation source argument. 607*81ad6265SDimitry Andric {{"memmem"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 608*81ad6265SDimitry Andric 609*81ad6265SDimitry Andric // The comment for memmem above also applies to strstr. 610*81ad6265SDimitry Andric {{"strstr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 611*81ad6265SDimitry Andric {{"strcasestr"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 612*81ad6265SDimitry Andric 613*81ad6265SDimitry Andric {{"strchrnul"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 614*81ad6265SDimitry Andric 615*81ad6265SDimitry Andric {{"index"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 616*81ad6265SDimitry Andric {{"rindex"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 617*81ad6265SDimitry Andric 618*81ad6265SDimitry Andric // FIXME: In case of arrays, only the first element of the array gets 619*81ad6265SDimitry Andric // tainted. 620*81ad6265SDimitry Andric {{"qsort"}, TR::Prop({{0}}, {{0}})}, 621*81ad6265SDimitry Andric {{"qsort_r"}, TR::Prop({{0}}, {{0}})}, 622*81ad6265SDimitry Andric 623*81ad6265SDimitry Andric {{"strcmp"}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 624*81ad6265SDimitry Andric {{"strcasecmp"}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 625*81ad6265SDimitry Andric {{"strncmp"}, TR::Prop({{0, 1, 2}}, {{ReturnValueIndex}})}, 626*81ad6265SDimitry Andric {{"strncasecmp"}, TR::Prop({{0, 1, 2}}, {{ReturnValueIndex}})}, 627*81ad6265SDimitry Andric {{"strspn"}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 628*81ad6265SDimitry Andric {{"strcspn"}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 629*81ad6265SDimitry Andric {{"strpbrk"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 630*81ad6265SDimitry Andric {{"strndup"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 631*81ad6265SDimitry Andric {{"strndupa"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 632*81ad6265SDimitry Andric {{"strlen"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 633*81ad6265SDimitry Andric {{"strnlen"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 634*81ad6265SDimitry Andric {{"strtol"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 635*81ad6265SDimitry Andric {{"strtoll"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 636*81ad6265SDimitry Andric {{"strtoul"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 637*81ad6265SDimitry Andric {{"strtoull"}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 638*81ad6265SDimitry Andric 639*81ad6265SDimitry Andric {{"isalnum"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 640*81ad6265SDimitry Andric {{"isalpha"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 641*81ad6265SDimitry Andric {{"isascii"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 642*81ad6265SDimitry Andric {{"isblank"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 643*81ad6265SDimitry Andric {{"iscntrl"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 644*81ad6265SDimitry Andric {{"isdigit"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 645*81ad6265SDimitry Andric {{"isgraph"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 646*81ad6265SDimitry Andric {{"islower"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 647*81ad6265SDimitry Andric {{"isprint"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 648*81ad6265SDimitry Andric {{"ispunct"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 649*81ad6265SDimitry Andric {{"isspace"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 650*81ad6265SDimitry Andric {{"isupper"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 651*81ad6265SDimitry Andric {{"isxdigit"}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 652*81ad6265SDimitry Andric 65304eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BIstrncat)}}, 65404eeddc0SDimitry Andric TR::Prop({{1, 2}}, {{0, ReturnValueIndex}})}, 65504eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BIstrlcpy)}}, 65604eeddc0SDimitry Andric TR::Prop({{1, 2}}, {{0}})}, 65704eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BIstrlcat)}}, 65804eeddc0SDimitry Andric TR::Prop({{1, 2}}, {{0}})}, 65904eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"snprintf"}}, 66004eeddc0SDimitry Andric TR::Prop({{1}, 3}, {{0, ReturnValueIndex}})}, 66104eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"sprintf"}}, 66204eeddc0SDimitry Andric TR::Prop({{1}, 2}, {{0, ReturnValueIndex}})}, 66304eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"strcpy"}}, 66404eeddc0SDimitry Andric TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 66504eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"stpcpy"}}, 66604eeddc0SDimitry Andric TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 66704eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"strcat"}}, 66804eeddc0SDimitry Andric TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 66904eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"strdup"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 67004eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"strdupa"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 67104eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"wcsdup"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 67204eeddc0SDimitry Andric 67304eeddc0SDimitry Andric // Sinks 67404eeddc0SDimitry Andric {{"system"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 67504eeddc0SDimitry Andric {{"popen"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 67604eeddc0SDimitry Andric {{"execl"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 67704eeddc0SDimitry Andric {{"execle"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 67804eeddc0SDimitry Andric {{"execlp"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 67904eeddc0SDimitry Andric {{"execvp"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 68004eeddc0SDimitry Andric {{"execvP"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 68104eeddc0SDimitry Andric {{"execve"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 68204eeddc0SDimitry Andric {{"dlopen"}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 68304eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"malloc"}}, TR::Sink({{0}}, MsgTaintedBufferSize)}, 68404eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"calloc"}}, TR::Sink({{0}}, MsgTaintedBufferSize)}, 68504eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"alloca"}}, TR::Sink({{0}}, MsgTaintedBufferSize)}, 68604eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"memccpy"}}, TR::Sink({{3}}, MsgTaintedBufferSize)}, 68704eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"realloc"}}, TR::Sink({{1}}, MsgTaintedBufferSize)}, 68804eeddc0SDimitry Andric {{{"setproctitle"}}, TR::Sink({{0}, 1}, MsgUncontrolledFormatString)}, 68904eeddc0SDimitry Andric {{{"setproctitle_fast"}}, 69004eeddc0SDimitry Andric TR::Sink({{0}, 1}, MsgUncontrolledFormatString)}, 69104eeddc0SDimitry Andric 69204eeddc0SDimitry Andric // SinkProps 69304eeddc0SDimitry Andric {{CDF_MaybeBuiltin, BI.getName(Builtin::BImemcpy)}, 69404eeddc0SDimitry Andric TR::SinkProp({{2}}, {{1, 2}}, {{0, ReturnValueIndex}}, 69504eeddc0SDimitry Andric MsgTaintedBufferSize)}, 69604eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BImemmove)}}, 69704eeddc0SDimitry Andric TR::SinkProp({{2}}, {{1, 2}}, {{0, ReturnValueIndex}}, 69804eeddc0SDimitry Andric MsgTaintedBufferSize)}, 69904eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BIstrncpy)}}, 70004eeddc0SDimitry Andric TR::SinkProp({{2}}, {{1, 2}}, {{0, ReturnValueIndex}}, 70104eeddc0SDimitry Andric MsgTaintedBufferSize)}, 70204eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {BI.getName(Builtin::BIstrndup)}}, 70304eeddc0SDimitry Andric TR::SinkProp({{1}}, {{0, 1}}, {{ReturnValueIndex}}, 70404eeddc0SDimitry Andric MsgTaintedBufferSize)}, 70504eeddc0SDimitry Andric {{CDF_MaybeBuiltin, {"bcopy"}}, 70604eeddc0SDimitry Andric TR::SinkProp({{2}}, {{0, 2}}, {{1}}, MsgTaintedBufferSize)}}; 707349cc55cSDimitry Andric 708349cc55cSDimitry Andric // `getenv` returns taint only in untrusted environments. 70904eeddc0SDimitry Andric if (TR::UntrustedEnv(C)) { 71004eeddc0SDimitry Andric // void setproctitle_init(int argc, char *argv[], char *envp[]) 71104eeddc0SDimitry Andric GlobalCRules.push_back( 712*81ad6265SDimitry Andric {{{"setproctitle_init"}}, TR::Sink({{1, 2}}, MsgCustomSink)}); 71304eeddc0SDimitry Andric GlobalCRules.push_back({{"getenv"}, TR::Source({{ReturnValueIndex}})}); 714349cc55cSDimitry Andric } 715349cc55cSDimitry Andric 71604eeddc0SDimitry Andric StaticTaintRules.emplace(std::make_move_iterator(GlobalCRules.begin()), 71704eeddc0SDimitry Andric std::make_move_iterator(GlobalCRules.end())); 7180b57cec5SDimitry Andric 71904eeddc0SDimitry Andric // User-provided taint configuration. 72004eeddc0SDimitry Andric CheckerManager *Mgr = C.getAnalysisManager().getCheckerManager(); 72104eeddc0SDimitry Andric assert(Mgr); 72204eeddc0SDimitry Andric GenericTaintRuleParser ConfigParser{*Mgr}; 72304eeddc0SDimitry Andric std::string Option{"Config"}; 72404eeddc0SDimitry Andric StringRef ConfigFile = 72504eeddc0SDimitry Andric Mgr->getAnalyzerOptions().getCheckerStringOption(this, Option); 72604eeddc0SDimitry Andric llvm::Optional<TaintConfiguration> Config = 72704eeddc0SDimitry Andric getConfiguration<TaintConfiguration>(*Mgr, this, Option, ConfigFile); 72804eeddc0SDimitry Andric if (!Config) { 72904eeddc0SDimitry Andric // We don't have external taint config, no parsing required. 73004eeddc0SDimitry Andric DynamicTaintRules = RuleLookupTy{}; 73104eeddc0SDimitry Andric return; 7325ffd83dbSDimitry Andric } 7330b57cec5SDimitry Andric 73404eeddc0SDimitry Andric GenericTaintRuleParser::RulesContTy Rules{ 735*81ad6265SDimitry Andric ConfigParser.parseConfiguration(Option, std::move(*Config))}; 7360b57cec5SDimitry Andric 73704eeddc0SDimitry Andric DynamicTaintRules.emplace(std::make_move_iterator(Rules.begin()), 73804eeddc0SDimitry Andric std::make_move_iterator(Rules.end())); 739480093f4SDimitry Andric } 740a7dea167SDimitry Andric 7415ffd83dbSDimitry Andric void GenericTaintChecker::checkPreCall(const CallEvent &Call, 7420b57cec5SDimitry Andric CheckerContext &C) const { 74304eeddc0SDimitry Andric initTaintRules(C); 744480093f4SDimitry Andric 74504eeddc0SDimitry Andric // FIXME: this should be much simpler. 74604eeddc0SDimitry Andric if (const auto *Rule = 74704eeddc0SDimitry Andric Call.isGlobalCFunction() ? StaticTaintRules->lookup(Call) : nullptr) 74804eeddc0SDimitry Andric Rule->process(*this, Call, C); 74904eeddc0SDimitry Andric else if (const auto *Rule = DynamicTaintRules->lookup(Call)) 75004eeddc0SDimitry Andric Rule->process(*this, Call, C); 7510b57cec5SDimitry Andric 75204eeddc0SDimitry Andric // FIXME: These edge cases are to be eliminated from here eventually. 75304eeddc0SDimitry Andric // 75404eeddc0SDimitry Andric // Additional check that is not supported by CallDescription. 75504eeddc0SDimitry Andric // TODO: Make CallDescription be able to match attributes such as printf-like 75604eeddc0SDimitry Andric // arguments. 75704eeddc0SDimitry Andric checkUncontrolledFormatString(Call, C); 758480093f4SDimitry Andric 75904eeddc0SDimitry Andric // TODO: Modeling sockets should be done in a specific checker. 76004eeddc0SDimitry Andric // Socket is a source, which taints the return value. 76104eeddc0SDimitry Andric taintUnsafeSocketProtocol(Call, C); 7620b57cec5SDimitry Andric } 7630b57cec5SDimitry Andric 7645ffd83dbSDimitry Andric void GenericTaintChecker::checkPostCall(const CallEvent &Call, 7650b57cec5SDimitry Andric CheckerContext &C) const { 7660b57cec5SDimitry Andric // Set the marked values as tainted. The return value only accessible from 7670b57cec5SDimitry Andric // checkPostStmt. 7680b57cec5SDimitry Andric ProgramStateRef State = C.getState(); 769*81ad6265SDimitry Andric const StackFrameContext *CurrentFrame = C.getStackFrame(); 7700b57cec5SDimitry Andric 7710b57cec5SDimitry Andric // Depending on what was tainted at pre-visit, we determined a set of 7720b57cec5SDimitry Andric // arguments which should be tainted after the function returns. These are 7730b57cec5SDimitry Andric // stored in the state as TaintArgsOnPostVisit set. 774*81ad6265SDimitry Andric TaintArgsOnPostVisitTy TaintArgsMap = State->get<TaintArgsOnPostVisit>(); 7750b57cec5SDimitry Andric 776*81ad6265SDimitry Andric const ImmutableSet<ArgIdxTy> *TaintArgs = TaintArgsMap.lookup(CurrentFrame); 777*81ad6265SDimitry Andric if (!TaintArgs) 778*81ad6265SDimitry Andric return; 779*81ad6265SDimitry Andric assert(!TaintArgs->isEmpty()); 780*81ad6265SDimitry Andric 781*81ad6265SDimitry Andric LLVM_DEBUG(for (ArgIdxTy I 782*81ad6265SDimitry Andric : *TaintArgs) { 783*81ad6265SDimitry Andric llvm::dbgs() << "PostCall<"; 784*81ad6265SDimitry Andric Call.dump(llvm::dbgs()); 785*81ad6265SDimitry Andric llvm::dbgs() << "> actually wants to taint arg index: " << I << '\n'; 786*81ad6265SDimitry Andric }); 787*81ad6265SDimitry Andric 788*81ad6265SDimitry Andric for (ArgIdxTy ArgNum : *TaintArgs) { 7890b57cec5SDimitry Andric // Special handling for the tainted return value. 7900b57cec5SDimitry Andric if (ArgNum == ReturnValueIndex) { 7915ffd83dbSDimitry Andric State = addTaint(State, Call.getReturnValue()); 7920b57cec5SDimitry Andric continue; 7930b57cec5SDimitry Andric } 7940b57cec5SDimitry Andric 7950b57cec5SDimitry Andric // The arguments are pointer arguments. The data they are pointing at is 7960b57cec5SDimitry Andric // tainted after the call. 79704eeddc0SDimitry Andric if (auto V = getPointeeOf(C, Call.getArgSVal(ArgNum))) 7980b57cec5SDimitry Andric State = addTaint(State, *V); 7990b57cec5SDimitry Andric } 8000b57cec5SDimitry Andric 8010b57cec5SDimitry Andric // Clear up the taint info from the state. 802*81ad6265SDimitry Andric State = State->remove<TaintArgsOnPostVisit>(CurrentFrame); 8030b57cec5SDimitry Andric C.addTransition(State); 8040b57cec5SDimitry Andric } 8050b57cec5SDimitry Andric 80604eeddc0SDimitry Andric void GenericTaintChecker::printState(raw_ostream &Out, ProgramStateRef State, 80704eeddc0SDimitry Andric const char *NL, const char *Sep) const { 80804eeddc0SDimitry Andric printTaint(State, Out, NL, Sep); 8090b57cec5SDimitry Andric } 8100b57cec5SDimitry Andric 81104eeddc0SDimitry Andric void GenericTaintRule::process(const GenericTaintChecker &Checker, 81204eeddc0SDimitry Andric const CallEvent &Call, CheckerContext &C) const { 8130b57cec5SDimitry Andric ProgramStateRef State = C.getState(); 81404eeddc0SDimitry Andric const ArgIdxTy CallNumArgs = fromArgumentCount(Call.getNumArgs()); 8150b57cec5SDimitry Andric 81604eeddc0SDimitry Andric /// Iterate every call argument, and get their corresponding Expr and SVal. 81704eeddc0SDimitry Andric const auto ForEachCallArg = [&C, &Call, CallNumArgs](auto &&Fun) { 81804eeddc0SDimitry Andric for (ArgIdxTy I = ReturnValueIndex; I < CallNumArgs; ++I) { 81904eeddc0SDimitry Andric const Expr *E = GetArgExpr(I, Call); 82004eeddc0SDimitry Andric Fun(I, E, C.getSVal(E)); 8210b57cec5SDimitry Andric } 82204eeddc0SDimitry Andric }; 8230b57cec5SDimitry Andric 82404eeddc0SDimitry Andric /// Check for taint sinks. 82504eeddc0SDimitry Andric ForEachCallArg([this, &Checker, &C, &State](ArgIdxTy I, const Expr *E, SVal) { 82604eeddc0SDimitry Andric if (SinkArgs.contains(I) && isTaintedOrPointsToTainted(E, State, C)) 827*81ad6265SDimitry Andric Checker.generateReportIfTainted(E, SinkMsg.value_or(MsgCustomSink), C); 82804eeddc0SDimitry Andric }); 8290b57cec5SDimitry Andric 83004eeddc0SDimitry Andric /// Check for taint filters. 83104eeddc0SDimitry Andric ForEachCallArg([this, &C, &State](ArgIdxTy I, const Expr *E, SVal S) { 83204eeddc0SDimitry Andric if (FilterArgs.contains(I)) { 83304eeddc0SDimitry Andric State = removeTaint(State, S); 83404eeddc0SDimitry Andric if (auto P = getPointeeOf(C, S)) 83504eeddc0SDimitry Andric State = removeTaint(State, *P); 8360b57cec5SDimitry Andric } 83704eeddc0SDimitry Andric }); 8380b57cec5SDimitry Andric 83904eeddc0SDimitry Andric /// Check for taint propagation sources. 84004eeddc0SDimitry Andric /// A rule is relevant if PropSrcArgs is empty, or if any of its signified 84104eeddc0SDimitry Andric /// args are tainted in context of the current CallEvent. 84204eeddc0SDimitry Andric bool IsMatching = PropSrcArgs.isEmpty(); 84304eeddc0SDimitry Andric ForEachCallArg( 84404eeddc0SDimitry Andric [this, &C, &IsMatching, &State](ArgIdxTy I, const Expr *E, SVal) { 84504eeddc0SDimitry Andric IsMatching = IsMatching || (PropSrcArgs.contains(I) && 84604eeddc0SDimitry Andric isTaintedOrPointsToTainted(E, State, C)); 84704eeddc0SDimitry Andric }); 8480b57cec5SDimitry Andric 84904eeddc0SDimitry Andric if (!IsMatching) 85004eeddc0SDimitry Andric return; 8510b57cec5SDimitry Andric 85204eeddc0SDimitry Andric const auto WouldEscape = [](SVal V, QualType Ty) -> bool { 853*81ad6265SDimitry Andric if (!isa<Loc>(V)) 8540b57cec5SDimitry Andric return false; 8550b57cec5SDimitry Andric 85604eeddc0SDimitry Andric const bool IsNonConstRef = Ty->isReferenceType() && !Ty.isConstQualified(); 85704eeddc0SDimitry Andric const bool IsNonConstPtr = 85804eeddc0SDimitry Andric Ty->isPointerType() && !Ty->getPointeeType().isConstQualified(); 8590b57cec5SDimitry Andric 86004eeddc0SDimitry Andric return IsNonConstRef || IsNonConstPtr; 86104eeddc0SDimitry Andric }; 86204eeddc0SDimitry Andric 86304eeddc0SDimitry Andric /// Propagate taint where it is necessary. 864*81ad6265SDimitry Andric auto &F = State->getStateManager().get_context<ArgIdxFactory>(); 865*81ad6265SDimitry Andric ImmutableSet<ArgIdxTy> Result = F.getEmptySet(); 86604eeddc0SDimitry Andric ForEachCallArg( 867*81ad6265SDimitry Andric [&](ArgIdxTy I, const Expr *E, SVal V) { 868*81ad6265SDimitry Andric if (PropDstArgs.contains(I)) { 869*81ad6265SDimitry Andric LLVM_DEBUG(llvm::dbgs() << "PreCall<"; Call.dump(llvm::dbgs()); 870*81ad6265SDimitry Andric llvm::dbgs() 871*81ad6265SDimitry Andric << "> prepares tainting arg index: " << I << '\n';); 872*81ad6265SDimitry Andric Result = F.add(Result, I); 873*81ad6265SDimitry Andric } 87404eeddc0SDimitry Andric 87504eeddc0SDimitry Andric // TODO: We should traverse all reachable memory regions via the 87604eeddc0SDimitry Andric // escaping parameter. Instead of doing that we simply mark only the 87704eeddc0SDimitry Andric // referred memory region as tainted. 878*81ad6265SDimitry Andric if (WouldEscape(V, E->getType())) { 879*81ad6265SDimitry Andric LLVM_DEBUG(if (!Result.contains(I)) { 880*81ad6265SDimitry Andric llvm::dbgs() << "PreCall<"; 881*81ad6265SDimitry Andric Call.dump(llvm::dbgs()); 882*81ad6265SDimitry Andric llvm::dbgs() << "> prepares tainting arg index: " << I << '\n'; 883*81ad6265SDimitry Andric }); 884*81ad6265SDimitry Andric Result = F.add(Result, I); 885*81ad6265SDimitry Andric } 88604eeddc0SDimitry Andric }); 88704eeddc0SDimitry Andric 888*81ad6265SDimitry Andric if (!Result.isEmpty()) 889*81ad6265SDimitry Andric State = State->set<TaintArgsOnPostVisit>(C.getStackFrame(), Result); 89004eeddc0SDimitry Andric C.addTransition(State); 8910b57cec5SDimitry Andric } 8920b57cec5SDimitry Andric 89304eeddc0SDimitry Andric bool GenericTaintRule::UntrustedEnv(CheckerContext &C) { 89404eeddc0SDimitry Andric return !C.getAnalysisManager() 89504eeddc0SDimitry Andric .getAnalyzerOptions() 89604eeddc0SDimitry Andric .ShouldAssumeControlledEnvironment; 8970b57cec5SDimitry Andric } 8980b57cec5SDimitry Andric 899a7dea167SDimitry Andric bool GenericTaintChecker::generateReportIfTainted(const Expr *E, StringRef Msg, 9000b57cec5SDimitry Andric CheckerContext &C) const { 9010b57cec5SDimitry Andric assert(E); 90204eeddc0SDimitry Andric Optional<SVal> TaintedSVal{getTaintedPointeeOrPointer(C, C.getSVal(E))}; 9030b57cec5SDimitry Andric 90404eeddc0SDimitry Andric if (!TaintedSVal) 9050b57cec5SDimitry Andric return false; 9060b57cec5SDimitry Andric 9070b57cec5SDimitry Andric // Generate diagnostic. 9080b57cec5SDimitry Andric if (ExplodedNode *N = C.generateNonFatalErrorNode()) { 90904eeddc0SDimitry Andric auto report = std::make_unique<PathSensitiveBugReport>(BT, Msg, N); 9100b57cec5SDimitry Andric report->addRange(E->getSourceRange()); 91104eeddc0SDimitry Andric report->addVisitor(std::make_unique<TaintBugVisitor>(*TaintedSVal)); 9120b57cec5SDimitry Andric C.emitReport(std::move(report)); 9130b57cec5SDimitry Andric return true; 9140b57cec5SDimitry Andric } 9150b57cec5SDimitry Andric return false; 9160b57cec5SDimitry Andric } 9170b57cec5SDimitry Andric 91804eeddc0SDimitry Andric /// TODO: remove checking for printf format attributes and socket whitelisting 91904eeddc0SDimitry Andric /// from GenericTaintChecker, and that means the following functions: 92004eeddc0SDimitry Andric /// getPrintfFormatArgumentNum, 92104eeddc0SDimitry Andric /// GenericTaintChecker::checkUncontrolledFormatString, 92204eeddc0SDimitry Andric /// GenericTaintChecker::taintUnsafeSocketProtocol 92304eeddc0SDimitry Andric 92404eeddc0SDimitry Andric static bool getPrintfFormatArgumentNum(const CallEvent &Call, 92504eeddc0SDimitry Andric const CheckerContext &C, 92604eeddc0SDimitry Andric ArgIdxTy &ArgNum) { 92704eeddc0SDimitry Andric // Find if the function contains a format string argument. 92804eeddc0SDimitry Andric // Handles: fprintf, printf, sprintf, snprintf, vfprintf, vprintf, vsprintf, 92904eeddc0SDimitry Andric // vsnprintf, syslog, custom annotated functions. 93004eeddc0SDimitry Andric const Decl *CallDecl = Call.getDecl(); 93104eeddc0SDimitry Andric if (!CallDecl) 93204eeddc0SDimitry Andric return false; 93304eeddc0SDimitry Andric const FunctionDecl *FDecl = CallDecl->getAsFunction(); 93404eeddc0SDimitry Andric if (!FDecl) 93504eeddc0SDimitry Andric return false; 93604eeddc0SDimitry Andric 93704eeddc0SDimitry Andric const ArgIdxTy CallNumArgs = fromArgumentCount(Call.getNumArgs()); 93804eeddc0SDimitry Andric 93904eeddc0SDimitry Andric for (const auto *Format : FDecl->specific_attrs<FormatAttr>()) { 94004eeddc0SDimitry Andric ArgNum = Format->getFormatIdx() - 1; 94104eeddc0SDimitry Andric if ((Format->getType()->getName() == "printf") && CallNumArgs > ArgNum) 94204eeddc0SDimitry Andric return true; 94304eeddc0SDimitry Andric } 94404eeddc0SDimitry Andric 94504eeddc0SDimitry Andric return false; 94604eeddc0SDimitry Andric } 94704eeddc0SDimitry Andric 9480b57cec5SDimitry Andric bool GenericTaintChecker::checkUncontrolledFormatString( 9495ffd83dbSDimitry Andric const CallEvent &Call, CheckerContext &C) const { 9500b57cec5SDimitry Andric // Check if the function contains a format string argument. 95104eeddc0SDimitry Andric ArgIdxTy ArgNum = 0; 9525ffd83dbSDimitry Andric if (!getPrintfFormatArgumentNum(Call, C, ArgNum)) 9530b57cec5SDimitry Andric return false; 9540b57cec5SDimitry Andric 9550b57cec5SDimitry Andric // If either the format string content or the pointer itself are tainted, 9560b57cec5SDimitry Andric // warn. 9575ffd83dbSDimitry Andric return generateReportIfTainted(Call.getArgExpr(ArgNum), 9580b57cec5SDimitry Andric MsgUncontrolledFormatString, C); 9590b57cec5SDimitry Andric } 9600b57cec5SDimitry Andric 96104eeddc0SDimitry Andric void GenericTaintChecker::taintUnsafeSocketProtocol(const CallEvent &Call, 9620b57cec5SDimitry Andric CheckerContext &C) const { 96304eeddc0SDimitry Andric if (Call.getNumArgs() < 1) 96404eeddc0SDimitry Andric return; 96504eeddc0SDimitry Andric const IdentifierInfo *ID = Call.getCalleeIdentifier(); 96604eeddc0SDimitry Andric if (!ID) 96704eeddc0SDimitry Andric return; 96804eeddc0SDimitry Andric if (!ID->getName().equals("socket")) 96904eeddc0SDimitry Andric return; 9700b57cec5SDimitry Andric 97104eeddc0SDimitry Andric SourceLocation DomLoc = Call.getArgExpr(0)->getExprLoc(); 97204eeddc0SDimitry Andric StringRef DomName = C.getMacroNameOrSpelling(DomLoc); 97304eeddc0SDimitry Andric // Allow internal communication protocols. 97404eeddc0SDimitry Andric bool SafeProtocol = DomName.equals("AF_SYSTEM") || 97504eeddc0SDimitry Andric DomName.equals("AF_LOCAL") || DomName.equals("AF_UNIX") || 97604eeddc0SDimitry Andric DomName.equals("AF_RESERVED_36"); 97704eeddc0SDimitry Andric if (SafeProtocol) 97804eeddc0SDimitry Andric return; 9790b57cec5SDimitry Andric 980*81ad6265SDimitry Andric ProgramStateRef State = C.getState(); 981*81ad6265SDimitry Andric auto &F = State->getStateManager().get_context<ArgIdxFactory>(); 982*81ad6265SDimitry Andric ImmutableSet<ArgIdxTy> Result = F.add(F.getEmptySet(), ReturnValueIndex); 983*81ad6265SDimitry Andric State = State->set<TaintArgsOnPostVisit>(C.getStackFrame(), Result); 984*81ad6265SDimitry Andric C.addTransition(State); 9850b57cec5SDimitry Andric } 9860b57cec5SDimitry Andric 98704eeddc0SDimitry Andric /// Checker registration 988a7dea167SDimitry Andric void ento::registerGenericTaintChecker(CheckerManager &Mgr) { 98904eeddc0SDimitry Andric Mgr.registerChecker<GenericTaintChecker>(); 9900b57cec5SDimitry Andric } 9910b57cec5SDimitry Andric 9925ffd83dbSDimitry Andric bool ento::shouldRegisterGenericTaintChecker(const CheckerManager &mgr) { 9930b57cec5SDimitry Andric return true; 9940b57cec5SDimitry Andric } 995