16ff6d951SJohn Birrell /* 26ff6d951SJohn Birrell * CDDL HEADER START 36ff6d951SJohn Birrell * 46ff6d951SJohn Birrell * The contents of this file are subject to the terms of the 51670a1c2SRui Paulo * Common Development and Distribution License (the "License"). 61670a1c2SRui Paulo * You may not use this file except in compliance with the License. 76ff6d951SJohn Birrell * 86ff6d951SJohn Birrell * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE 96ff6d951SJohn Birrell * or http://www.opensolaris.org/os/licensing. 106ff6d951SJohn Birrell * See the License for the specific language governing permissions 116ff6d951SJohn Birrell * and limitations under the License. 126ff6d951SJohn Birrell * 136ff6d951SJohn Birrell * When distributing Covered Code, include this CDDL HEADER in each 146ff6d951SJohn Birrell * file and include the License file at usr/src/OPENSOLARIS.LICENSE. 156ff6d951SJohn Birrell * If applicable, add the following below this CDDL HEADER, with the 166ff6d951SJohn Birrell * fields enclosed by brackets "[]" replaced with your own identifying 176ff6d951SJohn Birrell * information: Portions Copyright [yyyy] [name of copyright owner] 186ff6d951SJohn Birrell * 196ff6d951SJohn Birrell * CDDL HEADER END 206ff6d951SJohn Birrell */ 216ff6d951SJohn Birrell /* 221670a1c2SRui Paulo * Copyright 2008 Sun Microsystems, Inc. All rights reserved. 236ff6d951SJohn Birrell * Use is subject to license terms. 246ff6d951SJohn Birrell */ 256ff6d951SJohn Birrell 266ff6d951SJohn Birrell #include <unistd.h> 276ff6d951SJohn Birrell #include <fcntl.h> 286ff6d951SJohn Birrell #include <dlfcn.h> 296ff6d951SJohn Birrell #include <link.h> 306ff6d951SJohn Birrell #include <sys/dtrace.h> 316ff6d951SJohn Birrell 326ff6d951SJohn Birrell #include <stdarg.h> 336ff6d951SJohn Birrell #include <stdio.h> 346ff6d951SJohn Birrell #include <stdlib.h> 356ff6d951SJohn Birrell #include <string.h> 366ff6d951SJohn Birrell #include <errno.h> 370f2bd1e8SRui Paulo #include <libelf.h> 380f2bd1e8SRui Paulo #include <gelf.h> 396ff6d951SJohn Birrell 406ff6d951SJohn Birrell /* 416ff6d951SJohn Birrell * In Solaris 10 GA, the only mechanism for communicating helper information 426ff6d951SJohn Birrell * is through the DTrace helper pseudo-device node in /devices; there is 436ff6d951SJohn Birrell * no /dev link. Because of this, USDT providers and helper actions don't 446ff6d951SJohn Birrell * work inside of non-global zones. This issue was addressed by adding 456ff6d951SJohn Birrell * the /dev and having this initialization code use that /dev link. If the 466ff6d951SJohn Birrell * /dev link doesn't exist it falls back to looking for the /devices node 476ff6d951SJohn Birrell * as this code may be embedded in a binary which runs on Solaris 10 GA. 486ff6d951SJohn Birrell * 496ff6d951SJohn Birrell * Users may set the following environment variable to affect the way 506ff6d951SJohn Birrell * helper initialization takes place: 516ff6d951SJohn Birrell * 526ff6d951SJohn Birrell * DTRACE_DOF_INIT_DEBUG enable debugging output 536ff6d951SJohn Birrell * DTRACE_DOF_INIT_DISABLE disable helper loading 546ff6d951SJohn Birrell * DTRACE_DOF_INIT_DEVNAME set the path to the helper node 556ff6d951SJohn Birrell */ 566ff6d951SJohn Birrell 575fe26f7cSJohn Birrell static const char *devnamep = "/dev/dtrace/helper"; 580f2bd1e8SRui Paulo #if defined(sun) 596ff6d951SJohn Birrell static const char *olddevname = "/devices/pseudo/dtrace@0:helper"; 600f2bd1e8SRui Paulo #endif 616ff6d951SJohn Birrell 626ff6d951SJohn Birrell static const char *modname; /* Name of this load object */ 636ff6d951SJohn Birrell static int gen; /* DOF helper generation */ 640f2bd1e8SRui Paulo #if defined(sun) 656ff6d951SJohn Birrell extern dof_hdr_t __SUNW_dof; /* DOF defined in the .SUNW_dof section */ 660f2bd1e8SRui Paulo #endif 67*dba0ac63SRui Paulo static boolean_t dof_init_debug = B_FALSE; /* From DTRACE_DOF_INIT_DEBUG */ 686ff6d951SJohn Birrell 696ff6d951SJohn Birrell static void 706ff6d951SJohn Birrell dprintf(int debug, const char *fmt, ...) 716ff6d951SJohn Birrell { 726ff6d951SJohn Birrell va_list ap; 736ff6d951SJohn Birrell 741670a1c2SRui Paulo if (debug && !dof_init_debug) 756ff6d951SJohn Birrell return; 766ff6d951SJohn Birrell 776ff6d951SJohn Birrell va_start(ap, fmt); 786ff6d951SJohn Birrell 796ff6d951SJohn Birrell if (modname == NULL) 806ff6d951SJohn Birrell (void) fprintf(stderr, "dtrace DOF: "); 816ff6d951SJohn Birrell else 826ff6d951SJohn Birrell (void) fprintf(stderr, "dtrace DOF %s: ", modname); 836ff6d951SJohn Birrell 846ff6d951SJohn Birrell (void) vfprintf(stderr, fmt, ap); 856ff6d951SJohn Birrell 866ff6d951SJohn Birrell if (fmt[strlen(fmt) - 1] != '\n') 876ff6d951SJohn Birrell (void) fprintf(stderr, ": %s\n", strerror(errno)); 886ff6d951SJohn Birrell 896ff6d951SJohn Birrell va_end(ap); 906ff6d951SJohn Birrell } 916ff6d951SJohn Birrell 920f2bd1e8SRui Paulo #if !defined(sun) 930f2bd1e8SRui Paulo static void 940f2bd1e8SRui Paulo fixsymbol(Elf *e, Elf_Data *data, size_t idx, int nprobes, char *buf, 950f2bd1e8SRui Paulo dof_sec_t *sec, int *fixedprobes, char *dofstrtab) 960f2bd1e8SRui Paulo { 970f2bd1e8SRui Paulo GElf_Sym sym; 980f2bd1e8SRui Paulo char *s; 990f2bd1e8SRui Paulo unsigned char *funcname; 1000f2bd1e8SRui Paulo dof_probe_t *prb; 1010f2bd1e8SRui Paulo int j = 0; 1020f2bd1e8SRui Paulo int ndx; 1030f2bd1e8SRui Paulo 1040f2bd1e8SRui Paulo while (gelf_getsym(data, j++, &sym) != NULL) { 1050f2bd1e8SRui Paulo prb = (dof_probe_t *)(buf + sec->dofs_offset); 1060f2bd1e8SRui Paulo 1070f2bd1e8SRui Paulo for (ndx = nprobes; ndx; ndx--, prb += 1) { 1080f2bd1e8SRui Paulo funcname = dofstrtab + prb->dofpr_func; 1090f2bd1e8SRui Paulo s = elf_strptr(e, idx, sym.st_name); 1100f2bd1e8SRui Paulo if (strcmp(s, funcname) == 0) { 1110f2bd1e8SRui Paulo dprintf(1, "fixing %s() symbol\n", s); 1120f2bd1e8SRui Paulo prb->dofpr_addr = sym.st_value; 1130f2bd1e8SRui Paulo (*fixedprobes)++; 1140f2bd1e8SRui Paulo } 1150f2bd1e8SRui Paulo } 1160f2bd1e8SRui Paulo if (*fixedprobes == nprobes) 1170f2bd1e8SRui Paulo break; 1180f2bd1e8SRui Paulo } 1190f2bd1e8SRui Paulo } 1200f2bd1e8SRui Paulo #endif 1210f2bd1e8SRui Paulo 1225fe26f7cSJohn Birrell #if defined(sun) 1236ff6d951SJohn Birrell #pragma init(dtrace_dof_init) 1245fe26f7cSJohn Birrell #else 1255fe26f7cSJohn Birrell static void dtrace_dof_init(void) __attribute__ ((constructor)); 1265fe26f7cSJohn Birrell #endif 1275fe26f7cSJohn Birrell 1286ff6d951SJohn Birrell static void 1296ff6d951SJohn Birrell dtrace_dof_init(void) 1306ff6d951SJohn Birrell { 1310f2bd1e8SRui Paulo #if defined(sun) 1326ff6d951SJohn Birrell dof_hdr_t *dof = &__SUNW_dof; 1330f2bd1e8SRui Paulo #else 1340f2bd1e8SRui Paulo dof_hdr_t *dof = NULL; 1350f2bd1e8SRui Paulo #endif 1366ff6d951SJohn Birrell #ifdef _LP64 1376ff6d951SJohn Birrell Elf64_Ehdr *elf; 1386ff6d951SJohn Birrell #else 1396ff6d951SJohn Birrell Elf32_Ehdr *elf; 1406ff6d951SJohn Birrell #endif 1416ff6d951SJohn Birrell dof_helper_t dh; 1426ff6d951SJohn Birrell Link_map *lmp; 1430f2bd1e8SRui Paulo #if defined(sun) 1446ff6d951SJohn Birrell Lmid_t lmid; 1455fe26f7cSJohn Birrell #else 1465fe26f7cSJohn Birrell u_long lmid = 0; 1470f2bd1e8SRui Paulo dof_sec_t *sec; 1480f2bd1e8SRui Paulo size_t i; 1495fe26f7cSJohn Birrell #endif 1506ff6d951SJohn Birrell int fd; 1516ff6d951SJohn Birrell const char *p; 1520f2bd1e8SRui Paulo #if !defined(sun) 1530f2bd1e8SRui Paulo Elf *e; 1540f2bd1e8SRui Paulo Elf_Scn *scn = NULL; 1550f2bd1e8SRui Paulo Elf_Data *symtabdata = NULL, *dynsymdata = NULL; 1560f2bd1e8SRui Paulo GElf_Shdr shdr; 1570f2bd1e8SRui Paulo int efd, nprobes; 1580f2bd1e8SRui Paulo char *s; 1590f2bd1e8SRui Paulo size_t shstridx, symtabidx = 0, dynsymidx = 0; 1600f2bd1e8SRui Paulo unsigned char *dofstrtab = NULL; 1610f2bd1e8SRui Paulo unsigned char *buf; 1620f2bd1e8SRui Paulo int fixedprobes = 0; 1630f2bd1e8SRui Paulo #endif 1646ff6d951SJohn Birrell 1656ff6d951SJohn Birrell if (getenv("DTRACE_DOF_INIT_DISABLE") != NULL) 1666ff6d951SJohn Birrell return; 1676ff6d951SJohn Birrell 1681670a1c2SRui Paulo if (getenv("DTRACE_DOF_INIT_DEBUG") != NULL) 1691670a1c2SRui Paulo dof_init_debug = B_TRUE; 1701670a1c2SRui Paulo 1716ff6d951SJohn Birrell if (dlinfo(RTLD_SELF, RTLD_DI_LINKMAP, &lmp) == -1 || lmp == NULL) { 1726ff6d951SJohn Birrell dprintf(1, "couldn't discover module name or address\n"); 1736ff6d951SJohn Birrell return; 1746ff6d951SJohn Birrell } 1756ff6d951SJohn Birrell 1765fe26f7cSJohn Birrell #if defined(sun) 1776ff6d951SJohn Birrell if (dlinfo(RTLD_SELF, RTLD_DI_LMID, &lmid) == -1) { 1786ff6d951SJohn Birrell dprintf(1, "couldn't discover link map ID\n"); 1796ff6d951SJohn Birrell return; 1806ff6d951SJohn Birrell } 1815fe26f7cSJohn Birrell #endif 1826ff6d951SJohn Birrell 1830f2bd1e8SRui Paulo 1846ff6d951SJohn Birrell if ((modname = strrchr(lmp->l_name, '/')) == NULL) 1856ff6d951SJohn Birrell modname = lmp->l_name; 1866ff6d951SJohn Birrell else 1876ff6d951SJohn Birrell modname++; 1880f2bd1e8SRui Paulo #if !defined(sun) 1890f2bd1e8SRui Paulo elf_version(EV_CURRENT); 1900f2bd1e8SRui Paulo if ((efd = open(lmp->l_name, O_RDONLY, 0)) < 0) { 1910f2bd1e8SRui Paulo dprintf(1, "couldn't open file for reading\n"); 1920f2bd1e8SRui Paulo return; 1930f2bd1e8SRui Paulo } 1940f2bd1e8SRui Paulo if ((e = elf_begin(efd, ELF_C_READ, NULL)) == NULL) { 1950f2bd1e8SRui Paulo dprintf(1, "elf_begin failed\n"); 1960f2bd1e8SRui Paulo close(efd); 1970f2bd1e8SRui Paulo return; 1980f2bd1e8SRui Paulo } 1990f2bd1e8SRui Paulo elf_getshdrstrndx(e, &shstridx); 2000f2bd1e8SRui Paulo dof = NULL; 2010f2bd1e8SRui Paulo while ((scn = elf_nextscn(e, scn)) != NULL) { 2020f2bd1e8SRui Paulo gelf_getshdr(scn, &shdr); 2030f2bd1e8SRui Paulo if (shdr.sh_type == SHT_SYMTAB) { 2040f2bd1e8SRui Paulo symtabidx = shdr.sh_link; 2050f2bd1e8SRui Paulo symtabdata = elf_getdata(scn, NULL); 2060f2bd1e8SRui Paulo } else if (shdr.sh_type == SHT_DYNSYM) { 2070f2bd1e8SRui Paulo dynsymidx = shdr.sh_link; 2080f2bd1e8SRui Paulo dynsymdata = elf_getdata(scn, NULL); 2090f2bd1e8SRui Paulo } else if (shdr.sh_type == SHT_PROGBITS) { 2100f2bd1e8SRui Paulo s = elf_strptr(e, shstridx, shdr.sh_name); 2110f2bd1e8SRui Paulo if (s && strcmp(s, ".SUNW_dof") == 0) { 2120f2bd1e8SRui Paulo dof = elf_getdata(scn, NULL)->d_buf; 2130f2bd1e8SRui Paulo } 2140f2bd1e8SRui Paulo } 2150f2bd1e8SRui Paulo } 2160f2bd1e8SRui Paulo if (dof == NULL) { 2170f2bd1e8SRui Paulo dprintf(1, "SUNW_dof section not found\n"); 2180f2bd1e8SRui Paulo elf_end(e); 2190f2bd1e8SRui Paulo close(efd); 2200f2bd1e8SRui Paulo return; 2210f2bd1e8SRui Paulo } 2220f2bd1e8SRui Paulo #endif 2236ff6d951SJohn Birrell 2246ff6d951SJohn Birrell if (dof->dofh_ident[DOF_ID_MAG0] != DOF_MAG_MAG0 || 2256ff6d951SJohn Birrell dof->dofh_ident[DOF_ID_MAG1] != DOF_MAG_MAG1 || 2266ff6d951SJohn Birrell dof->dofh_ident[DOF_ID_MAG2] != DOF_MAG_MAG2 || 2276ff6d951SJohn Birrell dof->dofh_ident[DOF_ID_MAG3] != DOF_MAG_MAG3) { 2286ff6d951SJohn Birrell dprintf(0, ".SUNW_dof section corrupt\n"); 2296ff6d951SJohn Birrell return; 2306ff6d951SJohn Birrell } 2316ff6d951SJohn Birrell 2326ff6d951SJohn Birrell elf = (void *)lmp->l_addr; 2336ff6d951SJohn Birrell 2346ff6d951SJohn Birrell dh.dofhp_dof = (uintptr_t)dof; 2355fe26f7cSJohn Birrell dh.dofhp_addr = elf->e_type == ET_DYN ? (uintptr_t) lmp->l_addr : 0; 2366ff6d951SJohn Birrell 2376ff6d951SJohn Birrell if (lmid == 0) { 2386ff6d951SJohn Birrell (void) snprintf(dh.dofhp_mod, sizeof (dh.dofhp_mod), 2396ff6d951SJohn Birrell "%s", modname); 2406ff6d951SJohn Birrell } else { 2416ff6d951SJohn Birrell (void) snprintf(dh.dofhp_mod, sizeof (dh.dofhp_mod), 2426ff6d951SJohn Birrell "LM%lu`%s", lmid, modname); 2436ff6d951SJohn Birrell } 2446ff6d951SJohn Birrell 2456ff6d951SJohn Birrell if ((p = getenv("DTRACE_DOF_INIT_DEVNAME")) != NULL) 2465fe26f7cSJohn Birrell devnamep = p; 2476ff6d951SJohn Birrell 2485fe26f7cSJohn Birrell if ((fd = open64(devnamep, O_RDWR)) < 0) { 2495fe26f7cSJohn Birrell dprintf(1, "failed to open helper device %s", devnamep); 2500f2bd1e8SRui Paulo #if defined(sun) 2516ff6d951SJohn Birrell /* 2526ff6d951SJohn Birrell * If the device path wasn't explicitly set, try again with 2536ff6d951SJohn Birrell * the old device path. 2546ff6d951SJohn Birrell */ 2556ff6d951SJohn Birrell if (p != NULL) 2566ff6d951SJohn Birrell return; 2576ff6d951SJohn Birrell 2585fe26f7cSJohn Birrell devnamep = olddevname; 2596ff6d951SJohn Birrell 2605fe26f7cSJohn Birrell if ((fd = open64(devnamep, O_RDWR)) < 0) { 2615fe26f7cSJohn Birrell dprintf(1, "failed to open helper device %s", devnamep); 2626ff6d951SJohn Birrell return; 2636ff6d951SJohn Birrell } 2640f2bd1e8SRui Paulo #else 2650f2bd1e8SRui Paulo return; 2660f2bd1e8SRui Paulo #endif 2676ff6d951SJohn Birrell } 2680f2bd1e8SRui Paulo #if !defined(sun) 2690f2bd1e8SRui Paulo /* 2700f2bd1e8SRui Paulo * We need to fix the base address of each probe since this wasn't 2710f2bd1e8SRui Paulo * done by ld(1). (ld(1) needs to grow support for parsing the 2720f2bd1e8SRui Paulo * SUNW_dof section). 2730f2bd1e8SRui Paulo * 2740f2bd1e8SRui Paulo * The complexity of this is not that great. The first for loop 2750f2bd1e8SRui Paulo * iterates over the sections inside the DOF file. There are usually 2760f2bd1e8SRui Paulo * 10 sections here. We asume the STRTAB section comes first and the 2770f2bd1e8SRui Paulo * PROBES section comes after. Since we are only interested in fixing 2780f2bd1e8SRui Paulo * data inside the PROBES section we quit the for loop after processing 2790f2bd1e8SRui Paulo * the PROBES section. It's usually the case that the first section 2800f2bd1e8SRui Paulo * is the STRTAB section and the second section is the PROBES section, 2810f2bd1e8SRui Paulo * so this for loop is not meaningful when doing complexity analysis. 2820f2bd1e8SRui Paulo * 2830f2bd1e8SRui Paulo * After finding the probes section, we iterate over the symbols 2840f2bd1e8SRui Paulo * in the symtab section. When we find a symbol name that matches 2850f2bd1e8SRui Paulo * the probe function name, we fix it. If we have fixed all the 2860f2bd1e8SRui Paulo * probes, we exit all the loops and we are done. 2870f2bd1e8SRui Paulo * The number of probes is given by the variable 'nprobes' and this 2880f2bd1e8SRui Paulo * depends entirely on the user, but some optimizations were done. 2890f2bd1e8SRui Paulo * 2900f2bd1e8SRui Paulo * We are assuming the number of probes is less than the number of 2910f2bd1e8SRui Paulo * symbols (libc can have 4k symbols, for example). 2920f2bd1e8SRui Paulo */ 2930f2bd1e8SRui Paulo sec = (dof_sec_t *)(dof + 1); 2940f2bd1e8SRui Paulo buf = (char *)dof; 2950f2bd1e8SRui Paulo for (i = 0; i < dof->dofh_secnum; i++, sec++) { 2960f2bd1e8SRui Paulo if (sec->dofs_type == DOF_SECT_STRTAB) 2970f2bd1e8SRui Paulo dofstrtab = (unsigned char *)(buf + sec->dofs_offset); 2980f2bd1e8SRui Paulo else if (sec->dofs_type == DOF_SECT_PROBES && dofstrtab) 2990f2bd1e8SRui Paulo break; 3006ff6d951SJohn Birrell 3010f2bd1e8SRui Paulo } 3020f2bd1e8SRui Paulo nprobes = sec->dofs_size / sec->dofs_entsize; 3030f2bd1e8SRui Paulo fixsymbol(e, symtabdata, symtabidx, nprobes, buf, sec, &fixedprobes, 3040f2bd1e8SRui Paulo dofstrtab); 3050f2bd1e8SRui Paulo if (fixedprobes != nprobes) { 3060f2bd1e8SRui Paulo /* 3070f2bd1e8SRui Paulo * If we haven't fixed all the probes using the 3080f2bd1e8SRui Paulo * symtab section, look inside the dynsym 3090f2bd1e8SRui Paulo * section. 3100f2bd1e8SRui Paulo */ 3110f2bd1e8SRui Paulo fixsymbol(e, dynsymdata, dynsymidx, nprobes, buf, sec, 3120f2bd1e8SRui Paulo &fixedprobes, dofstrtab); 3130f2bd1e8SRui Paulo } 3140f2bd1e8SRui Paulo if (fixedprobes != nprobes) { 3150f2bd1e8SRui Paulo fprintf(stderr, "WARNING: number of probes " 3160f2bd1e8SRui Paulo "fixed does not match the number of " 3170f2bd1e8SRui Paulo "defined probes (%d != %d, " 3180f2bd1e8SRui Paulo "respectively)\n", fixedprobes, nprobes); 3190f2bd1e8SRui Paulo fprintf(stderr, "WARNING: some probes might " 3200f2bd1e8SRui Paulo "not fire or your program might crash\n"); 3210f2bd1e8SRui Paulo } 3220f2bd1e8SRui Paulo #endif 3236ff6d951SJohn Birrell if ((gen = ioctl(fd, DTRACEHIOC_ADDDOF, &dh)) == -1) 3246ff6d951SJohn Birrell dprintf(1, "DTrace ioctl failed for DOF at %p", dof); 3250f2bd1e8SRui Paulo else { 3266ff6d951SJohn Birrell dprintf(1, "DTrace ioctl succeeded for DOF at %p\n", dof); 3270f2bd1e8SRui Paulo #if !defined(sun) 3280f2bd1e8SRui Paulo gen = dh.gen; 3290f2bd1e8SRui Paulo #endif 3300f2bd1e8SRui Paulo } 3316ff6d951SJohn Birrell 3326ff6d951SJohn Birrell (void) close(fd); 3330f2bd1e8SRui Paulo #if !defined(sun) 3340f2bd1e8SRui Paulo elf_end(e); 3350f2bd1e8SRui Paulo (void) close(efd); 3360f2bd1e8SRui Paulo #endif 3376ff6d951SJohn Birrell } 3386ff6d951SJohn Birrell 3395fe26f7cSJohn Birrell #if defined(sun) 3406ff6d951SJohn Birrell #pragma fini(dtrace_dof_fini) 3415fe26f7cSJohn Birrell #else 3425fe26f7cSJohn Birrell static void dtrace_dof_fini(void) __attribute__ ((destructor)); 3435fe26f7cSJohn Birrell #endif 3445fe26f7cSJohn Birrell 3456ff6d951SJohn Birrell static void 3466ff6d951SJohn Birrell dtrace_dof_fini(void) 3476ff6d951SJohn Birrell { 3486ff6d951SJohn Birrell int fd; 3496ff6d951SJohn Birrell 3505fe26f7cSJohn Birrell if ((fd = open64(devnamep, O_RDWR)) < 0) { 3515fe26f7cSJohn Birrell dprintf(1, "failed to open helper device %s", devnamep); 3526ff6d951SJohn Birrell return; 3536ff6d951SJohn Birrell } 3546ff6d951SJohn Birrell 3550f2bd1e8SRui Paulo if ((gen = ioctl(fd, DTRACEHIOC_REMOVE, &gen)) == -1) 3566ff6d951SJohn Birrell dprintf(1, "DTrace ioctl failed to remove DOF (%d)\n", gen); 3576ff6d951SJohn Birrell else 3586ff6d951SJohn Birrell dprintf(1, "DTrace ioctl removed DOF (%d)\n", gen); 3596ff6d951SJohn Birrell 3606ff6d951SJohn Birrell (void) close(fd); 3616ff6d951SJohn Birrell } 362