Home
last modified time | relevance | path

Searched hist:ce723d8e048ef98ea64d12379e3921c933f5b3e0 (Results 1 – 1 of 1) sorted by relevance

/linux/net/ipv4/
H A Droute.cdiff ce723d8e048ef98ea64d12379e3921c933f5b3e0 Thu Sep 08 22:34:47 CEST 2005 Julian Anastasov <ja@ssi.bg> [IPV4]: Fix refcount damaging in net/ipv4/route.c

One such place that can damage the dst refcnts is route.c with
CONFIG_IP_ROUTE_MULTIPATH_CACHED enabled, i don't see the user's
.config. In this new code i see that rt_intern_hash is called before
dst->refcnt is set to 1, dst is the 2nd arg to rt_intern_hash.

Arg 2 of rt_intern_hash must come with refcnt 1 as it is added to
table or dropped depending on error/add/update. One such example is
ip_mkroute_input where __mkroute_input return rth with refcnt 0 which
is provided to rt_intern_hash. ip_mkroute_output looks like a 2nd such
place. Appending untested patch for comments and review. The idea is
to put previous reference as we are going to return next result/error.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>