Searched hist:"44117 a1d1732c513875d5a163f10d9adbe866c08" (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/tty/serial/ |
| H A D | serial_core.c | diff 44117a1d1732c513875d5a163f10d9adbe866c08 Thu Jan 11 18:57:26 CET 2018 Sebastian Andrzej Siewior <bigeasy@linutronix.de> serial: core: mark port as initialized after successful IRQ change
setserial changes the IRQ via uart_set_info(). It invokes
uart_shutdown() which free the current used IRQ and clear
TTY_PORT_INITIALIZED. It will then update the IRQ number and invoke
uart_startup() before returning to the caller leaving
TTY_PORT_INITIALIZED cleared.
The next open will crash with
| list_add double add: new=ffffffff839fcc98, prev=ffffffff839fcc98, next=ffffffff839fcc98.
since the close from the IOCTL won't free the IRQ (and clean the list)
due to the TTY_PORT_INITIALIZED check in uart_shutdown().
There is same pattern in uart_do_autoconfig() and I *think* it also
needs to set TTY_PORT_INITIALIZED there.
Is there a reason why uart_startup() does not set the flag by itself
after the IRQ has been acquired (since it is cleared in uart_shutdown)?
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|