1 /*-
2 * Copyright (c) 2003-2018 Tim Kientzle
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution.
13 *
14 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
15 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
16 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
17 * IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
18 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
19 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
20 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
21 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25 #include "test.h"
26
27 /*
28 * Test archive verifies that we ignore padding in the extra field.
29 *
30 * APPNOTE.txt does not provide any provision for padding the extra
31 * field, so libarchive used to error when there were unconsumed
32 * bytes. Apparently, some Zip writers do routinely put zero padding
33 * in the extra field.
34 *
35 * The extra fields in this test (for both the local file header
36 * and the central directory entry) are formatted as follows:
37 *
38 * 0000 0000 - unrecognized field with type zero, zero bytes
39 * 5554 0900 03d258155cdb58155c - UX field with length 9
40 * 0000 0400 00000000 - unrecognized field with type zero, four bytes
41 * 000000 - three bytes padding
42 *
43 * The two valid type zero fields should be skipped and ignored, as
44 * should the three bytes padding (which is too short to be a valid
45 * extra data object). If there were no errors and we read the UX
46 * field correctly, then we've correctly handled all of the padding
47 * fields above.
48 */
49
50
verify(struct archive * a)51 static void verify(struct archive *a) {
52 struct archive_entry *ae;
53
54 assertEqualIntA(a, ARCHIVE_OK, archive_read_next_header(a, &ae));
55 assertEqualString("a", archive_entry_pathname(ae));
56 assertEqualInt(AE_IFREG | 0664, archive_entry_mode(ae));
57 assertEqualInt(0x5c1558d2, archive_entry_mtime(ae));
58 assertEqualInt(0, archive_entry_ctime(ae));
59 assertEqualInt(0x5c1558db, archive_entry_atime(ae));
60
61 assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
62 }
63
DEFINE_TEST(test_read_format_zip_extra_padding)64 DEFINE_TEST(test_read_format_zip_extra_padding)
65 {
66 const char *refname = "test_read_format_zip_extra_padding.zip";
67 struct archive *a;
68 char *p;
69 size_t s;
70
71 extract_reference_file(refname);
72
73 /* Verify with seeking reader. */
74 assert((a = archive_read_new()) != NULL);
75 assertEqualIntA(a, ARCHIVE_OK, archive_read_support_filter_all(a));
76 assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
77 assertEqualIntA(a, ARCHIVE_OK, archive_read_open_filename(a, refname, 7));
78 verify(a);
79 assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
80 assertEqualInt(ARCHIVE_OK, archive_read_free(a));
81
82 /* Verify with streaming reader. */
83 p = slurpfile(&s, "%s", refname);
84 assert((a = archive_read_new()) != NULL);
85 assertEqualIntA(a, ARCHIVE_OK, archive_read_support_filter_all(a));
86 assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
87 assertEqualIntA(a, ARCHIVE_OK, read_open_memory(a, p, s, 3));
88 verify(a);
89 assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
90 assertEqualInt(ARCHIVE_OK, archive_read_free(a));
91
92 free(p);
93 }
94