Searched hist:f16b6e8d838b2e2bb4561201311c66ac02ad67df (Results 1 – 3 of 3) sorted by relevance
/linux/include/linux/sunrpc/ |
H A D | cache.h | diff f16b6e8d838b2e2bb4561201311c66ac02ad67df Thu Aug 12 09:04:06 CEST 2010 NeilBrown <neilb@suse.de> sunrpc/cache: allow threads to block while waiting for cache update.
The current practice of waiting for cache updates by queueing the whole request to be retried has (at least) two problems.
1/ With NFSv4, requests can be quite complex and re-trying a whole request when a later part fails should only be a last-resort, not a normal practice.
2/ Large requests, and in particular any 'write' request, will not be queued by the current code and doing so would be undesirable.
In many cases only a very sort wait is needed before the cache gets valid data.
So, providing the underlying transport permits it by setting ->thread_wait, arrange to wait briefly for an upcall to be completed (as reflected in the clearing of CACHE_PENDING). If the short wait was not long enough and CACHE_PENDING is still set, fall back on the old approach.
The 'thread_wait' value is set to 5 seconds when there are spare threads, and 1 second when there are no spare threads.
These values are probably much higher than needed, but will ensure some forward progress.
Note that as we only request an update for a non-valid item, and as non-valid items are updated in place it is extremely unlikely that cache_check will return -ETIMEDOUT. Normally cache_defer_req will sleep for a short while and then find that the item is_valid.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
/linux/net/sunrpc/ |
H A D | cache.c | diff f16b6e8d838b2e2bb4561201311c66ac02ad67df Thu Aug 12 09:04:06 CEST 2010 NeilBrown <neilb@suse.de> sunrpc/cache: allow threads to block while waiting for cache update.
The current practice of waiting for cache updates by queueing the whole request to be retried has (at least) two problems.
1/ With NFSv4, requests can be quite complex and re-trying a whole request when a later part fails should only be a last-resort, not a normal practice.
2/ Large requests, and in particular any 'write' request, will not be queued by the current code and doing so would be undesirable.
In many cases only a very sort wait is needed before the cache gets valid data.
So, providing the underlying transport permits it by setting ->thread_wait, arrange to wait briefly for an upcall to be completed (as reflected in the clearing of CACHE_PENDING). If the short wait was not long enough and CACHE_PENDING is still set, fall back on the old approach.
The 'thread_wait' value is set to 5 seconds when there are spare threads, and 1 second when there are no spare threads.
These values are probably much higher than needed, but will ensure some forward progress.
Note that as we only request an update for a non-valid item, and as non-valid items are updated in place it is extremely unlikely that cache_check will return -ETIMEDOUT. Normally cache_defer_req will sleep for a short while and then find that the item is_valid.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|
H A D | svc_xprt.c | diff f16b6e8d838b2e2bb4561201311c66ac02ad67df Thu Aug 12 09:04:06 CEST 2010 NeilBrown <neilb@suse.de> sunrpc/cache: allow threads to block while waiting for cache update.
The current practice of waiting for cache updates by queueing the whole request to be retried has (at least) two problems.
1/ With NFSv4, requests can be quite complex and re-trying a whole request when a later part fails should only be a last-resort, not a normal practice.
2/ Large requests, and in particular any 'write' request, will not be queued by the current code and doing so would be undesirable.
In many cases only a very sort wait is needed before the cache gets valid data.
So, providing the underlying transport permits it by setting ->thread_wait, arrange to wait briefly for an upcall to be completed (as reflected in the clearing of CACHE_PENDING). If the short wait was not long enough and CACHE_PENDING is still set, fall back on the old approach.
The 'thread_wait' value is set to 5 seconds when there are spare threads, and 1 second when there are no spare threads.
These values are probably much higher than needed, but will ensure some forward progress.
Note that as we only request an update for a non-valid item, and as non-valid items are updated in place it is extremely unlikely that cache_check will return -ETIMEDOUT. Normally cache_defer_req will sleep for a short while and then find that the item is_valid.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
|