Searched hist:efd49b8eef659e0aa962ec1dbf18740e34735219 (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/hwmon/ |
| H A D | chipcap2.c | diff efd49b8eef659e0aa962ec1dbf18740e34735219 Wed Feb 07 22:17:09 CET 2024 Javier Carrasco <javier.carrasco.cruz@gmail.com> hwmon: (chipcap2) fix return path in cc2_request_alarm_irqs()
The return path can be improved by returning upon first failure. The
current implementation would try to register the second interrupt even
if the first one failed, which is unnecessary.
Moreover, if no irqs are available, the return value should be zero
(the driver supports the use case with no interrupts). Currently the
initial value is unassigned and that may lead to returning an unknown
value if stack variables are not automatically set to zero and no irqs
were provided.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-hwmon/294e4634-89d4-415e-a723-b208d8770d7c@gmail.com/T/#t
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240207-chipcap2_init_vars-v1-2-08cafe43e20e@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
|