Searched hist:eb66eff6636de0e83f74294447b47aec51e069fc (Results 1 – 1 of 1) sorted by relevance
/linux/fs/ubifs/ |
H A D | replay.c | diff eb66eff6636de0e83f74294447b47aec51e069fc Fri Nov 02 16:39:24 CET 2018 Arnd Bergmann <arnd@arndb.de> ubifs: replay: Fix high stack usage
Having two shash descriptors on the stack cause a very significant kernel stack usage that can cross the warning threshold:
fs/ubifs/replay.c: In function 'authenticate_sleb': fs/ubifs/replay.c:633:1: error: the frame size of 1144 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
Normally, gcc optimizes the out, but with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING, it does not. Splitting the two stack allocations into separate functions means that they will use the same memory again. In normal configurations (optimizing for size or performance), those should get inlined and we get the same behavior as before.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Richard Weinberger <richard@nod.at>
|