Home
last modified time | relevance | path

Searched hist:d1122e4b7639941305166628613a42fdf6e16296 (Results 1 – 2 of 2) sorted by relevance

/linux/drivers/memory/tegra/
H A Dtegra124-emc.cdiff d1122e4b7639941305166628613a42fdf6e16296 Fri Oct 09 19:47:40 CEST 2015 Julia Lawall <julia.lawall@lip6.fr> memory: tegra: Delete unneeded of_node_put()

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

for_each_child_of_node(root, child) {
... when != of_node_get(child)
* of_node_put(child);
...
* continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>
H A Dmc.cdiff d1122e4b7639941305166628613a42fdf6e16296 Fri Oct 09 19:47:40 CEST 2015 Julia Lawall <julia.lawall@lip6.fr> memory: tegra: Delete unneeded of_node_put()

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

for_each_child_of_node(root, child) {
... when != of_node_get(child)
* of_node_put(child);
...
* continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>