Searched hist:cd9bdb7362f483a71de56d62c375a2c0294e917c (Results 1 – 3 of 3) sorted by relevance
/freebsd/lib/libc/arm/aeabi/ |
H A D | aeabi_int_div.S | cd9bdb7362f483a71de56d62c375a2c0294e917c Fri Feb 17 12:16:19 CET 2017 Michal Meloun <mmel@FreeBSD.org> Publish __aeabi_uidiv and __aeabi_idiv as compatible symbols from libc.
Due to bug[1] in libcompiler_rt, all symbols declared by DEFINE_AEABI_FUNCTION_ALIAS() are not hidden. All these but two are explicitly exported from libc and don't causes problems.
Remaining two, __aeabi_uidiv and __aeabi_idiv, infecting all non-versioned shared libraries. And these symbols are consumed by many (if not all) packages[2].
As workaround, export these from libc as compatible symbols, in global namespace. With this, these are still visible for rtld, but static linker doesn't use then.
[1] DEFINE_AEABI_FUNCTION_ALIAS() macro uses '.set' directive for declaration of aliased symbol. Unfortunately, '.set' doesn't inherit visibility of base symbol, and macro don't explicitly sets visibility for aliased one.
[2] Given symbols are exported from non-versioned libraries only if library itself uses them. So, if world is built for CPU with HW divide, these function are not used and given symbols are not exported. By this, contents of these libraries is not stable, and all packages fails to run.
Note: Due to r313823 I'm forced to commit this too early, without leave enough time for proper review.
MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D9632
|
H A D | Symbol.map | diff cd9bdb7362f483a71de56d62c375a2c0294e917c Fri Feb 17 12:16:19 CET 2017 Michal Meloun <mmel@FreeBSD.org> Publish __aeabi_uidiv and __aeabi_idiv as compatible symbols from libc.
Due to bug[1] in libcompiler_rt, all symbols declared by DEFINE_AEABI_FUNCTION_ALIAS() are not hidden. All these but two are explicitly exported from libc and don't causes problems.
Remaining two, __aeabi_uidiv and __aeabi_idiv, infecting all non-versioned shared libraries. And these symbols are consumed by many (if not all) packages[2].
As workaround, export these from libc as compatible symbols, in global namespace. With this, these are still visible for rtld, but static linker doesn't use then.
[1] DEFINE_AEABI_FUNCTION_ALIAS() macro uses '.set' directive for declaration of aliased symbol. Unfortunately, '.set' doesn't inherit visibility of base symbol, and macro don't explicitly sets visibility for aliased one.
[2] Given symbols are exported from non-versioned libraries only if library itself uses them. So, if world is built for CPU with HW divide, these function are not used and given symbols are not exported. By this, contents of these libraries is not stable, and all packages fails to run.
Note: Due to r313823 I'm forced to commit this too early, without leave enough time for proper review.
MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D9632
|
H A D | Makefile.inc | diff cd9bdb7362f483a71de56d62c375a2c0294e917c Fri Feb 17 12:16:19 CET 2017 Michal Meloun <mmel@FreeBSD.org> Publish __aeabi_uidiv and __aeabi_idiv as compatible symbols from libc.
Due to bug[1] in libcompiler_rt, all symbols declared by DEFINE_AEABI_FUNCTION_ALIAS() are not hidden. All these but two are explicitly exported from libc and don't causes problems.
Remaining two, __aeabi_uidiv and __aeabi_idiv, infecting all non-versioned shared libraries. And these symbols are consumed by many (if not all) packages[2].
As workaround, export these from libc as compatible symbols, in global namespace. With this, these are still visible for rtld, but static linker doesn't use then.
[1] DEFINE_AEABI_FUNCTION_ALIAS() macro uses '.set' directive for declaration of aliased symbol. Unfortunately, '.set' doesn't inherit visibility of base symbol, and macro don't explicitly sets visibility for aliased one.
[2] Given symbols are exported from non-versioned libraries only if library itself uses them. So, if world is built for CPU with HW divide, these function are not used and given symbols are not exported. By this, contents of these libraries is not stable, and all packages fails to run.
Note: Due to r313823 I'm forced to commit this too early, without leave enough time for proper review.
MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D9632
|