Home
last modified time | relevance | path

Searched hist:ca6961d8a851f3720175f500be38fe9cee5a2c13 (Results 1 – 1 of 1) sorted by relevance

/linux/drivers/hid/
H A Dhid-mcp2221.cdiff ca6961d8a851f3720175f500be38fe9cee5a2c13 Tue Apr 04 14:15:25 CEST 2023 Louis Morhet <lmorhet@kalrayinc.com> HID: mcp2221: fix get and get_direction for gpio

The mcp2221_raw_event retrieves the value and direction of gpio on the
same command, by setting the value on mcp->status and the direction on
mcp->gpio_dir; and the offset at which they are read is based on
mcp->gp_idx, set by the gpiochip callbacks.

However, the individual gpiochip calls set the index to look for
directly on the field they want to track. This create a "double offset"
in the final read in the response report.

Align the behaviour of mcp2221_raw_event and
mcp_gpio_get/mcp_gpio_get_direction by putting gp_idx on those calls to
the base offset of the gpio status struct.

Signed-off-by: Louis Morhet <lmorhet@kalrayinc.com>
Link: https://lore.kernel.org/r/dd0b23800a79d2a464e1e9ed429b018b69fd5df2.1680602387.git.lmorhet@kalrayinc.com
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>