Home
last modified time | relevance | path

Searched hist:c42bca92be928ce7dece5fc04cf68d0e37ee6718 (Results 1 – 4 of 4) sorted by relevance

/linux/fs/bcachefs/
H A Dfs-io.cdiff 2ed5cd508d0b893ded6a1ba586f7c6cd7a95cc36 Mon Jun 14 20:47:26 CEST 2021 Kent Overstreet <kent.overstreet@gmail.com> bcachefs: Fix a memory leak in dio write path

Commit c42bca92be928ce7dece5fc04cf68d0e37ee6718 "bio: don't copy bvec
for direct IO" changed bio_iov_iter_get_pages() to point bio->bi_iovec
at the incoming biovec, meaning if we already allocated one, it'll be
leaked.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
/linux/Documentation/filesystems/
H A Dporting.rstdiff c42bca92be928ce7dece5fc04cf68d0e37ee6718 Sat Jan 09 17:03:03 CET 2021 Pavel Begunkov <asml.silence@gmail.com> bio: don't copy bvec for direct IO

The block layer spends quite a while in blkdev_direct_IO() to copy and
initialise bio's bvec. However, if we've already got a bvec in the input
iterator it might be reused in some cases, i.e. when new
ITER_BVEC_FLAG_FIXED flag is set. Simple tests show considerable
performance boost, and it also reduces memory footprint.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
/linux/include/linux/
H A Dbio.hdiff c42bca92be928ce7dece5fc04cf68d0e37ee6718 Sat Jan 09 17:03:03 CET 2021 Pavel Begunkov <asml.silence@gmail.com> bio: don't copy bvec for direct IO

The block layer spends quite a while in blkdev_direct_IO() to copy and
initialise bio's bvec. However, if we've already got a bvec in the input
iterator it might be reused in some cases, i.e. when new
ITER_BVEC_FLAG_FIXED flag is set. Simple tests show considerable
performance boost, and it also reduces memory footprint.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
/linux/block/
H A Dbio.cdiff c42bca92be928ce7dece5fc04cf68d0e37ee6718 Sat Jan 09 17:03:03 CET 2021 Pavel Begunkov <asml.silence@gmail.com> bio: don't copy bvec for direct IO

The block layer spends quite a while in blkdev_direct_IO() to copy and
initialise bio's bvec. However, if we've already got a bvec in the input
iterator it might be reused in some cases, i.e. when new
ITER_BVEC_FLAG_FIXED flag is set. Simple tests show considerable
performance boost, and it also reduces memory footprint.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>