Searched hist:b738a185beaab8728943acdb3e67371b8a88185e (Results 1 – 1 of 1) sorted by relevance
/linux/net/ipv4/ |
H A D | tcp_output.c | diff b738a185beaab8728943acdb3e67371b8a88185e Thu Mar 19 20:49:55 CET 2020 Eric Dumazet <edumazet@google.com> tcp: ensure skb->dev is NULL before leaving TCP stack
skb->rbnode is sharing three skb fields : next, prev, dev
When a packet is sent, TCP keeps the original skb (master) in a rtx queue, which was converted to rbtree a while back.
__tcp_transmit_skb() is responsible to clone the master skb, and add the TCP header to the clone before sending it to network layer.
skb_clone() already clears skb->next and skb->prev, but copies the master oskb->dev into the clone.
We need to clear skb->dev, otherwise lower layers could interpret the value as a pointer to a netdev.
This old bug surfaced recently when commit 28f8bfd1ac94 ("netfilter: Support iif matches in POSTROUTING") was merged.
Before this netfilter commit, skb->dev value was ignored and changed before reaching dev_queue_xmit()
Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue") Fixes: 28f8bfd1ac94 ("netfilter: Support iif matches in POSTROUTING") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Martin Zaharinov <micron10@gmail.com> Cc: Florian Westphal <fw@strlen.de> Cc: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: David S. Miller <davem@davemloft.net>
|