Searched hist:a1f1c24368ec9b1d2bbc77075d2ba340ea9d0a83 (Results 1 – 1 of 1) sorted by relevance
/linux/net/bluetooth/cmtp/ |
H A D | capi.c | diff a1f1c24368ec9b1d2bbc77075d2ba340ea9d0a83 Fri Sep 06 00:54:40 CEST 2024 Justin Stitt <justinstitt@google.com> Bluetooth: replace deprecated strncpy with strscpy_pad
strncpy() is deprecated for use on NUL-terminated destination strings [0] and as such we should prefer more robust and less ambiguous string interfaces.
The CAPI (part II) [1] states that the manufacturer id should be a "zero-terminated ASCII string" and should "always [be] zero-terminated."
Much the same for the serial number: "The serial number, a seven-digit number coded as a zero-terminated ASCII string".
Along with this, its clear the original author intended for these buffers to be NUL-padded as well. To meet the specification as well as properly NUL-pad, use strscpy_pad().
In doing this, an opportunity to simplify this code is also present. Remove the min_t() and combine the length check into the main if.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [0] Link: https://capi.org/downloads.html [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt <justinstitt@google.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
|