Searched hist:"9 d04cbaadf563db3ba04426c317d3e84bc27bac1" (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/leds/ |
| H A D | leds-ns2.c | diff 9d04cbaadf563db3ba04426c317d3e84bc27bac1 Fri Mar 08 03:38:26 CET 2013 Jingoo Han <jg1.han@samsung.com> leds: leds-ns2: set devm_gpio_request_one() flags param correctly
The devm_gpio_request_one() flags parameter was set to:
GPIOF_DIR_OUT | gpio_get_value(template->cmd)
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
GPIOF_DIR_OUT (0 << 0)
GPIOF_DIR_IN (1 << 0)
So, when 'gpio_get_value(template->cmd)' is 1, the gpio pin can
be set as input, instead of output.
To prevent this problem, GPIOF_OUT_INIT flags should be used when
using devm_gpio_request_one().
Same goes for 'gpio_get_value(template->slow)' case.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
|