Searched hist:"97 cf56697a31e083c04aa3ec30710f24bbdac86f" (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/spi/ |
| H A D | spi-rockchip.c | diff 97cf56697a31e083c04aa3ec30710f24bbdac86f Wed Jan 28 14:25:10 CET 2015 Arnd Bergmann <arnd@arndb.de> spi/rockchip: avoid uninitialized-use warning
We currently get a warning about potentially uninitialized variables
in the rockchip spi driver, at least in certain toolchain versions:
spi/spi-rockchip.c: In function 'rockchip_spi_prepare_dma':
include/linux/dmaengine.h:796:2: warning: 'txdesc' may be used uninitialized in this function
include/linux/dmaengine.h:796:2: warning: 'rxdesc' may be used uninitialized in this function
The reason seems to be that gcc cannot know whether the value
of the rs->rx and rs->tx variables change between the two points
these are accessed.
The code is actually correct, but to make this clearer to the
compiler, this changes the conditionals to test for the local
rxdesc/txdesc variables instead, which it knows won't change.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
|