Searched hist:"80 f03e27a309f3e32ebdd9629ac0320005a2180b" (Results 1 – 1 of 1) sorted by relevance
/linux/net/ipv4/ |
H A D | tcp_output.c | diff 80f03e27a309f3e32ebdd9629ac0320005a2180b Tue Mar 24 23:58:52 CET 2015 Eric Dumazet <edumazet@google.com> tcp: md5: fix rcu lockdep splat
While timer handler effectively runs a rcu read locked section, there is no explicit rcu_read_lock()/rcu_read_unlock() annotations and lockdep can be confused here :
net/ipv4/tcp_ipv4.c-906- /* caller either holds rcu_read_lock() or socket lock */ net/ipv4/tcp_ipv4.c:907: md5sig = rcu_dereference_check(tp->md5sig_info, net/ipv4/tcp_ipv4.c-908- sock_owned_by_user(sk) || net/ipv4/tcp_ipv4.c-909- lockdep_is_held(&sk->sk_lock.slock));
Let's explicitely acquire rcu_read_lock() in tcp_make_synack()
Before commit fa76ce7328b ("inet: get rid of central tcp/dccp listener timer"), we were holding listener lock so lockdep was happy.
Fixes: fa76ce7328b ("inet: get rid of central tcp/dccp listener timer") Signed-off-by: Eric DUmazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|