Searched hist:"5843 ef421311c34f06d5ab82bced5aebfe185b2c" (Results 1 – 1 of 1) sorted by relevance
| /linux/net/ipv4/ |
| H A D | tcp_output.c | diff 5843ef421311c34f06d5ab82bced5aebfe185b2c Mon Sep 30 22:29:11 CEST 2013 Andi Kleen <ak@linux.intel.com> tcp: Always set options to 0 before calling tcp_established_options
tcp_established_options assumes opts->options is 0 before calling,
as it read modify writes it.
For the tcp_current_mss() case the opts structure is not zeroed,
so this can be done with uninitialized values.
This is ok, because ->options is not read in this path.
But it's still better to avoid the operation on the uninitialized
field. This shuts up a static code analyzer, and presumably
may help the optimizer.
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|