Searched hist:"5580 ba7bf61a6047a8b95459a9ed893f01947737" (Results 1 – 3 of 3) sorted by relevance
| /linux/sound/firewire/oxfw/ |
| H A D | oxfw-proc.c | diff 5580ba7bf61a6047a8b95459a9ed893f01947737 Fri Dec 12 20:27:03 CET 2014 Dan Carpenter <dan.carpenter@oracle.com> ALSA: oxfw: some signedness bugs
This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int". The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
| H A D | oxfw-pcm.c | diff 5580ba7bf61a6047a8b95459a9ed893f01947737 Fri Dec 12 20:27:03 CET 2014 Dan Carpenter <dan.carpenter@oracle.com> ALSA: oxfw: some signedness bugs
This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int". The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
| H A D | oxfw-stream.c | diff 5580ba7bf61a6047a8b95459a9ed893f01947737 Fri Dec 12 20:27:03 CET 2014 Dan Carpenter <dan.carpenter@oracle.com> ALSA: oxfw: some signedness bugs
This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int". The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|