Searched hist:"42 ec4f05a38f8c2b8d7eaa96d2b5dd542c3c9c4a" (Results 1 – 1 of 1) sorted by relevance
/freebsd/sys/kern/ |
H A D | uipc_mqueue.c | diff 42ec4f05a38f8c2b8d7eaa96d2b5dd542c3c9c4a Mon Jan 27 23:36:54 CET 2020 Warner Losh <imp@FreeBSD.org> Make mqueue objects work across a fork again.
In r110908 (2003) alfred added DFLAG_PASSABLE to tag those types of FD that can be passed via unix pipes, but mqueuefs didn't exist yet. Later, in r152825 (2005) davidxu neglected to include DFLAG_PASSABLE since people don't normally pass these things via unix sockets (it's a FreeBSD implementation detail that it's a file descriptor, nobody noticed). Then r223866 (2011) by jonathan used the new flag in fdcopy, which fork uses. Due to that, mqueuefs actually broke mqueue objects being propagated by fork. No mention of mqueuefs was made in r223866, so I think it was an unintended consequence.
Fix this by tagging mqueuefs as passable as well. They were prior to alfred's change (and it's clear there's no intent in his change to change this behavior), and POSIX requires this to be the case as well.
PR: 243103 Reviewed by: kib@, jiles@ Differential Revision: https://reviews.freebsd.org/D23038
|