Home
last modified time | relevance | path

Searched hist:"42 a71ef97b7ac31ae8f929c36048fec5cd201a49" (Results 1 – 1 of 1) sorted by relevance

/linux/drivers/mfd/
H A Dmenelaus.cdiff 42a71ef97b7ac31ae8f929c36048fec5cd201a49 Thu Aug 21 14:06:06 CEST 2014 Julia Lawall <julia.lawall@lip6.fr> mfd: menelaus: Fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>