Searched hist:"2 eab9b1a3006b4f7bf49c55ce23943170a0068db" (Results 1 – 1 of 1) sorted by relevance
/linux/drivers/dma/ioat/ |
H A D | init.c | diff 2eab9b1a3006b4f7bf49c55ce23943170a0068db Thu Jul 21 21:40:52 CEST 2016 Dave Jiang <dave.jiang@intel.com> dmaengine: ioatdma: fix uninitialized array usage
Static analysis showed that unitialized array is being used for compare. At line 850 when a dma_mapping_error() occurs, it jumps to dma_unmap. At this point, dma_srcs has not been initialized. However, the code after dma_unmap label checks dma_srcs for a comparison and thus is comparing to random garbage in the array. Given that when dest_dma is being mapped this is the first instance of mapping DMA memory and failed, there is really nothing to be cleaned up and thus should jump to free_resources label instead.
Signed-off-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
|