Searched hist:"2 b329f5694aec86107931584413c7d2ebc6b548d" (Results 1 – 7 of 7) sorted by relevance
/linux/drivers/platform/x86/dell/dell-wmi-sysman/ |
H A D | biosattr-interface.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
H A D | passwordattr-interface.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
/linux/drivers/platform/x86/dell/ |
H A D | dell-wmi-descriptor.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
H A D | dell-smbios-wmi.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
/linux/drivers/platform/x86/ |
H A D | wmi-bmof.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
H A D | wmi.c | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
/linux/include/linux/ |
H A D | wmi.h | diff 2b329f5694aec86107931584413c7d2ebc6b548d Mon Mar 01 17:04:04 CET 2021 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() (and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct wmi_driver::remove() return void, too. All implementers of this callback return 0 already and this way it should be obvious to driver authors that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|