Searched hist:"25945 af47e7a1d06c44c8c160045a866e90569ab" (Results 1 – 1 of 1) sorted by relevance
| /freebsd/libexec/tftpd/ |
| H A D | tftpd.c | diff 25945af47e7a1d06c44c8c160045a866e90569ab Fri May 10 23:15:54 CEST 2024 Dag-Erling Smørgrav <des@FreeBSD.org> tftpd: silence gcc overflow warnings
GCC 13 complains that we might be writing too much to an on-stack buffer
when createing a filename.
In practice there is a check that filename isn't too long given the
time format and other static characters so GCC is incorrect, but GCC
isn't wrong that we're potentially trying to put a MAXPATHLEN length
string + some other characters into a MAXPATHLEN buffer (if you ignore
the check GCC can't realistically evaluate at compile time).
Switch to snprintf to populate filename to ensure that future logic
errors don't result in a stack overflow.
Shorten the questionably named yyyymmdd buffer enough to slience the
warning (checking the snprintf return value isn't sufficent) while
preserving maximum flexibility for admins who use the -F option.
MFC after: 3 days
Sponsored by: Klara, Inc.
Reviewed by: brooks
Differential Revision: https://reviews.freebsd.org/D45086
|