Searched hist:"1 f035a52918a4c97b99c5d9f0d5023fe659bccaa" (Results 1 – 1 of 1) sorted by relevance
| /linux/scripts/kconfig/ |
| H A D | nconf.c | diff 1f035a52918a4c97b99c5d9f0d5023fe659bccaa Sat Apr 10 08:52:46 CEST 2021 Masahiro Yamada <masahiroy@kernel.org> kconfig: nconf: fix core dump when searching in empty menu
The following code in get_mext_match():
index = (index + items_num) % items_num;
... makes the program crash when items_num is zero (that is, the menu
is empty).
A menu can be empty when all the options in it are hidden by unmet
'depends on'.
For example,
menu "This menu will be empty"
config FOO
bool "foo"
depends on BROKEN
endmenu
If you visit this menu and press a '/' key and then another key, nconf
crashes with:
Floating point exception (core dumped)
When the number of items is zero, it does not make sense to search in
the menu. In this case, current_item() returns NULL, and item_index()
ERR, but get_mext_match() does not check it.
Let's make get_mext_match() just return if the menu is empty.
While I am here, change items_num from 'int' to 'unsigned int' because
it should never become negative.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|