Searched hist:"10 e2eb878f3ca07ac2f05fa5ca5e6c4c9174a27a" (Results 1 – 1 of 1) sorted by relevance
/linux/net/ipv4/ |
H A D | udp.c | diff 10e2eb878f3ca07ac2f05fa5ca5e6c4c9174a27a Sat Aug 01 12:14:33 CEST 2015 Eric Dumazet <edumazet@google.com> udp: fix dst races with multicast early demux
Multicast dst are not cached. They carry DST_NOCACHE.
As mentioned in commit f8864972126899 ("ipv4: fix dst race in sk_dst_get()"), these dst need special care before caching them into a socket.
Caching them is allowed only if their refcnt was not 0, ie we must use atomic_inc_not_zero()
Also, we must use READ_ONCE() to fetch sk->sk_rx_dst, as mentioned in commit d0c294c53a771 ("tcp: prevent fetching dst twice in early demux code")
Fixes: 421b3885bf6d ("udp: ipv4: Add udp early demux") Tested-by: Gregory Hoggarth <Gregory.Hoggarth@alliedtelesis.co.nz> Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Gregory Hoggarth <Gregory.Hoggarth@alliedtelesis.co.nz> Reported-by: Alex Gartrell <agartrell@fb.com> Cc: Michal Kubeček <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
|