Searched hist:"05 a1308a2e08e4a375bf60eb4c6c057a201d81fc" (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/net/ethernet/intel/ice/ |
| H A D | ice_gnss.c | diff 05a1308a2e08e4a375bf60eb4c6c057a201d81fc Thu May 25 12:52:58 CEST 2023 Simon Horman <horms@kernel.org> ice: Don't dereference NULL in ice_gnss_read error path
If pf is NULL in ice_gnss_read() then it will be dereferenced
in the error path by a call to dev_dbg(ice_pf_to_dev(pf), ...).
Avoid this by simply returning in this case.
If logging is desired an alternate approach might be to
use pr_err() before returning.
Flagged by Smatch as:
.../ice_gnss.c:196 ice_gnss_read() error: we previously assumed 'pf' could be null (see line 131)
Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
|