1 /*
2 * CDDL HEADER START
3 *
4 * The contents of this file are subject to the terms of the
5 * Common Development and Distribution License (the "License").
6 * You may not use this file except in compliance with the License.
7 *
8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
9 * or http://www.opensolaris.org/os/licensing.
10 * See the License for the specific language governing permissions
11 * and limitations under the License.
12 *
13 * When distributing Covered Code, include this CDDL HEADER in each
14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
15 * If applicable, add the following below this CDDL HEADER, with the
16 * fields enclosed by brackets "[]" replaced with your own identifying
17 * information: Portions Copyright [yyyy] [name of copyright owner]
18 *
19 * CDDL HEADER END
20 */
21
22 /*
23 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
24 * Copyright (c) 2011, 2018 by Delphix. All rights reserved.
25 */
26
27 #include <sys/zfs_context.h>
28 #include <sys/spa_impl.h>
29 #include <sys/dmu.h>
30 #include <sys/dmu_tx.h>
31 #include <sys/zap.h>
32 #include <sys/vdev_impl.h>
33 #include <sys/metaslab.h>
34 #include <sys/metaslab_impl.h>
35 #include <sys/uberblock_impl.h>
36 #include <sys/txg.h>
37 #include <sys/avl.h>
38 #include <sys/bpobj.h>
39 #include <sys/dsl_pool.h>
40 #include <sys/dsl_synctask.h>
41 #include <sys/dsl_dir.h>
42 #include <sys/arc.h>
43 #include <sys/zfeature.h>
44 #include <sys/vdev_indirect_births.h>
45 #include <sys/vdev_indirect_mapping.h>
46 #include <sys/abd.h>
47 #include <sys/vdev_initialize.h>
48 #include <sys/vdev_trim.h>
49
50 /*
51 * This file contains the necessary logic to remove vdevs from a
52 * storage pool. Currently, the only devices that can be removed
53 * are log, cache, and spare devices; and top level vdevs from a pool
54 * w/o raidz. (Note that members of a mirror can also be removed
55 * by the detach operation.)
56 *
57 * Log vdevs are removed by evacuating them and then turning the vdev
58 * into a hole vdev while holding spa config locks.
59 *
60 * Top level vdevs are removed and converted into an indirect vdev via
61 * a multi-step process:
62 *
63 * - Disable allocations from this device (spa_vdev_remove_top).
64 *
65 * - From a new thread (spa_vdev_remove_thread), copy data from
66 * the removing vdev to a different vdev. The copy happens in open
67 * context (spa_vdev_copy_impl) and issues a sync task
68 * (vdev_mapping_sync) so the sync thread can update the partial
69 * indirect mappings in core and on disk.
70 *
71 * - If a free happens during a removal, it is freed from the
72 * removing vdev, and if it has already been copied, from the new
73 * location as well (free_from_removing_vdev).
74 *
75 * - After the removal is completed, the copy thread converts the vdev
76 * into an indirect vdev (vdev_remove_complete) before instructing
77 * the sync thread to destroy the space maps and finish the removal
78 * (spa_finish_removal).
79 */
80
81 typedef struct vdev_copy_arg {
82 metaslab_t *vca_msp;
83 uint64_t vca_outstanding_bytes;
84 kcondvar_t vca_cv;
85 kmutex_t vca_lock;
86 } vdev_copy_arg_t;
87
88 /*
89 * The maximum amount of memory we can use for outstanding i/o while
90 * doing a device removal. This determines how much i/o we can have
91 * in flight concurrently.
92 */
93 int zfs_remove_max_copy_bytes = 64 * 1024 * 1024;
94
95 /*
96 * The largest contiguous segment that we will attempt to allocate when
97 * removing a device. This can be no larger than SPA_MAXBLOCKSIZE. If
98 * there is a performance problem with attempting to allocate large blocks,
99 * consider decreasing this.
100 *
101 * Note: we will issue I/Os of up to this size. The mpt driver does not
102 * respond well to I/Os larger than 1MB, so we set this to 1MB. (When
103 * mpt processes an I/O larger than 1MB, it needs to do an allocation of
104 * 2 physically contiguous pages; if this allocation fails, mpt will drop
105 * the I/O and hang the device.)
106 */
107 int zfs_remove_max_segment = 1024 * 1024;
108
109 /*
110 * Allow a remap segment to span free chunks of at most this size. The main
111 * impact of a larger span is that we will read and write larger, more
112 * contiguous chunks, with more "unnecessary" data -- trading off bandwidth
113 * for iops. The value here was chosen to align with
114 * zfs_vdev_read_gap_limit, which is a similar concept when doing regular
115 * reads (but there's no reason it has to be the same).
116 *
117 * Additionally, a higher span will have the following relatively minor
118 * effects:
119 * - the mapping will be smaller, since one entry can cover more allocated
120 * segments
121 * - more of the fragmentation in the removing device will be preserved
122 * - we'll do larger allocations, which may fail and fall back on smaller
123 * allocations
124 */
125 int vdev_removal_max_span = 32 * 1024;
126
127 /*
128 * This is used by the test suite so that it can ensure that certain
129 * actions happen while in the middle of a removal.
130 */
131 int zfs_removal_suspend_progress = 0;
132
133 #define VDEV_REMOVAL_ZAP_OBJS "lzap"
134
135 static void spa_vdev_remove_thread(void *arg);
136
137 static void
spa_sync_removing_state(spa_t * spa,dmu_tx_t * tx)138 spa_sync_removing_state(spa_t *spa, dmu_tx_t *tx)
139 {
140 VERIFY0(zap_update(spa->spa_dsl_pool->dp_meta_objset,
141 DMU_POOL_DIRECTORY_OBJECT,
142 DMU_POOL_REMOVING, sizeof (uint64_t),
143 sizeof (spa->spa_removing_phys) / sizeof (uint64_t),
144 &spa->spa_removing_phys, tx));
145 }
146
147 static nvlist_t *
spa_nvlist_lookup_by_guid(nvlist_t ** nvpp,int count,uint64_t target_guid)148 spa_nvlist_lookup_by_guid(nvlist_t **nvpp, int count, uint64_t target_guid)
149 {
150 for (int i = 0; i < count; i++) {
151 uint64_t guid =
152 fnvlist_lookup_uint64(nvpp[i], ZPOOL_CONFIG_GUID);
153
154 if (guid == target_guid)
155 return (nvpp[i]);
156 }
157
158 return (NULL);
159 }
160
161 static void
spa_vdev_remove_aux(nvlist_t * config,char * name,nvlist_t ** dev,int count,nvlist_t * dev_to_remove)162 spa_vdev_remove_aux(nvlist_t *config, char *name, nvlist_t **dev, int count,
163 nvlist_t *dev_to_remove)
164 {
165 nvlist_t **newdev = NULL;
166
167 if (count > 1)
168 newdev = kmem_alloc((count - 1) * sizeof (void *), KM_SLEEP);
169
170 for (int i = 0, j = 0; i < count; i++) {
171 if (dev[i] == dev_to_remove)
172 continue;
173 VERIFY(nvlist_dup(dev[i], &newdev[j++], KM_SLEEP) == 0);
174 }
175
176 VERIFY(nvlist_remove(config, name, DATA_TYPE_NVLIST_ARRAY) == 0);
177 VERIFY(nvlist_add_nvlist_array(config, name, newdev, count - 1) == 0);
178
179 for (int i = 0; i < count - 1; i++)
180 nvlist_free(newdev[i]);
181
182 if (count > 1)
183 kmem_free(newdev, (count - 1) * sizeof (void *));
184 }
185
186 static spa_vdev_removal_t *
spa_vdev_removal_create(vdev_t * vd)187 spa_vdev_removal_create(vdev_t *vd)
188 {
189 spa_vdev_removal_t *svr = kmem_zalloc(sizeof (*svr), KM_SLEEP);
190 mutex_init(&svr->svr_lock, NULL, MUTEX_DEFAULT, NULL);
191 cv_init(&svr->svr_cv, NULL, CV_DEFAULT, NULL);
192 svr->svr_allocd_segs = range_tree_create(NULL, RANGE_SEG64, NULL, 0, 0);
193 svr->svr_vdev_id = vd->vdev_id;
194
195 for (int i = 0; i < TXG_SIZE; i++) {
196 svr->svr_frees[i] = range_tree_create(NULL, RANGE_SEG64, NULL,
197 0, 0);
198 list_create(&svr->svr_new_segments[i],
199 sizeof (vdev_indirect_mapping_entry_t),
200 offsetof(vdev_indirect_mapping_entry_t, vime_node));
201 }
202
203 return (svr);
204 }
205
206 void
spa_vdev_removal_destroy(spa_vdev_removal_t * svr)207 spa_vdev_removal_destroy(spa_vdev_removal_t *svr)
208 {
209 for (int i = 0; i < TXG_SIZE; i++) {
210 ASSERT0(svr->svr_bytes_done[i]);
211 ASSERT0(svr->svr_max_offset_to_sync[i]);
212 range_tree_destroy(svr->svr_frees[i]);
213 list_destroy(&svr->svr_new_segments[i]);
214 }
215
216 range_tree_destroy(svr->svr_allocd_segs);
217 mutex_destroy(&svr->svr_lock);
218 cv_destroy(&svr->svr_cv);
219 kmem_free(svr, sizeof (*svr));
220 }
221
222 /*
223 * This is called as a synctask in the txg in which we will mark this vdev
224 * as removing (in the config stored in the MOS).
225 *
226 * It begins the evacuation of a toplevel vdev by:
227 * - initializing the spa_removing_phys which tracks this removal
228 * - computing the amount of space to remove for accounting purposes
229 * - dirtying all dbufs in the spa_config_object
230 * - creating the spa_vdev_removal
231 * - starting the spa_vdev_remove_thread
232 */
233 static void
vdev_remove_initiate_sync(void * arg,dmu_tx_t * tx)234 vdev_remove_initiate_sync(void *arg, dmu_tx_t *tx)
235 {
236 int vdev_id = (uintptr_t)arg;
237 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
238 vdev_t *vd = vdev_lookup_top(spa, vdev_id);
239 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
240 objset_t *mos = spa->spa_dsl_pool->dp_meta_objset;
241 spa_vdev_removal_t *svr = NULL;
242 uint64_t txg = dmu_tx_get_txg(tx);
243
244 ASSERT3P(vd->vdev_ops, !=, &vdev_raidz_ops);
245 svr = spa_vdev_removal_create(vd);
246
247 ASSERT(vd->vdev_removing);
248 ASSERT3P(vd->vdev_indirect_mapping, ==, NULL);
249
250 spa_feature_incr(spa, SPA_FEATURE_DEVICE_REMOVAL, tx);
251 if (spa_feature_is_enabled(spa, SPA_FEATURE_OBSOLETE_COUNTS)) {
252 /*
253 * By activating the OBSOLETE_COUNTS feature, we prevent
254 * the pool from being downgraded and ensure that the
255 * refcounts are precise.
256 */
257 spa_feature_incr(spa, SPA_FEATURE_OBSOLETE_COUNTS, tx);
258 uint64_t one = 1;
259 VERIFY0(zap_add(spa->spa_meta_objset, vd->vdev_top_zap,
260 VDEV_TOP_ZAP_OBSOLETE_COUNTS_ARE_PRECISE, sizeof (one), 1,
261 &one, tx));
262 ASSERT3U(vdev_obsolete_counts_are_precise(vd), !=, 0);
263 }
264
265 vic->vic_mapping_object = vdev_indirect_mapping_alloc(mos, tx);
266 vd->vdev_indirect_mapping =
267 vdev_indirect_mapping_open(mos, vic->vic_mapping_object);
268 vic->vic_births_object = vdev_indirect_births_alloc(mos, tx);
269 vd->vdev_indirect_births =
270 vdev_indirect_births_open(mos, vic->vic_births_object);
271 spa->spa_removing_phys.sr_removing_vdev = vd->vdev_id;
272 spa->spa_removing_phys.sr_start_time = gethrestime_sec();
273 spa->spa_removing_phys.sr_end_time = 0;
274 spa->spa_removing_phys.sr_state = DSS_SCANNING;
275 spa->spa_removing_phys.sr_to_copy = 0;
276 spa->spa_removing_phys.sr_copied = 0;
277
278 /*
279 * Note: We can't use vdev_stat's vs_alloc for sr_to_copy, because
280 * there may be space in the defer tree, which is free, but still
281 * counted in vs_alloc.
282 */
283 for (uint64_t i = 0; i < vd->vdev_ms_count; i++) {
284 metaslab_t *ms = vd->vdev_ms[i];
285 if (ms->ms_sm == NULL)
286 continue;
287
288 spa->spa_removing_phys.sr_to_copy +=
289 metaslab_allocated_space(ms);
290
291 /*
292 * Space which we are freeing this txg does not need to
293 * be copied.
294 */
295 spa->spa_removing_phys.sr_to_copy -=
296 range_tree_space(ms->ms_freeing);
297
298 ASSERT0(range_tree_space(ms->ms_freed));
299 for (int t = 0; t < TXG_SIZE; t++)
300 ASSERT0(range_tree_space(ms->ms_allocating[t]));
301 }
302
303 /*
304 * Sync tasks are called before metaslab_sync(), so there should
305 * be no already-synced metaslabs in the TXG_CLEAN list.
306 */
307 ASSERT3P(txg_list_head(&vd->vdev_ms_list, TXG_CLEAN(txg)), ==, NULL);
308
309 spa_sync_removing_state(spa, tx);
310
311 /*
312 * All blocks that we need to read the most recent mapping must be
313 * stored on concrete vdevs. Therefore, we must dirty anything that
314 * is read before spa_remove_init(). Specifically, the
315 * spa_config_object. (Note that although we already modified the
316 * spa_config_object in spa_sync_removing_state, that may not have
317 * modified all blocks of the object.)
318 */
319 dmu_object_info_t doi;
320 VERIFY0(dmu_object_info(mos, DMU_POOL_DIRECTORY_OBJECT, &doi));
321 for (uint64_t offset = 0; offset < doi.doi_max_offset; ) {
322 dmu_buf_t *dbuf;
323 VERIFY0(dmu_buf_hold(mos, DMU_POOL_DIRECTORY_OBJECT,
324 offset, FTAG, &dbuf, 0));
325 dmu_buf_will_dirty(dbuf, tx);
326 offset += dbuf->db_size;
327 dmu_buf_rele(dbuf, FTAG);
328 }
329
330 /*
331 * Now that we've allocated the im_object, dirty the vdev to ensure
332 * that the object gets written to the config on disk.
333 */
334 vdev_config_dirty(vd);
335
336 zfs_dbgmsg("starting removal thread for vdev %llu (%p) in txg %llu "
337 "im_obj=%llu", vd->vdev_id, vd, dmu_tx_get_txg(tx),
338 vic->vic_mapping_object);
339
340 spa_history_log_internal(spa, "vdev remove started", tx,
341 "%s vdev %llu %s", spa_name(spa), vd->vdev_id,
342 (vd->vdev_path != NULL) ? vd->vdev_path : "-");
343 /*
344 * Setting spa_vdev_removal causes subsequent frees to call
345 * free_from_removing_vdev(). Note that we don't need any locking
346 * because we are the sync thread, and metaslab_free_impl() is only
347 * called from syncing context (potentially from a zio taskq thread,
348 * but in any case only when there are outstanding free i/os, which
349 * there are not).
350 */
351 ASSERT3P(spa->spa_vdev_removal, ==, NULL);
352 spa->spa_vdev_removal = svr;
353 svr->svr_thread = thread_create(NULL, 0,
354 spa_vdev_remove_thread, spa, 0, &p0, TS_RUN, minclsyspri);
355 }
356
357 /*
358 * When we are opening a pool, we must read the mapping for each
359 * indirect vdev in order from most recently removed to least
360 * recently removed. We do this because the blocks for the mapping
361 * of older indirect vdevs may be stored on more recently removed vdevs.
362 * In order to read each indirect mapping object, we must have
363 * initialized all more recently removed vdevs.
364 */
365 int
spa_remove_init(spa_t * spa)366 spa_remove_init(spa_t *spa)
367 {
368 int error;
369
370 error = zap_lookup(spa->spa_dsl_pool->dp_meta_objset,
371 DMU_POOL_DIRECTORY_OBJECT,
372 DMU_POOL_REMOVING, sizeof (uint64_t),
373 sizeof (spa->spa_removing_phys) / sizeof (uint64_t),
374 &spa->spa_removing_phys);
375
376 if (error == ENOENT) {
377 spa->spa_removing_phys.sr_state = DSS_NONE;
378 spa->spa_removing_phys.sr_removing_vdev = -1;
379 spa->spa_removing_phys.sr_prev_indirect_vdev = -1;
380 spa->spa_indirect_vdevs_loaded = B_TRUE;
381 return (0);
382 } else if (error != 0) {
383 return (error);
384 }
385
386 if (spa->spa_removing_phys.sr_state == DSS_SCANNING) {
387 /*
388 * We are currently removing a vdev. Create and
389 * initialize a spa_vdev_removal_t from the bonus
390 * buffer of the removing vdevs vdev_im_object, and
391 * initialize its partial mapping.
392 */
393 spa_config_enter(spa, SCL_STATE, FTAG, RW_READER);
394 vdev_t *vd = vdev_lookup_top(spa,
395 spa->spa_removing_phys.sr_removing_vdev);
396
397 if (vd == NULL) {
398 spa_config_exit(spa, SCL_STATE, FTAG);
399 return (EINVAL);
400 }
401
402 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
403
404 ASSERT(vdev_is_concrete(vd));
405 spa_vdev_removal_t *svr = spa_vdev_removal_create(vd);
406 ASSERT3U(svr->svr_vdev_id, ==, vd->vdev_id);
407 ASSERT(vd->vdev_removing);
408
409 vd->vdev_indirect_mapping = vdev_indirect_mapping_open(
410 spa->spa_meta_objset, vic->vic_mapping_object);
411 vd->vdev_indirect_births = vdev_indirect_births_open(
412 spa->spa_meta_objset, vic->vic_births_object);
413 spa_config_exit(spa, SCL_STATE, FTAG);
414
415 spa->spa_vdev_removal = svr;
416 }
417
418 spa_config_enter(spa, SCL_STATE, FTAG, RW_READER);
419 uint64_t indirect_vdev_id =
420 spa->spa_removing_phys.sr_prev_indirect_vdev;
421 while (indirect_vdev_id != UINT64_MAX) {
422 vdev_t *vd = vdev_lookup_top(spa, indirect_vdev_id);
423 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
424
425 ASSERT3P(vd->vdev_ops, ==, &vdev_indirect_ops);
426 vd->vdev_indirect_mapping = vdev_indirect_mapping_open(
427 spa->spa_meta_objset, vic->vic_mapping_object);
428 vd->vdev_indirect_births = vdev_indirect_births_open(
429 spa->spa_meta_objset, vic->vic_births_object);
430
431 indirect_vdev_id = vic->vic_prev_indirect_vdev;
432 }
433 spa_config_exit(spa, SCL_STATE, FTAG);
434
435 /*
436 * Now that we've loaded all the indirect mappings, we can allow
437 * reads from other blocks (e.g. via predictive prefetch).
438 */
439 spa->spa_indirect_vdevs_loaded = B_TRUE;
440 return (0);
441 }
442
443 void
spa_restart_removal(spa_t * spa)444 spa_restart_removal(spa_t *spa)
445 {
446 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
447
448 if (svr == NULL)
449 return;
450
451 /*
452 * In general when this function is called there is no
453 * removal thread running. The only scenario where this
454 * is not true is during spa_import() where this function
455 * is called twice [once from spa_import_impl() and
456 * spa_async_resume()]. Thus, in the scenario where we
457 * import a pool that has an ongoing removal we don't
458 * want to spawn a second thread.
459 */
460 if (svr->svr_thread != NULL)
461 return;
462
463 if (!spa_writeable(spa))
464 return;
465
466 zfs_dbgmsg("restarting removal of %llu", svr->svr_vdev_id);
467 svr->svr_thread = thread_create(NULL, 0, spa_vdev_remove_thread, spa,
468 0, &p0, TS_RUN, minclsyspri);
469 }
470
471 /*
472 * Process freeing from a device which is in the middle of being removed.
473 * We must handle this carefully so that we attempt to copy freed data,
474 * and we correctly free already-copied data.
475 */
476 void
free_from_removing_vdev(vdev_t * vd,uint64_t offset,uint64_t size)477 free_from_removing_vdev(vdev_t *vd, uint64_t offset, uint64_t size)
478 {
479 spa_t *spa = vd->vdev_spa;
480 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
481 vdev_indirect_mapping_t *vim = vd->vdev_indirect_mapping;
482 uint64_t txg = spa_syncing_txg(spa);
483 uint64_t max_offset_yet = 0;
484
485 ASSERT(vd->vdev_indirect_config.vic_mapping_object != 0);
486 ASSERT3U(vd->vdev_indirect_config.vic_mapping_object, ==,
487 vdev_indirect_mapping_object(vim));
488 ASSERT3U(vd->vdev_id, ==, svr->svr_vdev_id);
489
490 mutex_enter(&svr->svr_lock);
491
492 /*
493 * Remove the segment from the removing vdev's spacemap. This
494 * ensures that we will not attempt to copy this space (if the
495 * removal thread has not yet visited it), and also ensures
496 * that we know what is actually allocated on the new vdevs
497 * (needed if we cancel the removal).
498 *
499 * Note: we must do the metaslab_free_concrete() with the svr_lock
500 * held, so that the remove_thread can not load this metaslab and then
501 * visit this offset between the time that we metaslab_free_concrete()
502 * and when we check to see if it has been visited.
503 *
504 * Note: The checkpoint flag is set to false as having/taking
505 * a checkpoint and removing a device can't happen at the same
506 * time.
507 */
508 ASSERT(!spa_has_checkpoint(spa));
509 metaslab_free_concrete(vd, offset, size, B_FALSE);
510
511 uint64_t synced_size = 0;
512 uint64_t synced_offset = 0;
513 uint64_t max_offset_synced = vdev_indirect_mapping_max_offset(vim);
514 if (offset < max_offset_synced) {
515 /*
516 * The mapping for this offset is already on disk.
517 * Free from the new location.
518 *
519 * Note that we use svr_max_synced_offset because it is
520 * updated atomically with respect to the in-core mapping.
521 * By contrast, vim_max_offset is not.
522 *
523 * This block may be split between a synced entry and an
524 * in-flight or unvisited entry. Only process the synced
525 * portion of it here.
526 */
527 synced_size = MIN(size, max_offset_synced - offset);
528 synced_offset = offset;
529
530 ASSERT3U(max_offset_yet, <=, max_offset_synced);
531 max_offset_yet = max_offset_synced;
532
533 DTRACE_PROBE3(remove__free__synced,
534 spa_t *, spa,
535 uint64_t, offset,
536 uint64_t, synced_size);
537
538 size -= synced_size;
539 offset += synced_size;
540 }
541
542 /*
543 * Look at all in-flight txgs starting from the currently syncing one
544 * and see if a section of this free is being copied. By starting from
545 * this txg and iterating forward, we might find that this region
546 * was copied in two different txgs and handle it appropriately.
547 */
548 for (int i = 0; i < TXG_CONCURRENT_STATES; i++) {
549 int txgoff = (txg + i) & TXG_MASK;
550 if (size > 0 && offset < svr->svr_max_offset_to_sync[txgoff]) {
551 /*
552 * The mapping for this offset is in flight, and
553 * will be synced in txg+i.
554 */
555 uint64_t inflight_size = MIN(size,
556 svr->svr_max_offset_to_sync[txgoff] - offset);
557
558 DTRACE_PROBE4(remove__free__inflight,
559 spa_t *, spa,
560 uint64_t, offset,
561 uint64_t, inflight_size,
562 uint64_t, txg + i);
563
564 /*
565 * We copy data in order of increasing offset.
566 * Therefore the max_offset_to_sync[] must increase
567 * (or be zero, indicating that nothing is being
568 * copied in that txg).
569 */
570 if (svr->svr_max_offset_to_sync[txgoff] != 0) {
571 ASSERT3U(svr->svr_max_offset_to_sync[txgoff],
572 >=, max_offset_yet);
573 max_offset_yet =
574 svr->svr_max_offset_to_sync[txgoff];
575 }
576
577 /*
578 * We've already committed to copying this segment:
579 * we have allocated space elsewhere in the pool for
580 * it and have an IO outstanding to copy the data. We
581 * cannot free the space before the copy has
582 * completed, or else the copy IO might overwrite any
583 * new data. To free that space, we record the
584 * segment in the appropriate svr_frees tree and free
585 * the mapped space later, in the txg where we have
586 * completed the copy and synced the mapping (see
587 * vdev_mapping_sync).
588 */
589 range_tree_add(svr->svr_frees[txgoff],
590 offset, inflight_size);
591 size -= inflight_size;
592 offset += inflight_size;
593
594 /*
595 * This space is already accounted for as being
596 * done, because it is being copied in txg+i.
597 * However, if i!=0, then it is being copied in
598 * a future txg. If we crash after this txg
599 * syncs but before txg+i syncs, then the space
600 * will be free. Therefore we must account
601 * for the space being done in *this* txg
602 * (when it is freed) rather than the future txg
603 * (when it will be copied).
604 */
605 ASSERT3U(svr->svr_bytes_done[txgoff], >=,
606 inflight_size);
607 svr->svr_bytes_done[txgoff] -= inflight_size;
608 svr->svr_bytes_done[txg & TXG_MASK] += inflight_size;
609 }
610 }
611 ASSERT0(svr->svr_max_offset_to_sync[TXG_CLEAN(txg) & TXG_MASK]);
612
613 if (size > 0) {
614 /*
615 * The copy thread has not yet visited this offset. Ensure
616 * that it doesn't.
617 */
618
619 DTRACE_PROBE3(remove__free__unvisited,
620 spa_t *, spa,
621 uint64_t, offset,
622 uint64_t, size);
623
624 if (svr->svr_allocd_segs != NULL)
625 range_tree_clear(svr->svr_allocd_segs, offset, size);
626
627 /*
628 * Since we now do not need to copy this data, for
629 * accounting purposes we have done our job and can count
630 * it as completed.
631 */
632 svr->svr_bytes_done[txg & TXG_MASK] += size;
633 }
634 mutex_exit(&svr->svr_lock);
635
636 /*
637 * Now that we have dropped svr_lock, process the synced portion
638 * of this free.
639 */
640 if (synced_size > 0) {
641 vdev_indirect_mark_obsolete(vd, synced_offset, synced_size);
642
643 /*
644 * Note: this can only be called from syncing context,
645 * and the vdev_indirect_mapping is only changed from the
646 * sync thread, so we don't need svr_lock while doing
647 * metaslab_free_impl_cb.
648 */
649 boolean_t checkpoint = B_FALSE;
650 vdev_indirect_ops.vdev_op_remap(vd, synced_offset, synced_size,
651 metaslab_free_impl_cb, &checkpoint);
652 }
653 }
654
655 /*
656 * Stop an active removal and update the spa_removing phys.
657 */
658 static void
spa_finish_removal(spa_t * spa,dsl_scan_state_t state,dmu_tx_t * tx)659 spa_finish_removal(spa_t *spa, dsl_scan_state_t state, dmu_tx_t *tx)
660 {
661 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
662 ASSERT3U(dmu_tx_get_txg(tx), ==, spa_syncing_txg(spa));
663
664 /* Ensure the removal thread has completed before we free the svr. */
665 spa_vdev_remove_suspend(spa);
666
667 ASSERT(state == DSS_FINISHED || state == DSS_CANCELED);
668
669 if (state == DSS_FINISHED) {
670 spa_removing_phys_t *srp = &spa->spa_removing_phys;
671 vdev_t *vd = vdev_lookup_top(spa, svr->svr_vdev_id);
672 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
673
674 if (srp->sr_prev_indirect_vdev != UINT64_MAX) {
675 vdev_t *pvd = vdev_lookup_top(spa,
676 srp->sr_prev_indirect_vdev);
677 ASSERT3P(pvd->vdev_ops, ==, &vdev_indirect_ops);
678 }
679
680 vic->vic_prev_indirect_vdev = srp->sr_prev_indirect_vdev;
681 srp->sr_prev_indirect_vdev = vd->vdev_id;
682 }
683 spa->spa_removing_phys.sr_state = state;
684 spa->spa_removing_phys.sr_end_time = gethrestime_sec();
685
686 spa->spa_vdev_removal = NULL;
687 spa_vdev_removal_destroy(svr);
688
689 spa_sync_removing_state(spa, tx);
690 spa_notify_waiters(spa);
691
692 vdev_config_dirty(spa->spa_root_vdev);
693 }
694
695 static void
free_mapped_segment_cb(void * arg,uint64_t offset,uint64_t size)696 free_mapped_segment_cb(void *arg, uint64_t offset, uint64_t size)
697 {
698 vdev_t *vd = arg;
699 vdev_indirect_mark_obsolete(vd, offset, size);
700 boolean_t checkpoint = B_FALSE;
701 vdev_indirect_ops.vdev_op_remap(vd, offset, size,
702 metaslab_free_impl_cb, &checkpoint);
703 }
704
705 /*
706 * On behalf of the removal thread, syncs an incremental bit more of
707 * the indirect mapping to disk and updates the in-memory mapping.
708 * Called as a sync task in every txg that the removal thread makes progress.
709 */
710 static void
vdev_mapping_sync(void * arg,dmu_tx_t * tx)711 vdev_mapping_sync(void *arg, dmu_tx_t *tx)
712 {
713 spa_vdev_removal_t *svr = arg;
714 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
715 vdev_t *vd = vdev_lookup_top(spa, svr->svr_vdev_id);
716 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
717 uint64_t txg = dmu_tx_get_txg(tx);
718 vdev_indirect_mapping_t *vim = vd->vdev_indirect_mapping;
719
720 ASSERT(vic->vic_mapping_object != 0);
721 ASSERT3U(txg, ==, spa_syncing_txg(spa));
722
723 vdev_indirect_mapping_add_entries(vim,
724 &svr->svr_new_segments[txg & TXG_MASK], tx);
725 vdev_indirect_births_add_entry(vd->vdev_indirect_births,
726 vdev_indirect_mapping_max_offset(vim), dmu_tx_get_txg(tx), tx);
727
728 /*
729 * Free the copied data for anything that was freed while the
730 * mapping entries were in flight.
731 */
732 mutex_enter(&svr->svr_lock);
733 range_tree_vacate(svr->svr_frees[txg & TXG_MASK],
734 free_mapped_segment_cb, vd);
735 ASSERT3U(svr->svr_max_offset_to_sync[txg & TXG_MASK], >=,
736 vdev_indirect_mapping_max_offset(vim));
737 svr->svr_max_offset_to_sync[txg & TXG_MASK] = 0;
738 mutex_exit(&svr->svr_lock);
739
740 spa_sync_removing_state(spa, tx);
741 }
742
743 typedef struct vdev_copy_segment_arg {
744 spa_t *vcsa_spa;
745 dva_t *vcsa_dest_dva;
746 uint64_t vcsa_txg;
747 range_tree_t *vcsa_obsolete_segs;
748 } vdev_copy_segment_arg_t;
749
750 static void
unalloc_seg(void * arg,uint64_t start,uint64_t size)751 unalloc_seg(void *arg, uint64_t start, uint64_t size)
752 {
753 vdev_copy_segment_arg_t *vcsa = arg;
754 spa_t *spa = vcsa->vcsa_spa;
755 blkptr_t bp = { 0 };
756
757 BP_SET_BIRTH(&bp, TXG_INITIAL, TXG_INITIAL);
758 BP_SET_LSIZE(&bp, size);
759 BP_SET_PSIZE(&bp, size);
760 BP_SET_COMPRESS(&bp, ZIO_COMPRESS_OFF);
761 BP_SET_CHECKSUM(&bp, ZIO_CHECKSUM_OFF);
762 BP_SET_TYPE(&bp, DMU_OT_NONE);
763 BP_SET_LEVEL(&bp, 0);
764 BP_SET_DEDUP(&bp, 0);
765 BP_SET_BYTEORDER(&bp, ZFS_HOST_BYTEORDER);
766
767 DVA_SET_VDEV(&bp.blk_dva[0], DVA_GET_VDEV(vcsa->vcsa_dest_dva));
768 DVA_SET_OFFSET(&bp.blk_dva[0],
769 DVA_GET_OFFSET(vcsa->vcsa_dest_dva) + start);
770 DVA_SET_ASIZE(&bp.blk_dva[0], size);
771
772 zio_free(spa, vcsa->vcsa_txg, &bp);
773 }
774
775 /*
776 * All reads and writes associated with a call to spa_vdev_copy_segment()
777 * are done.
778 */
779 static void
spa_vdev_copy_segment_done(zio_t * zio)780 spa_vdev_copy_segment_done(zio_t *zio)
781 {
782 vdev_copy_segment_arg_t *vcsa = zio->io_private;
783
784 range_tree_vacate(vcsa->vcsa_obsolete_segs,
785 unalloc_seg, vcsa);
786 range_tree_destroy(vcsa->vcsa_obsolete_segs);
787 kmem_free(vcsa, sizeof (*vcsa));
788
789 spa_config_exit(zio->io_spa, SCL_STATE, zio->io_spa);
790 }
791
792 /*
793 * The write of the new location is done.
794 */
795 static void
spa_vdev_copy_segment_write_done(zio_t * zio)796 spa_vdev_copy_segment_write_done(zio_t *zio)
797 {
798 vdev_copy_arg_t *vca = zio->io_private;
799
800 abd_free(zio->io_abd);
801
802 mutex_enter(&vca->vca_lock);
803 vca->vca_outstanding_bytes -= zio->io_size;
804 cv_signal(&vca->vca_cv);
805 mutex_exit(&vca->vca_lock);
806 }
807
808 /*
809 * The read of the old location is done. The parent zio is the write to
810 * the new location. Allow it to start.
811 */
812 static void
spa_vdev_copy_segment_read_done(zio_t * zio)813 spa_vdev_copy_segment_read_done(zio_t *zio)
814 {
815 zio_nowait(zio_unique_parent(zio));
816 }
817
818 /*
819 * If the old and new vdevs are mirrors, we will read both sides of the old
820 * mirror, and write each copy to the corresponding side of the new mirror.
821 * If the old and new vdevs have a different number of children, we will do
822 * this as best as possible. Since we aren't verifying checksums, this
823 * ensures that as long as there's a good copy of the data, we'll have a
824 * good copy after the removal, even if there's silent damage to one side
825 * of the mirror. If we're removing a mirror that has some silent damage,
826 * we'll have exactly the same damage in the new location (assuming that
827 * the new location is also a mirror).
828 *
829 * We accomplish this by creating a tree of zio_t's, with as many writes as
830 * there are "children" of the new vdev (a non-redundant vdev counts as one
831 * child, a 2-way mirror has 2 children, etc). Each write has an associated
832 * read from a child of the old vdev. Typically there will be the same
833 * number of children of the old and new vdevs. However, if there are more
834 * children of the new vdev, some child(ren) of the old vdev will be issued
835 * multiple reads. If there are more children of the old vdev, some copies
836 * will be dropped.
837 *
838 * For example, the tree of zio_t's for a 2-way mirror is:
839 *
840 * null
841 * / \
842 * write(new vdev, child 0) write(new vdev, child 1)
843 * | |
844 * read(old vdev, child 0) read(old vdev, child 1)
845 *
846 * Child zio's complete before their parents complete. However, zio's
847 * created with zio_vdev_child_io() may be issued before their children
848 * complete. In this case we need to make sure that the children (reads)
849 * complete before the parents (writes) are *issued*. We do this by not
850 * calling zio_nowait() on each write until its corresponding read has
851 * completed.
852 *
853 * The spa_config_lock must be held while zio's created by
854 * zio_vdev_child_io() are in progress, to ensure that the vdev tree does
855 * not change (e.g. due to a concurrent "zpool attach/detach"). The "null"
856 * zio is needed to release the spa_config_lock after all the reads and
857 * writes complete. (Note that we can't grab the config lock for each read,
858 * because it is not reentrant - we could deadlock with a thread waiting
859 * for a write lock.)
860 */
861 static void
spa_vdev_copy_one_child(vdev_copy_arg_t * vca,zio_t * nzio,vdev_t * source_vd,uint64_t source_offset,vdev_t * dest_child_vd,uint64_t dest_offset,int dest_id,uint64_t size)862 spa_vdev_copy_one_child(vdev_copy_arg_t *vca, zio_t *nzio,
863 vdev_t *source_vd, uint64_t source_offset,
864 vdev_t *dest_child_vd, uint64_t dest_offset, int dest_id, uint64_t size)
865 {
866 ASSERT3U(spa_config_held(nzio->io_spa, SCL_ALL, RW_READER), !=, 0);
867
868 mutex_enter(&vca->vca_lock);
869 vca->vca_outstanding_bytes += size;
870 mutex_exit(&vca->vca_lock);
871
872 abd_t *abd = abd_alloc_for_io(size, B_FALSE);
873
874 vdev_t *source_child_vd;
875 if (source_vd->vdev_ops == &vdev_mirror_ops && dest_id != -1) {
876 /*
877 * Source and dest are both mirrors. Copy from the same
878 * child id as we are copying to (wrapping around if there
879 * are more dest children than source children).
880 */
881 source_child_vd =
882 source_vd->vdev_child[dest_id % source_vd->vdev_children];
883 } else {
884 source_child_vd = source_vd;
885 }
886
887 zio_t *write_zio = zio_vdev_child_io(nzio, NULL,
888 dest_child_vd, dest_offset, abd, size,
889 ZIO_TYPE_WRITE, ZIO_PRIORITY_REMOVAL,
890 ZIO_FLAG_CANFAIL,
891 spa_vdev_copy_segment_write_done, vca);
892
893 zio_nowait(zio_vdev_child_io(write_zio, NULL,
894 source_child_vd, source_offset, abd, size,
895 ZIO_TYPE_READ, ZIO_PRIORITY_REMOVAL,
896 ZIO_FLAG_CANFAIL,
897 spa_vdev_copy_segment_read_done, vca));
898 }
899
900 /*
901 * Allocate a new location for this segment, and create the zio_t's to
902 * read from the old location and write to the new location.
903 */
904 static int
spa_vdev_copy_segment(vdev_t * vd,range_tree_t * segs,uint64_t maxalloc,uint64_t txg,vdev_copy_arg_t * vca,zio_alloc_list_t * zal)905 spa_vdev_copy_segment(vdev_t *vd, range_tree_t *segs,
906 uint64_t maxalloc, uint64_t txg,
907 vdev_copy_arg_t *vca, zio_alloc_list_t *zal)
908 {
909 metaslab_group_t *mg = vd->vdev_mg;
910 spa_t *spa = vd->vdev_spa;
911 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
912 vdev_indirect_mapping_entry_t *entry;
913 dva_t dst = { 0 };
914 uint64_t start = range_tree_min(segs);
915
916 ASSERT3U(maxalloc, <=, SPA_MAXBLOCKSIZE);
917
918 uint64_t size = range_tree_span(segs);
919 if (range_tree_span(segs) > maxalloc) {
920 /*
921 * We can't allocate all the segments. Prefer to end
922 * the allocation at the end of a segment, thus avoiding
923 * additional split blocks.
924 */
925 range_seg_max_t search;
926 zfs_btree_index_t where;
927 rs_set_start(&search, segs, start + maxalloc);
928 rs_set_end(&search, segs, start + maxalloc);
929 (void) zfs_btree_find(&segs->rt_root, &search, &where);
930 range_seg_t *rs = zfs_btree_prev(&segs->rt_root, &where,
931 &where);
932 if (rs != NULL) {
933 size = rs_get_end(rs, segs) - start;
934 } else {
935 /*
936 * There are no segments that end before maxalloc.
937 * I.e. the first segment is larger than maxalloc,
938 * so we must split it.
939 */
940 size = maxalloc;
941 }
942 }
943 ASSERT3U(size, <=, maxalloc);
944
945 /*
946 * An allocation class might not have any remaining vdevs or space
947 */
948 metaslab_class_t *mc = mg->mg_class;
949 if (mc != spa_normal_class(spa) && mc->mc_groups <= 1)
950 mc = spa_normal_class(spa);
951 int error = metaslab_alloc_dva(spa, mc, size, &dst, 0, NULL, txg, 0,
952 zal, 0);
953 if (error == ENOSPC && mc != spa_normal_class(spa)) {
954 error = metaslab_alloc_dva(spa, spa_normal_class(spa), size,
955 &dst, 0, NULL, txg, 0, zal, 0);
956 }
957 if (error != 0)
958 return (error);
959
960 /*
961 * Determine the ranges that are not actually needed. Offsets are
962 * relative to the start of the range to be copied (i.e. relative to the
963 * local variable "start").
964 */
965 range_tree_t *obsolete_segs = range_tree_create(NULL, RANGE_SEG64, NULL,
966 0, 0);
967
968 zfs_btree_index_t where;
969 range_seg_t *rs = zfs_btree_first(&segs->rt_root, &where);
970 ASSERT3U(rs_get_start(rs, segs), ==, start);
971 uint64_t prev_seg_end = rs_get_end(rs, segs);
972 while ((rs = zfs_btree_next(&segs->rt_root, &where, &where)) != NULL) {
973 if (rs_get_start(rs, segs) >= start + size) {
974 break;
975 } else {
976 range_tree_add(obsolete_segs,
977 prev_seg_end - start,
978 rs_get_start(rs, segs) - prev_seg_end);
979 }
980 prev_seg_end = rs_get_end(rs, segs);
981 }
982 /* We don't end in the middle of an obsolete range */
983 ASSERT3U(start + size, <=, prev_seg_end);
984
985 range_tree_clear(segs, start, size);
986
987 /*
988 * We can't have any padding of the allocated size, otherwise we will
989 * misunderstand what's allocated, and the size of the mapping.
990 * The caller ensures this will be true by passing in a size that is
991 * aligned to the worst (highest) ashift in the pool.
992 */
993 ASSERT3U(DVA_GET_ASIZE(&dst), ==, size);
994
995 entry = kmem_zalloc(sizeof (vdev_indirect_mapping_entry_t), KM_SLEEP);
996 DVA_MAPPING_SET_SRC_OFFSET(&entry->vime_mapping, start);
997 entry->vime_mapping.vimep_dst = dst;
998 if (spa_feature_is_enabled(spa, SPA_FEATURE_OBSOLETE_COUNTS)) {
999 entry->vime_obsolete_count = range_tree_space(obsolete_segs);
1000 }
1001
1002 vdev_copy_segment_arg_t *vcsa = kmem_zalloc(sizeof (*vcsa), KM_SLEEP);
1003 vcsa->vcsa_dest_dva = &entry->vime_mapping.vimep_dst;
1004 vcsa->vcsa_obsolete_segs = obsolete_segs;
1005 vcsa->vcsa_spa = spa;
1006 vcsa->vcsa_txg = txg;
1007
1008 /*
1009 * See comment before spa_vdev_copy_one_child().
1010 */
1011 spa_config_enter(spa, SCL_STATE, spa, RW_READER);
1012 zio_t *nzio = zio_null(spa->spa_txg_zio[txg & TXG_MASK], spa, NULL,
1013 spa_vdev_copy_segment_done, vcsa, 0);
1014 vdev_t *dest_vd = vdev_lookup_top(spa, DVA_GET_VDEV(&dst));
1015 if (dest_vd->vdev_ops == &vdev_mirror_ops) {
1016 for (int i = 0; i < dest_vd->vdev_children; i++) {
1017 vdev_t *child = dest_vd->vdev_child[i];
1018 spa_vdev_copy_one_child(vca, nzio, vd, start,
1019 child, DVA_GET_OFFSET(&dst), i, size);
1020 }
1021 } else {
1022 spa_vdev_copy_one_child(vca, nzio, vd, start,
1023 dest_vd, DVA_GET_OFFSET(&dst), -1, size);
1024 }
1025 zio_nowait(nzio);
1026
1027 list_insert_tail(&svr->svr_new_segments[txg & TXG_MASK], entry);
1028 ASSERT3U(start + size, <=, vd->vdev_ms_count << vd->vdev_ms_shift);
1029 vdev_dirty(vd, 0, NULL, txg);
1030
1031 return (0);
1032 }
1033
1034 /*
1035 * Complete the removal of a toplevel vdev. This is called as a
1036 * synctask in the same txg that we will sync out the new config (to the
1037 * MOS object) which indicates that this vdev is indirect.
1038 */
1039 static void
vdev_remove_complete_sync(void * arg,dmu_tx_t * tx)1040 vdev_remove_complete_sync(void *arg, dmu_tx_t *tx)
1041 {
1042 spa_vdev_removal_t *svr = arg;
1043 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
1044 vdev_t *vd = vdev_lookup_top(spa, svr->svr_vdev_id);
1045
1046 ASSERT3P(vd->vdev_ops, ==, &vdev_indirect_ops);
1047
1048 for (int i = 0; i < TXG_SIZE; i++) {
1049 ASSERT0(svr->svr_bytes_done[i]);
1050 }
1051
1052 ASSERT3U(spa->spa_removing_phys.sr_copied, ==,
1053 spa->spa_removing_phys.sr_to_copy);
1054
1055 vdev_destroy_spacemaps(vd, tx);
1056
1057 /* destroy leaf zaps, if any */
1058 ASSERT3P(svr->svr_zaplist, !=, NULL);
1059 for (nvpair_t *pair = nvlist_next_nvpair(svr->svr_zaplist, NULL);
1060 pair != NULL;
1061 pair = nvlist_next_nvpair(svr->svr_zaplist, pair)) {
1062 vdev_destroy_unlink_zap(vd, fnvpair_value_uint64(pair), tx);
1063 }
1064 fnvlist_free(svr->svr_zaplist);
1065
1066 spa_finish_removal(dmu_tx_pool(tx)->dp_spa, DSS_FINISHED, tx);
1067 /* vd->vdev_path is not available here */
1068 spa_history_log_internal(spa, "vdev remove completed", tx,
1069 "%s vdev %llu", spa_name(spa), vd->vdev_id);
1070 }
1071
1072 static void
vdev_remove_enlist_zaps(vdev_t * vd,nvlist_t * zlist)1073 vdev_remove_enlist_zaps(vdev_t *vd, nvlist_t *zlist)
1074 {
1075 ASSERT3P(zlist, !=, NULL);
1076 ASSERT3P(vd->vdev_ops, !=, &vdev_raidz_ops);
1077
1078 if (vd->vdev_leaf_zap != 0) {
1079 char zkey[32];
1080 (void) snprintf(zkey, sizeof (zkey), "%s-%"PRIu64,
1081 VDEV_REMOVAL_ZAP_OBJS, vd->vdev_leaf_zap);
1082 fnvlist_add_uint64(zlist, zkey, vd->vdev_leaf_zap);
1083 }
1084
1085 for (uint64_t id = 0; id < vd->vdev_children; id++) {
1086 vdev_remove_enlist_zaps(vd->vdev_child[id], zlist);
1087 }
1088 }
1089
1090 static void
vdev_remove_replace_with_indirect(vdev_t * vd,uint64_t txg)1091 vdev_remove_replace_with_indirect(vdev_t *vd, uint64_t txg)
1092 {
1093 vdev_t *ivd;
1094 dmu_tx_t *tx;
1095 spa_t *spa = vd->vdev_spa;
1096 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
1097
1098 /*
1099 * First, build a list of leaf zaps to be destroyed.
1100 * This is passed to the sync context thread,
1101 * which does the actual unlinking.
1102 */
1103 svr->svr_zaplist = fnvlist_alloc();
1104 vdev_remove_enlist_zaps(vd, svr->svr_zaplist);
1105
1106 ivd = vdev_add_parent(vd, &vdev_indirect_ops);
1107 ivd->vdev_removing = 0;
1108
1109 vd->vdev_leaf_zap = 0;
1110
1111 vdev_remove_child(ivd, vd);
1112 vdev_compact_children(ivd);
1113
1114 ASSERT(!list_link_active(&vd->vdev_state_dirty_node));
1115
1116 tx = dmu_tx_create_assigned(spa->spa_dsl_pool, txg);
1117 dsl_sync_task_nowait(spa->spa_dsl_pool, vdev_remove_complete_sync, svr,
1118 0, ZFS_SPACE_CHECK_NONE, tx);
1119 dmu_tx_commit(tx);
1120
1121 /*
1122 * Indicate that this thread has exited.
1123 * After this, we can not use svr.
1124 */
1125 mutex_enter(&svr->svr_lock);
1126 svr->svr_thread = NULL;
1127 cv_broadcast(&svr->svr_cv);
1128 mutex_exit(&svr->svr_lock);
1129 }
1130
1131 /*
1132 * Complete the removal of a toplevel vdev. This is called in open
1133 * context by the removal thread after we have copied all vdev's data.
1134 */
1135 static void
vdev_remove_complete(spa_t * spa)1136 vdev_remove_complete(spa_t *spa)
1137 {
1138 uint64_t txg;
1139
1140 /*
1141 * Wait for any deferred frees to be synced before we call
1142 * vdev_metaslab_fini()
1143 */
1144 txg_wait_synced(spa->spa_dsl_pool, 0);
1145 txg = spa_vdev_enter(spa);
1146 vdev_t *vd = vdev_lookup_top(spa, spa->spa_vdev_removal->svr_vdev_id);
1147 ASSERT3P(vd->vdev_initialize_thread, ==, NULL);
1148 ASSERT3P(vd->vdev_trim_thread, ==, NULL);
1149 ASSERT3P(vd->vdev_autotrim_thread, ==, NULL);
1150
1151 sysevent_t *ev = spa_event_create(spa, vd, NULL,
1152 ESC_ZFS_VDEV_REMOVE_DEV);
1153
1154 zfs_dbgmsg("finishing device removal for vdev %llu in txg %llu",
1155 vd->vdev_id, txg);
1156
1157 /*
1158 * Discard allocation state.
1159 */
1160 if (vd->vdev_mg != NULL) {
1161 vdev_metaslab_fini(vd);
1162 metaslab_group_destroy(vd->vdev_mg);
1163 vd->vdev_mg = NULL;
1164 spa_log_sm_set_blocklimit(spa);
1165 }
1166 ASSERT0(vd->vdev_stat.vs_space);
1167 ASSERT0(vd->vdev_stat.vs_dspace);
1168
1169 vdev_remove_replace_with_indirect(vd, txg);
1170
1171 /*
1172 * We now release the locks, allowing spa_sync to run and finish the
1173 * removal via vdev_remove_complete_sync in syncing context.
1174 *
1175 * Note that we hold on to the vdev_t that has been replaced. Since
1176 * it isn't part of the vdev tree any longer, it can't be concurrently
1177 * manipulated, even while we don't have the config lock.
1178 */
1179 (void) spa_vdev_exit(spa, NULL, txg, 0);
1180
1181 /*
1182 * Top ZAP should have been transferred to the indirect vdev in
1183 * vdev_remove_replace_with_indirect.
1184 */
1185 ASSERT0(vd->vdev_top_zap);
1186
1187 /*
1188 * Leaf ZAP should have been moved in vdev_remove_replace_with_indirect.
1189 */
1190 ASSERT0(vd->vdev_leaf_zap);
1191
1192 txg = spa_vdev_enter(spa);
1193 (void) vdev_label_init(vd, 0, VDEV_LABEL_REMOVE);
1194 /*
1195 * Request to update the config and the config cachefile.
1196 */
1197 vdev_config_dirty(spa->spa_root_vdev);
1198 (void) spa_vdev_exit(spa, vd, txg, 0);
1199
1200 spa_event_post(ev);
1201 }
1202
1203 /*
1204 * Evacuates a segment of size at most max_alloc from the vdev
1205 * via repeated calls to spa_vdev_copy_segment. If an allocation
1206 * fails, the pool is probably too fragmented to handle such a
1207 * large size, so decrease max_alloc so that the caller will not try
1208 * this size again this txg.
1209 */
1210 static void
spa_vdev_copy_impl(vdev_t * vd,spa_vdev_removal_t * svr,vdev_copy_arg_t * vca,uint64_t * max_alloc,dmu_tx_t * tx)1211 spa_vdev_copy_impl(vdev_t *vd, spa_vdev_removal_t *svr, vdev_copy_arg_t *vca,
1212 uint64_t *max_alloc, dmu_tx_t *tx)
1213 {
1214 uint64_t txg = dmu_tx_get_txg(tx);
1215 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
1216
1217 mutex_enter(&svr->svr_lock);
1218
1219 /*
1220 * Determine how big of a chunk to copy. We can allocate up
1221 * to max_alloc bytes, and we can span up to vdev_removal_max_span
1222 * bytes of unallocated space at a time. "segs" will track the
1223 * allocated segments that we are copying. We may also be copying
1224 * free segments (of up to vdev_removal_max_span bytes).
1225 */
1226 range_tree_t *segs = range_tree_create(NULL, RANGE_SEG64, NULL, 0, 0);
1227 for (;;) {
1228 range_tree_t *rt = svr->svr_allocd_segs;
1229 range_seg_t *rs = range_tree_first(rt);
1230
1231 if (rs == NULL)
1232 break;
1233
1234 uint64_t seg_length;
1235
1236 if (range_tree_is_empty(segs)) {
1237 /* need to truncate the first seg based on max_alloc */
1238 seg_length = MIN(rs_get_end(rs, rt) - rs_get_start(rs,
1239 rt), *max_alloc);
1240 } else {
1241 if (rs_get_start(rs, rt) - range_tree_max(segs) >
1242 vdev_removal_max_span) {
1243 /*
1244 * Including this segment would cause us to
1245 * copy a larger unneeded chunk than is allowed.
1246 */
1247 break;
1248 } else if (rs_get_end(rs, rt) - range_tree_min(segs) >
1249 *max_alloc) {
1250 /*
1251 * This additional segment would extend past
1252 * max_alloc. Rather than splitting this
1253 * segment, leave it for the next mapping.
1254 */
1255 break;
1256 } else {
1257 seg_length = rs_get_end(rs, rt) -
1258 rs_get_start(rs, rt);
1259 }
1260 }
1261
1262 range_tree_add(segs, rs_get_start(rs, rt), seg_length);
1263 range_tree_remove(svr->svr_allocd_segs,
1264 rs_get_start(rs, rt), seg_length);
1265 }
1266
1267 if (range_tree_is_empty(segs)) {
1268 mutex_exit(&svr->svr_lock);
1269 range_tree_destroy(segs);
1270 return;
1271 }
1272
1273 if (svr->svr_max_offset_to_sync[txg & TXG_MASK] == 0) {
1274 dsl_sync_task_nowait(dmu_tx_pool(tx), vdev_mapping_sync,
1275 svr, 0, ZFS_SPACE_CHECK_NONE, tx);
1276 }
1277
1278 svr->svr_max_offset_to_sync[txg & TXG_MASK] = range_tree_max(segs);
1279
1280 /*
1281 * Note: this is the amount of *allocated* space
1282 * that we are taking care of each txg.
1283 */
1284 svr->svr_bytes_done[txg & TXG_MASK] += range_tree_space(segs);
1285
1286 mutex_exit(&svr->svr_lock);
1287
1288 zio_alloc_list_t zal;
1289 metaslab_trace_init(&zal);
1290 uint64_t thismax = SPA_MAXBLOCKSIZE;
1291 while (!range_tree_is_empty(segs)) {
1292 int error = spa_vdev_copy_segment(vd,
1293 segs, thismax, txg, vca, &zal);
1294
1295 if (error == ENOSPC) {
1296 /*
1297 * Cut our segment in half, and don't try this
1298 * segment size again this txg. Note that the
1299 * allocation size must be aligned to the highest
1300 * ashift in the pool, so that the allocation will
1301 * not be padded out to a multiple of the ashift,
1302 * which could cause us to think that this mapping
1303 * is larger than we intended.
1304 */
1305 ASSERT3U(spa->spa_max_ashift, >=, SPA_MINBLOCKSHIFT);
1306 ASSERT3U(spa->spa_max_ashift, ==, spa->spa_min_ashift);
1307 uint64_t attempted =
1308 MIN(range_tree_span(segs), thismax);
1309 thismax = P2ROUNDUP(attempted / 2,
1310 1 << spa->spa_max_ashift);
1311 /*
1312 * The minimum-size allocation can not fail.
1313 */
1314 ASSERT3U(attempted, >, 1 << spa->spa_max_ashift);
1315 *max_alloc = attempted - (1 << spa->spa_max_ashift);
1316 } else {
1317 ASSERT0(error);
1318
1319 /*
1320 * We've performed an allocation, so reset the
1321 * alloc trace list.
1322 */
1323 metaslab_trace_fini(&zal);
1324 metaslab_trace_init(&zal);
1325 }
1326 }
1327 metaslab_trace_fini(&zal);
1328 range_tree_destroy(segs);
1329 }
1330
1331 /*
1332 * The removal thread operates in open context. It iterates over all
1333 * allocated space in the vdev, by loading each metaslab's spacemap.
1334 * For each contiguous segment of allocated space (capping the segment
1335 * size at SPA_MAXBLOCKSIZE), we:
1336 * - Allocate space for it on another vdev.
1337 * - Create a new mapping from the old location to the new location
1338 * (as a record in svr_new_segments).
1339 * - Initiate a logical read zio to get the data off the removing disk.
1340 * - In the read zio's done callback, initiate a logical write zio to
1341 * write it to the new vdev.
1342 * Note that all of this will take effect when a particular TXG syncs.
1343 * The sync thread ensures that all the phys reads and writes for the syncing
1344 * TXG have completed (see spa_txg_zio) and writes the new mappings to disk
1345 * (see vdev_mapping_sync()).
1346 */
1347 static void
spa_vdev_remove_thread(void * arg)1348 spa_vdev_remove_thread(void *arg)
1349 {
1350 spa_t *spa = arg;
1351 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
1352 vdev_copy_arg_t vca;
1353 uint64_t max_alloc = zfs_remove_max_segment;
1354 uint64_t last_txg = 0;
1355
1356 spa_config_enter(spa, SCL_CONFIG, FTAG, RW_READER);
1357 vdev_t *vd = vdev_lookup_top(spa, svr->svr_vdev_id);
1358 vdev_indirect_mapping_t *vim = vd->vdev_indirect_mapping;
1359 uint64_t start_offset = vdev_indirect_mapping_max_offset(vim);
1360
1361 ASSERT3P(vd->vdev_ops, !=, &vdev_indirect_ops);
1362 ASSERT(vdev_is_concrete(vd));
1363 ASSERT(vd->vdev_removing);
1364 ASSERT(vd->vdev_indirect_config.vic_mapping_object != 0);
1365 ASSERT(vim != NULL);
1366
1367 mutex_init(&vca.vca_lock, NULL, MUTEX_DEFAULT, NULL);
1368 cv_init(&vca.vca_cv, NULL, CV_DEFAULT, NULL);
1369 vca.vca_outstanding_bytes = 0;
1370
1371 mutex_enter(&svr->svr_lock);
1372
1373 /*
1374 * Start from vim_max_offset so we pick up where we left off
1375 * if we are restarting the removal after opening the pool.
1376 */
1377 uint64_t msi;
1378 for (msi = start_offset >> vd->vdev_ms_shift;
1379 msi < vd->vdev_ms_count && !svr->svr_thread_exit; msi++) {
1380 metaslab_t *msp = vd->vdev_ms[msi];
1381 ASSERT3U(msi, <=, vd->vdev_ms_count);
1382
1383 ASSERT0(range_tree_space(svr->svr_allocd_segs));
1384
1385 mutex_enter(&msp->ms_sync_lock);
1386 mutex_enter(&msp->ms_lock);
1387
1388 /*
1389 * Assert nothing in flight -- ms_*tree is empty.
1390 */
1391 for (int i = 0; i < TXG_SIZE; i++) {
1392 ASSERT0(range_tree_space(msp->ms_allocating[i]));
1393 }
1394
1395 /*
1396 * If the metaslab has ever been allocated from (ms_sm!=NULL),
1397 * read the allocated segments from the space map object
1398 * into svr_allocd_segs. Since we do this while holding
1399 * svr_lock and ms_sync_lock, concurrent frees (which
1400 * would have modified the space map) will wait for us
1401 * to finish loading the spacemap, and then take the
1402 * appropriate action (see free_from_removing_vdev()).
1403 */
1404 if (msp->ms_sm != NULL) {
1405 VERIFY0(space_map_load(msp->ms_sm,
1406 svr->svr_allocd_segs, SM_ALLOC));
1407
1408 range_tree_walk(msp->ms_unflushed_allocs,
1409 range_tree_add, svr->svr_allocd_segs);
1410 range_tree_walk(msp->ms_unflushed_frees,
1411 range_tree_remove, svr->svr_allocd_segs);
1412 range_tree_walk(msp->ms_freeing,
1413 range_tree_remove, svr->svr_allocd_segs);
1414
1415 /*
1416 * When we are resuming from a paused removal (i.e.
1417 * when importing a pool with a removal in progress),
1418 * discard any state that we have already processed.
1419 */
1420 range_tree_clear(svr->svr_allocd_segs, 0, start_offset);
1421 }
1422 mutex_exit(&msp->ms_lock);
1423 mutex_exit(&msp->ms_sync_lock);
1424
1425 vca.vca_msp = msp;
1426 zfs_dbgmsg("copying %llu segments for metaslab %llu",
1427 zfs_btree_numnodes(&svr->svr_allocd_segs->rt_root),
1428 msp->ms_id);
1429
1430 while (!svr->svr_thread_exit &&
1431 !range_tree_is_empty(svr->svr_allocd_segs)) {
1432
1433 mutex_exit(&svr->svr_lock);
1434
1435 /*
1436 * We need to periodically drop the config lock so that
1437 * writers can get in. Additionally, we can't wait
1438 * for a txg to sync while holding a config lock
1439 * (since a waiting writer could cause a 3-way deadlock
1440 * with the sync thread, which also gets a config
1441 * lock for reader). So we can't hold the config lock
1442 * while calling dmu_tx_assign().
1443 */
1444 spa_config_exit(spa, SCL_CONFIG, FTAG);
1445
1446 /*
1447 * This delay will pause the removal around the point
1448 * specified by zfs_removal_suspend_progress. We do this
1449 * solely from the test suite or during debugging.
1450 */
1451 uint64_t bytes_copied =
1452 spa->spa_removing_phys.sr_copied;
1453 for (int i = 0; i < TXG_SIZE; i++)
1454 bytes_copied += svr->svr_bytes_done[i];
1455 while (zfs_removal_suspend_progress &&
1456 !svr->svr_thread_exit)
1457 delay(hz);
1458
1459 mutex_enter(&vca.vca_lock);
1460 while (vca.vca_outstanding_bytes >
1461 zfs_remove_max_copy_bytes) {
1462 cv_wait(&vca.vca_cv, &vca.vca_lock);
1463 }
1464 mutex_exit(&vca.vca_lock);
1465
1466 dmu_tx_t *tx =
1467 dmu_tx_create_dd(spa_get_dsl(spa)->dp_mos_dir);
1468
1469 VERIFY0(dmu_tx_assign(tx, TXG_WAIT));
1470 uint64_t txg = dmu_tx_get_txg(tx);
1471
1472 /*
1473 * Reacquire the vdev_config lock. The vdev_t
1474 * that we're removing may have changed, e.g. due
1475 * to a vdev_attach or vdev_detach.
1476 */
1477 spa_config_enter(spa, SCL_CONFIG, FTAG, RW_READER);
1478 vd = vdev_lookup_top(spa, svr->svr_vdev_id);
1479
1480 if (txg != last_txg)
1481 max_alloc = zfs_remove_max_segment;
1482 last_txg = txg;
1483
1484 spa_vdev_copy_impl(vd, svr, &vca, &max_alloc, tx);
1485
1486 dmu_tx_commit(tx);
1487 mutex_enter(&svr->svr_lock);
1488 }
1489 }
1490
1491 mutex_exit(&svr->svr_lock);
1492
1493 spa_config_exit(spa, SCL_CONFIG, FTAG);
1494
1495 /*
1496 * Wait for all copies to finish before cleaning up the vca.
1497 */
1498 txg_wait_synced(spa->spa_dsl_pool, 0);
1499 ASSERT0(vca.vca_outstanding_bytes);
1500
1501 mutex_destroy(&vca.vca_lock);
1502 cv_destroy(&vca.vca_cv);
1503
1504 if (svr->svr_thread_exit) {
1505 mutex_enter(&svr->svr_lock);
1506 range_tree_vacate(svr->svr_allocd_segs, NULL, NULL);
1507 svr->svr_thread = NULL;
1508 cv_broadcast(&svr->svr_cv);
1509 mutex_exit(&svr->svr_lock);
1510 } else {
1511 ASSERT0(range_tree_space(svr->svr_allocd_segs));
1512 vdev_remove_complete(spa);
1513 }
1514 }
1515
1516 void
spa_vdev_remove_suspend(spa_t * spa)1517 spa_vdev_remove_suspend(spa_t *spa)
1518 {
1519 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
1520
1521 if (svr == NULL)
1522 return;
1523
1524 mutex_enter(&svr->svr_lock);
1525 svr->svr_thread_exit = B_TRUE;
1526 while (svr->svr_thread != NULL)
1527 cv_wait(&svr->svr_cv, &svr->svr_lock);
1528 svr->svr_thread_exit = B_FALSE;
1529 mutex_exit(&svr->svr_lock);
1530 }
1531
1532 /* ARGSUSED */
1533 static int
spa_vdev_remove_cancel_check(void * arg,dmu_tx_t * tx)1534 spa_vdev_remove_cancel_check(void *arg, dmu_tx_t *tx)
1535 {
1536 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
1537
1538 if (spa->spa_vdev_removal == NULL)
1539 return (ENOTACTIVE);
1540 return (0);
1541 }
1542
1543 /*
1544 * Cancel a removal by freeing all entries from the partial mapping
1545 * and marking the vdev as no longer being removing.
1546 */
1547 /* ARGSUSED */
1548 static void
spa_vdev_remove_cancel_sync(void * arg,dmu_tx_t * tx)1549 spa_vdev_remove_cancel_sync(void *arg, dmu_tx_t *tx)
1550 {
1551 spa_t *spa = dmu_tx_pool(tx)->dp_spa;
1552 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
1553 vdev_t *vd = vdev_lookup_top(spa, svr->svr_vdev_id);
1554 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
1555 vdev_indirect_mapping_t *vim = vd->vdev_indirect_mapping;
1556 objset_t *mos = spa->spa_meta_objset;
1557
1558 ASSERT3P(svr->svr_thread, ==, NULL);
1559
1560 spa_feature_decr(spa, SPA_FEATURE_DEVICE_REMOVAL, tx);
1561 if (vdev_obsolete_counts_are_precise(vd)) {
1562 spa_feature_decr(spa, SPA_FEATURE_OBSOLETE_COUNTS, tx);
1563 VERIFY0(zap_remove(spa->spa_meta_objset, vd->vdev_top_zap,
1564 VDEV_TOP_ZAP_OBSOLETE_COUNTS_ARE_PRECISE, tx));
1565 }
1566
1567 if (vdev_obsolete_sm_object(vd) != 0) {
1568 ASSERT(vd->vdev_obsolete_sm != NULL);
1569 ASSERT3U(vdev_obsolete_sm_object(vd), ==,
1570 space_map_object(vd->vdev_obsolete_sm));
1571
1572 space_map_free(vd->vdev_obsolete_sm, tx);
1573 VERIFY0(zap_remove(spa->spa_meta_objset, vd->vdev_top_zap,
1574 VDEV_TOP_ZAP_INDIRECT_OBSOLETE_SM, tx));
1575 space_map_close(vd->vdev_obsolete_sm);
1576 vd->vdev_obsolete_sm = NULL;
1577 spa_feature_decr(spa, SPA_FEATURE_OBSOLETE_COUNTS, tx);
1578 }
1579 for (int i = 0; i < TXG_SIZE; i++) {
1580 ASSERT(list_is_empty(&svr->svr_new_segments[i]));
1581 ASSERT3U(svr->svr_max_offset_to_sync[i], <=,
1582 vdev_indirect_mapping_max_offset(vim));
1583 }
1584
1585 for (uint64_t msi = 0; msi < vd->vdev_ms_count; msi++) {
1586 metaslab_t *msp = vd->vdev_ms[msi];
1587
1588 if (msp->ms_start >= vdev_indirect_mapping_max_offset(vim))
1589 break;
1590
1591 ASSERT0(range_tree_space(svr->svr_allocd_segs));
1592
1593 mutex_enter(&msp->ms_lock);
1594
1595 /*
1596 * Assert nothing in flight -- ms_*tree is empty.
1597 */
1598 for (int i = 0; i < TXG_SIZE; i++)
1599 ASSERT0(range_tree_space(msp->ms_allocating[i]));
1600 for (int i = 0; i < TXG_DEFER_SIZE; i++)
1601 ASSERT0(range_tree_space(msp->ms_defer[i]));
1602 ASSERT0(range_tree_space(msp->ms_freed));
1603
1604 if (msp->ms_sm != NULL) {
1605 mutex_enter(&svr->svr_lock);
1606 VERIFY0(space_map_load(msp->ms_sm,
1607 svr->svr_allocd_segs, SM_ALLOC));
1608
1609 range_tree_walk(msp->ms_unflushed_allocs,
1610 range_tree_add, svr->svr_allocd_segs);
1611 range_tree_walk(msp->ms_unflushed_frees,
1612 range_tree_remove, svr->svr_allocd_segs);
1613 range_tree_walk(msp->ms_freeing,
1614 range_tree_remove, svr->svr_allocd_segs);
1615
1616 /*
1617 * Clear everything past what has been synced,
1618 * because we have not allocated mappings for it yet.
1619 */
1620 uint64_t syncd = vdev_indirect_mapping_max_offset(vim);
1621 uint64_t sm_end = msp->ms_sm->sm_start +
1622 msp->ms_sm->sm_size;
1623 if (sm_end > syncd)
1624 range_tree_clear(svr->svr_allocd_segs,
1625 syncd, sm_end - syncd);
1626
1627 mutex_exit(&svr->svr_lock);
1628 }
1629 mutex_exit(&msp->ms_lock);
1630
1631 mutex_enter(&svr->svr_lock);
1632 range_tree_vacate(svr->svr_allocd_segs,
1633 free_mapped_segment_cb, vd);
1634 mutex_exit(&svr->svr_lock);
1635 }
1636
1637 /*
1638 * Note: this must happen after we invoke free_mapped_segment_cb,
1639 * because it adds to the obsolete_segments.
1640 */
1641 range_tree_vacate(vd->vdev_obsolete_segments, NULL, NULL);
1642
1643 ASSERT3U(vic->vic_mapping_object, ==,
1644 vdev_indirect_mapping_object(vd->vdev_indirect_mapping));
1645 vdev_indirect_mapping_close(vd->vdev_indirect_mapping);
1646 vd->vdev_indirect_mapping = NULL;
1647 vdev_indirect_mapping_free(mos, vic->vic_mapping_object, tx);
1648 vic->vic_mapping_object = 0;
1649
1650 ASSERT3U(vic->vic_births_object, ==,
1651 vdev_indirect_births_object(vd->vdev_indirect_births));
1652 vdev_indirect_births_close(vd->vdev_indirect_births);
1653 vd->vdev_indirect_births = NULL;
1654 vdev_indirect_births_free(mos, vic->vic_births_object, tx);
1655 vic->vic_births_object = 0;
1656
1657 /*
1658 * We may have processed some frees from the removing vdev in this
1659 * txg, thus increasing svr_bytes_done; discard that here to
1660 * satisfy the assertions in spa_vdev_removal_destroy().
1661 * Note that future txg's can not have any bytes_done, because
1662 * future TXG's are only modified from open context, and we have
1663 * already shut down the copying thread.
1664 */
1665 svr->svr_bytes_done[dmu_tx_get_txg(tx) & TXG_MASK] = 0;
1666 spa_finish_removal(spa, DSS_CANCELED, tx);
1667
1668 vd->vdev_removing = B_FALSE;
1669 vdev_config_dirty(vd);
1670
1671 zfs_dbgmsg("canceled device removal for vdev %llu in %llu",
1672 vd->vdev_id, dmu_tx_get_txg(tx));
1673 spa_history_log_internal(spa, "vdev remove canceled", tx,
1674 "%s vdev %llu %s", spa_name(spa),
1675 vd->vdev_id, (vd->vdev_path != NULL) ? vd->vdev_path : "-");
1676 }
1677
1678 int
spa_vdev_remove_cancel(spa_t * spa)1679 spa_vdev_remove_cancel(spa_t *spa)
1680 {
1681 spa_vdev_remove_suspend(spa);
1682
1683 if (spa->spa_vdev_removal == NULL)
1684 return (ENOTACTIVE);
1685
1686 uint64_t vdid = spa->spa_vdev_removal->svr_vdev_id;
1687
1688 int error = dsl_sync_task(spa->spa_name, spa_vdev_remove_cancel_check,
1689 spa_vdev_remove_cancel_sync, NULL, 0,
1690 ZFS_SPACE_CHECK_EXTRA_RESERVED);
1691
1692 if (error == 0) {
1693 spa_config_enter(spa, SCL_ALLOC | SCL_VDEV, FTAG, RW_WRITER);
1694 vdev_t *vd = vdev_lookup_top(spa, vdid);
1695 metaslab_group_activate(vd->vdev_mg);
1696 spa_config_exit(spa, SCL_ALLOC | SCL_VDEV, FTAG);
1697 }
1698
1699 return (error);
1700 }
1701
1702 void
svr_sync(spa_t * spa,dmu_tx_t * tx)1703 svr_sync(spa_t *spa, dmu_tx_t *tx)
1704 {
1705 spa_vdev_removal_t *svr = spa->spa_vdev_removal;
1706 int txgoff = dmu_tx_get_txg(tx) & TXG_MASK;
1707
1708 if (svr == NULL)
1709 return;
1710
1711 /*
1712 * This check is necessary so that we do not dirty the
1713 * DIRECTORY_OBJECT via spa_sync_removing_state() when there
1714 * is nothing to do. Dirtying it every time would prevent us
1715 * from syncing-to-convergence.
1716 */
1717 if (svr->svr_bytes_done[txgoff] == 0)
1718 return;
1719
1720 /*
1721 * Update progress accounting.
1722 */
1723 spa->spa_removing_phys.sr_copied += svr->svr_bytes_done[txgoff];
1724 svr->svr_bytes_done[txgoff] = 0;
1725
1726 spa_sync_removing_state(spa, tx);
1727 }
1728
1729 static void
vdev_remove_make_hole_and_free(vdev_t * vd)1730 vdev_remove_make_hole_and_free(vdev_t *vd)
1731 {
1732 uint64_t id = vd->vdev_id;
1733 spa_t *spa = vd->vdev_spa;
1734 vdev_t *rvd = spa->spa_root_vdev;
1735
1736 ASSERT(MUTEX_HELD(&spa_namespace_lock));
1737 ASSERT(spa_config_held(spa, SCL_ALL, RW_WRITER) == SCL_ALL);
1738
1739 vdev_free(vd);
1740
1741 vd = vdev_alloc_common(spa, id, 0, &vdev_hole_ops);
1742 vdev_add_child(rvd, vd);
1743 vdev_config_dirty(rvd);
1744
1745 /*
1746 * Reassess the health of our root vdev.
1747 */
1748 vdev_reopen(rvd);
1749 }
1750
1751 /*
1752 * Remove a log device. The config lock is held for the specified TXG.
1753 */
1754 static int
spa_vdev_remove_log(vdev_t * vd,uint64_t * txg)1755 spa_vdev_remove_log(vdev_t *vd, uint64_t *txg)
1756 {
1757 metaslab_group_t *mg = vd->vdev_mg;
1758 spa_t *spa = vd->vdev_spa;
1759 int error = 0;
1760
1761 ASSERT(vd->vdev_islog);
1762 ASSERT(vd == vd->vdev_top);
1763 ASSERT(MUTEX_HELD(&spa_namespace_lock));
1764
1765 /*
1766 * Stop allocating from this vdev.
1767 */
1768 metaslab_group_passivate(mg);
1769
1770 /*
1771 * Wait for the youngest allocations and frees to sync,
1772 * and then wait for the deferral of those frees to finish.
1773 */
1774 spa_vdev_config_exit(spa, NULL,
1775 *txg + TXG_CONCURRENT_STATES + TXG_DEFER_SIZE, 0, FTAG);
1776
1777 /*
1778 * Evacuate the device. We don't hold the config lock as
1779 * writer since we need to do I/O but we do keep the
1780 * spa_namespace_lock held. Once this completes the device
1781 * should no longer have any blocks allocated on it.
1782 */
1783 ASSERT(MUTEX_HELD(&spa_namespace_lock));
1784 if (vd->vdev_stat.vs_alloc != 0)
1785 error = spa_reset_logs(spa);
1786
1787 *txg = spa_vdev_config_enter(spa);
1788
1789 if (error != 0) {
1790 metaslab_group_activate(mg);
1791 return (error);
1792 }
1793 ASSERT0(vd->vdev_stat.vs_alloc);
1794
1795 /*
1796 * The evacuation succeeded. Remove any remaining MOS metadata
1797 * associated with this vdev, and wait for these changes to sync.
1798 */
1799 vd->vdev_removing = B_TRUE;
1800
1801 vdev_dirty_leaves(vd, VDD_DTL, *txg);
1802 vdev_config_dirty(vd);
1803
1804 /*
1805 * When the log space map feature is enabled we look at
1806 * the vdev's top_zap to find the on-disk flush data of
1807 * the metaslab we just flushed. Thus, while removing a
1808 * log vdev we make sure to call vdev_metaslab_fini()
1809 * first, which removes all metaslabs of this vdev from
1810 * spa_metaslabs_by_flushed before vdev_remove_empty()
1811 * destroys the top_zap of this log vdev.
1812 *
1813 * This avoids the scenario where we flush a metaslab
1814 * from the log vdev being removed that doesn't have a
1815 * top_zap and end up failing to lookup its on-disk flush
1816 * data.
1817 *
1818 * We don't call metaslab_group_destroy() right away
1819 * though (it will be called in vdev_free() later) as
1820 * during metaslab_sync() of metaslabs from other vdevs
1821 * we may touch the metaslab group of this vdev through
1822 * metaslab_class_histogram_verify()
1823 */
1824 vdev_metaslab_fini(vd);
1825 spa_log_sm_set_blocklimit(spa);
1826
1827 spa_history_log_internal(spa, "vdev remove", NULL,
1828 "%s vdev %llu (log) %s", spa_name(spa), vd->vdev_id,
1829 (vd->vdev_path != NULL) ? vd->vdev_path : "-");
1830
1831 /* Make sure these changes are sync'ed */
1832 spa_vdev_config_exit(spa, NULL, *txg, 0, FTAG);
1833
1834 /* Stop initializing and TRIM */
1835 vdev_initialize_stop_all(vd, VDEV_INITIALIZE_CANCELED);
1836 vdev_trim_stop_all(vd, VDEV_TRIM_CANCELED);
1837 vdev_autotrim_stop_wait(vd);
1838
1839 *txg = spa_vdev_config_enter(spa);
1840
1841 sysevent_t *ev = spa_event_create(spa, vd, NULL,
1842 ESC_ZFS_VDEV_REMOVE_DEV);
1843 ASSERT(MUTEX_HELD(&spa_namespace_lock));
1844 ASSERT(spa_config_held(spa, SCL_ALL, RW_WRITER) == SCL_ALL);
1845
1846 /* The top ZAP should have been destroyed by vdev_remove_empty. */
1847 ASSERT0(vd->vdev_top_zap);
1848 /* The leaf ZAP should have been destroyed by vdev_dtl_sync. */
1849 ASSERT0(vd->vdev_leaf_zap);
1850
1851 (void) vdev_label_init(vd, 0, VDEV_LABEL_REMOVE);
1852
1853 if (list_link_active(&vd->vdev_state_dirty_node))
1854 vdev_state_clean(vd);
1855 if (list_link_active(&vd->vdev_config_dirty_node))
1856 vdev_config_clean(vd);
1857
1858 ASSERT0(vd->vdev_stat.vs_alloc);
1859
1860 /*
1861 * Clean up the vdev namespace.
1862 */
1863 vdev_remove_make_hole_and_free(vd);
1864
1865 if (ev != NULL)
1866 spa_event_post(ev);
1867
1868 return (0);
1869 }
1870
1871 static int
spa_vdev_remove_top_check(vdev_t * vd)1872 spa_vdev_remove_top_check(vdev_t *vd)
1873 {
1874 spa_t *spa = vd->vdev_spa;
1875
1876 if (vd != vd->vdev_top)
1877 return (SET_ERROR(ENOTSUP));
1878
1879 if (!spa_feature_is_enabled(spa, SPA_FEATURE_DEVICE_REMOVAL))
1880 return (SET_ERROR(ENOTSUP));
1881
1882 /* available space in the pool's normal class */
1883 uint64_t available = dsl_dir_space_available(
1884 spa->spa_dsl_pool->dp_root_dir, NULL, 0, B_TRUE);
1885
1886 metaslab_class_t *mc = vd->vdev_mg->mg_class;
1887
1888 /*
1889 * When removing a vdev from an allocation class that has
1890 * remaining vdevs, include available space from the class.
1891 */
1892 if (mc != spa_normal_class(spa) && mc->mc_groups > 1) {
1893 uint64_t class_avail = metaslab_class_get_space(mc) -
1894 metaslab_class_get_alloc(mc);
1895
1896 /* add class space, adjusted for overhead */
1897 available += (class_avail * 94) / 100;
1898 }
1899
1900 /*
1901 * There has to be enough free space to remove the
1902 * device and leave double the "slop" space (i.e. we
1903 * must leave at least 3% of the pool free, in addition to
1904 * the normal slop space).
1905 */
1906 if (available < vd->vdev_stat.vs_dspace + spa_get_slop_space(spa)) {
1907 return (SET_ERROR(ENOSPC));
1908 }
1909
1910 /*
1911 * There can not be a removal in progress.
1912 */
1913 if (spa->spa_removing_phys.sr_state == DSS_SCANNING)
1914 return (SET_ERROR(EBUSY));
1915
1916 /*
1917 * The device must have all its data.
1918 */
1919 if (!vdev_dtl_empty(vd, DTL_MISSING) ||
1920 !vdev_dtl_empty(vd, DTL_OUTAGE))
1921 return (SET_ERROR(EBUSY));
1922
1923 /*
1924 * The device must be healthy.
1925 */
1926 if (!vdev_readable(vd))
1927 return (SET_ERROR(EIO));
1928
1929 /*
1930 * All vdevs in normal class must have the same ashift.
1931 */
1932 if (spa->spa_max_ashift != spa->spa_min_ashift) {
1933 return (SET_ERROR(EINVAL));
1934 }
1935
1936 /*
1937 * All vdevs in normal class must have the same ashift
1938 * and not be raidz.
1939 */
1940 vdev_t *rvd = spa->spa_root_vdev;
1941 int num_indirect = 0;
1942 for (uint64_t id = 0; id < rvd->vdev_children; id++) {
1943 vdev_t *cvd = rvd->vdev_child[id];
1944 if (cvd->vdev_ashift != 0 && !cvd->vdev_islog)
1945 ASSERT3U(cvd->vdev_ashift, ==, spa->spa_max_ashift);
1946 if (cvd->vdev_ops == &vdev_indirect_ops)
1947 num_indirect++;
1948 if (!vdev_is_concrete(cvd))
1949 continue;
1950 if (cvd->vdev_ops == &vdev_raidz_ops)
1951 return (SET_ERROR(EINVAL));
1952 /*
1953 * Need the mirror to be mirror of leaf vdevs only
1954 */
1955 if (cvd->vdev_ops == &vdev_mirror_ops) {
1956 for (uint64_t cid = 0;
1957 cid < cvd->vdev_children; cid++) {
1958 vdev_t *tmp = cvd->vdev_child[cid];
1959 if (!tmp->vdev_ops->vdev_op_leaf)
1960 return (SET_ERROR(EINVAL));
1961 }
1962 }
1963 }
1964
1965 return (0);
1966 }
1967
1968 /*
1969 * Initiate removal of a top-level vdev, reducing the total space in the pool.
1970 * The config lock is held for the specified TXG. Once initiated,
1971 * evacuation of all allocated space (copying it to other vdevs) happens
1972 * in the background (see spa_vdev_remove_thread()), and can be canceled
1973 * (see spa_vdev_remove_cancel()). If successful, the vdev will
1974 * be transformed to an indirect vdev (see spa_vdev_remove_complete()).
1975 */
1976 static int
spa_vdev_remove_top(vdev_t * vd,uint64_t * txg)1977 spa_vdev_remove_top(vdev_t *vd, uint64_t *txg)
1978 {
1979 spa_t *spa = vd->vdev_spa;
1980 int error;
1981
1982 /*
1983 * Check for errors up-front, so that we don't waste time
1984 * passivating the metaslab group and clearing the ZIL if there
1985 * are errors.
1986 */
1987 error = spa_vdev_remove_top_check(vd);
1988 if (error != 0)
1989 return (error);
1990
1991 /*
1992 * Stop allocating from this vdev. Note that we must check
1993 * that this is not the only device in the pool before
1994 * passivating, otherwise we will not be able to make
1995 * progress because we can't allocate from any vdevs.
1996 * The above check for sufficient free space serves this
1997 * purpose.
1998 */
1999 metaslab_group_t *mg = vd->vdev_mg;
2000 metaslab_group_passivate(mg);
2001
2002 /*
2003 * Wait for the youngest allocations and frees to sync,
2004 * and then wait for the deferral of those frees to finish.
2005 */
2006 spa_vdev_config_exit(spa, NULL,
2007 *txg + TXG_CONCURRENT_STATES + TXG_DEFER_SIZE, 0, FTAG);
2008
2009 /*
2010 * We must ensure that no "stubby" log blocks are allocated
2011 * on the device to be removed. These blocks could be
2012 * written at any time, including while we are in the middle
2013 * of copying them.
2014 */
2015 error = spa_reset_logs(spa);
2016
2017 /*
2018 * We stop any initializing and TRIM that is currently in progress
2019 * but leave the state as "active". This will allow the process to
2020 * resume if the removal is canceled sometime later.
2021 */
2022 vdev_initialize_stop_all(vd, VDEV_INITIALIZE_ACTIVE);
2023 vdev_trim_stop_all(vd, VDEV_TRIM_ACTIVE);
2024 vdev_autotrim_stop_wait(vd);
2025
2026 *txg = spa_vdev_config_enter(spa);
2027
2028 /*
2029 * Things might have changed while the config lock was dropped
2030 * (e.g. space usage). Check for errors again.
2031 */
2032 if (error == 0)
2033 error = spa_vdev_remove_top_check(vd);
2034
2035 if (error != 0) {
2036 metaslab_group_activate(mg);
2037 spa_async_request(spa, SPA_ASYNC_INITIALIZE_RESTART);
2038 spa_async_request(spa, SPA_ASYNC_TRIM_RESTART);
2039 spa_async_request(spa, SPA_ASYNC_AUTOTRIM_RESTART);
2040 return (error);
2041 }
2042
2043 vd->vdev_removing = B_TRUE;
2044
2045 vdev_dirty_leaves(vd, VDD_DTL, *txg);
2046 vdev_config_dirty(vd);
2047 dmu_tx_t *tx = dmu_tx_create_assigned(spa->spa_dsl_pool, *txg);
2048 dsl_sync_task_nowait(spa->spa_dsl_pool,
2049 vdev_remove_initiate_sync,
2050 (void *)(uintptr_t)vd->vdev_id, 0, ZFS_SPACE_CHECK_NONE, tx);
2051 dmu_tx_commit(tx);
2052
2053 return (0);
2054 }
2055
2056 /*
2057 * Remove a device from the pool.
2058 *
2059 * Removing a device from the vdev namespace requires several steps
2060 * and can take a significant amount of time. As a result we use
2061 * the spa_vdev_config_[enter/exit] functions which allow us to
2062 * grab and release the spa_config_lock while still holding the namespace
2063 * lock. During each step the configuration is synced out.
2064 */
2065 int
spa_vdev_remove(spa_t * spa,uint64_t guid,boolean_t unspare)2066 spa_vdev_remove(spa_t *spa, uint64_t guid, boolean_t unspare)
2067 {
2068 vdev_t *vd;
2069 nvlist_t **spares, **l2cache, *nv;
2070 uint64_t txg = 0;
2071 uint_t nspares, nl2cache;
2072 int error = 0;
2073 boolean_t locked = MUTEX_HELD(&spa_namespace_lock);
2074 sysevent_t *ev = NULL;
2075
2076 ASSERT(spa_writeable(spa));
2077
2078 if (!locked)
2079 txg = spa_vdev_enter(spa);
2080
2081 ASSERT(MUTEX_HELD(&spa_namespace_lock));
2082 if (spa_feature_is_active(spa, SPA_FEATURE_POOL_CHECKPOINT)) {
2083 error = (spa_has_checkpoint(spa)) ?
2084 ZFS_ERR_CHECKPOINT_EXISTS : ZFS_ERR_DISCARDING_CHECKPOINT;
2085
2086 if (!locked)
2087 return (spa_vdev_exit(spa, NULL, txg, error));
2088
2089 return (error);
2090 }
2091
2092 vd = spa_lookup_by_guid(spa, guid, B_FALSE);
2093
2094 if (spa->spa_spares.sav_vdevs != NULL &&
2095 nvlist_lookup_nvlist_array(spa->spa_spares.sav_config,
2096 ZPOOL_CONFIG_SPARES, &spares, &nspares) == 0 &&
2097 (nv = spa_nvlist_lookup_by_guid(spares, nspares, guid)) != NULL) {
2098 /*
2099 * Only remove the hot spare if it's not currently in use
2100 * in this pool.
2101 */
2102 if (vd == NULL || unspare) {
2103 char *nvstr = fnvlist_lookup_string(nv,
2104 ZPOOL_CONFIG_PATH);
2105 spa_history_log_internal(spa, "vdev remove", NULL,
2106 "%s vdev (%s) %s", spa_name(spa),
2107 VDEV_TYPE_SPARE, nvstr);
2108 if (vd == NULL)
2109 vd = spa_lookup_by_guid(spa, guid, B_TRUE);
2110 ev = spa_event_create(spa, vd, NULL,
2111 ESC_ZFS_VDEV_REMOVE_AUX);
2112 spa_vdev_remove_aux(spa->spa_spares.sav_config,
2113 ZPOOL_CONFIG_SPARES, spares, nspares, nv);
2114 spa_load_spares(spa);
2115 spa->spa_spares.sav_sync = B_TRUE;
2116 } else {
2117 error = SET_ERROR(EBUSY);
2118 }
2119 } else if (spa->spa_l2cache.sav_vdevs != NULL &&
2120 nvlist_lookup_nvlist_array(spa->spa_l2cache.sav_config,
2121 ZPOOL_CONFIG_L2CACHE, &l2cache, &nl2cache) == 0 &&
2122 (nv = spa_nvlist_lookup_by_guid(l2cache, nl2cache, guid)) != NULL) {
2123 char *nvstr = fnvlist_lookup_string(nv, ZPOOL_CONFIG_PATH);
2124 spa_history_log_internal(spa, "vdev remove", NULL,
2125 "%s vdev (%s) %s", spa_name(spa), VDEV_TYPE_L2CACHE, nvstr);
2126 /*
2127 * Cache devices can always be removed.
2128 */
2129 vd = spa_lookup_by_guid(spa, guid, B_TRUE);
2130 ev = spa_event_create(spa, vd, NULL, ESC_ZFS_VDEV_REMOVE_AUX);
2131 spa_vdev_remove_aux(spa->spa_l2cache.sav_config,
2132 ZPOOL_CONFIG_L2CACHE, l2cache, nl2cache, nv);
2133 spa_load_l2cache(spa);
2134 spa->spa_l2cache.sav_sync = B_TRUE;
2135 } else if (vd != NULL && vd->vdev_islog) {
2136 ASSERT(!locked);
2137 error = spa_vdev_remove_log(vd, &txg);
2138 } else if (vd != NULL) {
2139 ASSERT(!locked);
2140 error = spa_vdev_remove_top(vd, &txg);
2141 } else {
2142 /*
2143 * There is no vdev of any kind with the specified guid.
2144 */
2145 error = SET_ERROR(ENOENT);
2146 }
2147
2148 if (!locked)
2149 error = spa_vdev_exit(spa, NULL, txg, error);
2150
2151 if (ev != NULL) {
2152 if (error != 0) {
2153 spa_event_discard(ev);
2154 } else {
2155 spa_event_post(ev);
2156 }
2157 }
2158
2159 return (error);
2160 }
2161
2162 int
spa_removal_get_stats(spa_t * spa,pool_removal_stat_t * prs)2163 spa_removal_get_stats(spa_t *spa, pool_removal_stat_t *prs)
2164 {
2165 prs->prs_state = spa->spa_removing_phys.sr_state;
2166
2167 if (prs->prs_state == DSS_NONE)
2168 return (SET_ERROR(ENOENT));
2169
2170 prs->prs_removing_vdev = spa->spa_removing_phys.sr_removing_vdev;
2171 prs->prs_start_time = spa->spa_removing_phys.sr_start_time;
2172 prs->prs_end_time = spa->spa_removing_phys.sr_end_time;
2173 prs->prs_to_copy = spa->spa_removing_phys.sr_to_copy;
2174 prs->prs_copied = spa->spa_removing_phys.sr_copied;
2175
2176 if (spa->spa_vdev_removal != NULL) {
2177 for (int i = 0; i < TXG_SIZE; i++) {
2178 prs->prs_copied +=
2179 spa->spa_vdev_removal->svr_bytes_done[i];
2180 }
2181 }
2182
2183 prs->prs_mapping_memory = 0;
2184 uint64_t indirect_vdev_id =
2185 spa->spa_removing_phys.sr_prev_indirect_vdev;
2186 while (indirect_vdev_id != -1) {
2187 vdev_t *vd = spa->spa_root_vdev->vdev_child[indirect_vdev_id];
2188 vdev_indirect_config_t *vic = &vd->vdev_indirect_config;
2189 vdev_indirect_mapping_t *vim = vd->vdev_indirect_mapping;
2190
2191 ASSERT3P(vd->vdev_ops, ==, &vdev_indirect_ops);
2192 prs->prs_mapping_memory += vdev_indirect_mapping_size(vim);
2193 indirect_vdev_id = vic->vic_prev_indirect_vdev;
2194 }
2195
2196 return (0);
2197 }
2198