xref: /linux/drivers/gpu/drm/rockchip/cdn-dp-core.c (revision e70140ba0d2b1a30467d4af6bcfe761327b9ec95)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
4  * Author: Chris Zhong <zyw@rock-chips.com>
5  */
6 
7 #include <linux/clk.h>
8 #include <linux/component.h>
9 #include <linux/extcon.h>
10 #include <linux/firmware.h>
11 #include <linux/mfd/syscon.h>
12 #include <linux/phy/phy.h>
13 #include <linux/regmap.h>
14 #include <linux/reset.h>
15 
16 #include <sound/hdmi-codec.h>
17 
18 #include <drm/display/drm_dp_helper.h>
19 #include <drm/drm_atomic_helper.h>
20 #include <drm/drm_edid.h>
21 #include <drm/drm_of.h>
22 #include <drm/drm_probe_helper.h>
23 #include <drm/drm_simple_kms_helper.h>
24 
25 #include "cdn-dp-core.h"
26 #include "cdn-dp-reg.h"
27 
connector_to_dp(struct drm_connector * connector)28 static inline struct cdn_dp_device *connector_to_dp(struct drm_connector *connector)
29 {
30 	return container_of(connector, struct cdn_dp_device, connector);
31 }
32 
encoder_to_dp(struct drm_encoder * encoder)33 static inline struct cdn_dp_device *encoder_to_dp(struct drm_encoder *encoder)
34 {
35 	struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder);
36 
37 	return container_of(rkencoder, struct cdn_dp_device, encoder);
38 }
39 
40 #define GRF_SOC_CON9		0x6224
41 #define DP_SEL_VOP_LIT		BIT(12)
42 #define GRF_SOC_CON26		0x6268
43 #define DPTX_HPD_SEL		(3 << 12)
44 #define DPTX_HPD_DEL		(2 << 12)
45 #define DPTX_HPD_SEL_MASK	(3 << 28)
46 
47 #define CDN_FW_TIMEOUT_MS	(64 * 1000)
48 #define CDN_DPCD_TIMEOUT_MS	5000
49 #define CDN_DP_FIRMWARE		"rockchip/dptx.bin"
50 MODULE_FIRMWARE(CDN_DP_FIRMWARE);
51 
52 struct cdn_dp_data {
53 	u8 max_phy;
54 };
55 
56 static struct cdn_dp_data rk3399_cdn_dp = {
57 	.max_phy = 2,
58 };
59 
60 static const struct of_device_id cdn_dp_dt_ids[] = {
61 	{ .compatible = "rockchip,rk3399-cdn-dp",
62 		.data = (void *)&rk3399_cdn_dp },
63 	{}
64 };
65 
66 MODULE_DEVICE_TABLE(of, cdn_dp_dt_ids);
67 
cdn_dp_grf_write(struct cdn_dp_device * dp,unsigned int reg,unsigned int val)68 static int cdn_dp_grf_write(struct cdn_dp_device *dp,
69 			    unsigned int reg, unsigned int val)
70 {
71 	int ret;
72 
73 	ret = clk_prepare_enable(dp->grf_clk);
74 	if (ret) {
75 		DRM_DEV_ERROR(dp->dev, "Failed to prepare_enable grf clock\n");
76 		return ret;
77 	}
78 
79 	ret = regmap_write(dp->grf, reg, val);
80 	if (ret) {
81 		DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);
82 		clk_disable_unprepare(dp->grf_clk);
83 		return ret;
84 	}
85 
86 	clk_disable_unprepare(dp->grf_clk);
87 
88 	return 0;
89 }
90 
cdn_dp_clk_enable(struct cdn_dp_device * dp)91 static int cdn_dp_clk_enable(struct cdn_dp_device *dp)
92 {
93 	int ret;
94 	unsigned long rate;
95 
96 	ret = clk_prepare_enable(dp->pclk);
97 	if (ret < 0) {
98 		DRM_DEV_ERROR(dp->dev, "cannot enable dp pclk %d\n", ret);
99 		goto err_pclk;
100 	}
101 
102 	ret = clk_prepare_enable(dp->core_clk);
103 	if (ret < 0) {
104 		DRM_DEV_ERROR(dp->dev, "cannot enable core_clk %d\n", ret);
105 		goto err_core_clk;
106 	}
107 
108 	ret = pm_runtime_get_sync(dp->dev);
109 	if (ret < 0) {
110 		DRM_DEV_ERROR(dp->dev, "cannot get pm runtime %d\n", ret);
111 		goto err_pm_runtime_get;
112 	}
113 
114 	reset_control_assert(dp->core_rst);
115 	reset_control_assert(dp->dptx_rst);
116 	reset_control_assert(dp->apb_rst);
117 	reset_control_deassert(dp->core_rst);
118 	reset_control_deassert(dp->dptx_rst);
119 	reset_control_deassert(dp->apb_rst);
120 
121 	rate = clk_get_rate(dp->core_clk);
122 	if (!rate) {
123 		DRM_DEV_ERROR(dp->dev, "get clk rate failed\n");
124 		ret = -EINVAL;
125 		goto err_set_rate;
126 	}
127 
128 	cdn_dp_set_fw_clk(dp, rate);
129 	cdn_dp_clock_reset(dp);
130 
131 	return 0;
132 
133 err_set_rate:
134 	pm_runtime_put(dp->dev);
135 err_pm_runtime_get:
136 	clk_disable_unprepare(dp->core_clk);
137 err_core_clk:
138 	clk_disable_unprepare(dp->pclk);
139 err_pclk:
140 	return ret;
141 }
142 
cdn_dp_clk_disable(struct cdn_dp_device * dp)143 static void cdn_dp_clk_disable(struct cdn_dp_device *dp)
144 {
145 	pm_runtime_put_sync(dp->dev);
146 	clk_disable_unprepare(dp->pclk);
147 	clk_disable_unprepare(dp->core_clk);
148 }
149 
cdn_dp_get_port_lanes(struct cdn_dp_port * port)150 static int cdn_dp_get_port_lanes(struct cdn_dp_port *port)
151 {
152 	struct extcon_dev *edev = port->extcon;
153 	union extcon_property_value property;
154 	int dptx;
155 	u8 lanes;
156 
157 	dptx = extcon_get_state(edev, EXTCON_DISP_DP);
158 	if (dptx > 0) {
159 		extcon_get_property(edev, EXTCON_DISP_DP,
160 				    EXTCON_PROP_USB_SS, &property);
161 		if (property.intval)
162 			lanes = 2;
163 		else
164 			lanes = 4;
165 	} else {
166 		lanes = 0;
167 	}
168 
169 	return lanes;
170 }
171 
cdn_dp_get_sink_count(struct cdn_dp_device * dp,u8 * sink_count)172 static int cdn_dp_get_sink_count(struct cdn_dp_device *dp, u8 *sink_count)
173 {
174 	int ret;
175 	u8 value;
176 
177 	*sink_count = 0;
178 	ret = cdn_dp_dpcd_read(dp, DP_SINK_COUNT, &value, 1);
179 	if (ret)
180 		return ret;
181 
182 	*sink_count = DP_GET_SINK_COUNT(value);
183 	return 0;
184 }
185 
cdn_dp_connected_port(struct cdn_dp_device * dp)186 static struct cdn_dp_port *cdn_dp_connected_port(struct cdn_dp_device *dp)
187 {
188 	struct cdn_dp_port *port;
189 	int i, lanes;
190 
191 	for (i = 0; i < dp->ports; i++) {
192 		port = dp->port[i];
193 		lanes = cdn_dp_get_port_lanes(port);
194 		if (lanes)
195 			return port;
196 	}
197 	return NULL;
198 }
199 
cdn_dp_check_sink_connection(struct cdn_dp_device * dp)200 static bool cdn_dp_check_sink_connection(struct cdn_dp_device *dp)
201 {
202 	unsigned long timeout = jiffies + msecs_to_jiffies(CDN_DPCD_TIMEOUT_MS);
203 	struct cdn_dp_port *port;
204 	u8 sink_count = 0;
205 
206 	if (dp->active_port < 0 || dp->active_port >= dp->ports) {
207 		DRM_DEV_ERROR(dp->dev, "active_port is wrong!\n");
208 		return false;
209 	}
210 
211 	port = dp->port[dp->active_port];
212 
213 	/*
214 	 * Attempt to read sink count, retry in case the sink may not be ready.
215 	 *
216 	 * Sinks are *supposed* to come up within 1ms from an off state, but
217 	 * some docks need more time to power up.
218 	 */
219 	while (time_before(jiffies, timeout)) {
220 		if (!extcon_get_state(port->extcon, EXTCON_DISP_DP))
221 			return false;
222 
223 		if (!cdn_dp_get_sink_count(dp, &sink_count))
224 			return sink_count ? true : false;
225 
226 		usleep_range(5000, 10000);
227 	}
228 
229 	DRM_DEV_ERROR(dp->dev, "Get sink capability timed out\n");
230 	return false;
231 }
232 
233 static enum drm_connector_status
cdn_dp_connector_detect(struct drm_connector * connector,bool force)234 cdn_dp_connector_detect(struct drm_connector *connector, bool force)
235 {
236 	struct cdn_dp_device *dp = connector_to_dp(connector);
237 	enum drm_connector_status status = connector_status_disconnected;
238 
239 	mutex_lock(&dp->lock);
240 	if (dp->connected)
241 		status = connector_status_connected;
242 	mutex_unlock(&dp->lock);
243 
244 	return status;
245 }
246 
cdn_dp_connector_destroy(struct drm_connector * connector)247 static void cdn_dp_connector_destroy(struct drm_connector *connector)
248 {
249 	drm_connector_unregister(connector);
250 	drm_connector_cleanup(connector);
251 }
252 
253 static const struct drm_connector_funcs cdn_dp_atomic_connector_funcs = {
254 	.detect = cdn_dp_connector_detect,
255 	.destroy = cdn_dp_connector_destroy,
256 	.fill_modes = drm_helper_probe_single_connector_modes,
257 	.reset = drm_atomic_helper_connector_reset,
258 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
259 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
260 };
261 
cdn_dp_connector_get_modes(struct drm_connector * connector)262 static int cdn_dp_connector_get_modes(struct drm_connector *connector)
263 {
264 	struct cdn_dp_device *dp = connector_to_dp(connector);
265 	int ret = 0;
266 
267 	mutex_lock(&dp->lock);
268 
269 	ret = drm_edid_connector_add_modes(connector);
270 
271 	mutex_unlock(&dp->lock);
272 
273 	return ret;
274 }
275 
276 static enum drm_mode_status
cdn_dp_connector_mode_valid(struct drm_connector * connector,struct drm_display_mode * mode)277 cdn_dp_connector_mode_valid(struct drm_connector *connector,
278 			    struct drm_display_mode *mode)
279 {
280 	struct cdn_dp_device *dp = connector_to_dp(connector);
281 	struct drm_display_info *display_info = &dp->connector.display_info;
282 	u32 requested, actual, rate, sink_max, source_max = 0;
283 	u8 lanes, bpc;
284 
285 	/* If DP is disconnected, every mode is invalid */
286 	if (!dp->connected)
287 		return MODE_BAD;
288 
289 	switch (display_info->bpc) {
290 	case 10:
291 		bpc = 10;
292 		break;
293 	case 6:
294 		bpc = 6;
295 		break;
296 	default:
297 		bpc = 8;
298 		break;
299 	}
300 
301 	requested = mode->clock * bpc * 3 / 1000;
302 
303 	source_max = dp->lanes;
304 	sink_max = drm_dp_max_lane_count(dp->dpcd);
305 	lanes = min(source_max, sink_max);
306 
307 	source_max = drm_dp_bw_code_to_link_rate(CDN_DP_MAX_LINK_RATE);
308 	sink_max = drm_dp_max_link_rate(dp->dpcd);
309 	rate = min(source_max, sink_max);
310 
311 	actual = rate * lanes / 100;
312 
313 	/* efficiency is about 0.8 */
314 	actual = actual * 8 / 10;
315 
316 	if (requested > actual) {
317 		DRM_DEV_DEBUG_KMS(dp->dev,
318 				  "requested=%d, actual=%d, clock=%d\n",
319 				  requested, actual, mode->clock);
320 		return MODE_CLOCK_HIGH;
321 	}
322 
323 	return MODE_OK;
324 }
325 
326 static struct drm_connector_helper_funcs cdn_dp_connector_helper_funcs = {
327 	.get_modes = cdn_dp_connector_get_modes,
328 	.mode_valid = cdn_dp_connector_mode_valid,
329 };
330 
cdn_dp_firmware_init(struct cdn_dp_device * dp)331 static int cdn_dp_firmware_init(struct cdn_dp_device *dp)
332 {
333 	int ret;
334 	const u32 *iram_data, *dram_data;
335 	const struct firmware *fw = dp->fw;
336 	const struct cdn_firmware_header *hdr;
337 
338 	hdr = (struct cdn_firmware_header *)fw->data;
339 	if (fw->size != le32_to_cpu(hdr->size_bytes)) {
340 		DRM_DEV_ERROR(dp->dev, "firmware is invalid\n");
341 		return -EINVAL;
342 	}
343 
344 	iram_data = (const u32 *)(fw->data + hdr->header_size);
345 	dram_data = (const u32 *)(fw->data + hdr->header_size + hdr->iram_size);
346 
347 	ret = cdn_dp_load_firmware(dp, iram_data, hdr->iram_size,
348 				   dram_data, hdr->dram_size);
349 	if (ret)
350 		return ret;
351 
352 	ret = cdn_dp_set_firmware_active(dp, true);
353 	if (ret) {
354 		DRM_DEV_ERROR(dp->dev, "active ucpu failed: %d\n", ret);
355 		return ret;
356 	}
357 
358 	return cdn_dp_event_config(dp);
359 }
360 
cdn_dp_get_sink_capability(struct cdn_dp_device * dp)361 static int cdn_dp_get_sink_capability(struct cdn_dp_device *dp)
362 {
363 	const struct drm_display_info *info = &dp->connector.display_info;
364 	int ret;
365 
366 	if (!cdn_dp_check_sink_connection(dp))
367 		return -ENODEV;
368 
369 	ret = cdn_dp_dpcd_read(dp, DP_DPCD_REV, dp->dpcd,
370 			       DP_RECEIVER_CAP_SIZE);
371 	if (ret) {
372 		DRM_DEV_ERROR(dp->dev, "Failed to get caps %d\n", ret);
373 		return ret;
374 	}
375 
376 	drm_edid_free(dp->drm_edid);
377 	dp->drm_edid = drm_edid_read_custom(&dp->connector,
378 					    cdn_dp_get_edid_block, dp);
379 	drm_edid_connector_update(&dp->connector, dp->drm_edid);
380 
381 	dp->sink_has_audio = info->has_audio;
382 
383 	if (dp->drm_edid)
384 		DRM_DEV_DEBUG_KMS(dp->dev, "got edid: width[%d] x height[%d]\n",
385 				  info->width_mm / 10, info->height_mm / 10);
386 
387 	return 0;
388 }
389 
cdn_dp_enable_phy(struct cdn_dp_device * dp,struct cdn_dp_port * port)390 static int cdn_dp_enable_phy(struct cdn_dp_device *dp, struct cdn_dp_port *port)
391 {
392 	union extcon_property_value property;
393 	int ret;
394 
395 	if (!port->phy_enabled) {
396 		ret = phy_power_on(port->phy);
397 		if (ret) {
398 			DRM_DEV_ERROR(dp->dev, "phy power on failed: %d\n",
399 				      ret);
400 			goto err_phy;
401 		}
402 		port->phy_enabled = true;
403 	}
404 
405 	ret = cdn_dp_grf_write(dp, GRF_SOC_CON26,
406 			       DPTX_HPD_SEL_MASK | DPTX_HPD_SEL);
407 	if (ret) {
408 		DRM_DEV_ERROR(dp->dev, "Failed to write HPD_SEL %d\n", ret);
409 		goto err_power_on;
410 	}
411 
412 	ret = cdn_dp_get_hpd_status(dp);
413 	if (ret <= 0) {
414 		if (!ret)
415 			DRM_DEV_ERROR(dp->dev, "hpd does not exist\n");
416 		goto err_power_on;
417 	}
418 
419 	ret = extcon_get_property(port->extcon, EXTCON_DISP_DP,
420 				  EXTCON_PROP_USB_TYPEC_POLARITY, &property);
421 	if (ret) {
422 		DRM_DEV_ERROR(dp->dev, "get property failed\n");
423 		goto err_power_on;
424 	}
425 
426 	port->lanes = cdn_dp_get_port_lanes(port);
427 	ret = cdn_dp_set_host_cap(dp, port->lanes, property.intval);
428 	if (ret) {
429 		DRM_DEV_ERROR(dp->dev, "set host capabilities failed: %d\n",
430 			      ret);
431 		goto err_power_on;
432 	}
433 
434 	dp->active_port = port->id;
435 	return 0;
436 
437 err_power_on:
438 	if (phy_power_off(port->phy))
439 		DRM_DEV_ERROR(dp->dev, "phy power off failed: %d", ret);
440 	else
441 		port->phy_enabled = false;
442 
443 err_phy:
444 	cdn_dp_grf_write(dp, GRF_SOC_CON26,
445 			 DPTX_HPD_SEL_MASK | DPTX_HPD_DEL);
446 	return ret;
447 }
448 
cdn_dp_disable_phy(struct cdn_dp_device * dp,struct cdn_dp_port * port)449 static int cdn_dp_disable_phy(struct cdn_dp_device *dp,
450 			      struct cdn_dp_port *port)
451 {
452 	int ret;
453 
454 	if (port->phy_enabled) {
455 		ret = phy_power_off(port->phy);
456 		if (ret) {
457 			DRM_DEV_ERROR(dp->dev, "phy power off failed: %d", ret);
458 			return ret;
459 		}
460 	}
461 
462 	port->phy_enabled = false;
463 	port->lanes = 0;
464 	dp->active_port = -1;
465 	return 0;
466 }
467 
cdn_dp_disable(struct cdn_dp_device * dp)468 static int cdn_dp_disable(struct cdn_dp_device *dp)
469 {
470 	int ret, i;
471 
472 	if (!dp->active)
473 		return 0;
474 
475 	for (i = 0; i < dp->ports; i++)
476 		cdn_dp_disable_phy(dp, dp->port[i]);
477 
478 	ret = cdn_dp_grf_write(dp, GRF_SOC_CON26,
479 			       DPTX_HPD_SEL_MASK | DPTX_HPD_DEL);
480 	if (ret) {
481 		DRM_DEV_ERROR(dp->dev, "Failed to clear hpd sel %d\n",
482 			      ret);
483 		return ret;
484 	}
485 
486 	cdn_dp_set_firmware_active(dp, false);
487 	cdn_dp_clk_disable(dp);
488 	dp->active = false;
489 	dp->max_lanes = 0;
490 	dp->max_rate = 0;
491 	if (!dp->connected) {
492 		drm_edid_free(dp->drm_edid);
493 		dp->drm_edid = NULL;
494 	}
495 
496 	return 0;
497 }
498 
cdn_dp_enable(struct cdn_dp_device * dp)499 static int cdn_dp_enable(struct cdn_dp_device *dp)
500 {
501 	int ret, i, lanes;
502 	struct cdn_dp_port *port;
503 
504 	port = cdn_dp_connected_port(dp);
505 	if (!port) {
506 		DRM_DEV_ERROR(dp->dev,
507 			      "Can't enable without connection\n");
508 		return -ENODEV;
509 	}
510 
511 	if (dp->active)
512 		return 0;
513 
514 	ret = cdn_dp_clk_enable(dp);
515 	if (ret)
516 		return ret;
517 
518 	ret = cdn_dp_firmware_init(dp);
519 	if (ret) {
520 		DRM_DEV_ERROR(dp->dev, "firmware init failed: %d", ret);
521 		goto err_clk_disable;
522 	}
523 
524 	/* only enable the port that connected with downstream device */
525 	for (i = port->id; i < dp->ports; i++) {
526 		port = dp->port[i];
527 		lanes = cdn_dp_get_port_lanes(port);
528 		if (lanes) {
529 			ret = cdn_dp_enable_phy(dp, port);
530 			if (ret)
531 				continue;
532 
533 			ret = cdn_dp_get_sink_capability(dp);
534 			if (ret) {
535 				cdn_dp_disable_phy(dp, port);
536 			} else {
537 				dp->active = true;
538 				dp->lanes = port->lanes;
539 				return 0;
540 			}
541 		}
542 	}
543 
544 err_clk_disable:
545 	cdn_dp_clk_disable(dp);
546 	return ret;
547 }
548 
cdn_dp_encoder_mode_set(struct drm_encoder * encoder,struct drm_display_mode * mode,struct drm_display_mode * adjusted)549 static void cdn_dp_encoder_mode_set(struct drm_encoder *encoder,
550 				    struct drm_display_mode *mode,
551 				    struct drm_display_mode *adjusted)
552 {
553 	struct cdn_dp_device *dp = encoder_to_dp(encoder);
554 	struct drm_display_info *display_info = &dp->connector.display_info;
555 	struct video_info *video = &dp->video_info;
556 
557 	switch (display_info->bpc) {
558 	case 10:
559 		video->color_depth = 10;
560 		break;
561 	case 6:
562 		video->color_depth = 6;
563 		break;
564 	default:
565 		video->color_depth = 8;
566 		break;
567 	}
568 
569 	video->color_fmt = PXL_RGB;
570 	video->v_sync_polarity = !!(mode->flags & DRM_MODE_FLAG_NVSYNC);
571 	video->h_sync_polarity = !!(mode->flags & DRM_MODE_FLAG_NHSYNC);
572 
573 	drm_mode_copy(&dp->mode, adjusted);
574 }
575 
cdn_dp_check_link_status(struct cdn_dp_device * dp)576 static bool cdn_dp_check_link_status(struct cdn_dp_device *dp)
577 {
578 	u8 link_status[DP_LINK_STATUS_SIZE];
579 	struct cdn_dp_port *port = cdn_dp_connected_port(dp);
580 	u8 sink_lanes = drm_dp_max_lane_count(dp->dpcd);
581 
582 	if (!port || !dp->max_rate || !dp->max_lanes)
583 		return false;
584 
585 	if (cdn_dp_dpcd_read(dp, DP_LANE0_1_STATUS, link_status,
586 			     DP_LINK_STATUS_SIZE)) {
587 		DRM_ERROR("Failed to get link status\n");
588 		return false;
589 	}
590 
591 	/* if link training is requested we should perform it always */
592 	return drm_dp_channel_eq_ok(link_status, min(port->lanes, sink_lanes));
593 }
594 
cdn_dp_audio_handle_plugged_change(struct cdn_dp_device * dp,bool plugged)595 static void cdn_dp_audio_handle_plugged_change(struct cdn_dp_device *dp,
596 					       bool plugged)
597 {
598 	if (dp->codec_dev)
599 		dp->plugged_cb(dp->codec_dev, plugged);
600 }
601 
cdn_dp_encoder_enable(struct drm_encoder * encoder)602 static void cdn_dp_encoder_enable(struct drm_encoder *encoder)
603 {
604 	struct cdn_dp_device *dp = encoder_to_dp(encoder);
605 	int ret, val;
606 
607 	ret = drm_of_encoder_active_endpoint_id(dp->dev->of_node, encoder);
608 	if (ret < 0) {
609 		DRM_DEV_ERROR(dp->dev, "Could not get vop id, %d", ret);
610 		return;
611 	}
612 
613 	DRM_DEV_DEBUG_KMS(dp->dev, "vop %s output to cdn-dp\n",
614 			  (ret) ? "LIT" : "BIG");
615 	if (ret)
616 		val = DP_SEL_VOP_LIT | (DP_SEL_VOP_LIT << 16);
617 	else
618 		val = DP_SEL_VOP_LIT << 16;
619 
620 	ret = cdn_dp_grf_write(dp, GRF_SOC_CON9, val);
621 	if (ret)
622 		return;
623 
624 	mutex_lock(&dp->lock);
625 
626 	ret = cdn_dp_enable(dp);
627 	if (ret) {
628 		DRM_DEV_ERROR(dp->dev, "Failed to enable encoder %d\n",
629 			      ret);
630 		goto out;
631 	}
632 	if (!cdn_dp_check_link_status(dp)) {
633 		ret = cdn_dp_train_link(dp);
634 		if (ret) {
635 			DRM_DEV_ERROR(dp->dev, "Failed link train %d\n", ret);
636 			goto out;
637 		}
638 	}
639 
640 	ret = cdn_dp_set_video_status(dp, CONTROL_VIDEO_IDLE);
641 	if (ret) {
642 		DRM_DEV_ERROR(dp->dev, "Failed to idle video %d\n", ret);
643 		goto out;
644 	}
645 
646 	ret = cdn_dp_config_video(dp);
647 	if (ret) {
648 		DRM_DEV_ERROR(dp->dev, "Failed to config video %d\n", ret);
649 		goto out;
650 	}
651 
652 	ret = cdn_dp_set_video_status(dp, CONTROL_VIDEO_VALID);
653 	if (ret) {
654 		DRM_DEV_ERROR(dp->dev, "Failed to valid video %d\n", ret);
655 		goto out;
656 	}
657 
658 	cdn_dp_audio_handle_plugged_change(dp, true);
659 
660 out:
661 	mutex_unlock(&dp->lock);
662 }
663 
cdn_dp_encoder_disable(struct drm_encoder * encoder)664 static void cdn_dp_encoder_disable(struct drm_encoder *encoder)
665 {
666 	struct cdn_dp_device *dp = encoder_to_dp(encoder);
667 	int ret;
668 
669 	mutex_lock(&dp->lock);
670 	cdn_dp_audio_handle_plugged_change(dp, false);
671 
672 	if (dp->active) {
673 		ret = cdn_dp_disable(dp);
674 		if (ret) {
675 			DRM_DEV_ERROR(dp->dev, "Failed to disable encoder %d\n",
676 				      ret);
677 		}
678 	}
679 	mutex_unlock(&dp->lock);
680 
681 	/*
682 	 * In the following 2 cases, we need to run the event_work to re-enable
683 	 * the DP:
684 	 * 1. If there is not just one port device is connected, and remove one
685 	 *    device from a port, the DP will be disabled here, at this case,
686 	 *    run the event_work to re-open DP for the other port.
687 	 * 2. If re-training or re-config failed, the DP will be disabled here.
688 	 *    run the event_work to re-connect it.
689 	 */
690 	if (!dp->connected && cdn_dp_connected_port(dp))
691 		schedule_work(&dp->event_work);
692 }
693 
cdn_dp_encoder_atomic_check(struct drm_encoder * encoder,struct drm_crtc_state * crtc_state,struct drm_connector_state * conn_state)694 static int cdn_dp_encoder_atomic_check(struct drm_encoder *encoder,
695 				       struct drm_crtc_state *crtc_state,
696 				       struct drm_connector_state *conn_state)
697 {
698 	struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc_state);
699 
700 	s->output_mode = ROCKCHIP_OUT_MODE_AAAA;
701 	s->output_type = DRM_MODE_CONNECTOR_DisplayPort;
702 
703 	return 0;
704 }
705 
706 static const struct drm_encoder_helper_funcs cdn_dp_encoder_helper_funcs = {
707 	.mode_set = cdn_dp_encoder_mode_set,
708 	.enable = cdn_dp_encoder_enable,
709 	.disable = cdn_dp_encoder_disable,
710 	.atomic_check = cdn_dp_encoder_atomic_check,
711 };
712 
cdn_dp_parse_dt(struct cdn_dp_device * dp)713 static int cdn_dp_parse_dt(struct cdn_dp_device *dp)
714 {
715 	struct device *dev = dp->dev;
716 	struct device_node *np = dev->of_node;
717 	struct platform_device *pdev = to_platform_device(dev);
718 
719 	dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
720 	if (IS_ERR(dp->grf)) {
721 		DRM_DEV_ERROR(dev, "cdn-dp needs rockchip,grf property\n");
722 		return PTR_ERR(dp->grf);
723 	}
724 
725 	dp->regs = devm_platform_ioremap_resource(pdev, 0);
726 	if (IS_ERR(dp->regs)) {
727 		DRM_DEV_ERROR(dev, "ioremap reg failed\n");
728 		return PTR_ERR(dp->regs);
729 	}
730 
731 	dp->core_clk = devm_clk_get(dev, "core-clk");
732 	if (IS_ERR(dp->core_clk)) {
733 		DRM_DEV_ERROR(dev, "cannot get core_clk_dp\n");
734 		return PTR_ERR(dp->core_clk);
735 	}
736 
737 	dp->pclk = devm_clk_get(dev, "pclk");
738 	if (IS_ERR(dp->pclk)) {
739 		DRM_DEV_ERROR(dev, "cannot get pclk\n");
740 		return PTR_ERR(dp->pclk);
741 	}
742 
743 	dp->spdif_clk = devm_clk_get(dev, "spdif");
744 	if (IS_ERR(dp->spdif_clk)) {
745 		DRM_DEV_ERROR(dev, "cannot get spdif_clk\n");
746 		return PTR_ERR(dp->spdif_clk);
747 	}
748 
749 	dp->grf_clk = devm_clk_get(dev, "grf");
750 	if (IS_ERR(dp->grf_clk)) {
751 		DRM_DEV_ERROR(dev, "cannot get grf clk\n");
752 		return PTR_ERR(dp->grf_clk);
753 	}
754 
755 	dp->spdif_rst = devm_reset_control_get(dev, "spdif");
756 	if (IS_ERR(dp->spdif_rst)) {
757 		DRM_DEV_ERROR(dev, "no spdif reset control found\n");
758 		return PTR_ERR(dp->spdif_rst);
759 	}
760 
761 	dp->dptx_rst = devm_reset_control_get(dev, "dptx");
762 	if (IS_ERR(dp->dptx_rst)) {
763 		DRM_DEV_ERROR(dev, "no uphy reset control found\n");
764 		return PTR_ERR(dp->dptx_rst);
765 	}
766 
767 	dp->core_rst = devm_reset_control_get(dev, "core");
768 	if (IS_ERR(dp->core_rst)) {
769 		DRM_DEV_ERROR(dev, "no core reset control found\n");
770 		return PTR_ERR(dp->core_rst);
771 	}
772 
773 	dp->apb_rst = devm_reset_control_get(dev, "apb");
774 	if (IS_ERR(dp->apb_rst)) {
775 		DRM_DEV_ERROR(dev, "no apb reset control found\n");
776 		return PTR_ERR(dp->apb_rst);
777 	}
778 
779 	return 0;
780 }
781 
cdn_dp_audio_hw_params(struct device * dev,void * data,struct hdmi_codec_daifmt * daifmt,struct hdmi_codec_params * params)782 static int cdn_dp_audio_hw_params(struct device *dev,  void *data,
783 				  struct hdmi_codec_daifmt *daifmt,
784 				  struct hdmi_codec_params *params)
785 {
786 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
787 	struct audio_info audio = {
788 		.sample_width = params->sample_width,
789 		.sample_rate = params->sample_rate,
790 		.channels = params->channels,
791 	};
792 	int ret;
793 
794 	mutex_lock(&dp->lock);
795 	if (!dp->active) {
796 		ret = -ENODEV;
797 		goto out;
798 	}
799 
800 	switch (daifmt->fmt) {
801 	case HDMI_I2S:
802 		audio.format = AFMT_I2S;
803 		break;
804 	case HDMI_SPDIF:
805 		audio.format = AFMT_SPDIF;
806 		break;
807 	default:
808 		DRM_DEV_ERROR(dev, "Invalid format %d\n", daifmt->fmt);
809 		ret = -EINVAL;
810 		goto out;
811 	}
812 
813 	ret = cdn_dp_audio_config(dp, &audio);
814 	if (!ret)
815 		dp->audio_info = audio;
816 
817 out:
818 	mutex_unlock(&dp->lock);
819 	return ret;
820 }
821 
cdn_dp_audio_shutdown(struct device * dev,void * data)822 static void cdn_dp_audio_shutdown(struct device *dev, void *data)
823 {
824 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
825 	int ret;
826 
827 	mutex_lock(&dp->lock);
828 	if (!dp->active)
829 		goto out;
830 
831 	ret = cdn_dp_audio_stop(dp, &dp->audio_info);
832 	if (!ret)
833 		dp->audio_info.format = AFMT_UNUSED;
834 out:
835 	mutex_unlock(&dp->lock);
836 }
837 
cdn_dp_audio_mute_stream(struct device * dev,void * data,bool enable,int direction)838 static int cdn_dp_audio_mute_stream(struct device *dev, void *data,
839 				    bool enable, int direction)
840 {
841 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
842 	int ret;
843 
844 	mutex_lock(&dp->lock);
845 	if (!dp->active) {
846 		ret = -ENODEV;
847 		goto out;
848 	}
849 
850 	ret = cdn_dp_audio_mute(dp, enable);
851 
852 out:
853 	mutex_unlock(&dp->lock);
854 	return ret;
855 }
856 
cdn_dp_audio_get_eld(struct device * dev,void * data,u8 * buf,size_t len)857 static int cdn_dp_audio_get_eld(struct device *dev, void *data,
858 				u8 *buf, size_t len)
859 {
860 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
861 
862 	memcpy(buf, dp->connector.eld, min(sizeof(dp->connector.eld), len));
863 
864 	return 0;
865 }
866 
cdn_dp_audio_hook_plugged_cb(struct device * dev,void * data,hdmi_codec_plugged_cb fn,struct device * codec_dev)867 static int cdn_dp_audio_hook_plugged_cb(struct device *dev, void *data,
868 					hdmi_codec_plugged_cb fn,
869 					struct device *codec_dev)
870 {
871 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
872 
873 	mutex_lock(&dp->lock);
874 	dp->plugged_cb = fn;
875 	dp->codec_dev = codec_dev;
876 	cdn_dp_audio_handle_plugged_change(dp, dp->connected);
877 	mutex_unlock(&dp->lock);
878 
879 	return 0;
880 }
881 
882 static const struct hdmi_codec_ops audio_codec_ops = {
883 	.hw_params = cdn_dp_audio_hw_params,
884 	.audio_shutdown = cdn_dp_audio_shutdown,
885 	.mute_stream = cdn_dp_audio_mute_stream,
886 	.get_eld = cdn_dp_audio_get_eld,
887 	.hook_plugged_cb = cdn_dp_audio_hook_plugged_cb,
888 	.no_capture_mute = 1,
889 };
890 
cdn_dp_audio_codec_init(struct cdn_dp_device * dp,struct device * dev)891 static int cdn_dp_audio_codec_init(struct cdn_dp_device *dp,
892 				   struct device *dev)
893 {
894 	struct hdmi_codec_pdata codec_data = {
895 		.i2s = 1,
896 		.spdif = 1,
897 		.ops = &audio_codec_ops,
898 		.max_i2s_channels = 8,
899 	};
900 
901 	dp->audio_pdev = platform_device_register_data(
902 			 dev, HDMI_CODEC_DRV_NAME, PLATFORM_DEVID_AUTO,
903 			 &codec_data, sizeof(codec_data));
904 
905 	return PTR_ERR_OR_ZERO(dp->audio_pdev);
906 }
907 
cdn_dp_request_firmware(struct cdn_dp_device * dp)908 static int cdn_dp_request_firmware(struct cdn_dp_device *dp)
909 {
910 	int ret;
911 	unsigned long timeout = jiffies + msecs_to_jiffies(CDN_FW_TIMEOUT_MS);
912 	unsigned long sleep = 1000;
913 
914 	WARN_ON(!mutex_is_locked(&dp->lock));
915 
916 	if (dp->fw_loaded)
917 		return 0;
918 
919 	/* Drop the lock before getting the firmware to avoid blocking boot */
920 	mutex_unlock(&dp->lock);
921 
922 	while (time_before(jiffies, timeout)) {
923 		ret = request_firmware(&dp->fw, CDN_DP_FIRMWARE, dp->dev);
924 		if (ret == -ENOENT) {
925 			msleep(sleep);
926 			sleep *= 2;
927 			continue;
928 		} else if (ret) {
929 			DRM_DEV_ERROR(dp->dev,
930 				      "failed to request firmware: %d\n", ret);
931 			goto out;
932 		}
933 
934 		dp->fw_loaded = true;
935 		ret = 0;
936 		goto out;
937 	}
938 
939 	DRM_DEV_ERROR(dp->dev, "Timed out trying to load firmware\n");
940 	ret = -ETIMEDOUT;
941 out:
942 	mutex_lock(&dp->lock);
943 	return ret;
944 }
945 
cdn_dp_pd_event_work(struct work_struct * work)946 static void cdn_dp_pd_event_work(struct work_struct *work)
947 {
948 	struct cdn_dp_device *dp = container_of(work, struct cdn_dp_device,
949 						event_work);
950 	struct drm_connector *connector = &dp->connector;
951 	enum drm_connector_status old_status;
952 
953 	int ret;
954 
955 	mutex_lock(&dp->lock);
956 
957 	if (dp->suspended)
958 		goto out;
959 
960 	ret = cdn_dp_request_firmware(dp);
961 	if (ret)
962 		goto out;
963 
964 	dp->connected = true;
965 
966 	/* Not connected, notify userspace to disable the block */
967 	if (!cdn_dp_connected_port(dp)) {
968 		DRM_DEV_INFO(dp->dev, "Not connected; disabling cdn\n");
969 		dp->connected = false;
970 
971 	/* Connected but not enabled, enable the block */
972 	} else if (!dp->active) {
973 		DRM_DEV_INFO(dp->dev, "Connected, not enabled; enabling cdn\n");
974 		ret = cdn_dp_enable(dp);
975 		if (ret) {
976 			DRM_DEV_ERROR(dp->dev, "Enabling dp failed: %d\n", ret);
977 			dp->connected = false;
978 		}
979 
980 	/* Enabled and connected to a dongle without a sink, notify userspace */
981 	} else if (!cdn_dp_check_sink_connection(dp)) {
982 		DRM_DEV_INFO(dp->dev, "Connected without sink; assert hpd\n");
983 		dp->connected = false;
984 
985 	/* Enabled and connected with a sink, re-train if requested */
986 	} else if (!cdn_dp_check_link_status(dp)) {
987 		unsigned int rate = dp->max_rate;
988 		unsigned int lanes = dp->max_lanes;
989 		struct drm_display_mode *mode = &dp->mode;
990 
991 		DRM_DEV_INFO(dp->dev, "Connected with sink; re-train link\n");
992 		ret = cdn_dp_train_link(dp);
993 		if (ret) {
994 			dp->connected = false;
995 			DRM_DEV_ERROR(dp->dev, "Training link failed: %d\n", ret);
996 			goto out;
997 		}
998 
999 		/* If training result is changed, update the video config */
1000 		if (mode->clock &&
1001 		    (rate != dp->max_rate || lanes != dp->max_lanes)) {
1002 			ret = cdn_dp_config_video(dp);
1003 			if (ret) {
1004 				dp->connected = false;
1005 				DRM_DEV_ERROR(dp->dev, "Failed to configure video: %d\n", ret);
1006 			}
1007 		}
1008 	}
1009 
1010 out:
1011 	mutex_unlock(&dp->lock);
1012 
1013 	old_status = connector->status;
1014 	connector->status = connector->funcs->detect(connector, false);
1015 	if (old_status != connector->status)
1016 		drm_kms_helper_hotplug_event(dp->drm_dev);
1017 }
1018 
cdn_dp_pd_event(struct notifier_block * nb,unsigned long event,void * priv)1019 static int cdn_dp_pd_event(struct notifier_block *nb,
1020 			   unsigned long event, void *priv)
1021 {
1022 	struct cdn_dp_port *port = container_of(nb, struct cdn_dp_port,
1023 						event_nb);
1024 	struct cdn_dp_device *dp = port->dp;
1025 
1026 	/*
1027 	 * It would be nice to be able to just do the work inline right here.
1028 	 * However, we need to make a bunch of calls that might sleep in order
1029 	 * to turn on the block/phy, so use a worker instead.
1030 	 */
1031 	schedule_work(&dp->event_work);
1032 
1033 	return NOTIFY_DONE;
1034 }
1035 
cdn_dp_bind(struct device * dev,struct device * master,void * data)1036 static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
1037 {
1038 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
1039 	struct drm_encoder *encoder;
1040 	struct drm_connector *connector;
1041 	struct cdn_dp_port *port;
1042 	struct drm_device *drm_dev = data;
1043 	int ret, i;
1044 
1045 	ret = cdn_dp_parse_dt(dp);
1046 	if (ret < 0)
1047 		return ret;
1048 
1049 	dp->drm_dev = drm_dev;
1050 	dp->connected = false;
1051 	dp->active = false;
1052 	dp->active_port = -1;
1053 	dp->fw_loaded = false;
1054 
1055 	INIT_WORK(&dp->event_work, cdn_dp_pd_event_work);
1056 
1057 	encoder = &dp->encoder.encoder;
1058 
1059 	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev,
1060 							     dev->of_node);
1061 	DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs);
1062 
1063 	ret = drm_simple_encoder_init(drm_dev, encoder,
1064 				      DRM_MODE_ENCODER_TMDS);
1065 	if (ret) {
1066 		DRM_ERROR("failed to initialize encoder with drm\n");
1067 		return ret;
1068 	}
1069 
1070 	drm_encoder_helper_add(encoder, &cdn_dp_encoder_helper_funcs);
1071 
1072 	connector = &dp->connector;
1073 	connector->polled = DRM_CONNECTOR_POLL_HPD;
1074 	connector->dpms = DRM_MODE_DPMS_OFF;
1075 
1076 	ret = drm_connector_init(drm_dev, connector,
1077 				 &cdn_dp_atomic_connector_funcs,
1078 				 DRM_MODE_CONNECTOR_DisplayPort);
1079 	if (ret) {
1080 		DRM_ERROR("failed to initialize connector with drm\n");
1081 		goto err_free_encoder;
1082 	}
1083 
1084 	drm_connector_helper_add(connector, &cdn_dp_connector_helper_funcs);
1085 
1086 	ret = drm_connector_attach_encoder(connector, encoder);
1087 	if (ret) {
1088 		DRM_ERROR("failed to attach connector and encoder\n");
1089 		goto err_free_connector;
1090 	}
1091 
1092 	for (i = 0; i < dp->ports; i++) {
1093 		port = dp->port[i];
1094 
1095 		port->event_nb.notifier_call = cdn_dp_pd_event;
1096 		ret = devm_extcon_register_notifier(dp->dev, port->extcon,
1097 						    EXTCON_DISP_DP,
1098 						    &port->event_nb);
1099 		if (ret) {
1100 			DRM_DEV_ERROR(dev,
1101 				      "register EXTCON_DISP_DP notifier err\n");
1102 			goto err_free_connector;
1103 		}
1104 	}
1105 
1106 	pm_runtime_enable(dev);
1107 
1108 	schedule_work(&dp->event_work);
1109 
1110 	return 0;
1111 
1112 err_free_connector:
1113 	drm_connector_cleanup(connector);
1114 err_free_encoder:
1115 	drm_encoder_cleanup(encoder);
1116 	return ret;
1117 }
1118 
cdn_dp_unbind(struct device * dev,struct device * master,void * data)1119 static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
1120 {
1121 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
1122 	struct drm_encoder *encoder = &dp->encoder.encoder;
1123 	struct drm_connector *connector = &dp->connector;
1124 
1125 	cancel_work_sync(&dp->event_work);
1126 	cdn_dp_encoder_disable(encoder);
1127 	encoder->funcs->destroy(encoder);
1128 	connector->funcs->destroy(connector);
1129 
1130 	pm_runtime_disable(dev);
1131 	if (dp->fw_loaded)
1132 		release_firmware(dp->fw);
1133 	drm_edid_free(dp->drm_edid);
1134 	dp->drm_edid = NULL;
1135 }
1136 
1137 static const struct component_ops cdn_dp_component_ops = {
1138 	.bind = cdn_dp_bind,
1139 	.unbind = cdn_dp_unbind,
1140 };
1141 
cdn_dp_suspend(struct device * dev)1142 static int cdn_dp_suspend(struct device *dev)
1143 {
1144 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
1145 	int ret = 0;
1146 
1147 	mutex_lock(&dp->lock);
1148 	if (dp->active)
1149 		ret = cdn_dp_disable(dp);
1150 	dp->suspended = true;
1151 	mutex_unlock(&dp->lock);
1152 
1153 	return ret;
1154 }
1155 
cdn_dp_resume(struct device * dev)1156 static __maybe_unused int cdn_dp_resume(struct device *dev)
1157 {
1158 	struct cdn_dp_device *dp = dev_get_drvdata(dev);
1159 
1160 	mutex_lock(&dp->lock);
1161 	dp->suspended = false;
1162 	if (dp->fw_loaded)
1163 		schedule_work(&dp->event_work);
1164 	mutex_unlock(&dp->lock);
1165 
1166 	return 0;
1167 }
1168 
cdn_dp_probe(struct platform_device * pdev)1169 static int cdn_dp_probe(struct platform_device *pdev)
1170 {
1171 	struct device *dev = &pdev->dev;
1172 	const struct of_device_id *match;
1173 	struct cdn_dp_data *dp_data;
1174 	struct cdn_dp_port *port;
1175 	struct cdn_dp_device *dp;
1176 	struct extcon_dev *extcon;
1177 	struct phy *phy;
1178 	int ret;
1179 	int i;
1180 
1181 	dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
1182 	if (!dp)
1183 		return -ENOMEM;
1184 	dp->dev = dev;
1185 
1186 	match = of_match_node(cdn_dp_dt_ids, pdev->dev.of_node);
1187 	dp_data = (struct cdn_dp_data *)match->data;
1188 
1189 	for (i = 0; i < dp_data->max_phy; i++) {
1190 		extcon = extcon_get_edev_by_phandle(dev, i);
1191 		phy = devm_of_phy_get_by_index(dev, dev->of_node, i);
1192 
1193 		if (PTR_ERR(extcon) == -EPROBE_DEFER ||
1194 		    PTR_ERR(phy) == -EPROBE_DEFER)
1195 			return -EPROBE_DEFER;
1196 
1197 		if (IS_ERR(extcon) || IS_ERR(phy))
1198 			continue;
1199 
1200 		port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
1201 		if (!port)
1202 			return -ENOMEM;
1203 
1204 		port->extcon = extcon;
1205 		port->phy = phy;
1206 		port->dp = dp;
1207 		port->id = i;
1208 		dp->port[dp->ports++] = port;
1209 	}
1210 
1211 	if (!dp->ports) {
1212 		DRM_DEV_ERROR(dev, "missing extcon or phy\n");
1213 		return -EINVAL;
1214 	}
1215 
1216 	mutex_init(&dp->lock);
1217 	dev_set_drvdata(dev, dp);
1218 
1219 	ret = cdn_dp_audio_codec_init(dp, dev);
1220 	if (ret)
1221 		return ret;
1222 
1223 	ret = component_add(dev, &cdn_dp_component_ops);
1224 	if (ret)
1225 		goto err_audio_deinit;
1226 
1227 	return 0;
1228 
1229 err_audio_deinit:
1230 	platform_device_unregister(dp->audio_pdev);
1231 	return ret;
1232 }
1233 
cdn_dp_remove(struct platform_device * pdev)1234 static void cdn_dp_remove(struct platform_device *pdev)
1235 {
1236 	struct cdn_dp_device *dp = platform_get_drvdata(pdev);
1237 
1238 	platform_device_unregister(dp->audio_pdev);
1239 	cdn_dp_suspend(dp->dev);
1240 	component_del(&pdev->dev, &cdn_dp_component_ops);
1241 }
1242 
cdn_dp_shutdown(struct platform_device * pdev)1243 static void cdn_dp_shutdown(struct platform_device *pdev)
1244 {
1245 	struct cdn_dp_device *dp = platform_get_drvdata(pdev);
1246 
1247 	cdn_dp_suspend(dp->dev);
1248 }
1249 
1250 static const struct dev_pm_ops cdn_dp_pm_ops = {
1251 	SET_SYSTEM_SLEEP_PM_OPS(cdn_dp_suspend,
1252 				cdn_dp_resume)
1253 };
1254 
1255 struct platform_driver cdn_dp_driver = {
1256 	.probe = cdn_dp_probe,
1257 	.remove = cdn_dp_remove,
1258 	.shutdown = cdn_dp_shutdown,
1259 	.driver = {
1260 		   .name = "cdn-dp",
1261 		   .of_match_table = cdn_dp_dt_ids,
1262 		   .pm = &cdn_dp_pm_ops,
1263 	},
1264 };
1265