#
aa8e0519 |
| 21-Jan-1998 |
Brian Somers <brian@FreeBSD.org> |
Remove unused #includes. Make various bits static. Remove unused variables. Submitted by: eivind
|
#
313572f3 |
| 27-Dec-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow (and document) execution of commands from within our chat script. You can now even run chat(8) - see ppp.conf.sample.
|
#
70ee81ff |
| 24-Dec-1997 |
Brian Somers <brian@FreeBSD.org> |
Cosmetic (style): sizeof(var) -> sizeof var sizeof type -> sizeof(type)
Suggested by: J Wunsch <j@uriah.heep.sax.de>
|
#
6fefd436 |
| 23-Dec-1997 |
Brian Somers <brian@FreeBSD.org> |
strncpy(x,y,sizeof(x)) --> strncpy(x,y,sizeof(x)-1)
Suggested by: Philippe Charnier <charnier@lirmm.fr> Theo de Raadt <deraadt@cvs.openbsd.org>
|
#
16f81f68 |
| 18-Dec-1997 |
Brian Somers <brian@FreeBSD.org> |
Replace
strcpy(a, b); /* a and b are the same size */
with
strncpy(a, b, sizeof(a)); a[sizeof(a)-1] = '\0';
Making the code `correct at a glance'.
Suggested by: Theo de Raadt <deraadt@cvs
Replace
strcpy(a, b); /* a and b are the same size */
with
strncpy(a, b, sizeof(a)); a[sizeof(a)-1] = '\0';
Making the code `correct at a glance'.
Suggested by: Theo de Raadt <deraadt@cvs.openbsd.org>
show more ...
|
#
b6e82f33 |
| 22-Nov-1997 |
Brian Somers <brian@FreeBSD.org> |
Fix prototypes. Remove extraneous decls. Add ``const'' to several places. Allow ``make NOALIAS=1'' to remove IP aliasing. Merge with OpenBSD - only the Makefiles vary.
We can now survive a compile w
Fix prototypes. Remove extraneous decls. Add ``const'' to several places. Allow ``make NOALIAS=1'' to remove IP aliasing. Merge with OpenBSD - only the Makefiles vary.
We can now survive a compile with -Wall -Wbad-function-cast -Wcast-align -Wcast-qual -Winline -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings -Wchar-subscripts (although the Makefile just contains -Wall).
show more ...
|
#
86e02934 |
| 09-Nov-1997 |
Brian Somers <brian@FreeBSD.org> |
Increase chat script sizes to 512 Requested by: Michael Reifenberger <root@totum.plaut.de>
|
#
5106c671 |
| 09-Nov-1997 |
Brian Somers <brian@FreeBSD.org> |
Introduce ID0 logging. Stay as the invoking uid as much as possible. Execution as a normal user is still forbidden for now, so these changes are pretty ineffective. The next commit will implement the
Introduce ID0 logging. Stay as the invoking uid as much as possible. Execution as a normal user is still forbidden for now, so these changes are pretty ineffective. The next commit will implement the modifications suggested on -hackers a number of days ago.
show more ...
|
#
0fe7ca31 |
| 29-Oct-1997 |
Brian Somers <brian@FreeBSD.org> |
o Bump version to 1.3 to reflect major changes o Report modem connect time properly o Report bytes in/out over physical media o Fix phases (TERMINATE is *higher than* DEAD) o Do a LayerFinish fr
o Bump version to 1.3 to reflect major changes o Report modem connect time properly o Report bytes in/out over physical media o Fix phases (TERMINATE is *higher than* DEAD) o Do a LayerFinish from LcpDown o Bring down IPCP & CCP when we enter PHASE_TERMINATE o Give a new prompt when we go to PHASE_DEAD o Stop the modem timer properly when idle o Treat sig 15 like an exiting carrier loss o Log (DEBUG) offline & online transitions
show more ...
|
#
75240ed1 |
| 26-Oct-1997 |
Brian Somers <brian@FreeBSD.org> |
Cosmetic (no functional changes): o Add missing $Id$s o Move extern decls from .c -> .h files o Staticize o Remove #includes from .h files o style(9)ify includes o bcopy -> memcpy bze
Cosmetic (no functional changes): o Add missing $Id$s o Move extern decls from .c -> .h files o Staticize o Remove #includes from .h files o style(9)ify includes o bcopy -> memcpy bzero -> memset bcmp -> memcmp index -> strchr rindex -> strrchr o Move timeout.h -> timer.h (making it consistent w/ timer.c) o Add -Wmissing-prototypes
show more ...
|
#
9a571ec7 |
| 25-Oct-1997 |
Brian Somers <brian@FreeBSD.org> |
sleep => nointr_sleep usleep => nointr_usleep (not just a #define) Already done by: ache
|
Revision tags: release/2.2.5_cvs |
|
#
afc7fa2c |
| 01-Sep-1997 |
Brian Somers <brian@FreeBSD.org> |
Cosmetic: Make LogPrintf() calls consistent.
|
#
944f7098 |
| 25-Aug-1997 |
Brian Somers <brian@FreeBSD.org> |
Make the code format more in line with style(9). Update loadalias to use the new libalias api. Update to version 1.1.
|
#
eb53eaa3 |
| 18-Aug-1997 |
Brian Somers <brian@FreeBSD.org> |
Fix possible buffer overrun while "expect"ing something that's "nearly" what it wants.
|
#
5b9b0419 |
| 17-Aug-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow specification of fallback phone numbers to be used only if the dial script fails. PR: 4262
|
#
c09be724 |
| 14-Jul-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow a "hangup" capability. You can now "ATZ" your modem when it's closed.
Submitted by: peter@citylink.dinoex.sub.org (Peter Much)
|
#
873725cc |
| 01-Jul-1997 |
Brian Somers <brian@FreeBSD.org> |
Make HUP cause an exit (as it used to), and make INT cause a hangup - not exiting for -ddial & -auto.
HUP must exit because init sends this at system shutdown time (why, I don't know), and we don't
Make HUP cause an exit (as it used to), and make INT cause a hangup - not exiting for -ddial & -auto.
HUP must exit because init sends this at system shutdown time (why, I don't know), and we don't want to end up redialing after the HUP (due to another dfilter packet).
Pointed out by and discussed with: ache
show more ...
|
#
368aee2b |
| 24-Jun-1997 |
Brian Somers <brian@FreeBSD.org> |
o Fix uptime for direct connections. o Style police o Make hangup abort the current connection, not necessarily exiting (-auto/-ddial). o Trap HUP and INT during DoChat and abort the connection a
o Fix uptime for direct connections. o Style police o Make hangup abort the current connection, not necessarily exiting (-auto/-ddial). o Trap HUP and INT during DoChat and abort the connection attempt. This means you can now type "dial" and change your mind with ^C, or HUP the process to stop it dialing.
Slapped into doing it by: Chuck Robey <chuckr@glue.umd.edu>
show more ...
|
#
927145be |
| 09-Jun-1997 |
Brian Somers <brian@FreeBSD.org> |
Overhaul ppp: o Use syslog o Remove references to stdout/stderr (incl perror()) o Introduce VarTerm - the interactive terminal or zero o Allow "set timeout" to affect current session o Chan
Overhaul ppp: o Use syslog o Remove references to stdout/stderr (incl perror()) o Introduce VarTerm - the interactive terminal or zero o Allow "set timeout" to affect current session o Change "set debug" to "set log" o Allow "set log [+|-]flag" o Make MSEXT and PASSWDAUTH stuff the default o Move all #ifdef DEBUG stuff into the code - this shouldn't be too much overhead. It's now controlled with "set log +debug" o Add "set log command, debug, tun, warn, error, alert" o Remove cdefs.h, and assume an ansi compiler. o Improve all diagnostic output o Don't trap SIGSEGV o SIGHUP now terminates again (log files are controlled by syslog) o Call CloseModem() when changing devices o Fix parsing of third arg of "delete"
I think this fixes the "magic is same" problems that some people have been experiencing. The man page is being rewritten. It'll follow soon.
show more ...
|
#
6ed9fb2f |
| 26-May-1997 |
Brian Somers <brian@FreeBSD.org> |
De-couple ppp from libalias. If libalias isn't there, the alias commands simply won't work. Only root may specify the location of the alias lib (otherwise, it's hard-coded).
Make logprintf silentl
De-couple ppp from libalias. If libalias isn't there, the alias commands simply won't work. Only root may specify the location of the alias lib (otherwise, it's hard-coded).
Make logprintf silently fail if LogOpen hasn't been called.
Suggested by: eivind
show more ...
|
Revision tags: release/2.2.2_cvs |
|
#
274e766c |
| 10-May-1997 |
Brian Somers <brian@FreeBSD.org> |
Tidy up the code - bounds checking, return value checking etc.
Submitted by: eivind
|
#
e68d210e |
| 08-May-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow up to 40 args in the chat script (was 20). Ignore subsequent args rather than scribbling.
PR: 1952 Submitted by: Mikael Hybsch <micke@free.dynas.se>
|
Revision tags: release/2.2.1_cvs, release/2.2.0 |
|
#
f5ff0f7c |
| 13-Mar-1997 |
Brian Somers <brian@FreeBSD.org> |
Reviewed by: ache@freebsd.org These changes should fix the signal "problems" in ppp. The signal changes should really be put into 2.2 too ! The following patches should do it. There were some other
Reviewed by: ache@freebsd.org These changes should fix the signal "problems" in ppp. The signal changes should really be put into 2.2 too ! The following patches should do it. There were some other changes made by Andrey recently that havn't been brought into 2.2, it may be worth doing them now.
show more ...
|
Revision tags: release/2.1.7_cvs |
|
#
8ea7f057 |
| 09-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
cdefs cleanup
|
#
bbea88d0 |
| 09-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
I remove pending signals completely, they are not useless, they are dangerous! Signal handlers themself must be fixed to not call malloc, but no pended handlers, it will be correct fix. In finite cas
I remove pending signals completely, they are not useless, they are dangerous! Signal handlers themself must be fixed to not call malloc, but no pended handlers, it will be correct fix. In finite case each signal handler can set some variable which will be analized later, but calling handler functions manually is too dangerous (f.e. signals not blocked while the handler or handlers switch executed in this case). Of course this code can be fixed instead of removing, but it not worth fixing in any case.
Should go into 2.2
In addition sig.c code shows following dangerous fragments (there can be more, but I stop after two):
This fragment
if (fn == SIG_DFL || fn == SIG_IGN) { handler[sig-1] = (sig_type)0; <------------- here signal(sig,fn); } else {
cause NULL pointer reference when signal comes "here", but more worse fragment is below:
void handle_signals() { int sig;
if (caused) for (sig=0; sig<__MAXSIG; sig++, caused>>=1) if (caused&1) (*handler[sig])(sig+1); }
caused is bitmask which set corresponding bit on each signal coming. And now imagine, what happens when some signal comes (bit sets) while loop is executed (see caused>>=1 !!!)
In this light carrier drop situation was (as gdb shows) 1. SIGSEGV in handle_signals because some junk called as *handler reference. 2. Since SIGSEGV was pended too (== never happens), it can cause various range of disasters.
show more ...
|