#
c09be724 |
| 14-Jul-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow a "hangup" capability. You can now "ATZ" your modem when it's closed.
Submitted by: peter@citylink.dinoex.sub.org (Peter Much)
|
#
873725cc |
| 01-Jul-1997 |
Brian Somers <brian@FreeBSD.org> |
Make HUP cause an exit (as it used to), and make INT cause a hangup - not exiting for -ddial & -auto.
HUP must exit because init sends this at system shutdown time (why, I don't know), and we don't
Make HUP cause an exit (as it used to), and make INT cause a hangup - not exiting for -ddial & -auto.
HUP must exit because init sends this at system shutdown time (why, I don't know), and we don't want to end up redialing after the HUP (due to another dfilter packet).
Pointed out by and discussed with: ache
show more ...
|
#
368aee2b |
| 24-Jun-1997 |
Brian Somers <brian@FreeBSD.org> |
o Fix uptime for direct connections. o Style police o Make hangup abort the current connection, not necessarily exiting (-auto/-ddial). o Trap HUP and INT during DoChat and abort the connection a
o Fix uptime for direct connections. o Style police o Make hangup abort the current connection, not necessarily exiting (-auto/-ddial). o Trap HUP and INT during DoChat and abort the connection attempt. This means you can now type "dial" and change your mind with ^C, or HUP the process to stop it dialing.
Slapped into doing it by: Chuck Robey <chuckr@glue.umd.edu>
show more ...
|
#
927145be |
| 09-Jun-1997 |
Brian Somers <brian@FreeBSD.org> |
Overhaul ppp: o Use syslog o Remove references to stdout/stderr (incl perror()) o Introduce VarTerm - the interactive terminal or zero o Allow "set timeout" to affect current session o Chan
Overhaul ppp: o Use syslog o Remove references to stdout/stderr (incl perror()) o Introduce VarTerm - the interactive terminal or zero o Allow "set timeout" to affect current session o Change "set debug" to "set log" o Allow "set log [+|-]flag" o Make MSEXT and PASSWDAUTH stuff the default o Move all #ifdef DEBUG stuff into the code - this shouldn't be too much overhead. It's now controlled with "set log +debug" o Add "set log command, debug, tun, warn, error, alert" o Remove cdefs.h, and assume an ansi compiler. o Improve all diagnostic output o Don't trap SIGSEGV o SIGHUP now terminates again (log files are controlled by syslog) o Call CloseModem() when changing devices o Fix parsing of third arg of "delete"
I think this fixes the "magic is same" problems that some people have been experiencing. The man page is being rewritten. It'll follow soon.
show more ...
|
#
6ed9fb2f |
| 26-May-1997 |
Brian Somers <brian@FreeBSD.org> |
De-couple ppp from libalias. If libalias isn't there, the alias commands simply won't work. Only root may specify the location of the alias lib (otherwise, it's hard-coded).
Make logprintf silentl
De-couple ppp from libalias. If libalias isn't there, the alias commands simply won't work. Only root may specify the location of the alias lib (otherwise, it's hard-coded).
Make logprintf silently fail if LogOpen hasn't been called.
Suggested by: eivind
show more ...
|
Revision tags: release/2.2.2_cvs |
|
#
274e766c |
| 10-May-1997 |
Brian Somers <brian@FreeBSD.org> |
Tidy up the code - bounds checking, return value checking etc.
Submitted by: eivind
|
#
e68d210e |
| 08-May-1997 |
Brian Somers <brian@FreeBSD.org> |
Allow up to 40 args in the chat script (was 20). Ignore subsequent args rather than scribbling.
PR: 1952 Submitted by: Mikael Hybsch <micke@free.dynas.se>
|
Revision tags: release/2.2.1_cvs, release/2.2.0 |
|
#
f5ff0f7c |
| 13-Mar-1997 |
Brian Somers <brian@FreeBSD.org> |
Reviewed by: ache@freebsd.org These changes should fix the signal "problems" in ppp. The signal changes should really be put into 2.2 too ! The following patches should do it. There were some other
Reviewed by: ache@freebsd.org These changes should fix the signal "problems" in ppp. The signal changes should really be put into 2.2 too ! The following patches should do it. There were some other changes made by Andrey recently that havn't been brought into 2.2, it may be worth doing them now.
show more ...
|
Revision tags: release/2.1.7_cvs |
|
#
8ea7f057 |
| 09-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
cdefs cleanup
|
#
bbea88d0 |
| 09-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
I remove pending signals completely, they are not useless, they are dangerous! Signal handlers themself must be fixed to not call malloc, but no pended handlers, it will be correct fix. In finite cas
I remove pending signals completely, they are not useless, they are dangerous! Signal handlers themself must be fixed to not call malloc, but no pended handlers, it will be correct fix. In finite case each signal handler can set some variable which will be analized later, but calling handler functions manually is too dangerous (f.e. signals not blocked while the handler or handlers switch executed in this case). Of course this code can be fixed instead of removing, but it not worth fixing in any case.
Should go into 2.2
In addition sig.c code shows following dangerous fragments (there can be more, but I stop after two):
This fragment
if (fn == SIG_DFL || fn == SIG_IGN) { handler[sig-1] = (sig_type)0; <------------- here signal(sig,fn); } else {
cause NULL pointer reference when signal comes "here", but more worse fragment is below:
void handle_signals() { int sig;
if (caused) for (sig=0; sig<__MAXSIG; sig++, caused>>=1) if (caused&1) (*handler[sig])(sig+1); }
caused is bitmask which set corresponding bit on each signal coming. And now imagine, what happens when some signal comes (bit sets) while loop is executed (see caused>>=1 !!!)
In this light carrier drop situation was (as gdb shows) 1. SIGSEGV in handle_signals because some junk called as *handler reference. 2. Since SIGSEGV was pended too (== never happens), it can cause various range of disasters.
show more ...
|
#
0b6828d1 |
| 08-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
Unpend all signals before execv, it not makes any sense to pend them here
Should go into 2.2
|
#
06257ca4 |
| 08-Mar-1997 |
Andrey A. Chernov <ache@FreeBSD.org> |
Unpend all killing signals to shut down this thing immediately, or it is impossible to kill it in some situations. Unpend yet one SIGARLM (see timer.c commit)
Should go into 2.2
|
#
c3b6ad66 |
| 25-Feb-1997 |
Brian Somers <brian@FreeBSD.org> |
osreldate.h stuff suggested by: Eivind Eklund
Remove #include's from sig.h and get dependant modules to include them themselves. Make inclusion of if_var.h depend on __FreeBSD_version so that the -
osreldate.h stuff suggested by: Eivind Eklund
Remove #include's from sig.h and get dependant modules to include them themselves. Make inclusion of if_var.h depend on __FreeBSD_version so that the -current version of ppp can be used with 2.1.*
2.2 Candidate ?
show more ...
|
#
476602a9 |
| 22-Feb-1997 |
Peter Wemm <peter@FreeBSD.org> |
Revert $FreeBSD$ to $Id$
|
#
52cc0880 |
| 19-Feb-1997 |
Brian Somers <brian@FreeBSD.org> |
Tidy up signal handling. All signal() calls have been changed to pending_signal() calls. pending_signal() is defined in the new sig.c file. It remembers the handler and traps the signal with a funct
Tidy up signal handling. All signal() calls have been changed to pending_signal() calls. pending_signal() is defined in the new sig.c file. It remembers the handler and traps the signal with a function that will remember the signal.
main.c now calls handle_signals() to actually call the required handlers (if the above handler was called).
If this doesn't close PR2662 (was PR2347), I'll cry.
Joerg, I think this should go into 2.2, but I havn't done anything about it because I'm bound to botch it with the new sig.[ch] files.
I've just "cvs add"'d sig.[ch] so far.... can you update to 2.2 and tell me what you did ? Thanks.
show more ...
|
Revision tags: release/2.1.6_cvs, release/2.1.6.1 |
|
#
1130b656 |
| 14-Jan-1997 |
Jordan K. Hubbard <jkh@FreeBSD.org> |
Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!) avoiding the Id-smashing problem which has plagued developers for so
Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!) avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been insane otherwise.
show more ...
|
#
99c02d39 |
| 10-Jan-1997 |
Warner Losh <imp@FreeBSD.org> |
Fix many buffer overruns in the code. Specifically, disallow ExpandString to be used to expand things beyond the size of the buffer passed in. Also do a general cleanup of sprintf -> snprintf as we
Fix many buffer overruns in the code. Specifically, disallow ExpandString to be used to expand things beyond the size of the buffer passed in. Also do a general cleanup of sprintf -> snprintf as well as strcpy and strncat safety. Also expand some buffers to allow for the largest possible data that might be used.
This is a 2.2 candidate. However, it needs to be vetted on -current since little testing has been done on this due to my lack of PPP on this machine.
Reviewed by: Jordan Hubbard, Peter Wemm, Guido van Rooij
show more ...
|
#
053edb3c |
| 15-Dec-1996 |
Paul Traina <pst@FreeBSD.org> |
Avoid some buffer overrun problems.
|
Revision tags: release/2.1.5_cvs |
|
#
113dea91 |
| 09-Jun-1996 |
Andrey A. Chernov <ache@FreeBSD.org> |
Prepare for exec properly and check return values Submitted by: Arjan de Vet <devet@IAEhv.nl>
|
#
9c749ffb |
| 11-May-1996 |
Poul-Henning Kamp <phk@FreeBSD.org> |
Here is a diff of /usr/src/usr.sbin/ppp against current. The diffs add some logging functionality which I find very useful. 'set debug link' will record just link up/down and address assignments. 's
Here is a diff of /usr/src/usr.sbin/ppp against current. The diffs add some logging functionality which I find very useful. 'set debug link' will record just link up/down and address assignments. 'set debug connect' will record the entire chat dialog 'set debug carrier' will record just chat lines including 'CARRIER' (so that I can be sure I'm getting a 28.8 line).
There was a global change required to permit LogPrintf to take a bit mask instead of a bit position value (to permit logging some events on either of two flags, so that no change in 'set debug lcp' would result from the code supporting 'link'. Thus the diffs are rather long for such a small change. The man page is also touched.
Oh, and there was a slight syntax problem in route.c
Reviewed by: phk Submitted by: Tony Kimball <alk@Think.COM>
show more ...
|
#
81cc95f2 |
| 06-Apr-1996 |
Andrey A. Chernov <ache@FreeBSD.org> |
Here is a patch for a little bug in the WaitForString routine. The problem is when the matched string spans the end of the inbuff. This fix allocates twice the IBSIZE so that it can keep the last a
Here is a patch for a little bug in the WaitForString routine. The problem is when the matched string spans the end of the inbuff. This fix allocates twice the IBSIZE so that it can keep the last and the current text to search in the inbuff so that the match won't fail if it gets truncated by the read.
It also warns if the search string is to long and truncates it.
Submitted by: Dough Ambrisco <ambrisco@ambrisco.roble.com>
show more ...
|
#
a81c9c68 |
| 08-Mar-1996 |
Andrey A. Chernov <ache@FreeBSD.org> |
Prevent dial cycling on the last phone from the list, make phone list copy
|
#
cb7fddc6 |
| 08-Mar-1996 |
Andrey A. Chernov <ache@FreeBSD.org> |
Log phone as LOG_PHASE, it is valuable enough for multi-phone environment. Add missing return when terminal mode can't be re-established due to modem not opened.
|
#
1dff3fc5 |
| 08-Mar-1996 |
Andrey A. Chernov <ache@FreeBSD.org> |
1) Add multi-phone dialing/redialing, several phones separated by ':' 2) Improve on-line help subsystem 3) Make 'term' mode works even carrier dropped (old code close line forever here) 4) Make 'term
1) Add multi-phone dialing/redialing, several phones separated by ':' 2) Improve on-line help subsystem 3) Make 'term' mode works even carrier dropped (old code close line forever here) 4) Make 'term' mode 8bit clean. 5) Improve manual page 6) #ifdef DEBUG diagnostic about missing optional files. 7) Don't put interactive dialing info to logfile
show more ...
|
Revision tags: release/2.1.0_cvs |
|
#
c3899f8d |
| 02-Sep-1995 |
Atsushi Murai <amurai@FreeBSD.org> |
1. Do not log the password itself to ppp.log ( Mr. Rich Murphey ) 2. Add ability to execute shell commands and suspend back into invoking shell (Mr. J Wunsch)
Reviewed by: amurai@spec.co.jp Submi
1. Do not log the password itself to ppp.log ( Mr. Rich Murphey ) 2. Add ability to execute shell commands and suspend back into invoking shell (Mr. J Wunsch)
Reviewed by: amurai@spec.co.jp Submitted by: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) Rich Murphey <rich@lamprey.utmb.edu>
show more ...
|