Revision tags: release/7.1.0_cvs, release/7.1.0 |
|
#
e57c2b13 |
| 04-Dec-2008 |
Dag-Erling Smørgrav <des@FreeBSD.org> |
integrate from head@185615
|
Revision tags: release/6.4.0_cvs, release/6.4.0 |
|
#
c439bdd8 |
| 03-Nov-2008 |
John Baldwin <jhb@FreeBSD.org> |
Remove some unused and broken code that attempted to not invoke locking asserts on NULL vnode pointers. All the vnode assertion routines already check for NULL vnode pointers.
|
Revision tags: release/7.0.0_cvs, release/7.0.0, release/6.3.0_cvs, release/6.3.0, release/6.2.0_cvs, release/6.2.0 |
|
#
44d6e87b |
| 30-May-2006 |
Diomidis Spinellis <dds@FreeBSD.org> |
- Add two checks for syntax errors - Improve error reporting - Remove redundant conditionals
|
#
f69ec7af |
| 30-May-2006 |
Diomidis Spinellis <dds@FreeBSD.org> |
Assertion code specifications are introduced using special character sequences that are distinct from comments. %% is used for argument locks; %! for pre- and post-conditions.
|
#
3cd62520 |
| 26-May-2006 |
Diomidis Spinellis <dds@FreeBSD.org> |
Update usage comment to match reality.
|
Revision tags: release/5.5.0_cvs, release/5.5.0, release/6.1.0_cvs, release/6.1.0 |
|
#
0430a5e2 |
| 14-Dec-2005 |
Dag-Erling Smørgrav <des@FreeBSD.org> |
Eradicate caddr_t from the VFS API.
|
#
e26b05cf |
| 14-Dec-2005 |
Dag-Erling Smørgrav <des@FreeBSD.org> |
Nuke vnodeop_desc.vdesc_transports, which has been unused since the dawn of time (or the inception of ncvs, whichever came last)
|
Revision tags: release/6.0.0_cvs, release/6.0.0 |
|
#
679985d0 |
| 09-Jun-2005 |
Suleiman Souhlal <ssouhlal@FreeBSD.org> |
Allow EVFILT_VNODE events to work on every filesystem type, not just UFS by: - Making the pre and post hooks for the VOP functions work even when DEBUG_VFS_LOCKS is not defined. - Moving the KNOTE ac
Allow EVFILT_VNODE events to work on every filesystem type, not just UFS by: - Making the pre and post hooks for the VOP functions work even when DEBUG_VFS_LOCKS is not defined. - Moving the KNOTE activations into the corresponding VOP hooks. - Creating a MNTK_NOKNOTE flag for the mnt_kern_flag field of struct mount that permits filesystems to disable the new behavior. - Creating a default VOP_KQFILTER function: vfs_kqfilter()
My benchmarks have not revealed any performance degradation.
Reviewed by: jeff, bde Approved by: rwatson, jmg (kqueue changes), grehan (mentor)
show more ...
|
Revision tags: release/5.4.0_cvs, release/5.4.0 |
|
#
680a1ec6 |
| 11-Apr-2005 |
Jeff Roberson <jeff@FreeBSD.org> |
- Add the character "E" to the understood lock types. This means the VOP requires an exclusive lock.
Sponsored by: Isilon Systems, Inc.
|
#
119798b3 |
| 08-Feb-2005 |
Poul-Henning Kamp <phk@FreeBSD.org> |
Add VOP_FOO_APV() which takes a pointer to the vop_vector.
This allows stacked or partitioned filesystems to say "Continue the normal resolution from here", for instace from FFS to UFS.
Use VNASSER
Add VOP_FOO_APV() which takes a pointer to the vop_vector.
This allows stacked or partitioned filesystems to say "Continue the normal resolution from here", for instace from FFS to UFS.
Use VNASSERT() instead of KASSERT().
show more ...
|
Revision tags: release/4.11.0_cvs, release/4.11.0 |
|
#
de8a6c06 |
| 13-Jan-2005 |
Poul-Henning Kamp <phk@FreeBSD.org> |
Get rid of the VDESC() macro while the pot is boiling anyway, it is only used from generate files now, so we might as well generate the right stuff from the start.
|
#
63f89abf |
| 13-Jan-2005 |
Poul-Henning Kamp <phk@FreeBSD.org> |
Change the generated VOP_ macro implementations to improve type checking and KASSERT coverage.
After this check there is only one "nasty" cast in this code but there is a KASSERT to protect against
Change the generated VOP_ macro implementations to improve type checking and KASSERT coverage.
After this check there is only one "nasty" cast in this code but there is a KASSERT to protect against the wrong argument structure behind that cast.
Un-inlining the meat of VOP_FOO() saves 35kB of text segment on a typical kernel with no change in performance.
We also now run the checking and tracing on VOP's which have been layered by nullfs, umapfs, deadfs or unionfs.
Add new (non-inline) VOP_FOO_AP() functions which take a "struct foo_args" argument and does everything the VOP_FOO() macros used to do with checks and debugging code.
Add KASSERT to VOP_FOO_AP() check for argument type being correct.
Slim down VOP_FOO() inline functions to just stuff arguments into the struct foo_args and call VOP_FOO_AP().
Put function pointer to VOP_FOO_AP() into vop_foo_desc structure and make VCALL() use it instead of the current offsetoff() hack.
Retire vcall() which implemented the offsetoff()
Make deadfs and unionfs use VOP_FOO_AP() calls instead of VCALL(), we know which specific call we want already.
Remove unneeded arguments to VCALL() in nullfs and umapfs bypass functions.
Remove unused vdesc_offset and VOFFSET().
Generally improve style/readability of the generated code.
show more ...
|
#
60727d8b |
| 07-Jan-2005 |
Warner Losh <imp@FreeBSD.org> |
/* -> /*- for license, minor formatting changes
|
#
57c75b8f |
| 13-Dec-2004 |
Warner Losh <imp@FreeBSD.org> |
Rather than casting through a (void *) to avoid the aliasing warning, do things correctly from an aliasing perspective. Put the vop_generic_args element as the first element for all the vop_*_args a
Rather than casting through a (void *) to avoid the aliasing warning, do things correctly from an aliasing perspective. Put the vop_generic_args element as the first element for all the vop_*_args and adjust the code to take the address of that instead of the structure.
OK'd based on a vague description by: phk
show more ...
|
#
98a67cd8 |
| 13-Dec-2004 |
Warner Losh <imp@FreeBSD.org> |
Cast from the specific vop_*_args to vop_generic_args via a (void *) pointer to eliminate the hundreds of warnings that we have in tree at the moment.
# Chances are good that all the struct vop_*_ar
Cast from the specific vop_*_args to vop_generic_args via a (void *) pointer to eliminate the hundreds of warnings that we have in tree at the moment.
# Chances are good that all the struct vop_*_args should have, as its # first element, the struct vop_generic_args, and when necessary to # reference it, we just take its address rather than going through # this double case.
show more ...
|
#
aec0fb7b |
| 02-Dec-2004 |
Poul-Henning Kamp <phk@FreeBSD.org> |
Back when VOP_* was introduced, we did not have new-style struct initializations but we did have lofty goals and big ideals.
Adjust to more contemporary circumstances and gain type checking.
Repla
Back when VOP_* was introduced, we did not have new-style struct initializations but we did have lofty goals and big ideals.
Adjust to more contemporary circumstances and gain type checking.
Replace the entire vop_t frobbing thing with properly typed structures. The only casualty is that we can not add a new VOP_ method with a loadable module. History has not given us reason to belive this would ever be feasible in the the first place.
Eliminate in toto VOCALL(), vop_t, VNODEOP_SET() etc.
Give coda correct prototypes and function definitions for all vop_()s.
Generate a bit more data from the vnode_if.src file: a struct vop_vector and protype typedefs for all vop methods.
Add a new vop_bypass() and make vop_default be a pointer to another struct vop_vector.
Remove a lot of vfs_init since vop_vector is ready to use from the compiler.
Cast various vop_mumble() to void * with uppercase name, for instance VOP_PANIC, VOP_NULL etc.
Implement VCALL() by making vdesc_offset the offsetof() the relevant function pointer in vop_vector. This is disgusting but since the code is generated by a script comparatively safe. The alternative for nullfs etc. would be much worse.
Fix up all vnode method vectors to remove casts so they become typesafe. (The bulk of this is generated by scripts)
show more ...
|
#
be392b40 |
| 01-Dec-2004 |
Poul-Henning Kamp <phk@FreeBSD.org> |
emit a "typedef vop_foo_t(struct vop_foo_args *);" which we can use to prototype VOP functions with.
|
Revision tags: release/5.3.0_cvs, release/5.3.0, release/4.10.0_cvs, release/4.10.0 |
|
#
82c6e879 |
| 07-Apr-2004 |
Warner Losh <imp@FreeBSD.org> |
Remove advertising clause from University of California Regent's license, per letter dated July 22, 1999.
Approved by: core
|
Revision tags: release/5.2.1_cvs, release/5.2.1, release/5.2.0_cvs, release/5.2.0, release/4.9.0_cvs, release/4.9.0 |
|
#
7144b1d4 |
| 22-Jun-2003 |
Don Lewis <truckman@FreeBSD.org> |
Don't check the state of the vnode interlock if the specification says that the lock should not be checked.
Skip the lock assertion checks for *vpp or any other pointer to a vnode pointer if vpp (or
Don't check the state of the vnode interlock if the specification says that the lock should not be checked.
Skip the lock assertion checks for *vpp or any other pointer to a vnode pointer if vpp (or equivalent) is NULL.
show more ...
|
#
86ed8962 |
| 20-Jun-2003 |
Stefan Eßer <se@FreeBSD.org> |
The assertions generated to test VFS locking never included checks for vnodes reached through double indirection (i.e. **vpp). This is worked-around by special-casing the identifier "vpp" (adding one
The assertions generated to test VFS locking never included checks for vnodes reached through double indirection (i.e. **vpp). This is worked-around by special-casing the identifier "vpp" (adding one level of indirection).
The alternative fix mentioned in the PR had required substantial changes to this script.
In case there are locking violations that had been hidden without this patch, they may suddenly show up, now ...
This change does not affect code compiled without DEBUG_VFS_LOCKS.
PR: kern/46652
show more ...
|
Revision tags: release/5.1.0_cvs, release/5.1.0, release/4.8.0_cvs, release/4.8.0, release/5.0.0_cvs, release/5.0.0, release/4.7.0_cvs |
|
#
6423c943 |
| 26-Sep-2002 |
Jeff Roberson <jeff@FreeBSD.org> |
- Move ASSERT_VOP_*LOCK* functionality into functions in vfs_subr.c - Make the VI asserts more orthogonal to the rest of the asserts by using a new, common vfs_badlock() function and adding a 'st
- Move ASSERT_VOP_*LOCK* functionality into functions in vfs_subr.c - Make the VI asserts more orthogonal to the rest of the asserts by using a new, common vfs_badlock() function and adding a 'str' arg. - Adjust generated ASSERTS to match the new prototype. - Adjust explicit ASSERTS to match the new prototype.
show more ...
|
#
15597470 |
| 23-Sep-2002 |
Jeff Roberson <jeff@FreeBSD.org> |
- Automatically generate and insert KTR points in all VOPs.
|
#
71ea4ba5 |
| 21-Aug-2002 |
Jeff Roberson <jeff@FreeBSD.org> |
- Add two new debugging macros: ASSERT_VI_LOCKED and ASSERT_VI_UNLOCKED - Use the new VI asserts in place of the old mtx_assert checks. - Add the VI asserts to the automated lock checking in the VO
- Add two new debugging macros: ASSERT_VI_LOCKED and ASSERT_VI_UNLOCKED - Use the new VI asserts in place of the old mtx_assert checks. - Add the VI asserts to the automated lock checking in the VOP calls. The interlock should not be held across vops with a few exceptions. - Add the vop_(un)lock_{pre,post} functions to assert that interlock is held when LK_INTERLOCK is set.
show more ...
|
Revision tags: release/4.6.2_cvs, release/4.6.2 |
|
#
cf409a0a |
| 30-Jul-2002 |
Jeff Roberson <jeff@FreeBSD.org> |
- Add automatic post vop debug checks. These work in both the success and failure cases.
|
Revision tags: release/4.6.1 |
|
#
5c08ffed |
| 07-Jul-2002 |
Jeff Roberson <jeff@FreeBSD.org> |
- Use 'options DEBUG_VFS_LOCKS' instead of the DEBUG_ALL_VFS_LOCKS environment variable to enable the lock verifiction code.
|