Merge ^/head r303250 through r304235.

MFhead @ r304038

Improve a consistency check to not detect valid cases for
unordered user messages using DATA chunks as invalid ones.
While there, ensure that error causes are provided when
sending ABORT chunks in ca

Improve a consistency check to not detect valid cases for
unordered user messages using DATA chunks as invalid ones.
While there, ensure that error causes are provided when
sending ABORT chunks in case of reassembly problems detected.
Thanks to Taylor Brandstetter for making me aware of this problem.
MFC after: 3 days

show more ...

Fix various bugs in relation to the I-DATA chunk support

This is joint work with rrs.

MFC after: 3 days

Use correct order of conditions to avoid NULL deref.

MFC after: 3 days
X-MFC with: r302935

Fix the PR-SCTP behaviour.
This is done by rrs@.

MFC after: 3 days

Add missing sctps_reasmusrmsgs counter.
Joint work with rrs@.
MFC after: 3 days

Deal with a portential memory allocation failure, which was reported
by the clang static code analyzer.
Joint work with rrs@.

MFC after: 3 days

Don't free a data chunk twice.
Found by the clang static code analyzer running for the userland stack.

MFC after: 3 days

Fix a locking bug which only shows up on Mac OS X.

MFC after: 1 week

Retire net.inet.sctp.strict_sacks and net.inet.sctp.strict_data_order
sysctl's, since they where only there to interop with non-conformant
implementations. This should not be a problem anymore.

Use a format string in snprintf() for consistency.

This was reported by Radek Malcic when using the userland stack in
combination with MinGW.

MFC after: 1 week

Undo a spell fix introduced in r298942, which breaks compilation.

netinet/sctp*: minor spelling fixes in comments.

No functional change.

Reviewed by: tuexen

Don't use the control argument after calling sctp_add_to_readq().
This breaks the userland stack. There should be no functional change
for the FreeBSD kernel stack.
While there, use consistent variab

Don't use the control argument after calling sctp_add_to_readq().
This breaks the userland stack. There should be no functional change
for the FreeBSD kernel stack.
While there, use consistent variable nameing.

show more ...

Address issues found by the XCode code analyzer.

Fix signed/unsigned warnings.

Fix a warning about an unused variable.

Put panic() calls under INVARIANTS.

Cleanup debug output.

Don't use anonymous unions.

MFH

Sponsored by: The FreeBSD Foundation

This is work done by Michael Tuexen and myself at the IETF. This
adds the new I-Data (Interleaved Data) message. This allows a user
to be able to have complete freedom from Head Of Line blocking that

This is work done by Michael Tuexen and myself at the IETF. This
adds the new I-Data (Interleaved Data) message. This allows a user
to be able to have complete freedom from Head Of Line blocking that
was previously there due to the in-ability to send multiple large
messages without the TSN's being in sequence. The code as been
tested with Michaels various packet drill scripts as well as
inter-networking between the IETF's location in Argentina and Germany.

show more ...

MFH

Sponsored by: The FreeBSD Foundation

Improve compilation on windows 64-bit (for the userland stack).

MFC after: 1 week