xref: /linux/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c (revision 4a83c26a1d8702c516db77fc4423ae896ee904f1)
14f2a8f58SJoel Stanley // SPDX-License-Identifier: GPL-2.0+
24f2a8f58SJoel Stanley // Copyright 2018 IBM Corporation
34f2a8f58SJoel Stanley 
44f2a8f58SJoel Stanley #include <linux/clk.h>
54f2a8f58SJoel Stanley #include <linux/dma-mapping.h>
64f2a8f58SJoel Stanley #include <linux/irq.h>
74f2a8f58SJoel Stanley #include <linux/mfd/syscon.h>
84f2a8f58SJoel Stanley #include <linux/module.h>
94f2a8f58SJoel Stanley #include <linux/of.h>
10bce724faSJoel Stanley #include <linux/of_device.h>
114f2a8f58SJoel Stanley #include <linux/of_reserved_mem.h>
124f2a8f58SJoel Stanley #include <linux/platform_device.h>
134f2a8f58SJoel Stanley #include <linux/regmap.h>
144f2a8f58SJoel Stanley #include <linux/reset.h>
154f2a8f58SJoel Stanley 
164f2a8f58SJoel Stanley #include <drm/drm_atomic_helper.h>
174f2a8f58SJoel Stanley #include <drm/drm_crtc_helper.h>
184f2a8f58SJoel Stanley #include <drm/drm_device.h>
194f2a8f58SJoel Stanley #include <drm/drm_fb_helper.h>
20*4a83c26aSDanilo Krummrich #include <drm/drm_gem_dma_helper.h>
214f2a8f58SJoel Stanley #include <drm/drm_gem_framebuffer_helper.h>
2294afe983SJavier Martinez Canillas #include <drm/drm_module.h>
234f2a8f58SJoel Stanley #include <drm/drm_probe_helper.h>
244f2a8f58SJoel Stanley #include <drm/drm_simple_kms_helper.h>
254f2a8f58SJoel Stanley #include <drm/drm_vblank.h>
264f2a8f58SJoel Stanley #include <drm/drm_drv.h>
274f2a8f58SJoel Stanley 
284f2a8f58SJoel Stanley #include "aspeed_gfx.h"
294f2a8f58SJoel Stanley 
304f2a8f58SJoel Stanley /**
314f2a8f58SJoel Stanley  * DOC: ASPEED GFX Driver
324f2a8f58SJoel Stanley  *
334f2a8f58SJoel Stanley  * This driver is for the ASPEED BMC SoC's 'GFX' display hardware, also called
344f2a8f58SJoel Stanley  * the 'SOC Display Controller' in the datasheet. This driver runs on the ARM
354f2a8f58SJoel Stanley  * based BMC systems, unlike the ast driver which runs on a host CPU and is for
364f2a8f58SJoel Stanley  * a PCIe graphics device.
374f2a8f58SJoel Stanley  *
384f2a8f58SJoel Stanley  * The AST2500 supports a total of 3 output paths:
394f2a8f58SJoel Stanley  *
404f2a8f58SJoel Stanley  *   1. VGA output, the output target can choose either or both to the DAC
414f2a8f58SJoel Stanley  *   or DVO interface.
424f2a8f58SJoel Stanley  *
434f2a8f58SJoel Stanley  *   2. Graphics CRT output, the output target can choose either or both to
444f2a8f58SJoel Stanley  *   the DAC or DVO interface.
454f2a8f58SJoel Stanley  *
464f2a8f58SJoel Stanley  *   3. Video input from DVO, the video input can be used for video engine
474f2a8f58SJoel Stanley  *   capture or DAC display output.
484f2a8f58SJoel Stanley  *
494f2a8f58SJoel Stanley  * Output options are selected in SCU2C.
504f2a8f58SJoel Stanley  *
514f2a8f58SJoel Stanley  * The "VGA mode" device is the PCI attached controller. The "Graphics CRT"
524f2a8f58SJoel Stanley  * is the ARM's internal display controller.
534f2a8f58SJoel Stanley  *
544f2a8f58SJoel Stanley  * The driver only supports a simple configuration consisting of a 40MHz
554f2a8f58SJoel Stanley  * pixel clock, fixed by hardware limitations, and the VGA output path.
564f2a8f58SJoel Stanley  *
574f2a8f58SJoel Stanley  * The driver was written with the 'AST2500 Software Programming Guide' v17,
584f2a8f58SJoel Stanley  * which is available under NDA from ASPEED.
594f2a8f58SJoel Stanley  */
604f2a8f58SJoel Stanley 
61bce724faSJoel Stanley struct aspeed_gfx_config {
62bce724faSJoel Stanley 	u32 dac_reg;		/* DAC register in SCU */
635e2421ceSTommy Haung 	u32 int_clear_reg;	/* Interrupt clear register */
64bce724faSJoel Stanley 	u32 vga_scratch_reg;	/* VGA scratch register in SCU */
65bce724faSJoel Stanley 	u32 throd_val;		/* Default Threshold Seting */
66bce724faSJoel Stanley 	u32 scan_line_max;	/* Max memory size of one scan line */
67bce724faSJoel Stanley };
68bce724faSJoel Stanley 
69bce724faSJoel Stanley static const struct aspeed_gfx_config ast2400_config = {
70bce724faSJoel Stanley 	.dac_reg = 0x2c,
715e2421ceSTommy Haung 	.int_clear_reg = 0x60,
72bce724faSJoel Stanley 	.vga_scratch_reg = 0x50,
73bce724faSJoel Stanley 	.throd_val = CRT_THROD_LOW(0x1e) | CRT_THROD_HIGH(0x12),
74bce724faSJoel Stanley 	.scan_line_max = 64,
75bce724faSJoel Stanley };
76bce724faSJoel Stanley 
77bce724faSJoel Stanley static const struct aspeed_gfx_config ast2500_config = {
78bce724faSJoel Stanley 	.dac_reg = 0x2c,
795e2421ceSTommy Haung 	.int_clear_reg = 0x60,
80bce724faSJoel Stanley 	.vga_scratch_reg = 0x50,
81bce724faSJoel Stanley 	.throd_val = CRT_THROD_LOW(0x24) | CRT_THROD_HIGH(0x3c),
82bce724faSJoel Stanley 	.scan_line_max = 128,
83bce724faSJoel Stanley };
84bce724faSJoel Stanley 
85e41d27eaSTommy Haung static const struct aspeed_gfx_config ast2600_config = {
86e41d27eaSTommy Haung 	.dac_reg = 0xc0,
87e41d27eaSTommy Haung 	.int_clear_reg = 0x68,
88e41d27eaSTommy Haung 	.vga_scratch_reg = 0x50,
89e41d27eaSTommy Haung 	.throd_val = CRT_THROD_LOW(0x50) | CRT_THROD_HIGH(0x70),
90e41d27eaSTommy Haung 	.scan_line_max = 128,
91e41d27eaSTommy Haung };
92e41d27eaSTommy Haung 
93bce724faSJoel Stanley static const struct of_device_id aspeed_gfx_match[] = {
94bce724faSJoel Stanley 	{ .compatible = "aspeed,ast2400-gfx", .data = &ast2400_config },
95bce724faSJoel Stanley 	{ .compatible = "aspeed,ast2500-gfx", .data = &ast2500_config },
96e41d27eaSTommy Haung 	{ .compatible = "aspeed,ast2600-gfx", .data = &ast2600_config },
97bce724faSJoel Stanley 	{ },
98bce724faSJoel Stanley };
99bce724faSJoel Stanley MODULE_DEVICE_TABLE(of, aspeed_gfx_match);
100bce724faSJoel Stanley 
1014f2a8f58SJoel Stanley static const struct drm_mode_config_funcs aspeed_gfx_mode_config_funcs = {
1024f2a8f58SJoel Stanley 	.fb_create		= drm_gem_fb_create,
1034f2a8f58SJoel Stanley 	.atomic_check		= drm_atomic_helper_check,
1044f2a8f58SJoel Stanley 	.atomic_commit		= drm_atomic_helper_commit,
1054f2a8f58SJoel Stanley };
1064f2a8f58SJoel Stanley 
107c2c25c1cSDaniel Vetter static int aspeed_gfx_setup_mode_config(struct drm_device *drm)
1084f2a8f58SJoel Stanley {
109c2c25c1cSDaniel Vetter 	int ret;
110c2c25c1cSDaniel Vetter 
111c2c25c1cSDaniel Vetter 	ret = drmm_mode_config_init(drm);
112c2c25c1cSDaniel Vetter 	if (ret)
113c2c25c1cSDaniel Vetter 		return ret;
1144f2a8f58SJoel Stanley 
1154f2a8f58SJoel Stanley 	drm->mode_config.min_width = 0;
1164f2a8f58SJoel Stanley 	drm->mode_config.min_height = 0;
1174f2a8f58SJoel Stanley 	drm->mode_config.max_width = 800;
1184f2a8f58SJoel Stanley 	drm->mode_config.max_height = 600;
1194f2a8f58SJoel Stanley 	drm->mode_config.funcs = &aspeed_gfx_mode_config_funcs;
120c2c25c1cSDaniel Vetter 
121c2c25c1cSDaniel Vetter 	return ret;
1224f2a8f58SJoel Stanley }
1234f2a8f58SJoel Stanley 
1244f2a8f58SJoel Stanley static irqreturn_t aspeed_gfx_irq_handler(int irq, void *data)
1254f2a8f58SJoel Stanley {
1264f2a8f58SJoel Stanley 	struct drm_device *drm = data;
127cd829454SDaniel Vetter 	struct aspeed_gfx *priv = to_aspeed_gfx(drm);
1284f2a8f58SJoel Stanley 	u32 reg;
1294f2a8f58SJoel Stanley 
1304f2a8f58SJoel Stanley 	reg = readl(priv->base + CRT_CTRL1);
1314f2a8f58SJoel Stanley 
1324f2a8f58SJoel Stanley 	if (reg & CRT_CTRL_VERTICAL_INTR_STS) {
1334f2a8f58SJoel Stanley 		drm_crtc_handle_vblank(&priv->pipe.crtc);
1345e2421ceSTommy Haung 		writel(reg, priv->base + priv->int_clr_reg);
1354f2a8f58SJoel Stanley 		return IRQ_HANDLED;
1364f2a8f58SJoel Stanley 	}
1374f2a8f58SJoel Stanley 
1384f2a8f58SJoel Stanley 	return IRQ_NONE;
1394f2a8f58SJoel Stanley }
1404f2a8f58SJoel Stanley 
1414f2a8f58SJoel Stanley static int aspeed_gfx_load(struct drm_device *drm)
1424f2a8f58SJoel Stanley {
1434f2a8f58SJoel Stanley 	struct platform_device *pdev = to_platform_device(drm->dev);
144cd829454SDaniel Vetter 	struct aspeed_gfx *priv = to_aspeed_gfx(drm);
14592614ad5SJoel Stanley 	struct device_node *np = pdev->dev.of_node;
146bce724faSJoel Stanley 	const struct aspeed_gfx_config *config;
147bce724faSJoel Stanley 	const struct of_device_id *match;
1484f2a8f58SJoel Stanley 	struct resource *res;
1494f2a8f58SJoel Stanley 	int ret;
1504f2a8f58SJoel Stanley 
1514f2a8f58SJoel Stanley 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1524f2a8f58SJoel Stanley 	priv->base = devm_ioremap_resource(drm->dev, res);
1534f2a8f58SJoel Stanley 	if (IS_ERR(priv->base))
1544f2a8f58SJoel Stanley 		return PTR_ERR(priv->base);
1554f2a8f58SJoel Stanley 
156bce724faSJoel Stanley 	match = of_match_device(aspeed_gfx_match, &pdev->dev);
157bce724faSJoel Stanley 	if (!match)
158bce724faSJoel Stanley 		return -EINVAL;
159bce724faSJoel Stanley 	config = match->data;
160bce724faSJoel Stanley 
161bce724faSJoel Stanley 	priv->dac_reg = config->dac_reg;
1625e2421ceSTommy Haung 	priv->int_clr_reg = config->int_clear_reg;
163bce724faSJoel Stanley 	priv->vga_scratch_reg = config->vga_scratch_reg;
164bce724faSJoel Stanley 	priv->throd_val = config->throd_val;
165bce724faSJoel Stanley 	priv->scan_line_max = config->scan_line_max;
166bce724faSJoel Stanley 
16792614ad5SJoel Stanley 	priv->scu = syscon_regmap_lookup_by_phandle(np, "syscon");
16892614ad5SJoel Stanley 	if (IS_ERR(priv->scu)) {
1694f2a8f58SJoel Stanley 		priv->scu = syscon_regmap_lookup_by_compatible("aspeed,ast2500-scu");
1704f2a8f58SJoel Stanley 		if (IS_ERR(priv->scu)) {
1714f2a8f58SJoel Stanley 			dev_err(&pdev->dev, "failed to find SCU regmap\n");
1724f2a8f58SJoel Stanley 			return PTR_ERR(priv->scu);
1734f2a8f58SJoel Stanley 		}
17492614ad5SJoel Stanley 	}
1754f2a8f58SJoel Stanley 
1764f2a8f58SJoel Stanley 	ret = of_reserved_mem_device_init(drm->dev);
1774f2a8f58SJoel Stanley 	if (ret) {
1784f2a8f58SJoel Stanley 		dev_err(&pdev->dev,
1794f2a8f58SJoel Stanley 			"failed to initialize reserved mem: %d\n", ret);
1804f2a8f58SJoel Stanley 		return ret;
1814f2a8f58SJoel Stanley 	}
1824f2a8f58SJoel Stanley 
1834f2a8f58SJoel Stanley 	ret = dma_set_mask_and_coherent(drm->dev, DMA_BIT_MASK(32));
1844f2a8f58SJoel Stanley 	if (ret) {
1854f2a8f58SJoel Stanley 		dev_err(&pdev->dev, "failed to set DMA mask: %d\n", ret);
1864f2a8f58SJoel Stanley 		return ret;
1874f2a8f58SJoel Stanley 	}
1884f2a8f58SJoel Stanley 
1894f2a8f58SJoel Stanley 	priv->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
1904f2a8f58SJoel Stanley 	if (IS_ERR(priv->rst)) {
1914f2a8f58SJoel Stanley 		dev_err(&pdev->dev,
1924f2a8f58SJoel Stanley 			"missing or invalid reset controller device tree entry");
1934f2a8f58SJoel Stanley 		return PTR_ERR(priv->rst);
1944f2a8f58SJoel Stanley 	}
1954f2a8f58SJoel Stanley 	reset_control_deassert(priv->rst);
1964f2a8f58SJoel Stanley 
1974f2a8f58SJoel Stanley 	priv->clk = devm_clk_get(drm->dev, NULL);
1984f2a8f58SJoel Stanley 	if (IS_ERR(priv->clk)) {
1994f2a8f58SJoel Stanley 		dev_err(&pdev->dev,
2004f2a8f58SJoel Stanley 			"missing or invalid clk device tree entry");
2014f2a8f58SJoel Stanley 		return PTR_ERR(priv->clk);
2024f2a8f58SJoel Stanley 	}
2034f2a8f58SJoel Stanley 	clk_prepare_enable(priv->clk);
2044f2a8f58SJoel Stanley 
2054f2a8f58SJoel Stanley 	/* Sanitize control registers */
2064f2a8f58SJoel Stanley 	writel(0, priv->base + CRT_CTRL1);
2074f2a8f58SJoel Stanley 	writel(0, priv->base + CRT_CTRL2);
2084f2a8f58SJoel Stanley 
209c2c25c1cSDaniel Vetter 	ret = aspeed_gfx_setup_mode_config(drm);
210c2c25c1cSDaniel Vetter 	if (ret < 0)
211c2c25c1cSDaniel Vetter 		return ret;
2124f2a8f58SJoel Stanley 
2134f2a8f58SJoel Stanley 	ret = drm_vblank_init(drm, 1);
2144f2a8f58SJoel Stanley 	if (ret < 0) {
2154f2a8f58SJoel Stanley 		dev_err(drm->dev, "Failed to initialise vblank\n");
2164f2a8f58SJoel Stanley 		return ret;
2174f2a8f58SJoel Stanley 	}
2184f2a8f58SJoel Stanley 
2194f2a8f58SJoel Stanley 	ret = aspeed_gfx_create_output(drm);
2204f2a8f58SJoel Stanley 	if (ret < 0) {
2214f2a8f58SJoel Stanley 		dev_err(drm->dev, "Failed to create outputs\n");
2224f2a8f58SJoel Stanley 		return ret;
2234f2a8f58SJoel Stanley 	}
2244f2a8f58SJoel Stanley 
2254f2a8f58SJoel Stanley 	ret = aspeed_gfx_create_pipe(drm);
2264f2a8f58SJoel Stanley 	if (ret < 0) {
2274f2a8f58SJoel Stanley 		dev_err(drm->dev, "Cannot setup simple display pipe\n");
2284f2a8f58SJoel Stanley 		return ret;
2294f2a8f58SJoel Stanley 	}
2304f2a8f58SJoel Stanley 
2314f2a8f58SJoel Stanley 	ret = devm_request_irq(drm->dev, platform_get_irq(pdev, 0),
2324f2a8f58SJoel Stanley 			       aspeed_gfx_irq_handler, 0, "aspeed gfx", drm);
2334f2a8f58SJoel Stanley 	if (ret < 0) {
2344f2a8f58SJoel Stanley 		dev_err(drm->dev, "Failed to install IRQ handler\n");
2354f2a8f58SJoel Stanley 		return ret;
2364f2a8f58SJoel Stanley 	}
2374f2a8f58SJoel Stanley 
2384f2a8f58SJoel Stanley 	drm_mode_config_reset(drm);
2394f2a8f58SJoel Stanley 
2404f2a8f58SJoel Stanley 	return 0;
2414f2a8f58SJoel Stanley }
2424f2a8f58SJoel Stanley 
2434f2a8f58SJoel Stanley static void aspeed_gfx_unload(struct drm_device *drm)
2444f2a8f58SJoel Stanley {
2454f2a8f58SJoel Stanley 	drm_kms_helper_poll_fini(drm);
2464f2a8f58SJoel Stanley }
2474f2a8f58SJoel Stanley 
248*4a83c26aSDanilo Krummrich DEFINE_DRM_GEM_DMA_FOPS(fops);
2494f2a8f58SJoel Stanley 
25070a59dd8SDaniel Vetter static const struct drm_driver aspeed_gfx_driver = {
2510424fdafSDaniel Vetter 	.driver_features        = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
252*4a83c26aSDanilo Krummrich 	DRM_GEM_DMA_DRIVER_OPS,
2534f2a8f58SJoel Stanley 	.fops = &fops,
2544f2a8f58SJoel Stanley 	.name = "aspeed-gfx-drm",
2554f2a8f58SJoel Stanley 	.desc = "ASPEED GFX DRM",
2564f2a8f58SJoel Stanley 	.date = "20180319",
2574f2a8f58SJoel Stanley 	.major = 1,
2584f2a8f58SJoel Stanley 	.minor = 0,
2594f2a8f58SJoel Stanley };
2604f2a8f58SJoel Stanley 
261696029ebSJoel Stanley static ssize_t dac_mux_store(struct device *dev, struct device_attribute *attr,
262696029ebSJoel Stanley 			     const char *buf, size_t count)
263696029ebSJoel Stanley {
264696029ebSJoel Stanley 	struct aspeed_gfx *priv = dev_get_drvdata(dev);
265696029ebSJoel Stanley 	u32 val;
266696029ebSJoel Stanley 	int rc;
267696029ebSJoel Stanley 
268696029ebSJoel Stanley 	rc = kstrtou32(buf, 0, &val);
269696029ebSJoel Stanley 	if (rc)
270696029ebSJoel Stanley 		return rc;
271696029ebSJoel Stanley 
272696029ebSJoel Stanley 	if (val > 3)
273696029ebSJoel Stanley 		return -EINVAL;
274696029ebSJoel Stanley 
275bce724faSJoel Stanley 	rc = regmap_update_bits(priv->scu, priv->dac_reg, 0x30000, val << 16);
276696029ebSJoel Stanley 	if (rc < 0)
277696029ebSJoel Stanley 		return 0;
278696029ebSJoel Stanley 
279696029ebSJoel Stanley 	return count;
280696029ebSJoel Stanley }
281696029ebSJoel Stanley 
282696029ebSJoel Stanley static ssize_t dac_mux_show(struct device *dev, struct device_attribute *attr, char *buf)
283696029ebSJoel Stanley {
284696029ebSJoel Stanley 	struct aspeed_gfx *priv = dev_get_drvdata(dev);
285696029ebSJoel Stanley 	u32 reg;
286696029ebSJoel Stanley 	int rc;
287696029ebSJoel Stanley 
288bce724faSJoel Stanley 	rc = regmap_read(priv->scu, priv->dac_reg, &reg);
289696029ebSJoel Stanley 	if (rc)
290696029ebSJoel Stanley 		return rc;
291696029ebSJoel Stanley 
292696029ebSJoel Stanley 	return sprintf(buf, "%u\n", (reg >> 16) & 0x3);
293696029ebSJoel Stanley }
294696029ebSJoel Stanley static DEVICE_ATTR_RW(dac_mux);
295696029ebSJoel Stanley 
296696029ebSJoel Stanley static ssize_t
297696029ebSJoel Stanley vga_pw_show(struct device *dev, struct device_attribute *attr, char *buf)
298696029ebSJoel Stanley {
299696029ebSJoel Stanley 	struct aspeed_gfx *priv = dev_get_drvdata(dev);
300696029ebSJoel Stanley 	u32 reg;
301696029ebSJoel Stanley 	int rc;
302696029ebSJoel Stanley 
303bce724faSJoel Stanley 	rc = regmap_read(priv->scu, priv->vga_scratch_reg, &reg);
304696029ebSJoel Stanley 	if (rc)
305696029ebSJoel Stanley 		return rc;
306696029ebSJoel Stanley 
307b4a6aaeaSJoel Stanley 	return sprintf(buf, "%u\n", reg);
308696029ebSJoel Stanley }
309696029ebSJoel Stanley static DEVICE_ATTR_RO(vga_pw);
310696029ebSJoel Stanley 
311696029ebSJoel Stanley static struct attribute *aspeed_sysfs_entries[] = {
312696029ebSJoel Stanley 	&dev_attr_vga_pw.attr,
313696029ebSJoel Stanley 	&dev_attr_dac_mux.attr,
314696029ebSJoel Stanley 	NULL,
315696029ebSJoel Stanley };
316696029ebSJoel Stanley 
317696029ebSJoel Stanley static struct attribute_group aspeed_sysfs_attr_group = {
318696029ebSJoel Stanley 	.attrs = aspeed_sysfs_entries,
319696029ebSJoel Stanley };
320696029ebSJoel Stanley 
3214f2a8f58SJoel Stanley static int aspeed_gfx_probe(struct platform_device *pdev)
3224f2a8f58SJoel Stanley {
323cd829454SDaniel Vetter 	struct aspeed_gfx *priv;
3244f2a8f58SJoel Stanley 	int ret;
3254f2a8f58SJoel Stanley 
326cd829454SDaniel Vetter 	priv = devm_drm_dev_alloc(&pdev->dev, &aspeed_gfx_driver,
327cd829454SDaniel Vetter 				  struct aspeed_gfx, drm);
328cd829454SDaniel Vetter 	if (IS_ERR(priv))
329cd829454SDaniel Vetter 		return PTR_ERR(priv);
3304f2a8f58SJoel Stanley 
331cd829454SDaniel Vetter 	ret = aspeed_gfx_load(&priv->drm);
3324f2a8f58SJoel Stanley 	if (ret)
333cd829454SDaniel Vetter 		return ret;
3344f2a8f58SJoel Stanley 
3355dd331d4SJulia Lawall 	platform_set_drvdata(pdev, priv);
336696029ebSJoel Stanley 
337696029ebSJoel Stanley 	ret = sysfs_create_group(&pdev->dev.kobj, &aspeed_sysfs_attr_group);
338696029ebSJoel Stanley 	if (ret)
339696029ebSJoel Stanley 		return ret;
340696029ebSJoel Stanley 
341cd829454SDaniel Vetter 	ret = drm_dev_register(&priv->drm, 0);
3424f2a8f58SJoel Stanley 	if (ret)
3434f2a8f58SJoel Stanley 		goto err_unload;
3444f2a8f58SJoel Stanley 
34522493574SGuenter Roeck 	drm_fbdev_generic_setup(&priv->drm, 32);
3464f2a8f58SJoel Stanley 	return 0;
3474f2a8f58SJoel Stanley 
3484f2a8f58SJoel Stanley err_unload:
349696029ebSJoel Stanley 	sysfs_remove_group(&pdev->dev.kobj, &aspeed_sysfs_attr_group);
350cd829454SDaniel Vetter 	aspeed_gfx_unload(&priv->drm);
3514f2a8f58SJoel Stanley 
3524f2a8f58SJoel Stanley 	return ret;
3534f2a8f58SJoel Stanley }
3544f2a8f58SJoel Stanley 
3554f2a8f58SJoel Stanley static int aspeed_gfx_remove(struct platform_device *pdev)
3564f2a8f58SJoel Stanley {
3574f2a8f58SJoel Stanley 	struct drm_device *drm = platform_get_drvdata(pdev);
3584f2a8f58SJoel Stanley 
359696029ebSJoel Stanley 	sysfs_remove_group(&pdev->dev.kobj, &aspeed_sysfs_attr_group);
3604f2a8f58SJoel Stanley 	drm_dev_unregister(drm);
3614f2a8f58SJoel Stanley 	aspeed_gfx_unload(drm);
3624f2a8f58SJoel Stanley 
3634f2a8f58SJoel Stanley 	return 0;
3644f2a8f58SJoel Stanley }
3654f2a8f58SJoel Stanley 
3664f2a8f58SJoel Stanley static struct platform_driver aspeed_gfx_platform_driver = {
3674f2a8f58SJoel Stanley 	.probe		= aspeed_gfx_probe,
3684f2a8f58SJoel Stanley 	.remove		= aspeed_gfx_remove,
3694f2a8f58SJoel Stanley 	.driver = {
3704f2a8f58SJoel Stanley 		.name = "aspeed_gfx",
3714f2a8f58SJoel Stanley 		.of_match_table = aspeed_gfx_match,
3724f2a8f58SJoel Stanley 	},
3734f2a8f58SJoel Stanley };
3744f2a8f58SJoel Stanley 
37594afe983SJavier Martinez Canillas drm_module_platform_driver(aspeed_gfx_platform_driver);
3764f2a8f58SJoel Stanley 
3774f2a8f58SJoel Stanley MODULE_AUTHOR("Joel Stanley <joel@jms.id.au>");
3784f2a8f58SJoel Stanley MODULE_DESCRIPTION("ASPEED BMC DRM/KMS driver");
3794f2a8f58SJoel Stanley MODULE_LICENSE("GPL");
380