Searched hist:b7a14708aafeb12730ab23de8ecedd14f401a30c (Results 1 – 1 of 1) sorted by relevance
/linux/fs/nfsd/ |
H A D | nfsctl.c | diff b7a14708aafeb12730ab23de8ecedd14f401a30c Fri Nov 03 19:35:16 CET 2023 Al Viro <viro@zeniv.linux.org.uk> switch nfsd_client_rmdir() to use of simple_recursive_removal()
nfsd_client_rmdir() open-codes a subset of simple_recursive_removal(). Conversion to calling simple_recursive_removal() allows to clean things up quite a bit.
While we are at it, nfsdfs_create_files() doesn't need to mess with "pick the reference to struct nfsdfs_client from the already created parent" - the caller already knows it (that's where the parent got it from, after all), so we might as well just pass it as an explicit argument. So __get_nfsdfs_client() is only needed in get_nfsdfs_client() and can be folded in there.
Incidentally, the locking in get_nfsdfs_client() is too heavy - we don't need ->i_rwsem for that, ->i_lock serves just fine.
Reviewed-by: Jeff Layton <jlayton@kernel.org> Tested-by: Jeff Layton <jlayton@kernel.org> Acked-by: Chuck Lever <chuck.lever@oracle.com> Acked-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
|