Home
last modified time | relevance | path

Searched hist:"2 ffd2a6ad1d3a8213bb5805f45f49098fe615db1" (Results 1 – 1 of 1) sorted by relevance

/linux/fs/ext4/
H A Dindirect.cdiff 2ffd2a6ad1d3a8213bb5805f45f49098fe615db1 Fri Jan 05 10:21:01 CET 2024 Kemeng Shi <shikemeng@huaweicloud.com> ext4: remove unnecessary parameter "needed" in ext4_discard_preallocations

The "needed" controls the number of ext4_prealloc_space to discard in
ext4_discard_preallocations. Function ext4_discard_preallocations is
supposed to discard all non-used preallocated blocks when "needed"
is 0 and now ext4_discard_preallocations is always called with "needed"
= 0. Remove unnecessary parameter "needed" and remove all non-used
preallocated spaces in ext4_discard_preallocations to simplify the
code.

Note: If count of non-used preallocated spaces could be more than
UINT_MAX, there was a memory leak as some non-used preallocated
spaces are left ununsed and this commit will fix it. Otherwise,
there is no behavior change.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240105092102.496631-9-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>