en Copyright 2015 Java http://kernelsources.org:8080/source/history/linux/tools/tracing/rtla/src/cli.h#244d0cbff2efa13931115784e5dc4d1270a04ec7 rtla/tests: Add unit tests for _parse_args() functionsAdd a test suite for the _parse_args() function of each tool that checksthe params structures (struct common_params, struct osnoise_params,struct timerlat_params) returned by them for correctness.One test case is added per option, as well as a few special cases fortricky combinations of options. Test cases are ordered the same as theoption arrays and help message to allow easy checking of whether alloptions are covered.This should help clarify what the proper command line behavior of RTLAis in case there are holes in the documentation and verify that theintended behavior is implemented correctly.A few necessary changes to the unit tests were done as part of thiscommit:- Unit tests now also link to libsubcmd and its dependencies.- A new global variable in_unit_test is added to RTLA's CLI interface, causing it to skip check for root if running in unit tests. This allows the CLI unit tests to run as non-root, like existing unit tests.There is quite a lot of duplication, some of it is mitigated with macros,but partially it is intentional so that future changes in behavior aretracked across tools.Link: https://lore.kernel.org/r/20260528103254.2990068-6-tglozar@redhat.comSigned-off-by: Tomas Glozar <tglozar@redhat.com> List of files: /linux/tools/tracing/rtla/src/cli.h Thu, 28 May 2026 12:32:53 +0200 Tomas Glozar <tglozar@redhat.com> http://kernelsources.org:8080/source/history/linux/tools/tracing/rtla/src/cli.h#5d9af63e80b5a202e69ce5bcf54af320e46f397a rtla: Parse cmdline using libsubcmdInstead of using getopt_long() directly to parse the command linearguments given to an RTLA tool, use libsubcmd's parse_options().Utilizing libsubcmd for parsing command line arguments has severalbenefits:- A help message is automatically generated by libsubcmd from the specification, removing the need of writing it by hand.- Options are sorted into groups based on which part of tracing (CPU, thread, auto-analysis, tuning, histogram) they relate to.- Common parsing patterns for numerical and boolean values now share code, with the target variable being stored in the option array.To avoid duplication of the option parsing logic, RTLA-specificmacros defining struct option values are created:- RTLA_OPT_* for options common to all tools- OSNOISE_OPT_* and TIMERLAT_OPT_* for options specific to osnoise/timerlat tools- HIST_OPT_* macros for options specific to histogram-based tools.Individual *_parse_args() functions then construct an array out ofthese macros that is then passed to libsubcmd's parse_options().All code specific to command line options parsing is moved out of theindividual tool files into a new file, cli.c, which also contains thecontents of the rtla.c file. A private header, cli_p.h, is addedalongside the public header cli.h, so that unit tests are able to teststatically declared option callbacks.Minor changes:- The return value of tool-level help option changes to 129, as this is the value set by libsubcmd; this is reflected in affected test cases. The implementation of help for command-level and tracer-level help is set to 129 as well for consistency, and the change is reflected in exit value documentation.- Related to the above, {rtla,osnoise,timerlat}_usage() are marked __noreturn and exit() is removed from after they are called for cleaner code.- The error messages for invalid argument for options --dma-latency and -E/--entries were corrected, fixing off-by-one in the limits.Note that unsetting options (using --no-<opt> syntax) is currently notimplemented for options that use custom callbacks. For --irq and--thread, it will never be implemented, as they conflict with alreadyexisting --no-irq and --no-thread with a different meaning.Assisted-by: Composer:composer-1.5Link: https://lore.kernel.org/r/20260528103254.2990068-5-tglozar@redhat.comSigned-off-by: Tomas Glozar <tglozar@redhat.com> List of files: /linux/tools/tracing/rtla/src/cli.h Thu, 28 May 2026 12:32:52 +0200 Tomas Glozar <tglozar@redhat.com>