c8c2bd2bcf67c43f0b2ec8250c258cd8c486b1a2 - selftests: net: getsockopt_iter: cleanup

Thu, 07 May 2026 12:57:54 +0200

selftests: net: getsockopt_iter: cleanupApply two cleanups suggested by Stanislav and bobby on the originalselftest series:- Reorder local variable declarations into reverse christmas-tree order (longest line first). Because that ordering puts socklen_t optlen before the variable whose size it stores, the "optlen = sizeof(...)" initializer is moved out of the declaration to a plain assignment in the test body, as Stanislav suggested.- Add ASSERT_EQ(optlen, ...) on every error path so the value the kernel writes back to the userspace optlen is pinned down even when the syscall returns -1. With do_sock_getsockopt() now writing opt->optlen back to userspace unconditionally, asserting that the netlink/vsock error paths leave the original input length untouched guards against future regressions.Bobby Eshleman pointed out thatSO_VM_SOCKETS_CONNECT_TIMEOUT_NEW/OLD return a sock_timeval-shapedpayload (16 bytes on 64-bit), which is wider than the u64 casealready covered. Add four tests that exercise this path:- connect_timeout_new_exact exact-size buffer- connect_timeout_new_oversize_clamped oversize buffer, clamped- connect_timeout_new_undersize undersize -> -EINVAL, optlen untouched- connect_timeout_old_exact exact-size buffer for OLD optnameSuggested-by: Stanislav Fomichev Suggested-by: Bobby Eshleman Signed-off-by: Breno Leitao Link: https://patch.msgid.link/20260507-getsock_two-v2-5-5873111d9c12@debian.orgSigned-off-by: Jakub Kicinski List of files: /linux/tools/testing/selftests/net/getsockopt_iter.c

d39887f55d8edaacdb4fbc4cbfecff31dec1dc6a - net: selftests: add getsockopt_iter regression tests

Fri, 01 May 2026 17:52:53 +0200

net: selftests: add getsockopt_iter regression testsAdd a single kselftest covering the proto_ops getsockopt_iterconversions for AF_NETLINK and AF_VSOCK, using one fixture per protocol:netlink:NETLINK_PKTINFO covers the flag-style int path (exact size, oversizeclamp, undersize -EINVAL); NETLINK_LIST_MEMBERSHIPS covers thesize-discovery path that always reports the required buffer length backvia optlen, even when the user buffer is too small to receive any groupbits.vsock:SO_VM_SOCKETS_BUFFER_SIZE covers the u64 path (exact size, oversizeclamp, undersize -EINVAL).Each fixture also exercises an unknown optname and a bogus level sothe returned-length / errno semantics preserved by the sockopt_tconversion are pinned down.Signed-off-by: Breno Leitao Reviewed-by: Bobby Eshleman Acked-by: Stanislav Fomichev Link: https://patch.msgid.link/20260501-getsock_one-v1-3-810ce23ea70e@debian.orgSigned-off-by: Jakub Kicinski List of files: /linux/tools/testing/selftests/net/getsockopt_iter.c

Changes in getsockopt_iter.c

c8c2bd2bcf67c43f0b2ec8250c258cd8c486b1a2 - selftests: net: getsockopt_iter: cleanup

d39887f55d8edaacdb4fbc4cbfecff31dec1dc6a - net: selftests: add getsockopt_iter regression tests