Changes in attrib.c

ff9726d7a0068e6c2ae1969415285d12ef4d5c6f - Merge tag 'ntfs-for-7.1-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfs

Fri, 24 Apr 2026 22:40:25 +0200

Merge tag 'ntfs-for-7.1-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfsPull ntfs updates from Namjae Jeon: - Fix potential data leakage by zeroing the portion of the straddle block beyond initialized_size when reading non-resident attributes - Remove unnecessary zeroing in ntfs_punch_hole() for ranges beyond initialized_size, as they are already returned as zeros on read - Fix writable check in ntfs_file_mmap_prepare() to correctly handle shared mappings using VMA_SHARED_BIT | VMA_MAYWRITE_BIT - Use page allocation instead of kmemdup() for IOMAP_INLINE data to ensure page-aligned address and avoid BUG trap in iomap_inline_data_valid() caused by the page boundary check - Add a size check before memory allocation in ntfs_attr_readall() and reject overly large attributes - Remove unneeded noop_direct_IO from ntfs_aops as it is no longer required following the FMODE_CAN_ODIRECT flag - Fix seven static analysis warnings reported by Smatch* tag 'ntfs-for-7.1-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfs: ntfs: use page allocation for resident attribute inline data ntfs: fix mmap_prepare writable check for shared mappings ntfs: fix potential 32-bit truncation in ntfs_write_cb() ntfs: fix uninitialized variable in ntfs_map_runlist_nolock ntfs: delete dead code ntfs: add missing error code in ntfs_mft_record_alloc() ntfs: fix uninitialized variables in ntfs_ea_set_wsl_inode() ntfs: fix uninitialized pointer in ntfs_write_mft_block ntfs: fix uninitialized variable in ntfs_write_simple_iomap_begin_non_resident ntfs: remove noop_direct_IO from address_space_operations ntfs: limit memory allocation in ntfs_attr_readall ntfs: not zero out range beyond init in punch_hole ntfs: zero out stale data in straddle block beyond initialized_size List of files: /linux/fs/ntfs/attrib.c

dacc18029ef69ed225fdb4d7c3215c285e9e8ef4 - ntfs: fix uninitialized variable in ntfs_map_runlist_nolock

Fri, 10 Apr 2026 17:18:30 +0200

ntfs: fix uninitialized variable in ntfs_map_runlist_nolockSmatch reported that ctx_needs_reset could be used uninitialized ifntfs_map_runlist_nolock() fails early when a search context is provided.Specifically, if the function returns -EIO because the attribute isresident, the code jumps to err_out. This initializes ctx_needs_reset tofalse to satisfy the static checker.Reported-by: Dan Carpenter Reviewed-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

0b79de3299079e4132972ab5e04136c770e38038 - ntfs: limit memory allocation in ntfs_attr_readall

Fri, 03 Apr 2026 03:10:39 +0200

ntfs: limit memory allocation in ntfs_attr_readallcheck an attribute size before memory allocation, and reject if the sizeis over the maximum size.Signed-off-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

cdd4dc3aebeab43a72ce0bc2b5bab6f0a80b97a5 - Merge tag 'ntfs-for-7.1-rc1-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfs

Sat, 18 Apr 2026 01:35:49 +0200

Merge tag 'ntfs-for-7.1-rc1-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfsPull ntfs resurrection from Namjae Jeon: "Ever since Kari Argillander’s 2022 report [1] regarding the state of the ntfs3 driver, I have spent the last 4 years working to provide full write support and current trends (iomap, no buffer head, folio), enhanced performance, stable maintenance, utility support including fsck for NTFS in Linux. This new implementation is built upon the clean foundation of the original read-only NTFS driver, adding: - Write support: Implemented full write support based on the classic read-only NTFS driver. Added delayed allocation to improve write performance through multi-cluster allocation and reduced fragmentation of the cluster bitmap. - iomap conversion: Switched buffered IO (reads/writes), direct IO, file extent mapping, readpages, and writepages to use iomap. - Remove buffer_head: Completely removed buffer_head usage by converting to folios. As a result, the dependency on CONFIG_BUFFER_HEAD has been removed from Kconfig. - Stability improvements: The new ntfs driver passes 326 xfstests, compared to 273 for ntfs3. All tests passed by ntfs3 are a complete subset of the tests passed by this implementation. Added support for fallocate, idmapped mounts, permissions, and more. xfstests Results report: Total tests run: 787 Passed : 326 Failed : 38 Skipped : 423 Failed tests breakdown: - 34 tests require metadata journaling - 4 other tests: 094: No unwritten extent concept in NTFS on-disk format 563: cgroup v2 aware writeback accounting not supported 631: RENAME_WHITEOUT support required 787: NFS delegation test"Link: https://lore.kernel.org/all/da20d32b-5185-f40b-48b8-2986922d8b25@stargateuniverse.net/ [1][ Let's see if this undead filesystem ends up being of the "Easter miracle" kind, or the "Nosferatu of filesystems" kind... ]* tag 'ntfs-for-7.1-rc1-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/ntfs: (46 commits) ntfs: remove redundant out-of-bound checks ntfs: add bound checking to ntfs_external_attr_find ntfs: add bound checking to ntfs_attr_find ntfs: fix ignoring unreachable code warnings ntfs: fix inconsistent indenting warnings ntfs: fix variable dereferenced before check warnings ntfs: prefer IS_ERR_OR_NULL() over manual NULL check ntfs: harden ntfs_listxattr against EA entries ntfs: harden ntfs_ea_lookup against malformed EA entries ntfs: check $EA query-length in ntfs_ea_get ntfs: validate WSL EA payload sizes ntfs: fix WSL ea restore condition ntfs: add missing newlines to pr_err() messages ntfs: fix pointer/integer casting warnings ntfs: use ->mft_no instead of ->i_ino in prints ntfs: change mft_no type to u64 ntfs: select FS_IOMAP in Kconfig ntfs: add MODULE_ALIAS_FS ntfs: reduce stack usage in ntfs_write_mft_block() ntfs: fix sysctl table registration and path ... List of files: /linux/fs/ntfs/attrib.c

a198a0c4b898f7c62f240a5b6baef93e456fb033 - ntfs: add bound checking to ntfs_external_attr_find

Mon, 16 Mar 2026 05:28:34 +0100

ntfs: add bound checking to ntfs_external_attr_findAdd bound validation in ntfs_external_attr_find toprevent out-of-bounds memory accesses. This ensuresthat the attribute record's length, name offset, andboth resident and non-resident value offsets strictlyfall within the safe boundaries of the MFT record.Signed-off-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

6ceb4cc81ef3409ff79dcb959771f9110787397a - ntfs: add bound checking to ntfs_attr_find

Thu, 12 Mar 2026 02:23:46 +0100

ntfs: add bound checking to ntfs_attr_findAdd bound validations in ntfs_attr_find to ensureattribute value offsets and lengths are safe toaccess. It verifies that resident attributes meettype-specific minimum length requirements andcheck the mapping_pairs_offset boundaries fornon-resident attributes.Signed-off-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

4e59f8a1a82beaa49d7796648fc4dc538eff6485 - ntfs: fix variable dereferenced before check warnings

Fri, 13 Mar 2026 00:59:07 +0100

ntfs: fix variable dereferenced before check warningsDetected by Smatch.lcnalloc.c:736 ntfs_cluster_alloc() error: we previously assumed 'rl' could be null (see line 719)inode.c:3275 ntfs_inode_close() warn: variable dereferenced before check 'tmp_nis' (see line 3255)attrib.c:4952 ntfs_attr_remove() warn: variable dereferenced before check 'ni' (see line 4951)dir.c:1035 ntfs_readdir() error: we previously assumed 'private' could be null (see line 850)Signed-off-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

ea3566a3fa235cd0325b2bedf91ceec65073004b - ntfs: add missing newlines to pr_err() messages

Tue, 10 Mar 2026 09:50:57 +0100

ntfs: add missing newlines to pr_err() messagesThere is an inconsistent use of pr_err() statements in the current code.Many error messages are missing the \n termination, what results in themessages being printed with a delay, only after a next printk() line isprinted. It prevents relying on printk() to monitor the driver errors.This patch is modifying only text messages, no functional change.Signed-off-by: Woody Suwalski Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

e7d82353986c7267fbd03d7385829cc763807b55 - ntfs: use ->mft_no instead of ->i_ino in prints

Thu, 05 Mar 2026 02:46:42 +0100

ntfs: use ->mft_no instead of ->i_ino in printsThis improves log accuracy for NTFS debugging and removes unnecessaryreliance on the VFS i_ino field ahead of the core VFS type change.Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

d9038d99fb5c623f43bcd8b726bfbbe8562648c2 - ntfs: change mft_no type to u64

Thu, 05 Mar 2026 02:40:54 +0100

ntfs: change mft_no type to u64Changes the type of ntfs_inode::mft_no from unsigned long to u64to safely handle the full 48-bit range without truncation risk, especiallyin preparation for broader VFS inode number type (i_ino:u64) and toimprove consistency with ntfs driver practices.Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

ac9ccb6e75c5af84095bece1019f22cb45ab43e5 - ntfs: Fix possible deadlock

Thu, 26 Feb 2026 17:09:06 +0100

ntfs: Fix possible deadlockIn the error path for ntfs_attr_map_whole_runlist() the lock is notreleased.Add release for lock.Detected by Smatch:fs/ntfs/attrib.c:5197 ntfs_non_resident_attr_collapse_range() warn:inconsistent returns '&ni->runlist.lock'.Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

1c85157ea88e87644e171c7ae3e1877f43b4b345 - ntfs: Add missing error code

Thu, 26 Feb 2026 17:09:05 +0100

ntfs: Add missing error codeIf ntfs_attr_iget() fails no error code is assigned to be returned.Detected by Smatch:fs/ntfs/attrib.c:2665 ntfs_attr_add() warn:missing error code 'err'Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

c418e96754100a9cafd7bff32c83cad746f32781 - ntfs: Place check before dereference

Thu, 26 Feb 2026 17:09:04 +0100

ntfs: Place check before dereferenceThe variable ni has the possiblity of being null and is checked for itbut, only after it was dereferenced in a log message.Put check before dereference.Detected by Smatch:fs/ntfs/attrib.c:2115 ntfs_resident_attr_record_add() warn:variable dereferenced before check 'ni' (see line 2111)fs/ntfs/attrib.c:2237 ntfs_non_resident_attr_record_add() warn:variable dereferenced before check 'ni' (see line 2232)Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

495e90fa334828d4119061e2726af51d0a0fb4ed - ntfs: update attrib operations

Fri, 13 Feb 2026 02:43:34 +0100

ntfs: update attrib operationsOverhaul the attribute operations to support write access, includingfull attribute list management for handling multiple MFT records, andcompressed writes.Acked-by: Christoph Hellwig Signed-off-by: Hyunchul Lee Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

1e9ea7e04472d4e5e12e58c881eaacfb3e49b669 - Revert "fs: Remove NTFS classic"

Tue, 30 Dec 2025 06:24:16 +0100

Revert "fs: Remove NTFS classic"This reverts commit 7ffa8f3d30236e0ab897c30bdb01224ff1fe1c89.Reverts the removal of the classic read-only ntfs driver toserve as the base for a new read-write ntfs implementation.If we stack changes on top of the revert patch, It will significantlyreduce the diff size, making the review easier.This revert intentionally excludes the restoration of Kconfig andMakefile. The Kconfig and Makefile will be added back in the final patchof this series, enabling the driver only after all features andimprovements have been applied.Acked-by: Christoph Hellwig Signed-off-by: Namjae Jeon List of files: /linux/fs/ntfs/attrib.c

cdd5b5a9761fd66d17586e4f4ba6588c70e640ea - Merge branch 'next' into for-linus

Tue, 07 Nov 2023 00:42:08 +0100

Merge branch 'next' into for-linusPrepare input updates for 6.7 merge window. List of files: /linux/fs/ntfs/attrib.c

34069d12e239ae8f36dd96c378e4622fb1c42a76 - Merge tag 'v6.5' into next

Tue, 05 Sep 2023 23:08:14 +0200

Merge tag 'v6.5' into nextSync up with mainline to bring in updates to the shared infrastructure. List of files: /linux/fs/ntfs/attrib.c

2612e3bbc0386368a850140a6c9b990cd496a5ec - Merge drm/drm-next into drm-intel-next

Mon, 07 Aug 2023 23:14:42 +0200

Merge drm/drm-next into drm-intel-nextCatching-up with drm-next and drm-intel-gt-next.It will unblock a code refactor around the platformdefinitions (names vs acronyms).Signed-off-by: Rodrigo Vivi List of files: /linux/fs/ntfs/attrib.c

9f771739a04919226081a107167596de75108fbb - Merge drm/drm-next into drm-intel-gt-next

Mon, 07 Aug 2023 12:29:40 +0200

Merge drm/drm-next into drm-intel-gt-nextNeed to pull in b3e4aae612ec ("drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism") asa dependency for https://patchwork.freedesktop.org/series/121735/Signed-off-by: Joonas Lahtinen List of files: /linux/fs/ntfs/attrib.c

61b7369483efb5e0a9f3b48e75fac00d46d661e0 - Merge drm/drm-next into drm-misc-next

Mon, 24 Jul 2023 15:44:47 +0200

Merge drm/drm-next into drm-misc-nextBackmerging to get v6.5-rc2.Signed-off-by: Thomas Zimmermann List of files: /linux/fs/ntfs/attrib.c