Changes in intel_mchbar.c

d1dc0c08e25172819c0490791f48490a6c43b58e - drm/i915/display: define and use intel_reg_{offset, equal, valid}() helpers

Tue, 05 May 2026 11:16:48 +0200

drm/i915/display: define and use intel_reg_{offset, equal, valid}() helpersAdd display specific helpers for getting the register offset, checkingfor equality and validity. Add them as static inlines for increased typesafety.Reviewed-by: Michał Grzelak Acked-by: Ville Syrjälä Link: https://patch.msgid.link/7fe12d4e5465778209ccf29359767a197b031dd9.1777972548.git.jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c

e892c68bba23d3e5be72933186fb74034a8e1bfe - drm/i915/display: add typedef for intel_reg_t and use it

Tue, 05 May 2026 11:16:45 +0200

drm/i915/display: add typedef for intel_reg_t and use itAdd a typedef alias intel_reg_t for i915_reg_t, and use it exclusivelyin display code. The goal is to eventually define a distinct type fordisplay, but for now just use an alias.In a handful of places include intel_display_reg_defs.h instead ofi915_reg_defs.h to get the definition, and isolate the i915_reg_defs.hinclude there.Reviewed-by: Michał Grzelak Acked-by: Ville Syrjälä Link: https://patch.msgid.link/f5bb0122143c39ce7f9ce8a1605a7637e569f7f8.1777972548.git.jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c

d54377e487a7576d076e4993e80b7d1cded81b0a - drm/i915/mchbar: include intel_mchbar_regs.h from intel_mchbar.h

Tue, 07 Apr 2026 21:36:26 +0200

drm/i915/mchbar: include intel_mchbar_regs.h from intel_mchbar.hAs an exception to the rule of not including unnecessary headers fromheaders, include intel_mchbar_regs.h from intel_mchbar.h. In order touse the interfaces in intel_mchbar.h you will always have to include theregisters anyway, so the includes are in pairs everywhere. There is zeroasymmetry. Simplify.Reviewed-by: Ville Syrjälä Link: https://patch.msgid.link/e44dc2daf3fc39d02c3f598c323caa3c08a54304.1775590536.git.jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c

86435ca5140bca8bef52809560d7678b6a9a5400 - drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accesses

Tue, 31 Mar 2026 17:42:58 +0200

drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accessesReplace the naked intel_uncore_read*() with intel_de_read*()in the MCHBAR code.v2: Rebase due to intel_uncore_read64_2x32()Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä Link: https://patch.msgid.link/20260331154259.24600-12-ville.syrjala@linux.intel.com List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c

84b0366809193fc6238e37c9839cd4b24db5e909 - drm/i915/mchbar: WARN when accessing non-MCHBAR registers via intel_mchbar_read*()

Tue, 31 Mar 2026 17:42:51 +0200

drm/i915/mchbar: WARN when accessing non-MCHBAR registers via intel_mchbar_read*()The intel_mchbar_read*() functions should only be used foraccessing MCHBAR registers. Warn if someone tries to usethem for other registers.I suppose we could even have a dedicated type for MCHBARregisters. But that is true for many other special registertypes as well, and so far we haven't bothered adding anyspecial types apart from i915_mcr_reg_t.v2: Print the register offset (Jani) Mention i915_mcr_reg_t (Jani)Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä Link: https://patch.msgid.link/20260331154259.24600-5-ville.syrjala@linux.intel.com List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c

81dbca71885df32b0683104d1f49065d792870e0 - drm/i915/mchbar: Provide intel_mchbar_read*() abstraction

Tue, 31 Mar 2026 17:42:49 +0200

drm/i915/mchbar: Provide intel_mchbar_read*() abstractionMCHBAR registers are a bit special in that:- we access them through the mirror- the mirror is read only on HSW+- the mirror requires the actual MCHBAR to be enabled in device 0:0.0- the mirror is gone on MTL+So I'd prefer to treat MCHBAR registers as a bit special inthe code as well, and do all accesses to them via dedicatedfunctions. Prodive such functions in the form ofintel_mchbar_read*().v2: Put the function arguments on one line No intel_uncore_read64() on xe, use intel_uncore_read64_2x32() Name the new function intel_mchbar_read64_2x32() as wellReviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä Link: https://patch.msgid.link/20260331154259.24600-3-ville.syrjala@linux.intel.com List of files: /linux/drivers/gpu/drm/i915/display/intel_mchbar.c