Changes in node-tree-test.c

47f05f71ad988c3180bdba807151e6e86ed75aa3 - Merge tag 'firewire-updates-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394

Sat, 22 Aug 2026 17:41:28 +0200

Merge tag 'firewire-updates-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394Pull firewire updates from Takashi Sakamoto: "Error handling, a potential bug fix, and KUnit tests: - Handle failures when generating the contents of the configuration ROM with parameters supplied by in-kernel implementations such as unit drivers (Sreeraj S Kurup) - Fix potential memory leak when an invalid self-ID sequence causes an error while building the internal node tree (Abdun Nihaal) KUnit tests have been added to trigger this case"* tag 'firewire-updates-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394: firewire: core: fix memory leak in error path of build_tree() firewire: core: validate parent port count before allocating nodes in build_tree() firewire: core: consolidate port counting in build_tree() firewire: core: add KUnit tests for failure of tree building firewire: core: add KUnit tests for successful tree building firewire: core: add KUnit test skeleton for node tree firewire: core: validate sub-block lengths in fw_core_add_descriptor() firewire: core: validate overall descriptor length in fw_core_add_descriptor() List of files: /linux/drivers/firewire/node-tree-test.c

05bfb1327dc5fb61528bab31cd8f0c1e4bddec23 - firewire: core: fix memory leak in error path of build_tree()

Tue, 11 Aug 2026 14:09:28 +0200

firewire: core: fix memory leak in error path of build_tree()In the error path of build_tree(), node instances can remain in the locallinked list when the function returns.Whenever an invalid value is detected in the self ID sequence, eachallocated node instance is either an entry in the linked list or anentry in the ports array of its parent node. Therefore, the allocatenode instances can be safely released by traversing the linked list fromits head.Release the remaining node instances with for_each_fw_node() beforereturning to the caller.Fixes: 3038e353cfaf ("firewire: Add core firewire stack.")Reported-by: Abdun Nihaal Link: https://lore.kernel.org/all/20260727095955.104972-1-nihaal@cse.iitm.ac.in/Link: https://lore.kernel.org/r/20260811120928.700577-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux/drivers/firewire/node-tree-test.c

f744022705b7eb479a1931ddd95aae4e9a4be221 - firewire: core: add KUnit tests for failure of tree building

Mon, 10 Aug 2026 08:41:19 +0200

firewire: core: add KUnit tests for failure of tree buildingAbdun Nihaal has reported a memory leak when tree building fails in themiddle of self ID sequence enumeration. This is caused by an invalidself ID sequence and is not a common occurrence.This commit is intended to assist in fixing the issue by adding KUnittests to show the cases in which the memory leak is triggered. The leakoccurs internally in the build_tree() function, therefore it cannot bedetected directly by the tests.Link: https://lore.kernel.org/r/20260810064119.410324-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux/drivers/firewire/node-tree-test.c

7b763ea17152cf61ede5289c3c66bf133c8aafa7 - firewire: core: add KUnit tests for successful tree building

Mon, 10 Aug 2026 08:41:18 +0200

firewire: core: add KUnit tests for successful tree buildingAfter a bus reset, self ID sequence is captured by 1394 OHCI hardware andpassed to software through SelfID DMA context. The core parses the sequenceto build an internal cache of the node tree for the current generationof the bus. This is the first step in managing resources on the bus.The tree is build by the build_tree() function. This commit adds KUnittests for the function, covering several successful scenarios.Link: https://lore.kernel.org/r/20260810064119.410324-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux/drivers/firewire/node-tree-test.c

1f9b65cf57081035547b4d3ca1805df20892e9db - firewire: core: add KUnit test skeleton for node tree

Mon, 10 Aug 2026 08:41:17 +0200

firewire: core: add KUnit test skeleton for node treeSome issues have been reported in node tree management. Refactoringthe topology-related code in the core is required. Adding unit testswould help ensure that the refactoring does not introduce regressions.This commit adds a KUnit test skeleton for this purpose.Link: https://lore.kernel.org/r/20260810064119.410324-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux/drivers/firewire/node-tree-test.c