Changes in kernel.cc

95fc64cc29fb4cddc7cad093cfa32587a623f560 - ctld: More consistent error messages

Thu, 28 May 2026 19:22:43 +0200

ctld: More consistent error messagesThe error messages ctld emits when it finds a port or LUN it did notcreate were inconsistent with each other as well as with ctld's othererror messages.MFC after: 1 weekSponsored by: Klara, Inc.Sponsored by: NetApp, Inc.Reviewed by: jhbDifferential Revision: https://reviews.freebsd.org/D57270 List of files: /freebsd/usr.sbin/ctld/kernel.cc

caef3c50ac067ca751ba4950f310821a521ebf57 - ctld: Refactor ioctl port handling

Wed, 27 May 2026 22:57:23 +0200

ctld: Refactor ioctl port handling- Normalize ioctl port names when the port name is first added to the configuration. This can catch potential duplicate port names sooner and helps with other parts of this change.- When recognizing existing ioctl ports, always expand the name to include the physical and virtual port numbers. This permits binding ioctl/0/0 or ioctl/1/0 to a target, for example.- When adding physical ports to a target, first check for an existing kernel port to reuse. This handles both ioctl and non-ioctl ports and removes the need for the conf::add_port method for ioctl ports to check in kports.- If an existing kport isn't found when adding physical ports, check to see if the port name is an ioctl port. If so, call conf::add_port to add an ioctl port. This add_port method overload is now simpler as it always creates a new port.NB: The kernel_port class handles CTL ports that already existedbefore ctld started including existing ioctl ports, whereas theioctl_port class handles ioctl ports that are created and completelymanaged by ctld. This was true before this change but is perhaps moreobvious after this change.Sponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D57092 List of files: /freebsd/usr.sbin/ctld/kernel.cc

7a436d378951bedbdaa71d45bf236fb001323549 - ctld: Don't ignore pp/vp values of kernel ports with pp == 0 but vp != 0

Wed, 27 May 2026 22:56:39 +0200

ctld: Don't ignore pp/vp values of kernel ports with pp == 0 but vp != 0Fixes: c6f1e9b8a412 ("ctld: Simplify XML parsing memory management")Sponsored by: Chelsio Communications List of files: /freebsd/usr.sbin/ctld/kernel.cc

d9c0594191f5c45d7f3c737350321ee59bfce9bf - ctld: kernel-sourced portal groups are not dummies

Tue, 28 Apr 2026 22:51:50 +0200

ctld: kernel-sourced portal groups are not dummiesThe current and historical versions of ctld would flag our initial setof kernel ports as dummies, because their portal groups were empty sinceportals come from the configuration on-disk.As a result, we would never try to remove a kernel port at startup thatdidn't exist in the configuration (possibly a feature if you wantedconcurrent ctld(8)), and we would always try to port->kernel_add() onports in the configuration (even if they actually did have an existingkernel port).Flag these portal groups as kernel groups so that we avoid trying to addports that already exist. It may be the case that the kernel_remove()loop in conf::apply() needs to do something other than the current`oldport->is_dummy()` to avoid removing ports that it isn't supposed tobe managing, but that wuld also seem to apply to LUNs that would beremoved today.Reviewed by: jhbDifferential Revision: https://reviews.freebsd.org/D51782 List of files: /freebsd/usr.sbin/ctld/kernel.cc

d21b513988b7d685edf2ad77886b3e3c95cc0df8 - ctld: Be more explicit in a few uses of types to avoid potential ambiguity

Thu, 07 Aug 2025 23:11:31 +0200

ctld: Be more explicit in a few uses of types to avoid potential ambiguityThis appeases -Wchanges-meaning warnings from GCC.Sponsored by: Chelsio Communications List of files: /freebsd/usr.sbin/ctld/kernel.cc

66b5296f1b29083634e2875ff08c32e7b6b866a8 - ctld: Add support for NVMe over Fabrics

Wed, 06 Aug 2025 21:57:50 +0200

ctld: Add support for NVMe over FabricsWhile the overall structure is similar for NVMeoF controllers andiSCSI targets, there are sufficient differences that NVMe support usesan alternate configuration syntax.- In authentication groups, permitted NVMeoF hosts can be allowed by names (NQNs) via "host-nqn" values (similar to "initiator-name" for iSCSI). Similarly, "host-address" accepts permitted host addresses similar to "initiator-portal" for iSCSI.- A new "transport-group" context enumerates transports that can be used by a group of NVMeoF controllers similar to the "portal-group" context for iSCSI. In this section, the "listen" keyword accepts a transport as well as an address to permit other types of transports besides TCP in the future. The "foreign", "offload", and "redirect" keywords are also not meaningful and thus not supported.- A new "controller" context describes an NVMeoF I/O controller similar to the "target" context for iSCSI. One key difference here is that "lun" objects are replaced by "namespace" objects. However, a "namespace" can reference a named global lun permitting LUNs to be shared between iSCSI targets and NVMeoF controllers.NB: Authentication via CHAP is not implemented for NVMeoF.Reviewed by: impSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D48773 List of files: /freebsd/usr.sbin/ctld/kernel.cc

7e844dcad22bdbbdfa9c73271fe46b9ef963d34c - ctld: Add abstractions to support multiple target protocols

Wed, 06 Aug 2025 21:56:56 +0200

ctld: Add abstractions to support multiple target protocolsThis is a prerequisite for adding NVMe over Fabrics support.Convert portal_group, portal_group_port, and target into abstractclasses with virtual methods to support protocol-specific methods.Add new iscsi_portal_group, iscsi_port, iscsi_portal and iscsi_targetsubclasses in a new iscsi.cc file and move some iSCSI-specific logicthere. Rename ctld_connection to iscsi_connection and move it to anew iscsi.hh header. Move iscsi_connection methods out of ctld.cc andkernel.cc into iscsi.cc.Reviewed by: impSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D48772 List of files: /freebsd/usr.sbin/ctld/kernel.cc

ed076901ec80e23804ef432cfa7edeb10c4f9ede - ctld: Convert struct ctld_connection to a C++ class

Mon, 04 Aug 2025 21:38:08 +0200

ctld: Convert struct ctld_connection to a C++ classNote that some of the functions for handling iSCSI login, discovery,and kernel handoff are now functions of this class as they are logicaloperations on an iSCSI connection and need access to various membersof this class.This also fixes some memory leaks as ctld_connection wasn't properlytorn down once a connection finishes. These leaks were harmless inpractice since the ctld process exits after handling each connection.Sponsored by: Chelsio CommunicationsPull Request: https://github.com/freebsd/freebsd-src/pull/1794 List of files: /freebsd/usr.sbin/ctld/kernel.cc

c6f1e9b8a412e4ab7ca5b144708c170d790e4567 - ctld: Simplify XML parsing memory management

Mon, 04 Aug 2025 21:38:08 +0200

ctld: Simplify XML parsing memory managementUse C++ STL containers (std::string, std::list) for the data structureholding the parsed output of the XML configuration obtained from thekernel. This simplifies the code in various places and removes theneed for manual memory freeing (which was incomplete).Use a std::list of pairs of std::string objects for the port and LUNattribute lists instead of an nvlist.Use a std::vector for the resizable buffer receiving XML resultsvia ioctl(). Also, reuse the buffer from CTL_LUN_LIST forCTL_PORT_LIST rather than doing a free() only to turn around andmalloc() again. While here, split out the code for fetching andparsing the XML into a separate function.Sponsored by: Chelsio CommunicationsPull Request: https://github.com/freebsd/freebsd-src/pull/1794 List of files: /freebsd/usr.sbin/ctld/kernel.cc

888ec3a71912994e4585a6444962de691b56d5d6 - ctld: Convert struct conf to a C++ class