Changes in fetchmissingdists

47535ba3d35eda44d1eb961551173a9dadef17fa - bsdinstall: Remove unused variables in fetchmissingdists

Thu, 26 Oct 2023 14:16:54 +0200

bsdinstall: Remove unused variables in fetchmissingdistsALL_DISTRIBUTIONS and VERIFY_MANIFEST_SIGThey are neither used in the script nor exported.Not referenced anywhere in bsdinstall/*Approved by: imp@Differential Revision: https://reviews.freebsd.org/D42369 List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

c0e249d32c780ee8240fe8b3b8144078a8eec41f - bsdinstall: avoid conflicts with fd 3

Tue, 15 Aug 2023 17:44:02 +0200

bsdinstall: avoid conflicts with fd 3Throughout the bsdinstall script fd 3 is used by f_dprintf (set through$TERMINAL_STDOUT_PASSTHRU). In several places in the bsdinstalls scripts,we use fd 3 to juggle stdout when calling out to other tools, which cancause the installer to fail with a "Bad file descriptor" error whenf_dprintf attempts to use it.This commit replaces all constructs like this: exec 3>&1 SOME_VARIABLE=$(some command 2>&1 1>&3) exec 3>&-With: exec 5>&1 SOME_VARIABLE=$(some command 2>&1 1>&5) exec 5>&-PR: 273148Reviewed by: corvinkFixes: 1f7746d81f53447ac15cc99395bb714d4dd0a4da ("bsdinstall: stop messing with file descriptors")MFC after: 1 week List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 19:55:03 +0200

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

12b92f3ed82aa71c0eba246ce3053ef225724570 - bsdinstall: use the correct DISTDIR for fetching local distfiles

Fri, 14 Oct 2022 07:22:09 +0200

bsdinstall: use the correct DISTDIR for fetching local distfilesfetchmissingdists naturally sets BSDINSTALL_DISTDIR to a directory inthe new filesystem that it can write fetched distfiles to. As a result,BSDINSTALL_DISTSITE was incorrectly set to the scratch space on /mnt forthe call to distfetch when grabbing local distfiles, and it wouldsubsequently fail.Switch to using the copy of BSDINSTALL_DISTDIR that we stashed offcoming into fetchmissingdists; this one is in-fact set to the path wherethe local distfiles are stored.Patch suggested by jrtc27.Reported and tested by: Daniel O'Connor MFC after: 1 week List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

2913e785f057f54f7ee825fe4f9fe3c039c0f78f - bsdinstall: fix a couple stragglers in whitelabeling the scripts

Wed, 14 Sep 2022 19:04:07 +0200

bsdinstall: fix a couple stragglers in whitelabeling the scriptsPR: 265797Reviewed by: allanjude, asicilianoSponsored by: Rubicon Communications, LLC ("Netgate")Differential Revision: https://reviews.freebsd.org/D36235 List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

cc42ef5328963ee55c3305b136e9a86145f24594 - bsdinstall: allow whitelabeling the scripts

Tue, 24 May 2022 17:49:06 +0200

bsdinstall: allow whitelabeling the scriptsApproved by: allanjude, asicilianoDifferential Revision: https://reviews.freebsd.org/D35197Sponsored by: Rubicon Communications, LLC ("Netgate") List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

48af6ad902640abfcd19578b3f2e6f8a073d349d - bsdinstall fetchmissingdists: Replace dialog with bsddialog

Tue, 29 Mar 2022 16:39:43 +0200

bsdinstall fetchmissingdists: Replace dialog with bsddialogReplace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility.Approved by: bapt (mentor)Differential Revision: https://reviews.freebsd.org/D34654 List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

f0ec0fda01c3ecd435201813ebbc929eeccf10a5 - bsdinstall: Add quotes around error message argument

Thu, 27 Jan 2022 18:10:06 +0100

bsdinstall: Add quotes around error message argumentWhen error is called with a message with spaces (and probably multiplelines) these are passed into dialog unquoted and an error message waspresented, wrap with quotes.Reviewed by: bapt, allanjudeSponsored by: Ampere Computing LLCSponsored by: Klara Inc.Differential Revision: https://reviews.freebsd.org/D33918 List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists

40923b0c81cc2c151388ec5ead59f4bed89ac432 - Fix scripted installation from media without local distfiles.

Fri, 28 May 2021 15:53:42 +0200

Fix scripted installation from media without local distfiles.The bsdinstall script target did not have the infrastructure to fetchdistfiles from a remote server the way the interactive installer doeson e.g. bootonly media. Solve this by factoring out the parts of theinstaller that deal with fetching missing distributions into a newinstall stage called 'fetchmissingdists', which is called by both theinteractive and scripted installer frontends.In the course of these changes, cleaned up a few other issues withthe fetching of missing distribution files and added a warning iffetching the MANIFEST file, which is used to verify the integrity ofthe distribution files. We should at some point add cryptographicsignatures to MANIFEST so that it can be fetched safely if not presenton the install media (which it is for bootonly media).Initial patch by: Vinícius ZavamPR: 255659, 250928Reviewed by: dteskeMFC after: 4 weeksDifferential Revision: https://reviews.freebsd.org/D27121 List of files: /freebsd/usr.sbin/bsdinstall/scripts/fetchmissingdists