en Copyright 2015 Java http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#656f7f43f204ad1e6956f8257f66b50e032a6c61 call g_new_geom instead for callers that pass regular string to g_new_geomfReviewed by: impPull Request: https://github.com/freebsd/freebsd-src/pull/1786 List of files: /freebsd/sys/geom/raid3/g_raid3.c Tue, 29 Jul 2025 05:42:24 +0200 Wuyang Chung <wy-chung@outlook.com> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#955f213fa2f14d5b5e9b655d8922e28315eb9fa3 graid3: Fix teardown in g_raid3_try_destroy()Commit 33cb9b3c3a22 replaced a g_raid3_destroy_device() call with ag_raid3_free_device() call, which was incorrect and could lead to apanic if a RAID3 GEOM failed to start (e.g., due to missing disks).Reported by: graid3 testsFixes: 33cb9b3c3a22 ("graid3: Fix teardown races")MFC after: 3 daysSponsored by: Klara, Inc. List of files: /freebsd/sys/geom/raid3/g_raid3.c Sat, 20 Apr 2024 18:02:06 +0200 Mark Johnston <markj@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#4eb861d362d6a9493df7f77eab8e28f9c826702a shutdown: audit shutdown_post_sync event callbacksEnsure they are all panic/debugger safe.Most handlers for this event are for disk drivers/geom modules. Thereare a mix of checks being used here (or not), so let's standardize onchecking the presence of the RB_NOSYNC flag.This flag is set whenever: 1. The kernel has panicked and kern.sync_on_panic=0* 2. We reboot from within the kernel debugger (the "reset" command) 3. Userspace requested it, e.g. by 'reboot -n'Name the functions consistently.*This sysctl is tuned to zero by default, but its existence means thatthese handlers can be executed after a panic, at the user's discretion.IMO this use-case is implicitly understood to be risky, and we'd bebetter off eliminating it altogether.Reviewed by: markjSponsored by: The FreeBSD FoundationMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D42337 List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 23 Nov 2023 16:58:27 +0100 Mitchell Horne <mhorne@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#f3dc172763aee039c917fdba03f1e27095f5a7a9 geom: sort includes for some filesThis is not exhaustive, just done ahead of some upcoming changes tothese files.Don't include sys/cdefs.h explicitly. No functional change intended.Reviewed by: imp, jhbMFC after: 3 daysSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D42335 List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 23 Nov 2023 16:23:07 +0100 Mitchell Horne <mhorne@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#33cb9b3c3a2260cc273713b0adcd95016ff8b675 graid3: Fix teardown racesPort commit dc399583ba09 from g_mirror, which has an effectivelyidentical startup sequence.This fixes a race that was occasionally causing panics during GEOM testsuite runs on riscv.MFC after: 1 month List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 02 Nov 2023 19:35:37 +0100 Mark Johnston <markj@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#685dc743dc3b5645e34836464128e1c0558b404b sys: Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 16 Aug 2023 19:54:36 +0200 Warner Losh <imp@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#4d846d260e2b9a3d4d0a701462568268cbfe7a5b spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 10 May 2023 17:40:58 +0200 Warner Losh <imp@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#fd02d0bc14b5c8d7109a180575b565fa7427b93e graid3: Pre-allocate the timeout event structureAs in commit 2f1cfb7f63ca ("gmirror: Pre-allocate the timeout eventstructure"), graid3 must avoid M_WAITOK allocations in callout handlers.Reported by: graid3 regression testsMFC after 2 weeks List of files: /freebsd/sys/geom/raid3/g_raid3.c Sun, 26 Mar 2023 20:14:53 +0200 Mark Johnston <markj@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#10ae42ccbde4fe7c8c9de3d54f3c0d63457a1a68 GEOM: Set G_CF_DIRECT_SEND/RECEIVE for taste consumers.All I/O requests through the taste consumers are synchronous, donewith g_read_data() and without any locks held. It makes no senseto delegate the I/O to g_down/g_up threads.This removes many of context switches during disk retaste.MFC after: 2 weeks List of files: /freebsd/sys/geom/raid3/g_raid3.c Sun, 30 Jan 2022 03:59:03 +0100 Alexander Motin <mav@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#2cc5a480a63b48af606b845079f91f2d6a1bb44a geom_raid3: plug set-but-not-unused varsSponsored by: Rubicon Communications, LLC ("Netgate") List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 09 Dec 2021 19:08:03 +0100 Mateusz Guzik <mjg@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#39552dff7bb5463a74e5195d65a3252c583d9414 graid3: Zero the metadata block before writingEnsure that string buffers and pad bytes are zero-filled before writinggraid3 metadata.Reported by: KMSANMFC after: 2 weeksSponsored by: The FreeBSD Foundation List of files: /freebsd/sys/geom/raid3/g_raid3.c Tue, 13 Jul 2021 23:46:02 +0200 Mark Johnston <markj@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#cd8537910406e68d4719136a5b0cf6d23bb1b23b Make MAXPHYS tunable. Bump MAXPHYS to 1M.Replace MAXPHYS by runtime variable maxphys. It is initialized fromMAXPHYS by default, but can be also adjusted with the tunable kern.maxphys.Make b_pages[] array in struct buf flexible. Size b_pages[] for buffercache buffers exactly to atop(maxbcachebuf) (currently it is sized toatop(MAXPHYS)), and b_pages[] for pbufs is sized to atop(maxphys) + 1.The +1 for pbufs allow several pbuf consumers, among them vmapbuf(),to use unaligned buffers still sized to maxphys, esp. when suchbuffers come from userspace (*). Overall, we save significant amountof otherwise wasted memory in b_pages[] for buffer cache buffers,while bumping MAXPHYS to desired high value.Eliminate all direct uses of the MAXPHYS constant in kernel and driversources, except a place which initialize maxphys. Some random (andarguably weird) uses of MAXPHYS, e.g. in linuxolator, are convertedstraight. Some drivers, which use MAXPHYS to size embeded structures,get private MAXPHYS-like constant; their convertion is out of scopefor this work.Changes to cam/, dev/ahci, dev/ata, dev/mpr, dev/mpt, dev/mvs,dev/siis, where either submitted by, or based on changes by mav.Suggested by: mav (*)Reviewed by: imp, mav, imp, mckusick, scottl (intermediate versions)Tested by: phoSponsored by: The FreeBSD FoundationDifferential revision: https://reviews.freebsd.org/D27225 List of files: /freebsd/sys/geom/raid3/g_raid3.c Sat, 28 Nov 2020 13:12:51 +0100 Konstantin Belousov <kib@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#d22ff249d9733ed0ff628efd797f3ea3ec66c913 Make g_attach() return ENXIO for orphaned providers; update variousclasses to add missing error checking.Reviewed by: impMFC after: 2 weeksSponsored by: NetApp, Inc.Sponsored by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D26658 List of files: /freebsd/sys/geom/raid3/g_raid3.c Sun, 18 Oct 2020 18:24:08 +0200 Edward Tomasz Napierala <trasz@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#d40bc607528a613afeb59bdaabd09ad4d33c67be geom: clean up empty lines in .c and .h files List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 02 Sep 2020 00:14:09 +0200 Mateusz Guzik <mjg@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#75dfc66c1b2b44609e5a7c3e1d6a751be4922689 Merge ^/head r358269 through r358399. List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 27 Feb 2020 20:07:10 +0100 Dimitry Andric <dim@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#7029da5c36f2d3cf6bb6c81bf551229f416399e8 Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly marked).Use it in preparation for a general review of all nodes.This is non-functional change that adds annotations to SYSCTL_NODE andSYSCTL_PROC nodes using one of the soon-to-be-required flags.Mark all obvious cases as MPSAFE. All entries that haven't been markedas MPSAFE before are by default marked as NEEDGIANTApproved by: kib (mentor, blanket)Commented by: kib, gallatin, melifaroDifferential Revision: https://reviews.freebsd.org/D23718 List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 26 Feb 2020 15:26:36 +0100 Pawel Biernacki <kaktus@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#8b522bdae65ca1b2e5db20e9aeee0b5acd89e7ed Pass BIO_SPEEDUP through all the geom layersWhile some geom layers pass unknown commands down, not all do. For the ones thatdon't, pass BIO_SPEEDUP down to the providers that constittue the geom, asapplicable. No changes to vinum or virstor because I was unsure how to add thissupport, and I'm also unsure how to test these. gvinum doesn't implementBIO_FLUSH either, so it may just be poorly maintained. gvirstor is for testingand not supportig BIO_SPEEDUP is fine.Reviewed by: chsDifferential Revision: https://reviews.freebsd.org/D23183 List of files: /freebsd/sys/geom/raid3/g_raid3.c Fri, 17 Jan 2020 02:15:55 +0100 Warner Losh <imp@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#ac03832ef3afa26cc8e23bf5cfeaa32501b21c3e GEOM: Reduce unnecessary log interleaving with sbufsSimilar to what was done for device_printfs in r347229.Convert g_print_bio() to a thin shim around g_format_bio(), which acts on ansbuf; documented in g_bio.9.Reviewed by: markjDiscussed with: rlibbySponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D21165 List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 07 Aug 2019 21:28:35 +0200 Conrad Meyer <cem@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#e532a99901e26d3961f8f5c0e4969fce86f09456 MFHead @349234Sponsored by: The FreeBSD Foundation List of files: /freebsd/sys/geom/raid3/g_raid3.c Thu, 20 Jun 2019 17:56:08 +0200 Alan Somers <asomers@FreeBSD.org> http://kernelsources.org:8080/source/history/freebsd/sys/geom/raid3/g_raid3.c#49ee0fcea52c43f055ce8d63bc6f72dbb91c509d Use sbuf_cat() in GEOM confxml generation.When it comes to megabytes of text, difference between sbuf_printf() andsbuf_cat() becomes substantial.MFC after: 2 weeksSponsored by: iXsystems, Inc. List of files: /freebsd/sys/geom/raid3/g_raid3.c Wed, 19 Jun 2019 17:36:02 +0200 Alexander Motin <mav@FreeBSD.org>