Changes in tdfx_linux.c

790c27317ec1a997a4e5c2bdee9e4acc610c8e3c - linux: Make the macro LINUX_IOCTL_SET public

Mon, 20 Oct 2025 06:28:41 +0200

linux: Make the macro LINUX_IOCTL_SET publicThere're some other drivers want to register and unregister linuxioctl handler. Move the macro LINUX_IOCTL_SET from tdfx_linux.h tolinux_ioctl.h so that they can also benefit it.While here, rename the declaration of linux ioctl function to beconsistent with the name of the handler.Meanwhile, drop a comment about the macro, since its function isobvious.Reviewed by: markjMFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D53158 List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

2873d841f81cdc205135370875d3d71a3402e90a - tdfx: Handle errors from copyin() and copyout()

Wed, 27 Dec 2023 00:59:21 +0100

tdfx: Handle errors from copyin() and copyout()This is in preparation for annotating copyin() and related functionswith __result_use_check.MFC after: 1 week List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

fdafd315ad0d0f28a11b9fb4476a9ab059c62b92 - sys: Automated cleanup of cdefs and other formatting

Fri, 24 Nov 2023 21:12:57 +0100

sys: Automated cleanup of cdefs and other formattingApply the following automated changes to try to eliminateno-longer-needed sys/cdefs.h includes as well as now-emptyblank lines in a row.Remove /^#if.*\n#endif.*\n#include\s+.*\n/Remove /\n+#include\s+.*\n+#if.*\n#endif.*\n+/Remove /\n+#if.*\n#endif.*\n+/Remove /^#if.*\n#endif.*\n/Remove /\n+#include\s+\n#include\s+/Remove /\n+#include\s+\n#include\s+/Remove /\n+#include\s+\n#include\s+/Sponsored by: Netflix List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

685dc743dc3b5645e34836464128e1c0558b404b - sys: Remove $FreeBSD$: one-line .c pattern

Wed, 16 Aug 2023 19:54:36 +0200

sys: Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/ List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

4d846d260e2b9a3d4d0a701462568268cbfe7a5b - spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

Wed, 10 May 2023 17:40:58 +0200

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

6b3a9a0f3d2cd66145e89fdd8d07cb33a9963e8f - Convert remaining cap_rights_init users to cap_rights_init_one

Tue, 12 Jan 2021 13:11:26 +0100

Convert remaining cap_rights_init users to cap_rights_init_onesemantic patch:@@expression rights, r;@@- cap_rights_init(&rights, r)+ cap_rights_init_one(&rights, r) List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

718cf2ccb9956613756ab15d7a0e28f2c8e91cab - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 15:52:40 +0100

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

6cec9cad762b6476313fb1f8e931a1647822db6b - MFC @ r266724

Tue, 03 Jun 2014 04:34:21 +0200

MFC @ r266724An SVM update will follow this. List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

3b8f08459569bf0faa21473e5cec2491e95c9349 - Merge head

Mon, 28 Apr 2014 09:50:45 +0200

Merge head List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

84e51a1b679bececc13cbe3cd3cb9b7d461b9fe7 - IFC @264767

Wed, 23 Apr 2014 23:52:43 +0200

IFC @264767 List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

1709ccf9d38a5753192420ce5fccd93b04ce4d07 - Merge head up to r263906.

Sat, 29 Mar 2014 09:39:53 +0100

Merge head up to r263906. List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

4a14441044e0bdb55c81010ea92b24d87c25ee56 - Update kernel inclusions of capability.h to use capsicum.h instead; some

Sun, 16 Mar 2014 11:55:57 +0100

Update kernel inclusions of capability.h to use capsicum.h instead; somefurther refinement is required as some device drivers intended to beportable over FreeBSD versions rely on __FreeBSD_version to decide whetherto include capability.h.MFC after: 3 weeks List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

0bfd163f522701b486e066fa2e56624c02f5081a - Merge head r233826 through r256722.

Fri, 18 Oct 2013 11:32:02 +0200

Merge head r233826 through r256722. List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

1ccca3b5e8e31290b0932dbead89e6e31af184c7 - IFC @256277

Thu, 10 Oct 2013 23:46:43 +0200

IFC @256277Approved by: ken (mentor) List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

ef90af83a58199ef3980d8c9a7dad07ec9b4bea3 - IFC @ r255692

Fri, 20 Sep 2013 02:46:29 +0200

IFC @ r255692Comment out IA32_MISC_ENABLE MSR access - this doesn't exist on AMD.Need to sort out how arch-specific MSRs will be handled. List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

47823319c3978679f8cdbae0e99b52c8b532e89a - IFC @ r255459

Wed, 11 Sep 2013 02:19:16 +0200

IFC @ r255459 List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

0fbf163e60fe783d01ba4358d503695a0286e79d - MFC

Fri, 06 Sep 2013 19:42:12 +0200

MFC List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

d1d015864103b253b3fcb2f72a0da5b0cfeb31b6 - Merge from head

Thu, 05 Sep 2013 22:18:59 +0200

Merge from head List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

7008be5bd7341259037f383434a72960413cfeb8 - Change the cap_rights_t type from uint64_t to a structure that we can extend

Thu, 05 Sep 2013 02:09:56 +0200

Change the cap_rights_t type from uint64_t to a structure that we can extendin the future in a backward compatible (API and ABI) way.The cap_rights_t represents capability rights. We used to use one bit torepresent one right, but we are running out of spare bits. Currently the newstructure provides place for 114 rights (so 50 more than the previouscap_rights_t), but it is possible to grow the structure to hold at least 285rights, although we can make it even larger if 285 rights won't be enough.The structure definition looks like this: struct cap_rights { uint64_t cr_rights[CAP_RIGHTS_VERSION + 2]; };The initial CAP_RIGHTS_VERSION is 0.The top two bits in the first element of the cr_rights[] array contain totalnumber of elements in the array - 2. This means if those two bits are equal to0, we have 2 array elements.The top two bits in all remaining array elements should be 0.The next five bits in all array elements contain array index. Only one bit isused and bit position in this five-bits range defines array index. This meansthere can be at most five array elements in the future.To define new right the CAPRIGHT() macro must be used. The macro takes twoarguments - an array index and a bit to set, eg. #define CAP_PDKILL CAPRIGHT(1, 0x0000000000000800ULL)We still support aliases that combine few rights, but the rights have to belongto the same array element, eg: #define CAP_LOOKUP CAPRIGHT(0, 0x0000000000000400ULL) #define CAP_FCHMOD CAPRIGHT(0, 0x0000000000002000ULL) #define CAP_FCHMODAT (CAP_FCHMOD | CAP_LOOKUP)There is new API to manage the new cap_rights_t structure: cap_rights_t *cap_rights_init(cap_rights_t *rights, ...); void cap_rights_set(cap_rights_t *rights, ...); void cap_rights_clear(cap_rights_t *rights, ...); bool cap_rights_is_set(const cap_rights_t *rights, ...); bool cap_rights_is_valid(const cap_rights_t *rights); void cap_rights_merge(cap_rights_t *dst, const cap_rights_t *src); void cap_rights_remove(cap_rights_t *dst, const cap_rights_t *src); bool cap_rights_contains(const cap_rights_t *big, const cap_rights_t *little);Capability rights to the cap_rights_init(), cap_rights_set(),cap_rights_clear() and cap_rights_is_set() functions are provided byseparating them with commas, eg: cap_rights_t rights; cap_rights_init(&rights, CAP_READ, CAP_WRITE, CAP_FSTAT);There is no need to terminate the list of rights, as those functions areactually macros that take care of the termination, eg: #define cap_rights_set(rights, ...) \ __cap_rights_set((rights), __VA_ARGS__, 0ULL) void __cap_rights_set(cap_rights_t *rights, ...);Thanks to using one bit as an array index we can assert in those functions thatthere are no two rights belonging to different array elements providedtogether. For example this is illegal and will be detected, because CAP_LOOKUPbelongs to element 0 and CAP_PDKILL to element 1: cap_rights_init(&rights, CAP_LOOKUP | CAP_PDKILL);Providing several rights that belongs to the same array's element this way iscorrect, but is not advised. It should only be used for aliases definition.This commit also breaks compatibility with some existing Capsicum system calls,but I see no other way to do that. This should be fine as Capsicum is stillexperimental and this change is not going to 9.x.Sponsored by: The FreeBSD Foundation List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c

9823d52705ad71f19ef2205aa729547ac396e3eb - Revert previous commit...

Wed, 10 Oct 2012 10:36:38 +0200

Revert previous commit...Pointyhat to: kevlo (myself) List of files: /freebsd/sys/dev/tdfx/tdfx_linux.c