Changes in cesa.h

95ee2897e98f5d444f26ed2334cc7c439f9c16c6 - sys: Remove $FreeBSD$: two-line .h pattern

Wed, 16 Aug 2023 19:54:11 +0200

sys: Remove $FreeBSD$: two-line .h patternRemove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ List of files: /freebsd/sys/dev/cesa/cesa.h

4d846d260e2b9a3d4d0a701462568268cbfe7a5b - spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

Wed, 10 May 2023 17:40:58 +0200

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd/sys/dev/cesa/cesa.h

7ae99f80b6661760c5de3edd330b279f04b092a2 - pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t.

Fri, 23 Sep 2022 00:08:52 +0200

pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t.This matches the return type of pmap_mapdev/bios.Reviewed by: kib, markjSponsored by: DARPADifferential Revision: https://reviews.freebsd.org/D36548 List of files: /freebsd/sys/dev/cesa/cesa.h

cee9a741b261aaced00c1e9e2de3f0fa283f27af - cesa: remove unused CESA_SESSIONS macro

Tue, 05 Oct 2021 14:12:03 +0200

cesa: remove unused CESA_SESSIONS macroUnused since 1b0909d51a8aa8b5 ("OpenCrypto: Convert sessions to opaque handlesinstead of integers")Sponsored by: Rubicon Communications, LLC ("Netgate") List of files: /freebsd/sys/dev/cesa/cesa.h

c03414326909ed7a740be3ba63fbbef01fe513a8 - Refactor driver and consumer interfaces for OCF (in-kernel crypto).

Fri, 27 Mar 2020 19:25:23 +0100

Refactor driver and consumer interfaces for OCF (in-kernel crypto).- The linked list of cryptoini structures used in session initialization is replaced with a new flat structure: struct crypto_session_params. This session includes a new mode to define how the other fields should be interpreted. Available modes include: - COMPRESS (for compression/decompression) - CIPHER (for simply encryption/decryption) - DIGEST (computing and verifying digests) - AEAD (combined auth and encryption such as AES-GCM and AES-CCM) - ETA (combined auth and encryption using encrypt-then-authenticate) Additional modes could be added in the future (e.g. if we wanted to support TLS MtE for AES-CBC in the kernel we could add a new mode for that. TLS modes might also affect how AAD is interpreted, etc.) The flat structure also includes the key lengths and algorithms as before. However, code doesn't have to walk the linked list and switch on the algorithm to determine which key is the auth key vs encryption key. The 'csp_auth_*' fields are always used for auth keys and settings and 'csp_cipher_*' for cipher. (Compression algorithms are stored in csp_cipher_alg.)- Drivers no longer register a list of supported algorithms. This doesn't quite work when you factor in modes (e.g. a driver might support both AES-CBC and SHA2-256-HMAC separately but not combined for ETA). Instead, a new 'crypto_probesession' method has been added to the kobj interface for symmteric crypto drivers. This method returns a negative value on success (similar to how device_probe works) and the crypto framework uses this value to pick the "best" driver. There are three constants for hardware (e.g. ccr), accelerated software (e.g. aesni), and plain software (cryptosoft) that give preference in that order. One effect of this is that if you request only hardware when creating a new session, you will no longer get a session using accelerated software. Another effect is that the default setting to disallow software crypto via /dev/crypto now disables accelerated software. Once a driver is chosen, 'crypto_newsession' is invoked as before.- Crypto operations are now solely described by the flat 'cryptop' structure. The linked list of descriptors has been removed. A separate enum has been added to describe the type of data buffer in use instead of using CRYPTO_F_* flags to make it easier to add more types in the future if needed (e.g. wired userspace buffers for zero-copy). It will also make it easier to re-introduce separate input and output buffers (in-kernel TLS would benefit from this). Try to make the flags related to IV handling less insane: - CRYPTO_F_IV_SEPARATE means that the IV is stored in the 'crp_iv' member of the operation structure. If this flag is not set, the IV is stored in the data buffer at the 'crp_iv_start' offset. - CRYPTO_F_IV_GENERATE means that a random IV should be generated and stored into the data buffer. This cannot be used with CRYPTO_F_IV_SEPARATE. If a consumer wants to deal with explicit vs implicit IVs, etc. it can always generate the IV however it needs and store partial IVs in the buffer and the full IV/nonce in crp_iv and set CRYPTO_F_IV_SEPARATE. The layout of the buffer is now described via fields in cryptop. crp_aad_start and crp_aad_length define the boundaries of any AAD. Previously with GCM and CCM you defined an auth crd with this range, but for ETA your auth crd had to span both the AAD and plaintext (and they had to be adjacent). crp_payload_start and crp_payload_length define the boundaries of the plaintext/ciphertext. Modes that only do a single operation (COMPRESS, CIPHER, DIGEST) should only use this region and leave the AAD region empty. If a digest is present (or should be generated), it's starting location is marked by crp_digest_start. Instead of using the CRD_F_ENCRYPT flag to determine the direction of the operation, cryptop now includes an 'op' field defining the operation to perform. For digests I've added a new VERIFY digest mode which assumes a digest is present in the input and fails the request with EBADMSG if it doesn't match the internally-computed digest. GCM and CCM already assumed this, and the new AEAD mode requires this for decryption. The new ETA mode now also requires this for decryption, so IPsec and GELI no longer do their own authentication verification. Simple DIGEST operations can also do this, though there are no in-tree consumers. To eventually support some refcounting to close races, the session cookie is now passed to crypto_getop() and clients should no longer set crp_sesssion directly.- Assymteric crypto operation structures should be allocated via crypto_getkreq() and freed via crypto_freekreq(). This permits the crypto layer to track open asym requests and close races with a driver trying to unregister while asym requests are in flight.- crypto_copyback, crypto_copydata, crypto_apply, and crypto_contiguous_subsegment now accept the 'crp' object as the first parameter instead of individual members. This makes it easier to deal with different buffer types in the future as well as separate input and output buffers. It's also simpler for driver writers to use.- bus_dmamap_load_crp() loads a DMA mapping for a crypto buffer. This understands the various types of buffers so that drivers that use DMA do not have to be aware of different buffer types.- Helper routines now exist to build an auth context for HMAC IPAD and OPAD. This reduces some duplicated work among drivers.- Key buffers are now treated as const throughout the framework and in device drivers. However, session key buffers provided when a session is created are expected to remain alive for the duration of the session.- GCM and CCM sessions now only specify a cipher algorithm and a cipher key. The redundant auth information is not needed or used.- For cryptosoft, split up the code a bit such that the 'process' callback now invokes a function pointer in the session. This function pointer is set based on the mode (in effect) though it simplifies a few edge cases that would otherwise be in the switch in 'process'. It does split up GCM vs CCM which I think is more readable even if there is some duplication.- I changed /dev/crypto to support GMAC requests using CRYPTO_AES_NIST_GMAC as an auth algorithm and updated cryptocheck to work with it.- Combined cipher and auth sessions via /dev/crypto now always use ETA mode. The COP_F_CIPHER_FIRST flag is now a no-op that is ignored. This was actually documented as being true in crypto(4) before, but the code had not implemented this before I added the CIPHER_FIRST flag.- I have not yet updated /dev/crypto to be aware of explicit modes for sessions. I will probably do that at some point in the future as well as teach it about IV/nonce and tag lengths for AEAD so we can support all of the NIST KAT tests for GCM and CCM.- I've split up the exising crypto.9 manpage into several pages of which many are written from scratch.- I have converted all drivers and consumers in the tree and verified that they compile, but I have not tested all of them. I have tested the following drivers: - cryptosoft - aesni (AES only) - blake2 - ccr and the following consumers: - cryptodev - IPsec - ktls_ocf - GELI (lightly) I have not tested the following: - ccp - aesni with sha - hifn - kgssapi_krb5 - ubsec - padlock - safe - armv8_crypto (aarch64) - glxsb (i386) - sec (ppc) - cesa (armv7) - cryptocteon (mips64) - nlmsec (mips64)Discussed with: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D23677 List of files: /freebsd/sys/dev/cesa/cesa.h

1b0909d51a8aa8b5ec5a61c2dc1a69642976a732 - OpenCrypto: Convert sessions to opaque handles instead of integers

Wed, 18 Jul 2018 02:56:25 +0200

OpenCrypto: Convert sessions to opaque handles instead of integersTrack session objects in the framework, and pass handles between theframework (OCF), consumers, and drivers. Avoid redundancy and complexity inindividual drivers by allocating session memory in the framework andproviding it to drivers in ::newsession().Session handles are no longer integers with information encoded in varioushigh bits. Use of the CRYPTO_SESID2FOO() macros should be replaced with theappropriate crypto_ses2foo() function on the opaque session handle.Convert OCF drivers (in particular, cryptosoft, as well as myriad others) tothe opaque handle interface. Discard existing session tracking as much aspossible (quick pass). There may be additional code ripe for deletion.Convert OCF consumers (ipsec, geom_eli, krb5, cryptodev) to handle-styleinterface. The conversion is largely mechnical.The change is documented in crypto.9.Inspired byhttps://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html .No objection from: ae (ipsec portion)Reported by: jhb List of files: /freebsd/sys/dev/cesa/cesa.h

e9e2a7c1d3c496cf7edf362e5488a76384b3602f - Enable cesa driver to work with Linux DT binding

Tue, 10 Apr 2018 01:36:52 +0200

Enable cesa driver to work with Linux DT bindingLinux device tree binding, whose usage is obligatory,comprises faulty representation of Marvell cryptographicengine (CESA) - two engines are artificially gathered intosingle DT node, in order to avoid certain SW limitation.This patch improves the cesa driver to support above binding,depending on compatible string, which helps to ensurebackward compatibility.Submitted by: Patryk DudaObtained from: SemihalfSponsored by: StormshieldDifferential Revision: https://reviews.freebsd.org/D14760 List of files: /freebsd/sys/dev/cesa/cesa.h

4fc74049d22a6dffa621a370bafef97ffb7b6004 - Merge ^/head r327169 through r327340.

Fri, 29 Dec 2017 13:51:26 +0100

Merge ^/head r327169 through r327340. List of files: /freebsd/sys/dev/cesa/cesa.h

8a97717048f0beb0d5aaa6cc3eddf7fbed7faad2 - SPDX: fix wrong license ID tag in dev/cesa.

Thu, 28 Dec 2017 04:10:57 +0100

SPDX: fix wrong license ID tag in dev/cesa. List of files: /freebsd/sys/dev/cesa/cesa.h

718cf2ccb9956613756ab15d7a0e28f2c8e91cab - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 15:52:40 +0100

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd/sys/dev/cesa/cesa.h

ea1e967cbf9a3e1bbf964b01859c4d37965548d4 - Merge ^/head r318380 through r318559.

Fri, 19 May 2017 23:20:01 +0200

Merge ^/head r318380 through r318559. List of files: /freebsd/sys/dev/cesa/cesa.h

fcb93d74937ba64f0a5b0b054d08b948bdb9adf7 - Enable proper configuration of CESA MBUS windows

Fri, 19 May 2017 10:19:39 +0200

Enable proper configuration of CESA MBUS windowsFor all Marvell devices, MBUS windows configuration is donein a common place. Only CESA was an exception, so move itsrelated code from driver to mv_common.c. This way it usessame proper DRAM information, same as all other interfacesinstead of parsing DT /memory node directly.Submitted by: Marcin Wojtas Obtained from: SemihalfSponsored by: StormshieldReviewed by: loosDifferential revision: https://reviews.freebsd.org/D10723 List of files: /freebsd/sys/dev/cesa/cesa.h

f9edb08480901b8c7d85837d72f8702008b0a773 - Merge ^/head r313055 through r313300.

Sun, 05 Feb 2017 21:03:05 +0100

Merge ^/head r313055 through r313300. List of files: /freebsd/sys/dev/cesa/cesa.h

9b3ece1c2eb92a881cb2553271e123382bfe31c1 - MFhead@r313243

Sat, 04 Feb 2017 19:06:09 +0100

MFhead@r313243 List of files: /freebsd/sys/dev/cesa/cesa.h

ae0f418aa435bd4cd81f481cd042f79d5a1290ab - Remove remaining ifdefs from CESA header

Thu, 02 Feb 2017 07:07:39 +0100

Remove remaining ifdefs from CESA headerCommit r312743 ("Use SoC ID - based detection in CESA") resultedin build failing for Marvell armv5 platforms, which don't supportthe newer version of CESA controller. This patch provides a fix byremoving ifdefs around bitfields' definitions, so that they areknown to all platforms.Submitted by: Marcin Wojtas Obtained from: SemihalfSponsored by: Stormshield List of files: /freebsd/sys/dev/cesa/cesa.h

14f850f3df8ef009bc2d024ae290abfb52ccaa9b - Merge ^/head r312720 through r312893.

Fri, 27 Jan 2017 21:01:46 +0100

Merge ^/head r312720 through r312893. List of files: /freebsd/sys/dev/cesa/cesa.h

81526b839f1f0464a4ee7e04dfeba77cab8009df - Use SoC ID - based detection in CESA

Wed, 25 Jan 2017 11:22:07 +0100

Use SoC ID - based detection in CESAThis commit introduces following changes in order to get rid ofifdef's from all around the driver.* Introduce sc_soc_id field in cesa_softc structure - this value is obtained in cesa_attach() anyway, so make use of it.* Replace ifdefs with SoC ID checks.* Perform PM control status only for relevant SoC's.Submitted by: Marcin Wojtas Obtained from: SemihalfSponsored by: StormshieldReviewed by: zbbDifferential revision: https://reviews.freebsd.org/D9247 List of files: /freebsd/sys/dev/cesa/cesa.h

2cf4c169db3c9a3444cceede883f1ca6aed5691d - Use proper interface for FDT parsing and memory mapping in CESA

Fri, 03 Jun 2016 20:54:16 +0200

Use proper interface for FDT parsing and memory mapping in CESAImprovements after r301220.Bus space methods are not called so simple pmap_mapdev will suffice.Use OF_getencprop to get buffer with already converted endianess.Pointed out by: ianSubmitted by: Michal Stanek Obtained from: Semihalf List of files: /freebsd/sys/dev/cesa/cesa.h

b07df6e5a91d89764d942959dd1ca7b5ca132af8 - Add HMAC-SHA256 support in CESA

Thu, 02 Jun 2016 20:39:33 +0200

Add HMAC-SHA256 support in CESAOnly HMAC-SHA256 is added as it is the only SHA-2 variant supported bycryptodev. It is not possible to register hardware support for otheralgorithms in the family including regular non-keyed SHA256.Submitted by: Michal Stanek Obtained from: SemihalfSponsored by: StormshieldDifferential revision: https://reviews.freebsd.org/D6219 List of files: /freebsd/sys/dev/cesa/cesa.h

1e964f8a5264e2b7b01b918271bfa490f9049a4a - Truncate HMAC output only if requested by the client

Thu, 02 Jun 2016 20:37:50 +0200

Truncate HMAC output only if requested by the clientThe output of HMAC was previously truncated to 12 bytes. This was onlycorrect in case of one particular crypto client - the new version of IPSEC.Fix by taking into account the cri_mlen field in cryptoini session requestfilled in by the client.Submitted by: Michal Stanek Obtained from: SemihalfSponsored by: StormshieldDifferential revision: https://reviews.freebsd.org/D6218 List of files: /freebsd/sys/dev/cesa/cesa.h