Changes in Makefile

7c6a5272f1ded20e91b63fe3d1a016243641a37d - libthr.so: mark as -z initfirst

Sat, 03 May 2025 10:15:36 +0200

libthr.so: mark as -z initfirstPR: 286537Sponsored by: The FreeBSD FoundationMFC after: 1 weekDifferential revision: https://reviews.freebsd.org/D50133 List of files: /freebsd/lib/libthr/Makefile

3750ccefb8629a08890bfbae894dd6bc6a7483b4 - Retire MK_PROFILE infrastructure

Sun, 08 Aug 2021 03:00:28 +0200

Retire MK_PROFILE infrastructureIt was disabled by default in fe52b7f60ef4. We planned to (but did not)remove the option before FreeBSD 14. Remove it now, for FreeBSD 15.Relnotes: YesReviewed by: impSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D31558 List of files: /freebsd/lib/libthr/Makefile

e9ac41698b2f322d55ccf9da50a3596edb2c1800 - Remove residual blank line at start of Makefile

Mon, 15 Jul 2024 06:46:32 +0200

Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix List of files: /freebsd/lib/libthr/Makefile

39733922edc43001e8750307704daa835a14b5ac - rtld: actually resolve memcpy plt

Mon, 08 Jul 2024 01:46:49 +0200

rtld: actually resolve memcpy pltThe call to memcpy() meant to cause plt resolution in _thr_rtld_init()was getting optimized by the compiler. Tell the compiler not to use itsbuiltins in thr_rtld.c. We could avoid just the memcpy builtin butdisabling all will be more robust against future changes.Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D45891 List of files: /freebsd/lib/libthr/Makefile

9bfd3b4076a7b0dfd27ab22318e5113dc84fea28 - Add a build knob for _FORTIFY_SOURCE

Mon, 13 May 2024 07:23:50 +0200

Add a build knob for _FORTIFY_SOURCEIn the future, we will Default to _FORTIFY_SOURCE=2 if SSP is enabled,otherwise default to _FORTIFY_SOURCE=0. For now we default it to 0unconditionally to ease bisect across older versions without the newsymbols, and we'll put out a call for testing.include/*.h include their ssp/*.h equivalents as needed based on theknob. Programs and users are allowed to override FORTIFY_SOURCE in theirMakefiles or src.conf/make.conf to force it off.Reviewed by: des, markjRelnotes: yesSponsored by: StormshieldSponsored by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D32308 List of files: /freebsd/lib/libthr/Makefile

f8bbbce458194ff4312c610d32a64ff4a3a71d45 - libthr: remove explicit sys/cdefs.h includes

Wed, 06 Mar 2024 08:06:35 +0100

libthr: remove explicit sys/cdefs.h includesSponsored by: The FreeBSD FoundationMFC after: 1 week List of files: /freebsd/lib/libthr/Makefile

eb90239d08863bcff3cf82a556ad9d89776cdf3f - lib{c,thr}: add DT_RUNPATH for gcc -m32

Mon, 19 Feb 2024 23:44:08 +0100

lib{c,thr}: add DT_RUNPATH for gcc -m32To allow gcc -m32 to work, link libc and libthr with --rpath-/usr/lib32.When called with -m32, gcc is currently unable to communicate tothe bfd linker that it should look in /usr/lib32 to resolve needed (asopposed to explicitly linked) libraries so we need to provide a hint.See also: https://sourceware.org/bugzilla/show_bug.cgi?id=31395Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D43910 List of files: /freebsd/lib/libthr/Makefile

99ea67573164637d633e8051eb0a5d52f1f9488e - lib{c,sys}: move auxargs more firmly into libsys

Mon, 19 Feb 2024 23:44:08 +0100

lib{c,sys}: move auxargs more firmly into libsysContinue to filter the public interface (elf_aux_info()), but entierlyrelocate the private interfaces (_elf_aux_info(),__init_elf_aux_vector(), and __elf_aux_vector) to libsys.This ensures that rtld updates the correct (only) copy of__elf_aux_vector. After 968a18975adc9c2a619bb52aa2f009de99fc9e24updates were confused and __getosreldate was failing, causingthe system to fall back to compat compat12 syscalls in some cases.Return to explicitly linking libc to libsys and link libthr with libcand libsys (in that order).Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D43910 List of files: /freebsd/lib/libthr/Makefile

49d684369c6682eebca325c55a6c96b7c03f5aeb - libthr: filter rather than link with libsys

Wed, 07 Feb 2024 20:38:16 +0100

libthr: filter rather than link with libsysThe allows gcc + GNU ld to link programs with -m32 -pthread withouterroring out due to _umtx_op_err being undefined (unless -lsys is addedto the link command.We now always link _umtx_op_err into libthr (not just when it's static)and filter it with libsys so we call that implementation. The dynamicimplementations (at least the assembly ones) should likely become stubsas a further refinement.Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D43783 List of files: /freebsd/lib/libthr/Makefile

ef9871c6205c158b16ee23702d2b8c043debc51a - libthr: move _umtx_op_err() to libsys

Wed, 17 Jan 2024 21:26:52 +0100

libthr: move _umtx_op_err() to libsysDeclare in sys/umtx.h and implement in libsys. Explicitly link libthrwith libsys.When building libthr static include _umtx_op_err so we don't break staticlinkage with -lpthread.Reviewed by: kib, emaste, impPull Request: https://github.com/freebsd/freebsd-src/pull/908 List of files: /freebsd/lib/libthr/Makefile

d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 19:55:03 +0200

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd/lib/libthr/Makefile

642cd511028b8839db2c89a44cf7807d80664f38 - libthr: Add src.conf variable WITHOUT_PTHREADS_ASSERTIONS

Fri, 07 Jul 2023 02:30:02 +0200

libthr: Add src.conf variable WITHOUT_PTHREADS_ASSERTIONSThis patch fixes a bug which prevents building libthr without_PTHREADS_INVARIANTS defined. The default remains to build libthrwith -D_PTHREADS_INVARIANTS. However, with this patch, if one buildslibthr with WITHOUT_PTHREADS_ASSERTIONS=true then the latency toacquire+release a default pthread mutex is reduced by roughly 5%, and arobust mutex by roughly 18% (as measured by a simple synthetic test on aXeon E5-2697a based machine).Reviewed by: jhb, kib, mjgMFC after: 1 weekDifferential revision: https://reviews.freebsd.org/D40900 List of files: /freebsd/lib/libthr/Makefile

bbf4df1722060fb78939419476fb624114fb303d - libthr: Disable stack unwinding on ARM.

Thu, 10 Feb 2022 21:47:08 +0100

libthr: Disable stack unwinding on ARM.When a thread exits, _Unwind_ForcedUnwind() is used to walk up stackframes executing pending cleanups pushed by pthread_cleanup_push().The cleanups are popped by thread_unwind_stop() which is passed as acallback function to _Unwind_ForcedUnwind().LLVM's libunwind uses a different function type for the callback on32-bit ARM relative to all other platforms. The previous unwind.hheader (as well as the unwind.h from libcxxrt) use the non-ARM type onall platforms, so this has likely been broken on 32-bit arm since itswitched to using LLVM's libunwind.For now, just disable stack unwinding on 32-bit arm to unbreak thebuild until a proper fix is tested. List of files: /freebsd/lib/libthr/Makefile

c00d345665366a89aaba7244d6f078dc756f4c53 - Install unwind.h into /usr/include

Thu, 10 Feb 2022 18:57:49 +0100

Install unwind.h into /usr/includeInstall headers from LLVM's libunwind in place of the headers fromlibcxxrt and allow C applications to use the library.As part of this, remove include/unwind.h and switch libthr over tousing the installed unwind.h.Reviewed by: dim, emasteMFC after: 10 daysDifferential Revision: https://reviews.freebsd.org/D34065 List of files: /freebsd/lib/libthr/Makefile

9efbe526e00f47d946b3320f595e73fea26805df - libthr: work around an ASAN false-positive

Mon, 02 Aug 2021 10:49:21 +0200

libthr: work around an ASAN false-positiveI got the following error with an ASAN-instrument libthr:==803==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdb0 at pc 0x000801863396 bp 0x7ff8READ of size 4 at 0x7fffffffcdb0 thread T0 #0 0x801863395 in handle_signal /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:262:2 #1 0x801860da2 in thr_sighandler /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:246:2Address 0x7fffffffcdb0 is located in stack of thread T0 at offset 208 in frame #0 0x80186080f in thr_sighandler /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:213 This frame has 1 object(s): [32, 64) 'act' (line 216) <== Memory access at offset 208 overflows this variableHINT: this may be a false positive if your program uses some custom stackThis seems like a false-positive since the line in question is`SIGSETOR(actp->sa_mask, ucp->uc_sigmask);` and it complains about a readoperation (from the ucontext_t argument) so this indicates to me that ASANdoes not understand that thr_sighandler() is a signal handler.Differential Revision: https://reviews.freebsd.org/D31074 List of files: /freebsd/lib/libthr/Makefile

c8c62548bffb83f3d25e062929c45d66fea755f1 - Don't add -Winline for WARNS=6

Mon, 22 Mar 2021 12:55:45 +0100

Don't add -Winline for WARNS=6This warning is very rarely useful (inline is a hint and not mandatory).This flag results in many warnings being printed when compiling C++code that uses the standard library with GCC.This flag was originally added in back in r94332 but the flag is a no-opin Clang ("This diagnostic flag exists for GCC compatibility, and has noeffect in Clang"). Removing it should make the GCC build output slightlymore readable.Reviewed By: jrtc27, impDifferential Revision: https://reviews.freebsd.org/D29235 List of files: /freebsd/lib/libthr/Makefile

fac6dee9eb58b2b558fec2aea749460ca623f6d6 - Remove tests for obsolete compilers in the build system

Tue, 12 May 2020 17:22:40 +0200

Remove tests for obsolete compilers in the build systemAssume gcc is at least 6.4, the oldest xtoolchain in the ports tree.Assume clang is at least 6, which was in 11.2-RELEASE. Drop conditionsfor older compilers.Reviewed by: imp (earlier version), emaste, jhbMFC after: 2 weeksSponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D24802 List of files: /freebsd/lib/libthr/Makefile

9a696dc6bb0e8e783dfd169c8299e1f33aac2935 - MFHead@r345880

Thu, 04 Apr 2019 20:26:32 +0200

MFHead@r345880 List of files: /freebsd/lib/libthr/Makefile

5d00c5a6571cdf533228338fa7ca532c91af1d66 - Fix initial exec TLS mode for dynamically loaded shared objects.

Fri, 29 Mar 2019 18:52:57 +0100

Fix initial exec TLS mode for dynamically loaded shared objects.If dso uses initial exec TLS mode, rtld tries to allocate TLS instatic space. If there is no space left, the dlopen(3) fails. If spaceif allocated, initial content from PT_TLS segment is distributed toall threads' pcbs, which was missed and caused un-initialized TLSsegment for such dso after dlopen(3).The mode is auto-detected either due to the relocation used, or if theDF_STATIC_TLS dynamic flag is set. In the later case, the TLS segmentis tried to allocate earlier, which increases chance of the dlopen(3)to succeed. LLD was recently fixed to properly emit the flag, ld.bdfdid it always.Initial test by: dumbbellTested by: emaste (amd64), ian (arm)Tested by: Gerald Aryeetey (arm64)Sponsored by: The FreeBSD FoundationMFC after: 2 weeksDifferential revision: https://reviews.freebsd.org/D19072 List of files: /freebsd/lib/libthr/Makefile

415e34c4d5dff4c334330d58e06644da5c39b0bd - MFHead@r345677

Fri, 29 Mar 2019 04:25:20 +0100

MFHead@r345677 List of files: /freebsd/lib/libthr/Makefile